)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"0ca170ceac9867b9d205f24f240fc6a5a63251f0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Tegile is in the process of setting up a CI. It will be start reporting"},{"line_number":26,"context_line":"this week as \"Tegile Storage CI\"."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Implements: blueprint tegile-volume-driver"},{"line_number":29,"context_line":"Change-Id: Ia0e6c320964f3955d6c7d4dcff4a0241a3960495"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_f55360e0","line":27,"updated":"2015-11-18 15:19:59.000000000","message":"We should add a DocImpact tag here since we are adding config options in tegile.py.","commit_id":"d08c49ec084466a9fd8449dadf651b6275152979"}],"cinder/tests/unit/test_tegile.py":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"0ca170ceac9867b9d205f24f240fc6a5a63251f0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                          }]"},{"line_number":71,"context_line":"               }"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class FakeTegileService(object):"},{"line_number":75,"context_line":"    @staticmethod"},{"line_number":76,"context_line":"    def send_api_request(method, params\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_9523f4a6","line":73,"updated":"2015-11-18 15:19:59.000000000","message":"Some of your pep8 errors are happening because your lines are over 80 characters on a single line. If you need to, please use () for line continuation and not \\.","commit_id":"d08c49ec084466a9fd8449dadf651b6275152979"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"dc938d1828296158d0f199e654c4e0df3318e5e1","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        with mock.patch.object(tegile_driver,"},{"line_number":230,"context_line":"                               \u0027_api_executor\u0027,"},{"line_number":231,"context_line":"                               fake_tegile_backend):"},{"line_number":232,"context_line":"            tegile_driver.create_cloned_volume(test_volume, test_volume)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def test_create_cloned_volume_fail(self):"},{"line_number":235,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_3677e33b","line":232,"updated":"2015-12-17 19:58:54.000000000","message":"Need to assert as create cloned volume returns data","commit_id":"24ff75d058d1667f3eb1b7a7851a001a5703d14f"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"dc938d1828296158d0f199e654c4e0df3318e5e1","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        with mock.patch.object(tegile_driver,"},{"line_number":246,"context_line":"                               \u0027_api_executor\u0027,"},{"line_number":247,"context_line":"                               fake_tegile_backend):"},{"line_number":248,"context_line":"            tegile_driver.get_volume_stats(True)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_get_pool(self):"},{"line_number":251,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_16bae7c0","line":248,"updated":"2015-12-17 19:58:54.000000000","message":"Need to assert for returned data","commit_id":"24ff75d058d1667f3eb1b7a7851a001a5703d14f"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"dc938d1828296158d0f199e654c4e0df3318e5e1","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        with mock.patch.object(tegile_driver,"},{"line_number":260,"context_line":"                               \u0027_api_executor\u0027,"},{"line_number":261,"context_line":"                               fake_tegile_backend):"},{"line_number":262,"context_line":"            tegile_driver.extend_volume(test_volume, 12)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    def test_extend_volume_fail(self):"},{"line_number":265,"context_line":"        tegile_driver \u003d self.get_object(self.configuration)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_b6e753e3","line":262,"updated":"2015-12-17 19:58:54.000000000","message":"ditto.","commit_id":"24ff75d058d1667f3eb1b7a7851a001a5703d14f"}],"cinder/volume/drivers/tegile.py":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"0ca170ceac9867b9d205f24f240fc6a5a63251f0","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def debugger(func):"},{"line_number":55,"context_line":"    \"\"\"Returns a wrapper that wraps func. The wrapper will log the entry and exit points of the function\"\"\""},{"line_number":56,"context_line":"    def wrapper(*args, **kwds):"},{"line_number":57,"context_line":"        if DEBUG_LOGGING:"},{"line_number":58,"context_line":"            LOG.debug(\u0027Entering %s.%s\u0027 % (args[0].__class__.__name__,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d2ce722d","line":55,"updated":"2015-11-18 15:19:59.000000000","message":"Some of your pep8 errors are happening because your lines are over 80 characters on a single line. If you need to, please use () for line continuation and not \\.","commit_id":"d08c49ec084466a9fd8449dadf651b6275152979"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"0ca170ceac9867b9d205f24f240fc6a5a63251f0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        return f_result"},{"line_number":67,"context_line":"    return wrapper"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class TegileAPIException(exception.VolumeBackendAPIException):"},{"line_number":71,"context_line":"    message \u003d _(\"Unexpected response from IntelliFlash API\")"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_15ee24b4","line":69,"updated":"2015-11-18 15:19:59.000000000","message":"I think we need to move the below Exception classes into exception.py.","commit_id":"d08c49ec084466a9fd8449dadf651b6275152979"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"e9e063031afff75cedb170c706af07c123d51ea3","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        return self.get_additional_info(volume, pool, project)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    @debugger"},{"line_number":327,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":328,"context_line":"        \"\"\"Get volume status."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        If \u0027refresh\u0027 is True, run update first."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_a4952641","line":327,"updated":"2015-12-15 00:12:24.000000000","message":"I could not find it, Could you point me to the checkin/review, so that I can change it.\nAs far as I can see, there are calls like this \"stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)\" in manager.py.","commit_id":"6f2251a08a9150bf55bc3b837f335f1c58582b48"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"c0c4d13db830fe6da361d9beb643bb80d0cd18a1","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        return self.get_additional_info(volume, pool, project)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    @debugger"},{"line_number":327,"context_line":"    def get_volume_stats(self, refresh\u003dFalse):"},{"line_number":328,"context_line":"        \"\"\"Get volume status."},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        If \u0027refresh\u0027 is True, run update first."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_46f3160b","line":327,"updated":"2015-12-04 03:01:21.000000000","message":"The refresh parameter was removed in a previous commit, you can have a check.","commit_id":"6f2251a08a9150bf55bc3b837f335f1c58582b48"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"c0c4d13db830fe6da361d9beb643bb80d0cd18a1","unresolved":false,"context_lines":[{"line_number":367,"context_line":""},{"line_number":368,"context_line":"            self._stats \u003d data"},{"line_number":369,"context_line":"        except Exception as e:"},{"line_number":370,"context_line":"            LOG.debug("},{"line_number":371,"context_line":"                \u0027TegileIntelliFlashVolumeDriver(%s)\u0027"},{"line_number":372,"context_line":"                \u0027_update_volume_stats failed: %s\u0027 % (self.__class__.__name__,"},{"line_number":373,"context_line":"                                                     six.text_type(e)))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_66cf32b1","line":370,"updated":"2015-12-04 03:01:21.000000000","message":"Warning is better","commit_id":"6f2251a08a9150bf55bc3b837f335f1c58582b48"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"c0c4d13db830fe6da361d9beb643bb80d0cd18a1","unresolved":false,"context_lines":[{"line_number":605,"context_line":"        connectors \u003d \u0027\u0027"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"        for wwpn in wwpns:"},{"line_number":608,"context_line":"            connectors +\u003d wwpn + \u0027,\u0027"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        params.append(connectors)"},{"line_number":611,"context_line":"        target_info \u003d self._api_executor.send_api_request("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_c66ce69e","line":608,"updated":"2015-12-04 03:01:21.000000000","message":"can be changed to:\n\nconnectors \u003d \u0027,\u0027.join(wwpns)","commit_id":"6f2251a08a9150bf55bc3b837f335f1c58582b48"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"dc938d1828296158d0f199e654c4e0df3318e5e1","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"tegile_opts \u003d ["},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027tegile_default_pool\u0027,"},{"line_number":45,"context_line":"               default\u003dNone,"},{"line_number":46,"context_line":"               help\u003d\u0027Create volumes in this pool\u0027),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027tegile_default_project\u0027,"},{"line_number":48,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_00894126","line":45,"updated":"2015-12-17 19:58:54.000000000","message":"Do not need to set default\u003dNone, it\u0027s done by default :)","commit_id":"24ff75d058d1667f3eb1b7a7851a001a5703d14f"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"dc938d1828296158d0f199e654c4e0df3318e5e1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               default\u003dNone,"},{"line_number":46,"context_line":"               help\u003d\u0027Create volumes in this pool\u0027),"},{"line_number":47,"context_line":"    cfg.StrOpt(\u0027tegile_default_project\u0027,"},{"line_number":48,"context_line":"               default\u003dNone,"},{"line_number":49,"context_line":"               help\u003d\u0027Create volumes in this project\u0027)]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_208c7d34","line":48,"updated":"2015-12-17 19:58:54.000000000","message":"ditto ^^","commit_id":"24ff75d058d1667f3eb1b7a7851a001a5703d14f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c2f99d405298502fe468fa9b0b8e955c53162b38","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def wrapper(*args, **kwds):"},{"line_number":60,"context_line":"        if DEBUG_LOGGING:"},{"line_number":61,"context_line":"            LOG.debug(\u0027Entering %s.%s\u0027 % (args[0].__class__.__name__,"},{"line_number":62,"context_line":"                                          func.__name__))"},{"line_number":63,"context_line":"            LOG.debug(\u0027Arguments: %s, %s\u0027, args[1:], kwds)"},{"line_number":64,"context_line":"        f_result \u003d func(*args, **kwds)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_ada166ab","line":61,"range":{"start_line":61,"start_character":23,"end_line":61,"end_character":31},"updated":"2015-12-23 17:32:07.000000000","message":"See comments on line 115 and 116. Multiple instances throughout where this needs to be fixed.","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"7e1a023e1815a9f2ad2de08a21b19b7408f7f605","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def wrapper(*args, **kwds):"},{"line_number":60,"context_line":"        if DEBUG_LOGGING:"},{"line_number":61,"context_line":"            LOG.debug(\u0027Entering %s.%s\u0027 % (args[0].__class__.__name__,"},{"line_number":62,"context_line":"                                          func.__name__))"},{"line_number":63,"context_line":"            LOG.debug(\u0027Arguments: %s, %s\u0027, args[1:], kwds)"},{"line_number":64,"context_line":"        f_result \u003d func(*args, **kwds)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_29a561b4","line":61,"range":{"start_line":61,"start_character":23,"end_line":61,"end_character":31},"in_reply_to":"1a7b0d38_ada166ab","updated":"2015-12-23 23:53:43.000000000","message":"Done","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c2f99d405298502fe468fa9b0b8e955c53162b38","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                               verify\u003dFalse)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if fine_logging:"},{"line_number":115,"context_line":"            LOG.debug(\u0027TegileAPIExecutor(%s) method: %s,\u0027"},{"line_number":116,"context_line":"                      \u0027return code: %s\u0027 % (self._classname,"},{"line_number":117,"context_line":"                                           method,"},{"line_number":118,"context_line":"                                           str(req)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_2d733682","line":115,"updated":"2015-12-23 17:32:07.000000000","message":"Needs space on the end so it doesn\u0027t run together with the next line.","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"7e1a023e1815a9f2ad2de08a21b19b7408f7f605","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                               verify\u003dFalse)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if fine_logging:"},{"line_number":115,"context_line":"            LOG.debug(\u0027TegileAPIExecutor(%s) method: %s,\u0027"},{"line_number":116,"context_line":"                      \u0027return code: %s\u0027 % (self._classname,"},{"line_number":117,"context_line":"                                           method,"},{"line_number":118,"context_line":"                                           str(req)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_c9ab7d88","line":115,"in_reply_to":"1a7b0d38_2d733682","updated":"2015-12-23 23:53:43.000000000","message":"Done","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c2f99d405298502fe468fa9b0b8e955c53162b38","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if fine_logging:"},{"line_number":115,"context_line":"            LOG.debug(\u0027TegileAPIExecutor(%s) method: %s,\u0027"},{"line_number":116,"context_line":"                      \u0027return code: %s\u0027 % (self._classname,"},{"line_number":117,"context_line":"                                           method,"},{"line_number":118,"context_line":"                                           str(req)))"},{"line_number":119,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_0d019aae","line":116,"range":{"start_line":116,"start_character":39,"end_line":116,"end_character":40},"updated":"2015-12-23 17:32:07.000000000","message":"Change % to , and pass in the formatting variables as args to the logger.\n\nAlso, name formatting variables since there is more than one (i.e. change %s to %(classname)s, etc).","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"7e1a023e1815a9f2ad2de08a21b19b7408f7f605","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if fine_logging:"},{"line_number":115,"context_line":"            LOG.debug(\u0027TegileAPIExecutor(%s) method: %s,\u0027"},{"line_number":116,"context_line":"                      \u0027return code: %s\u0027 % (self._classname,"},{"line_number":117,"context_line":"                                           method,"},{"line_number":118,"context_line":"                                           str(req)))"},{"line_number":119,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_8996d54a","line":116,"range":{"start_line":116,"start_character":39,"end_line":116,"end_character":40},"in_reply_to":"1a7b0d38_0d019aae","updated":"2015-12-23 23:53:43.000000000","message":"Done","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c2f99d405298502fe468fa9b0b8e955c53162b38","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        try:"},{"line_number":120,"context_line":"            response \u003d req.json()"},{"line_number":121,"context_line":"            if fine_logging:"},{"line_number":122,"context_line":"                LOG.debug(\u0027TegileAPIExecutor(%s) method: %s,\u0027"},{"line_number":123,"context_line":"                          \u0027response: %s\u0027 % (self._classname,"},{"line_number":124,"context_line":"                                            method,"},{"line_number":125,"context_line":"                                            str(response)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_0d9d1a65","line":122,"range":{"start_line":122,"start_character":59,"end_line":122,"end_character":61},"updated":"2015-12-23 17:32:07.000000000","message":"Space needed on the end.","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"7e1a023e1815a9f2ad2de08a21b19b7408f7f605","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        try:"},{"line_number":120,"context_line":"            response \u003d req.json()"},{"line_number":121,"context_line":"            if fine_logging:"},{"line_number":122,"context_line":"                LOG.debug(\u0027TegileAPIExecutor(%s) method: %s,\u0027"},{"line_number":123,"context_line":"                          \u0027response: %s\u0027 % (self._classname,"},{"line_number":124,"context_line":"                                            method,"},{"line_number":125,"context_line":"                                            str(response)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_a9915154","line":122,"range":{"start_line":122,"start_character":59,"end_line":122,"end_character":61},"in_reply_to":"1a7b0d38_0d9d1a65","updated":"2015-12-23 23:53:43.000000000","message":"Done","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c2f99d405298502fe468fa9b0b8e955c53162b38","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            LOG.warning(_LW(\u0027TegileIntelliFlashVolumeDriver(%(clsname)s) \u0027"},{"line_number":369,"context_line":"                            \u0027_update_volume_stats failed: %(error)s\u0027),"},{"line_number":370,"context_line":"                        {\u0027clsname\u0027: self.__class__.__name__,"},{"line_number":371,"context_line":"                         \u0027error\u0027: six.text_type(e)})"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    @debugger"},{"line_number":374,"context_line":"    def get_pool(self, volume):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_eddbee19","line":371,"range":{"start_line":371,"start_character":38,"end_line":371,"end_character":47},"updated":"2015-12-23 17:32:07.000000000","message":"six.text_type not needed here since it is being passed as an argument into the logger. The logger will take care of any necessary conversion if and when needed.","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"7e1a023e1815a9f2ad2de08a21b19b7408f7f605","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            LOG.warning(_LW(\u0027TegileIntelliFlashVolumeDriver(%(clsname)s) \u0027"},{"line_number":369,"context_line":"                            \u0027_update_volume_stats failed: %(error)s\u0027),"},{"line_number":370,"context_line":"                        {\u0027clsname\u0027: self.__class__.__name__,"},{"line_number":371,"context_line":"                         \u0027error\u0027: six.text_type(e)})"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    @debugger"},{"line_number":374,"context_line":"    def get_pool(self, volume):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_49a0ed9f","line":371,"range":{"start_line":371,"start_character":38,"end_line":371,"end_character":47},"in_reply_to":"1a7b0d38_eddbee19","updated":"2015-12-23 23:53:43.000000000","message":"Done","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c2f99d405298502fe468fa9b0b8e955c53162b38","unresolved":false,"context_lines":[{"line_number":625,"context_line":"    @fczm_utils.RemoveFCZone"},{"line_number":626,"context_line":"    @debugger"},{"line_number":627,"context_line":"    def terminate_connection(self, volume, connector, force\u003dFalse, **kwargs):"},{"line_number":628,"context_line":"        connection_data \u003d self.initialize_connection(volume, connector)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        return connection_data"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_cd65d245","line":628,"updated":"2015-12-23 17:32:07.000000000","message":"This doesn\u0027t look right for terminating a connection.","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":17357,"name":"Abhilash Divakaran","email":"abhilashd@tegile.com","username":"abhilashd"},"change_message_id":"7e1a023e1815a9f2ad2de08a21b19b7408f7f605","unresolved":false,"context_lines":[{"line_number":625,"context_line":"    @fczm_utils.RemoveFCZone"},{"line_number":626,"context_line":"    @debugger"},{"line_number":627,"context_line":"    def terminate_connection(self, volume, connector, force\u003dFalse, **kwargs):"},{"line_number":628,"context_line":"        connection_data \u003d self.initialize_connection(volume, connector)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        return connection_data"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_897d751e","line":628,"in_reply_to":"1a7b0d38_cd65d245","updated":"2015-12-23 23:53:43.000000000","message":"This was looking for almost the same data as initialize_connection. I changed it to only include our API call and hence no side effects, Thanks for the comment.","commit_id":"880f1c6994f4d7c52b706c9bfdcc5dff56aa73f7"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"05f65d2025bef936fd7bc20054410127e2f4e907","unresolved":false,"context_lines":[{"line_number":38,"context_line":"TEGILE_API_PATH \u003d \u0027zebi/api\u0027"},{"line_number":39,"context_line":"TEGILE_DEFAULT_BLOCK_SIZE \u003d \u002732KB\u0027"},{"line_number":40,"context_line":"TEGILE_LOCAL_CONTAINER_NAME \u003d \u0027Local\u0027"},{"line_number":41,"context_line":"DEBUG_LOGGING \u003d False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"tegile_opts \u003d ["},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027tegile_default_pool\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_241aae18","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":21},"updated":"2015-12-29 19:12:15.000000000","message":"Thanks for your explanation that this is strictly for development use and should not be configurable or turned on except during dev work.","commit_id":"951a757ec0ace2148367c0e137396286ad3ca7b2"}]}