)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"0243a8900eac6ed7e3c8ddfa2c0949d06b5f3025","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* update_consistencygroup"},{"line_number":24,"context_line":"* delete_cgsnapshot"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1] The statements \"return True\":"},{"line_number":27,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L610"},{"line_number":28,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L651"},{"line_number":29,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L708"},{"line_number":30,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L808"},{"line_number":31,"context_line":"..."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I38bac64b9eb1be6a4756cfcd3894615d2b849551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a7b0d38_a57bf27a","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":3},"updated":"2015-12-22 16:32:43.000000000","message":"I don\u0027t think these are necessary given we will see what lines are being edited in the actual patch.","commit_id":"585996819370aa7f6f91c3edcf9b6145f84d8010"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"e4fd96555f3013ec2a72ea694a83b14a47124650","unresolved":false,"context_lines":[{"line_number":23,"context_line":"* update_consistencygroup"},{"line_number":24,"context_line":"* delete_cgsnapshot"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"[1] The statements \"return True\":"},{"line_number":27,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L610"},{"line_number":28,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L651"},{"line_number":29,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L708"},{"line_number":30,"context_line":"https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L808"},{"line_number":31,"context_line":"..."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I38bac64b9eb1be6a4756cfcd3894615d2b849551"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a7b0d38_97019eb1","line":31,"range":{"start_line":26,"start_character":0,"end_line":31,"end_character":3},"in_reply_to":"1a7b0d38_a57bf27a","updated":"2015-12-29 11:56:03.000000000","message":"OK,I\u0027ll remove it.","commit_id":"585996819370aa7f6f91c3edcf9b6145f84d8010"}],"cinder/volume/manager.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"0243a8900eac6ed7e3c8ddfa2c0949d06b5f3025","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            self.publish_service_capabilities(context)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        LOG.info(_LI(\"Deleted volume successfully.\"), resource\u003dvolume)"},{"line_number":708,"context_line":"        return True"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def _clear_db(self, context, is_migrating_dest, volume_ref, status):"},{"line_number":711,"context_line":"        # This method is called when driver.unmanage() or"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_dabb7974","side":"PARENT","line":708,"range":{"start_line":708,"start_character":15,"end_line":708,"end_character":19},"updated":"2015-12-22 16:32:43.000000000","message":"Why is this being removed entirely instead of removing the True and then just returning?","commit_id":"8c0926bb4e2385687c1e0fa1f21791980fa80693"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"e4fd96555f3013ec2a72ea694a83b14a47124650","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            self.publish_service_capabilities(context)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        LOG.info(_LI(\"Deleted volume successfully.\"), resource\u003dvolume)"},{"line_number":708,"context_line":"        return True"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def _clear_db(self, context, is_migrating_dest, volume_ref, status):"},{"line_number":711,"context_line":"        # This method is called when driver.unmanage() or"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_b48e18ce","side":"PARENT","line":708,"range":{"start_line":708,"start_character":15,"end_line":708,"end_character":19},"in_reply_to":"1a7b0d38_dabb7974","updated":"2015-12-29 11:56:03.000000000","message":"These two effects are the same(both means returning None), I\u0027m OK with both. we can keep the \u0027return\u0027 if you mind. thanks~","commit_id":"8c0926bb4e2385687c1e0fa1f21791980fa80693"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"0243a8900eac6ed7e3c8ddfa2c0949d06b5f3025","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            QUOTAS.commit(context, reservations, project_id\u003dproject_id)"},{"line_number":841,"context_line":"        LOG.info(_LI(\"Delete snapshot completed successfully\"),"},{"line_number":842,"context_line":"                 resource\u003dsnapshot)"},{"line_number":843,"context_line":"        return True"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"    def attach_volume(self, context, volume_id, instance_uuid, host_name,"},{"line_number":846,"context_line":"                      mountpoint, mode):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_1a9341fc","side":"PARENT","line":843,"updated":"2015-12-22 16:32:43.000000000","message":"Why is this being removed entirely instead of removing the True and then just returning?","commit_id":"8c0926bb4e2385687c1e0fa1f21791980fa80693"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ae541a204ed3de1c05c63b79a87632e298d6095d","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            # be deleted when resuming deletes from init_host()."},{"line_number":616,"context_line":"            LOG.debug(\"Attempted delete of non-existent volume: %s\","},{"line_number":617,"context_line":"                      volume_id)"},{"line_number":618,"context_line":"            return True"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        if context.project_id !\u003d volume.project_id:"},{"line_number":621,"context_line":"            project_id \u003d volume.project_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba63e191_302653bb","side":"PARENT","line":618,"range":{"start_line":618,"start_character":19,"end_line":618,"end_character":23},"updated":"2016-01-19 05:30:25.000000000","message":"just remove this line of code ?","commit_id":"88c0dad3ac3776c89c75a9e4f39acd2227cfff55"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"ea59e0f388cf22193c8cd578ff44c1ab9a985a89","unresolved":false,"context_lines":[{"line_number":615,"context_line":"            # be deleted when resuming deletes from init_host()."},{"line_number":616,"context_line":"            LOG.debug(\"Attempted delete of non-existent volume: %s\","},{"line_number":617,"context_line":"                      volume_id)"},{"line_number":618,"context_line":"            return True"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        if context.project_id !\u003d volume.project_id:"},{"line_number":621,"context_line":"            project_id \u003d volume.project_id"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_c51424ea","side":"PARENT","line":618,"range":{"start_line":618,"start_character":19,"end_line":618,"end_character":23},"in_reply_to":"ba63e191_302653bb","updated":"2016-02-08 09:36:04.000000000","message":"If we remove this \"return\", it will change the original code execution path. Because the volume is not found, it is not necessary to execute the following code. Thanks~","commit_id":"88c0dad3ac3776c89c75a9e4f39acd2227cfff55"}]}