)]}'
{"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"15de890086d42badcbcc7c4dbe94132965140a4c","unresolved":false,"context_lines":[{"line_number":1629,"context_line":"        svInstance[\u0027SystemElement\u0027] \u003d sourceInstanceName"},{"line_number":1630,"context_line":"        svInstance[\u0027CreationClassName\u0027] \u003d \u0027SE_StorageSynchronized_SV_SV\u0027"},{"line_number":1631,"context_line":"        svInstance[\u0027PercentSynced\u0027] \u003d 100"},{"line_number":1632,"context_line":"        svInstance[\u0027CopyState\u0027] \u003d 7"},{"line_number":1633,"context_line":"        svInstances.append(svInstance)"},{"line_number":1634,"context_line":"        return svInstances"},{"line_number":1635,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a5de9d1_8906abcc","line":1632,"range":{"start_line":1632,"start_character":31,"end_line":1632,"end_character":32},"updated":"2016-01-29 05:31:54.000000000","message":"Just curious, why here svInstance[\u0027Copystate\u0027] \u003d 7?","commit_id":"304a583c5ae47591c8f5bbc556df537bc86cd2d0"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c7ad7fc227ece2e8b3ee9ba463aa7255efa8878b","unresolved":false,"context_lines":[{"line_number":1629,"context_line":"        svInstance[\u0027SystemElement\u0027] \u003d sourceInstanceName"},{"line_number":1630,"context_line":"        svInstance[\u0027CreationClassName\u0027] \u003d \u0027SE_StorageSynchronized_SV_SV\u0027"},{"line_number":1631,"context_line":"        svInstance[\u0027PercentSynced\u0027] \u003d 100"},{"line_number":1632,"context_line":"        svInstance[\u0027CopyState\u0027] \u003d 7"},{"line_number":1633,"context_line":"        svInstances.append(svInstance)"},{"line_number":1634,"context_line":"        return svInstances"},{"line_number":1635,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_74a7230b","line":1632,"range":{"start_line":1632,"start_character":31,"end_line":1632,"end_character":32},"in_reply_to":"7a5de9d1_8906abcc","updated":"2016-02-08 10:13:57.000000000","message":"This is necessary test data for one or more of the tests to work, otherwise it will throw a keyerror exception.  It would be preferable to use \nsyncname[\u0027CopyState\u0027] \u003d self.data.UNSYNCHRONIZED.  I will change it.  Thanks","commit_id":"304a583c5ae47591c8f5bbc556df537bc86cd2d0"}],"cinder/volume/drivers/emc/emc_vmax_fc.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"1418d74e9fb7fe6b7195a5052b6d5f1d0d72985b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3   - Bug - Changing PercentSynced to CopyState"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5c012905","line":45,"updated":"2015-11-18 19:15:56.000000000","message":"I really think you want to keep the third number in the version as this patch will have a merge conflict with patch: https://review.openstack.org/#/c/244933\n\nAssuming 244933 lands first or you can make this patch dependent on this one. If this was my driver I would have have the following \n\n2.3.6 - Changing PercentSynced to CopyState (bug #1517103)\n.\n.\n.\nVERSION \u003d \"2.3.6\"","commit_id":"afead8608619094ad2c4086dc3310e2aa12b7972"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"02723dcb304ac1d961575c229d5e30633d812004","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3   - Bug - Changing PercentSynced to CopyState"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_83c8e575","line":45,"in_reply_to":"ba8a016a_028a5a1b","updated":"2015-11-23 11:31:36.000000000","message":"Will change it as you have suggested in all bug fixes.  Thanks","commit_id":"afead8608619094ad2c4086dc3310e2aa12b7972"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"18ddcd451506c677d39da06f9ae2dc93c2895191","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3   - Bug - Changing PercentSynced to CopyState"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_028a5a1b","line":45,"in_reply_to":"ba8a016a_5c012905","updated":"2015-11-18 19:50:38.000000000","message":"To use the same version style as the VNX team, we can change to the following:\n\n2.3 - Changing PercentSynced to CopyState (bug #1517103)\n\nGood idea to reference the launchpad bug #.","commit_id":"afead8608619094ad2c4086dc3310e2aa12b7972"}],"cinder/volume/drivers/emc/emc_vmax_utils.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"835ba8d4de819c9ee5885dbf7cb3c81827dbebce","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        LOG.debug(\"CopyState is %(copyState)lu.\","},{"line_number":444,"context_line":"                  {\u0027copyState\u0027: copyState})"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        if copyState !\u003d 4:"},{"line_number":447,"context_line":"            return False"},{"line_number":448,"context_line":"        else:"},{"line_number":449,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_f572a310","line":446,"updated":"2015-11-23 21:10:42.000000000","message":"Suggestion, make 4 a constant with a human readable name. It would make the code easier to read.","commit_id":"3dca3125697c39b0d91ef178258b27193e2c0daf"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"a35f795c002119163ee55b23f855bd42c1223a64","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        LOG.debug(\"CopyState is %(copyState)lu.\","},{"line_number":444,"context_line":"                  {\u0027copyState\u0027: copyState})"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        if copyState !\u003d 4:"},{"line_number":447,"context_line":"            return False"},{"line_number":448,"context_line":"        else:"},{"line_number":449,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_f208e693","line":446,"in_reply_to":"ba8a016a_f572a310","updated":"2015-11-24 11:22:41.000000000","message":"Will do.  Thanks","commit_id":"3dca3125697c39b0d91ef178258b27193e2c0daf"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"d6557d5d8816168ac384c2b2a38bf0eb4e0764e4","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        LOG.debug(\"CopyState is %(copyState)lu.\","},{"line_number":445,"context_line":"                  {\u0027copyState\u0027: copyState})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if copyState !\u003d SYNCHRONIZED:"},{"line_number":448,"context_line":"            return False"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_b579d231","line":447,"updated":"2015-12-15 01:53:15.000000000","message":"You could simplify this block:\n\nreturn copyState \u003d\u003d SYNCHORNIZED","commit_id":"129e6784abc75b62086645ef424ea63300a87658"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8df07109164758b17b1f4799278be03beb4d7dcf","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        LOG.debug(\"CopyState is %(copyState)lu.\","},{"line_number":445,"context_line":"                  {\u0027copyState\u0027: copyState})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if copyState !\u003d SYNCHRONIZED:"},{"line_number":448,"context_line":"            return False"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_dc8fab21","line":447,"in_reply_to":"5a710552_b579d231","updated":"2015-12-15 22:46:56.000000000","message":"I can change this.  Thanks","commit_id":"129e6784abc75b62086645ef424ea63300a87658"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"c839d28d7e6e810e826fcfed2eb1b32fcebbeb12","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        LOG.debug(\"CopyState is %(copyState)lu.\","},{"line_number":445,"context_line":"                  {\u0027copyState\u0027: copyState})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if copyState !\u003d SYNCHRONIZED:"},{"line_number":448,"context_line":"            return False"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba63e191_5e520adf","line":447,"range":{"start_line":447,"start_character":36,"end_line":447,"end_character":37},"updated":"2016-01-18 21:17:27.000000000","message":"447 to 450 can be simplified into \nreturn False if copyState !\u003d SYNCHRONIZED else True","commit_id":"77ded3f1d6e0565c2302565d433532f7d1a9fbbd"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"17b1e6eeec9ac3a2f7ccb388dedc676d330d05e8","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        LOG.debug(\"CopyState is %(copyState)lu.\","},{"line_number":445,"context_line":"                  {\u0027copyState\u0027: copyState})"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        if copyState !\u003d SYNCHRONIZED:"},{"line_number":448,"context_line":"            return False"},{"line_number":449,"context_line":"        else:"},{"line_number":450,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba63e191_8be58aa9","line":447,"range":{"start_line":447,"start_character":36,"end_line":447,"end_character":37},"in_reply_to":"ba63e191_5e520adf","updated":"2016-01-19 10:01:22.000000000","message":"Thanks.  I will change this","commit_id":"77ded3f1d6e0565c2302565d433532f7d1a9fbbd"}]}