)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"e9ecf70187047b67942932153f8c7bb34b3a2485","unresolved":false,"context_lines":[{"line_number":7,"context_line":"FlashSystem reports error in _find_host_exhaustive()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While host was deleted by someone else, the deleted host still"},{"line_number":10,"context_line":"exist in hosts. In _find_host_exhaustive(), all hosts would be"},{"line_number":11,"context_line":"enumerated. Thus, \u0027lshost\u0027 command will failed in this situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In this fix,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_f48992cb","line":10,"updated":"2015-11-24 20:36:50.000000000","message":"s/exist/existed/","commit_id":"80b226b250d42d0c12597974d7b9d35c14f4cb8c"},{"author":{"_account_id":12105,"name":"Edwin Wang","email":"wym.oohoo@gmail.com"},"change_message_id":"6ee5399da022331ae9d6c75f711207a95ff9ce3e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"FlashSystem reports error in _find_host_exhaustive()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While host was deleted by someone else, the deleted host still"},{"line_number":10,"context_line":"exist in hosts. In _find_host_exhaustive(), all hosts would be"},{"line_number":11,"context_line":"enumerated. Thus, \u0027lshost\u0027 command will failed in this situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In this fix,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_2047cabc","line":10,"in_reply_to":"9a8ffd7b_f48992cb","updated":"2015-11-25 03:50:53.000000000","message":"Done","commit_id":"80b226b250d42d0c12597974d7b9d35c14f4cb8c"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"e9ecf70187047b67942932153f8c7bb34b3a2485","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While host was deleted by someone else, the deleted host still"},{"line_number":10,"context_line":"exist in hosts. In _find_host_exhaustive(), all hosts would be"},{"line_number":11,"context_line":"enumerated. Thus, \u0027lshost\u0027 command will failed in this situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In this fix,"},{"line_number":14,"context_line":"* Adds hostname check before issue \u0027lshost\u0027 command for FC."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_946846f7","line":11,"updated":"2015-11-24 20:36:50.000000000","message":"s/failed/fail/","commit_id":"80b226b250d42d0c12597974d7b9d35c14f4cb8c"},{"author":{"_account_id":12105,"name":"Edwin Wang","email":"wym.oohoo@gmail.com"},"change_message_id":"6ee5399da022331ae9d6c75f711207a95ff9ce3e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While host was deleted by someone else, the deleted host still"},{"line_number":10,"context_line":"exist in hosts. In _find_host_exhaustive(), all hosts would be"},{"line_number":11,"context_line":"enumerated. Thus, \u0027lshost\u0027 command will failed in this situation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In this fix,"},{"line_number":14,"context_line":"* Adds hostname check before issue \u0027lshost\u0027 command for FC."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_e01782a1","line":11,"in_reply_to":"9a8ffd7b_946846f7","updated":"2015-11-25 03:50:53.000000000","message":"Done","commit_id":"80b226b250d42d0c12597974d7b9d35c14f4cb8c"}],"cinder/tests/unit/test_ibm_flashsystem.py":[{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"a76b2698fa1f7f10fac477ca6216998053a0f17e","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"                               \u0027_ssh\u0027) as mock_ssh:"},{"line_number":1210,"context_line":"            mock_ssh.return_value \u003d (\"pass\", \"\")"},{"line_number":1211,"context_line":"            self.driver._find_host_exhaustive(conn1, [host2])"},{"line_number":1212,"context_line":"            self.assert not mock_ssh.called"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"        # clear environment"},{"line_number":1215,"context_line":"        self.driver._delete_host(host1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1759fa34","line":1212,"updated":"2015-11-19 19:28:38.000000000","message":"The above line is causing a python syntax error.\n\nYou can use: self.assertFalse(mock_ssh.called)\n\nIt will check that mock_ssh was not called.","commit_id":"7f32651d286a9e4c9a015f5629793f5d726f44c8"},{"author":{"_account_id":12105,"name":"Edwin Wang","email":"wym.oohoo@gmail.com"},"change_message_id":"0702a23effe844e8c72a75b906b5b3f9c277102c","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"                               \u0027_ssh\u0027) as mock_ssh:"},{"line_number":1210,"context_line":"            mock_ssh.return_value \u003d (\"pass\", \"\")"},{"line_number":1211,"context_line":"            self.driver._find_host_exhaustive(conn1, [host2])"},{"line_number":1212,"context_line":"            self.assert not mock_ssh.called"},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"        # clear environment"},{"line_number":1215,"context_line":"        self.driver._delete_host(host1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0537794d","line":1212,"in_reply_to":"ba8a016a_1759fa34","updated":"2015-11-20 00:41:56.000000000","message":"Oh... sorry... I got my mistaken code uploaded.\nIt should be \u0027assert not mock_ssh.called\u0027.\nThanks, Anthony! Your suggestion is more perfect! :)","commit_id":"7f32651d286a9e4c9a015f5629793f5d726f44c8"}],"cinder/volume/drivers/ibm/flashsystem_fc.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"31204f112aa670d24a0986aa6123ed0df2443067","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                    map(str.lower, map(str, connector[\u0027wwpns\u0027]))):"},{"line_number":154,"context_line":"                return host"},{"line_number":155,"context_line":"        else:"},{"line_number":156,"context_line":"            msg \u003d (_(\u0027Host %(host)s is not found on backend storage.\u0027)"},{"line_number":157,"context_line":"                   % {\u0027host\u0027: hname})"},{"line_number":158,"context_line":"            LOG.info(msg)"},{"line_number":159,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_8f9a58c4","line":156,"updated":"2015-11-23 04:17:46.000000000","message":"Since you are using LOG.info below, you have to use _LI() instead of _().","commit_id":"3b47f2b16939263c2026efc9613d398ef47e49cd"},{"author":{"_account_id":12105,"name":"Edwin Wang","email":"wym.oohoo@gmail.com"},"change_message_id":"757e7efc5070358aa5ec0becb820993252807fb5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                    map(str.lower, map(str, connector[\u0027wwpns\u0027]))):"},{"line_number":154,"context_line":"                return host"},{"line_number":155,"context_line":"        else:"},{"line_number":156,"context_line":"            msg \u003d (_(\u0027Host %(host)s is not found on backend storage.\u0027)"},{"line_number":157,"context_line":"                   % {\u0027host\u0027: hname})"},{"line_number":158,"context_line":"            LOG.info(msg)"},{"line_number":159,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_6a87e2d7","line":156,"in_reply_to":"ba8a016a_8f9a58c4","updated":"2015-11-23 06:10:10.000000000","message":"Done","commit_id":"3b47f2b16939263c2026efc9613d398ef47e49cd"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"95165b1a3942c584a90a56e93a95ad53d0f31b07","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                    map(str.lower, map(str, connector[\u0027wwpns\u0027]))):"},{"line_number":155,"context_line":"                return host"},{"line_number":156,"context_line":"        else:"},{"line_number":157,"context_line":"            LOG.info(_LI(\u0027Host %(host)s is not found on backend storage.\u0027),"},{"line_number":158,"context_line":"                     {\u0027host\u0027: hname})"},{"line_number":159,"context_line":"        return None"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2509f3dd","line":157,"updated":"2015-11-25 16:29:59.000000000","message":"Suggest \"Host %(host)s was not found on backend storage.\"\n\nAlso, wonder if this shouldn\u0027t be a warning message or it is really just info?","commit_id":"58be2ff04160ddf8ab196ce0c88c26e8a815b65f"},{"author":{"_account_id":12105,"name":"Edwin Wang","email":"wym.oohoo@gmail.com"},"change_message_id":"6552439a0231697ea4cd6ec765d6c8ac8b334960","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                    map(str.lower, map(str, connector[\u0027wwpns\u0027]))):"},{"line_number":155,"context_line":"                return host"},{"line_number":156,"context_line":"        else:"},{"line_number":157,"context_line":"            LOG.info(_LI(\u0027Host %(host)s is not found on backend storage.\u0027),"},{"line_number":158,"context_line":"                     {\u0027host\u0027: hname})"},{"line_number":159,"context_line":"        return None"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_315b5f56","line":157,"in_reply_to":"9a8ffd7b_2509f3dd","updated":"2015-11-26 01:58:56.000000000","message":"Thanks, Jay!\nChanged to LOG.warning(_LW()).","commit_id":"58be2ff04160ddf8ab196ce0c88c26e8a815b65f"}]}