)]}'
{"cinder/objects/base.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"f85d602f961c6b257c1dcb138c6720a739466d12","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __contains__(self, name):"},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            # Overriding this to make properties pass \u0027foo\u0027 in obj tests"},{"line_number":128,"context_line":"            return name in self.obj_extra_fields or self.obj_attr_is_set(name)"},{"line_number":129,"context_line":"        except AttributeError:"},{"line_number":130,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_97b8dfc9","line":127,"updated":"2015-11-26 13:23:49.000000000","message":"Should probably say that you are overriding it to handle both aliases and fields.","commit_id":"14c29df43ab78d909018c9e1b35621cc4e4e9280"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0d29d8a6395cf4e2468ef2d70e583fa907b581ef","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def __contains__(self, name):"},{"line_number":126,"context_line":"        try:"},{"line_number":127,"context_line":"            # Overriding this to make properties pass \u0027foo\u0027 in obj tests"},{"line_number":128,"context_line":"            return name in self.obj_extra_fields or self.obj_attr_is_set(name)"},{"line_number":129,"context_line":"        except AttributeError:"},{"line_number":130,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_2973ca16","line":127,"in_reply_to":"9a8ffd7b_97b8dfc9","updated":"2015-11-26 17:13:33.000000000","message":"I\u0027ve reworded it a bit in the next patchset.","commit_id":"14c29df43ab78d909018c9e1b35621cc4e4e9280"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"ff67fe032ca92f8cea643b18dbc906d2b90b85f7","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def __contains__(self, name):"},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            # Overriding this to make properties pass \u0027foo\u0027 in obj tests"},{"line_number":246,"context_line":"            return name in self.obj_extra_fields or self.obj_attr_is_set(name)"},{"line_number":247,"context_line":"        except AttributeError:"},{"line_number":248,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_f9763da2","line":245,"updated":"2015-12-01 16:30:36.000000000","message":"My comments in patch #4 were not addressed.\n\nYou should update this comment to say that you are overriding it to handle both aliases and fields.","commit_id":"9a6dbdf933f345ace9a849e46e24cb020c0bf35c"}],"cinder/tests/unit/objects/test_base.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"ff67fe032ca92f8cea643b18dbc906d2b90b85f7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"@objects.base.CinderObjectRegistry.register_if(False)"},{"line_number":40,"context_line":"class TestDictObject(objects.base.CinderObjectDictCompat,"},{"line_number":41,"context_line":"                     objects.base.CinderObject):"},{"line_number":42,"context_line":"    obj_extra_fields \u003d [\u0027foo\u0027]"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_39ecc5f2","line":40,"updated":"2015-12-01 16:30:36.000000000","message":"I do not believe this test object will be used elsewhere, so it may be better to just define it in TestCinderDictObject.","commit_id":"9a6dbdf933f345ace9a849e46e24cb020c0bf35c"}]}