)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"d5f63cc5a1ec4d7229f2b39cf191beb7aa34790d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerald McBrearty \u003cgfm@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-20 19:38:18 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add config option to control flash copy rate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a flash copy of a vdisk during a clone"},{"line_number":10,"context_line":"or a snapshot operation the svcinfo mkfcmap operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_e74eb695","line":7,"updated":"2015-11-22 01:11:43.000000000","message":"s/add/Add","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"0e2e6c0a23b1d3ca2b662ec65f5273812d63f347","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Adding a configuration option storwize_copy_rate to allow"},{"line_number":18,"context_line":"an operator to specify the default copy rate when starting"},{"line_number":19,"context_line":"a vdisk flash copy on a clone or snapshot operation."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Iffa50cf934f5d340a1f24ed3cfea8381b6dd6630"},{"line_number":22,"context_line":"Closes-Bug: 1517185"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_2b58e055","line":20,"updated":"2015-11-23 16:12:14.000000000","message":"I think we need to add a DocImpact tag here since we are adding config options in __init__.py.","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"35be6e00a4526838ccf0f2ca26db818eb13f026c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Adding a configuration option storwize_copy_rate to allow"},{"line_number":18,"context_line":"an operator to specify the default copy rate when starting"},{"line_number":19,"context_line":"a vdisk flash copy on a clone or snapshot operation."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Iffa50cf934f5d340a1f24ed3cfea8381b6dd6630"},{"line_number":22,"context_line":"Closes-Bug: 1517185"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_cf941dea","line":20,"in_reply_to":"ba8a016a_2b58e055","updated":"2015-11-24 11:15:12.000000000","message":"+1","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"b6f6077d3205041086d94ab5b8410fc2e39d6ecf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerald McBrearty \u003cgfm@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-02 10:56:56 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add config option to control flash copy rate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a flash copy of a vdisk during a clone"},{"line_number":10,"context_line":"or a snapshot operation the svcinfo mkfcmap operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a8ffd7b_bdf5b8ed","line":7,"updated":"2015-12-02 17:17:48.000000000","message":"Add \u0027Storwise:\u0027 to the beginning of the commit message please - makes log reviews much easier. Thanks","commit_id":"92304ff642530fc349a5cf99b2f03f21d805a0cb"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"b242a3543ad7a804fa38ab6518225ef28e5676c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerald McBrearty \u003cgfm@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-02 11:29:23 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwise: add config option to control flash copy rate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a flash copy of a vdisk during a clone"},{"line_number":10,"context_line":"or a snapshot operation the svcinfo mkfcmap operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a8ffd7b_d031765a","line":7,"updated":"2015-12-02 21:44:41.000000000","message":"Storwise -\u003e Storwize","commit_id":"828f3db7f63f4619e2df22e51003387185e3747f"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"cb5e994e1d9ae95377b6d5ac6479d7fb5e1f298d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gerald McBrearty \u003cgfm@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-02 11:29:23 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwise: add config option to control flash copy rate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a flash copy of a vdisk during a clone"},{"line_number":10,"context_line":"or a snapshot operation the svcinfo mkfcmap operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_11624ed9","line":7,"in_reply_to":"9a8ffd7b_d031765a","updated":"2015-12-03 15:13:35.000000000","message":"yep","commit_id":"828f3db7f63f4619e2df22e51003387185e3747f"}],"cinder/tests/unit/test_storwize_svc.py":[{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"d5f63cc5a1ec4d7229f2b39cf191beb7aa34790d","unresolved":false,"context_lines":[{"line_number":2077,"context_line":"        # validate copyrate was set on the flash copy"},{"line_number":2078,"context_line":"        for i, fcmap in self.sim._fcmappings_list.iteritems():"},{"line_number":2079,"context_line":"            if fcmap[\u0027target\u0027] \u003d\u003d vol2:"},{"line_number":2080,"context_line":"                self.assertEqual(fcmap[\u0027copyrate\u0027], \u002749\u0027)"},{"line_number":2081,"context_line":"        self._assert_vol_exists(vol3[\u0027name\u0027], True)"},{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"        # Delete in the \u0027opposite\u0027 order to make sure it works"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_a73f4ed5","line":2080,"updated":"2015-11-22 01:11:43.000000000","message":"Should put the expected value as the first parameter of self.assertEqual:\nself.assertEqual(\u0027\u002749\u0027, fcmap[\u0027copyrate\u0027])","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"35be6e00a4526838ccf0f2ca26db818eb13f026c","unresolved":false,"context_lines":[{"line_number":2077,"context_line":"        # validate copyrate was set on the flash copy"},{"line_number":2078,"context_line":"        for i, fcmap in self.sim._fcmappings_list.iteritems():"},{"line_number":2079,"context_line":"            if fcmap[\u0027target\u0027] \u003d\u003d vol2:"},{"line_number":2080,"context_line":"                self.assertEqual(fcmap[\u0027copyrate\u0027], \u002749\u0027)"},{"line_number":2081,"context_line":"        self._assert_vol_exists(vol3[\u0027name\u0027], True)"},{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"        # Delete in the \u0027opposite\u0027 order to make sure it works"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6f8651bb","line":2080,"in_reply_to":"ba8a016a_a73f4ed5","updated":"2015-11-24 11:15:12.000000000","message":"+1","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"6205e01b1ef10cbf0104f95e3215dd5c7748f1a2","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"        self._assert_vol_exists(vol3[\u0027name\u0027], False)"},{"line_number":2072,"context_line":"        vol3[\u0027size\u0027] -\u003d 1"},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"        if self.USESIM:"},{"line_number":2075,"context_line":"            self.sim.error_injection(\u0027lsfcmap\u0027, \u0027speed_up\u0027)"},{"line_number":2076,"context_line":"        self.driver.create_cloned_volume(vol3, vol2)"},{"line_number":2077,"context_line":"        if self.USESIM:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_58640de4","line":2074,"updated":"2015-12-01 23:40:06.000000000","message":"Not related to this patch, but do you know if this error_injection here does anything? I stepped through it and it doesn\u0027t seem to be actually doing anything but I could be wrong...","commit_id":"8d29ea3bce6c984bfcecbfeb38c0d62321b0ad20"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"b0c27631d03b9a8aa13dc3b60e3029dbe98c6840","unresolved":false,"context_lines":[{"line_number":2071,"context_line":"        self._assert_vol_exists(vol3[\u0027name\u0027], False)"},{"line_number":2072,"context_line":"        vol3[\u0027size\u0027] -\u003d 1"},{"line_number":2073,"context_line":""},{"line_number":2074,"context_line":"        if self.USESIM:"},{"line_number":2075,"context_line":"            self.sim.error_injection(\u0027lsfcmap\u0027, \u0027speed_up\u0027)"},{"line_number":2076,"context_line":"        self.driver.create_cloned_volume(vol3, vol2)"},{"line_number":2077,"context_line":"        if self.USESIM:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_ad66f44e","line":2074,"in_reply_to":"9a8ffd7b_58640de4","updated":"2015-12-02 15:18:13.000000000","message":"It triggers the flashcopy completion percentage to go up when lsfcmap is called. Like 0 to 50 and 50 to 100%","commit_id":"8d29ea3bce6c984bfcecbfeb38c0d62321b0ad20"}],"cinder/volume/drivers/ibm/storwize_svc/__init__.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"35be6e00a4526838ccf0f2ca26db818eb13f026c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    cfg.IntOpt(\u0027storwize_copy_rate\u0027,"},{"line_number":123,"context_line":"               default\u003d50,"},{"line_number":124,"context_line":"               min\u003d1, max\u003d100,"},{"line_number":125,"context_line":"               help\u003d\u0027Specifies the flash copy rate.\u0027),"},{"line_number":126,"context_line":"]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_5241b238","line":125,"updated":"2015-11-24 11:15:12.000000000","message":"Please, specify that this param will be used only for full copy","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"38f8ea55e667811a9749b32202e01f9e258eba13","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                     \u0027creation.\u0027),"},{"line_number":122,"context_line":"    cfg.IntOpt(\u0027storwize_copy_rate\u0027,"},{"line_number":123,"context_line":"               default\u003d50,"},{"line_number":124,"context_line":"               min\u003d1, max\u003d100,"},{"line_number":125,"context_line":"               help\u003d\u0027Specifies the flash copy that is used when creating\u0027"},{"line_number":126,"context_line":"                    \u0027 a full volume copy.\u0027),"},{"line_number":127,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_de0d0d90","line":124,"updated":"2015-12-02 19:43:08.000000000","message":"Should this be \"flash copy rate\"?  Also not sure if we want to mention anything about the range in the description?","commit_id":"828f3db7f63f4619e2df22e51003387185e3747f"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"cb5e994e1d9ae95377b6d5ac6479d7fb5e1f298d","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                     \u0027creation.\u0027),"},{"line_number":122,"context_line":"    cfg.IntOpt(\u0027storwize_copy_rate\u0027,"},{"line_number":123,"context_line":"               default\u003d50,"},{"line_number":124,"context_line":"               min\u003d1, max\u003d100,"},{"line_number":125,"context_line":"               help\u003d\u0027Specifies the flash copy that is used when creating\u0027"},{"line_number":126,"context_line":"                    \u0027 a full volume copy.\u0027),"},{"line_number":127,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_5113f65c","line":124,"in_reply_to":"9a8ffd7b_9870f073","updated":"2015-12-03 15:13:35.000000000","message":"I\u0027ll need to change this, I didn\u0027t follow the naming convention of storewize_svc and I\u0027ll update the help text.\nthe option shoudl be storewize_svc_flashcopy_rate to be consistent with the flash copy timeout.","commit_id":"828f3db7f63f4619e2df22e51003387185e3747f"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"90fe0cb1d2ef6a085e5dd4ffaec92ff6ef0a07cd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                     \u0027creation.\u0027),"},{"line_number":122,"context_line":"    cfg.IntOpt(\u0027storwize_copy_rate\u0027,"},{"line_number":123,"context_line":"               default\u003d50,"},{"line_number":124,"context_line":"               min\u003d1, max\u003d100,"},{"line_number":125,"context_line":"               help\u003d\u0027Specifies the flash copy that is used when creating\u0027"},{"line_number":126,"context_line":"                    \u0027 a full volume copy.\u0027),"},{"line_number":127,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_fdbb2ec2","line":124,"in_reply_to":"9a8ffd7b_de0d0d90","updated":"2015-12-02 23:27:37.000000000","message":"It looks like all of the other config options are storwize_* as well.","commit_id":"828f3db7f63f4619e2df22e51003387185e3747f"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"b8c52027329f9ba424b9f27762e09bac780d84d1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                     \u0027creation.\u0027),"},{"line_number":122,"context_line":"    cfg.IntOpt(\u0027storwize_copy_rate\u0027,"},{"line_number":123,"context_line":"               default\u003d50,"},{"line_number":124,"context_line":"               min\u003d1, max\u003d100,"},{"line_number":125,"context_line":"               help\u003d\u0027Specifies the flash copy that is used when creating\u0027"},{"line_number":126,"context_line":"                    \u0027 a full volume copy.\u0027),"},{"line_number":127,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_9870f073","line":124,"in_reply_to":"9a8ffd7b_fdbb2ec2","updated":"2015-12-02 23:41:43.000000000","message":"Sorry, I wasn\u0027t very clear - my comment is about changing the help to s/Specifies the flash copy that/Specifies the flash copy rate that/, not the actual config name","commit_id":"828f3db7f63f4619e2df22e51003387185e3747f"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"4e5e7da22fb9b41b173fd97094585479d91d0419","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def mkfcmap(self, source, target, full_copy, copy_rate\u003d50,"},{"line_number":263,"context_line":"                consistgrp\u003dNone):"},{"line_number":264,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027mkfcmap\u0027, \u0027-source\u0027, source, \u0027-target\u0027,"},{"line_number":265,"context_line":"                   target, \u0027-autodelete\u0027]"},{"line_number":266,"context_line":"        if not full_copy:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_00ce5283","line":263,"updated":"2015-11-20 22:40:52.000000000","message":"Since this is a new kwarg, why not add it after the last existing kwarg consistgrp\u003dNone ?","commit_id":"cca1b15fee8b43f7afbda58083edb8fd819e7047"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"3d904c6c839bccc91c476a7a0d3d4cf0b99d429a","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def mkfcmap(self, source, target, full_copy, copy_rate\u003d50,"},{"line_number":263,"context_line":"                consistgrp\u003dNone):"},{"line_number":264,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027mkfcmap\u0027, \u0027-source\u0027, source, \u0027-target\u0027,"},{"line_number":265,"context_line":"                   target, \u0027-autodelete\u0027]"},{"line_number":266,"context_line":"        if not full_copy:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_7b034f77","line":263,"in_reply_to":"ba8a016a_00ce5283","updated":"2015-11-20 23:28:49.000000000","message":"Good catch I didn\u0027t start off with this a new kwarg.","commit_id":"cca1b15fee8b43f7afbda58083edb8fd819e7047"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"4e5e7da22fb9b41b173fd97094585479d91d0419","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        self.create_vdisk(target, src_size, \u0027b\u0027, pool, opts)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        self.ssh.mkfcmap(source, target, full_copy,"},{"line_number":1172,"context_line":"                         copy_rate\u003dconfig.storwize_copy_rate,"},{"line_number":1173,"context_line":"                         consistgrp\u003dconsistgrp)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        LOG.debug(\u0027Leave: create_flashcopy_to_consistgrp: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_40aa1a87","line":1172,"updated":"2015-11-20 22:40:52.000000000","message":"Why change the order of the params being added?  I\u0027d add the new option at the end of the list.","commit_id":"cca1b15fee8b43f7afbda58083edb8fd819e7047"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"3d904c6c839bccc91c476a7a0d3d4cf0b99d429a","unresolved":false,"context_lines":[{"line_number":1169,"context_line":"        self.create_vdisk(target, src_size, \u0027b\u0027, pool, opts)"},{"line_number":1170,"context_line":""},{"line_number":1171,"context_line":"        self.ssh.mkfcmap(source, target, full_copy,"},{"line_number":1172,"context_line":"                         copy_rate\u003dconfig.storwize_copy_rate,"},{"line_number":1173,"context_line":"                         consistgrp\u003dconsistgrp)"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":"        LOG.debug(\u0027Leave: create_flashcopy_to_consistgrp: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_fbf73f8a","line":1172,"in_reply_to":"ba8a016a_40aa1a87","updated":"2015-11-20 23:28:49.000000000","message":"Yes that makes sense.","commit_id":"cca1b15fee8b43f7afbda58083edb8fd819e7047"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"d5f63cc5a1ec4d7229f2b39cf191beb7aa34790d","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        if not full_copy:"},{"line_number":267,"context_line":"            ssh_cmd.extend([\u0027-copyrate\u0027, \u00270\u0027])"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            ssh_cmd.extend([\u0027-copyrate\u0027, str(copy_rate)])"},{"line_number":270,"context_line":"        if consistgrp:"},{"line_number":271,"context_line":"            ssh_cmd.extend([\u0027-consistgrp\u0027, consistgrp])"},{"line_number":272,"context_line":"        out, err \u003d self._ssh(ssh_cmd, check_exit_code\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_27559e1c","line":269,"updated":"2015-11-22 01:11:43.000000000","message":"Please use six.text_type() instead of str().","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"35be6e00a4526838ccf0f2ca26db818eb13f026c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        if not full_copy:"},{"line_number":267,"context_line":"            ssh_cmd.extend([\u0027-copyrate\u0027, \u00270\u0027])"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            ssh_cmd.extend([\u0027-copyrate\u0027, str(copy_rate)])"},{"line_number":270,"context_line":"        if consistgrp:"},{"line_number":271,"context_line":"            ssh_cmd.extend([\u0027-consistgrp\u0027, consistgrp])"},{"line_number":272,"context_line":"        out, err \u003d self._ssh(ssh_cmd, check_exit_code\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_af7199e2","line":269,"in_reply_to":"ba8a016a_27559e1c","updated":"2015-11-24 11:15:12.000000000","message":"+1","commit_id":"ec9579d0d8999c0ac9e9ad15e85f98340c641732"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"6205e01b1ef10cbf0104f95e3215dd5c7748f1a2","unresolved":false,"context_lines":[{"line_number":259,"context_line":"             \u0027-unit\u0027, \u0027gb\u0027, vdisk])"},{"line_number":260,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def mkfcmap(self, source, target, full_copy, consistgrp\u003dNone,"},{"line_number":263,"context_line":"                copy_rate\u003d50):"},{"line_number":264,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027mkfcmap\u0027, \u0027-source\u0027, source, \u0027-target\u0027,"},{"line_number":265,"context_line":"                   target, \u0027-autodelete\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_f8b9412f","line":262,"updated":"2015-12-01 23:40:06.000000000","message":"Does this actually need to be an optional param, seems like we\u0027re passing it in everywhere we call this from and we already default to 50 in config?","commit_id":"8d29ea3bce6c984bfcecbfeb38c0d62321b0ad20"},{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"b0c27631d03b9a8aa13dc3b60e3029dbe98c6840","unresolved":false,"context_lines":[{"line_number":259,"context_line":"             \u0027-unit\u0027, \u0027gb\u0027, vdisk])"},{"line_number":260,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def mkfcmap(self, source, target, full_copy, consistgrp\u003dNone,"},{"line_number":263,"context_line":"                copy_rate\u003d50):"},{"line_number":264,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027mkfcmap\u0027, \u0027-source\u0027, source, \u0027-target\u0027,"},{"line_number":265,"context_line":"                   target, \u0027-autodelete\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_eddf1cd4","line":262,"in_reply_to":"9a8ffd7b_f8b9412f","updated":"2015-12-02 15:18:13.000000000","message":"Good catch it doesn\u0027t need to be.","commit_id":"8d29ea3bce6c984bfcecbfeb38c0d62321b0ad20"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"6205e01b1ef10cbf0104f95e3215dd5c7748f1a2","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"            return mapping_ready"},{"line_number":1131,"context_line":"        self._wait_for_a_condition(prepare_fc_consistgrp_success, timeout)"},{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    def run_flashcopy(self, source, target, timeout, full_copy\u003dTrue,"},{"line_number":1134,"context_line":"                      copy_rate\u003d50):"},{"line_number":1135,"context_line":"        \"\"\"Create a FlashCopy mapping from the source to the target.\"\"\""},{"line_number":1136,"context_line":"        LOG.debug(\u0027Enter: run_flashcopy: execute FlashCopy from source \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_b882d950","line":1133,"updated":"2015-12-01 23:40:06.000000000","message":"^ ditto","commit_id":"8d29ea3bce6c984bfcecbfeb38c0d62321b0ad20"}]}