)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"0291cfa3ac20e3d30aefa3ed3b826a25ba364171","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix iscsi chap discovery bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* use the correct setting parameter name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8e61394ba5109f2a6c7018855f8b85133bc76412"},{"line_number":12,"context_line":"Closes-Bug: #1518945"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_6d3162a2","line":9,"updated":"2015-11-24 17:17:33.000000000","message":"Can you please provide more detail here about why this was necessary?  Was it changed or just a bug that has always been in place?  Thanks!","commit_id":"ccfdfdd9803093e4098f2b4cbe7251d6436f1dd3"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"851e05fc616bb02c2d2c80b97afecefea83d87d4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix iscsi chap discovery bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* use the correct setting parameter name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8e61394ba5109f2a6c7018855f8b85133bc76412"},{"line_number":12,"context_line":"Closes-Bug: #1518945"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_77359244","line":9,"in_reply_to":"9a8ffd7b_6d3162a2","updated":"2015-11-25 07:50:24.000000000","message":"Done","commit_id":"ccfdfdd9803093e4098f2b4cbe7251d6436f1dd3"}],"cinder/volume/drivers/emc/xtremio.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d7f0c37e6593dbbc3144ad577bcd71c9df8d88fe","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        if discovery_chap:"},{"line_number":727,"context_line":"            data[\u0027initiator-discovery-user-name\u0027] \u003d \u0027chap_user\u0027"},{"line_number":728,"context_line":"            discovery_passwd \u003d self._get_password()"},{"line_number":729,"context_line":"            data[\u0027initiator-discovery-password\u0027] \u003d discovery_passwd"},{"line_number":730,"context_line":"        return login_passwd, discovery_passwd"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    def _create_initiator(self, connector, login_chap, discovery_chap):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_7554d753","line":729,"updated":"2015-12-03 16:44:05.000000000","message":"I think you can write a small unit test just for _add_auth and assert that \u0027initiator-discovery-password\u0027 is in data and not \u0027chap-discovery-initiator-password\u0027.","commit_id":"923f87b518d1d6e67c9408f0573f6730e1d57952"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"02c1d279c4c78e49de53f9ec9d5fde84f0a26b1f","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        if discovery_chap:"},{"line_number":727,"context_line":"            data[\u0027initiator-discovery-user-name\u0027] \u003d \u0027chap_user\u0027"},{"line_number":728,"context_line":"            discovery_passwd \u003d self._get_password()"},{"line_number":729,"context_line":"            data[\u0027initiator-discovery-password\u0027] \u003d discovery_passwd"},{"line_number":730,"context_line":"        return login_passwd, discovery_passwd"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    def _create_initiator(self, connector, login_chap, discovery_chap):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_245fa20f","line":729,"in_reply_to":"7a740942_7554d753","updated":"2015-12-06 12:57:38.000000000","message":"Done","commit_id":"923f87b518d1d6e67c9408f0573f6730e1d57952"}]}
