)]}'
{"cinder/tests/unit/test_vmware_vmdk.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"8cc2f73ee229242e18c3802eb61f9b7c7611c8f6","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _create_image_meta(self,"},{"line_number":309,"context_line":"                           disk_format\u003d\u0027vmdk\u0027,"},{"line_number":310,"context_line":"                           size\u003d1*units.Gi,"},{"line_number":311,"context_line":"                           container_format\u003d\u0027bare\u0027,"},{"line_number":312,"context_line":"                           vmware_disktype\u003d\u0027streamOptimized\u0027,"},{"line_number":313,"context_line":"                           vmware_adaptertype\u003d\u0027lsiLogic\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_61909896","line":310,"updated":"2015-11-24 15:14:17.000000000","message":"Should be size\u003dunits.Gi","commit_id":"11ae8b8deaae31da6033fbf0cacf97a0a5d1bb6a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"16364be1829edac1132170195ecf2f81c2dc72cd","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _create_image_meta(self,"},{"line_number":309,"context_line":"                           disk_format\u003d\u0027vmdk\u0027,"},{"line_number":310,"context_line":"                           size\u003d1*units.Gi,"},{"line_number":311,"context_line":"                           container_format\u003d\u0027bare\u0027,"},{"line_number":312,"context_line":"                           vmware_disktype\u003d\u0027streamOptimized\u0027,"},{"line_number":313,"context_line":"                           vmware_adaptertype\u003d\u0027lsiLogic\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8c258dac","line":310,"in_reply_to":"9a8ffd7b_306894f5","updated":"2015-11-25 06:30:03.000000000","message":"units.Gi is a constant factor for converting disk sizes to different units. The expression 1 * units.Gi emphasizes that we need a size of 1G. I find this slightly more readable and there are several examples in our code base which supports that:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_gpfs.py#L1861\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_hpelefthand.py#L1582\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_nfs.py#L431\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/test_solidfire.py#L168\n\nOf course it is a matter of personal taste and there is nothing wrong writing either way. I hope it answers your concern.","commit_id":"11ae8b8deaae31da6033fbf0cacf97a0a5d1bb6a"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"1da38b48e4624c129483cdadf91bfd52667942dd","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _create_image_meta(self,"},{"line_number":309,"context_line":"                           disk_format\u003d\u0027vmdk\u0027,"},{"line_number":310,"context_line":"                           size\u003d1*units.Gi,"},{"line_number":311,"context_line":"                           container_format\u003d\u0027bare\u0027,"},{"line_number":312,"context_line":"                           vmware_disktype\u003d\u0027streamOptimized\u0027,"},{"line_number":313,"context_line":"                           vmware_adaptertype\u003d\u0027lsiLogic\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_f0b44cd2","line":310,"in_reply_to":"9a8ffd7b_61909896","updated":"2015-11-24 16:23:32.000000000","message":"I believe this should actually be size\u003d1 * units.Gi The whitespace is why pep8 failed.","commit_id":"11ae8b8deaae31da6033fbf0cacf97a0a5d1bb6a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"16364be1829edac1132170195ecf2f81c2dc72cd","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _create_image_meta(self,"},{"line_number":309,"context_line":"                           disk_format\u003d\u0027vmdk\u0027,"},{"line_number":310,"context_line":"                           size\u003d1*units.Gi,"},{"line_number":311,"context_line":"                           container_format\u003d\u0027bare\u0027,"},{"line_number":312,"context_line":"                           vmware_disktype\u003d\u0027streamOptimized\u0027,"},{"line_number":313,"context_line":"                           vmware_adaptertype\u003d\u0027lsiLogic\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b1630a1a","line":310,"in_reply_to":"9a8ffd7b_f0b44cd2","updated":"2015-11-25 06:30:03.000000000","message":"Done","commit_id":"11ae8b8deaae31da6033fbf0cacf97a0a5d1bb6a"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"dcb76649f3bfef8cf3b8765f96ec109d85308f0d","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _create_image_meta(self,"},{"line_number":309,"context_line":"                           disk_format\u003d\u0027vmdk\u0027,"},{"line_number":310,"context_line":"                           size\u003d1*units.Gi,"},{"line_number":311,"context_line":"                           container_format\u003d\u0027bare\u0027,"},{"line_number":312,"context_line":"                           vmware_disktype\u003d\u0027streamOptimized\u0027,"},{"line_number":313,"context_line":"                           vmware_adaptertype\u003d\u0027lsiLogic\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_306894f5","line":310,"in_reply_to":"9a8ffd7b_f0b44cd2","updated":"2015-11-24 16:27:04.000000000","message":"it makes no sense to multiply by 1","commit_id":"11ae8b8deaae31da6033fbf0cacf97a0a5d1bb6a"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"e1add1f3514b2cba242d20acfc0b6517535a5c21","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _create_image_meta(self,"},{"line_number":309,"context_line":"                           disk_format\u003d\u0027vmdk\u0027,"},{"line_number":310,"context_line":"                           size\u003d1 * units.Gi,"},{"line_number":311,"context_line":"                           container_format\u003d\u0027bare\u0027,"},{"line_number":312,"context_line":"                           vmware_disktype\u003d\u0027streamOptimized\u0027,"},{"line_number":313,"context_line":"                           vmware_adaptertype\u003d\u0027lsiLogic\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_4c5aa9f3","line":310,"updated":"2015-11-27 19:45:40.000000000","message":"What sense is in this multiplication. Did I miss something?","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"afa4526342b450e71abf3a369ba68671656d32d7","unresolved":false,"context_lines":[{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    def _create_image_meta(self,"},{"line_number":309,"context_line":"                           disk_format\u003d\u0027vmdk\u0027,"},{"line_number":310,"context_line":"                           size\u003d1 * units.Gi,"},{"line_number":311,"context_line":"                           container_format\u003d\u0027bare\u0027,"},{"line_number":312,"context_line":"                           vmware_disktype\u003d\u0027streamOptimized\u0027,"},{"line_number":313,"context_line":"                           vmware_adaptertype\u003d\u0027lsiLogic\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_4d257eac","line":310,"in_reply_to":"9a8ffd7b_4c5aa9f3","updated":"2015-11-30 20:02:02.000000000","message":"See Vipin\u0027s comment on the 1st patchset for an explanation. It\u0027s pretty much down to readability as far as I understand.","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"79b5a5432246bc414f5839be24963e672f9d0975","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            create_disk_from_non_stream_opt_image,"},{"line_number":349,"context_line":"            vmware_disk_type,"},{"line_number":350,"context_line":"            backing_disk_size\u003dVOL_SIZE,"},{"line_number":351,"context_line":"            call_extend_backing\u003dFalse):"},{"line_number":352,"context_line":"        image_service \u003d mock.Mock()"},{"line_number":353,"context_line":"        image_meta \u003d self._create_image_meta(vmware_disktype\u003dvmware_disk_type)"},{"line_number":354,"context_line":"        image_service.show.return_value \u003d image_meta"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_f7f4ddcf","line":351,"updated":"2015-12-02 10:03:31.000000000","message":"nit: This is actually harder to read, it would be neater if these parameters were at least aligned with the (","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2b70255f04a6c3b0ffb4c3bdb52186ec25cea0b1","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            create_disk_from_non_stream_opt_image,"},{"line_number":349,"context_line":"            vmware_disk_type,"},{"line_number":350,"context_line":"            backing_disk_size\u003dVOL_SIZE,"},{"line_number":351,"context_line":"            call_extend_backing\u003dFalse):"},{"line_number":352,"context_line":"        image_service \u003d mock.Mock()"},{"line_number":353,"context_line":"        image_meta \u003d self._create_image_meta(vmware_disktype\u003dvmware_disk_type)"},{"line_number":354,"context_line":"        image_service.show.return_value \u003d image_meta"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_b3ee60eb","line":351,"in_reply_to":"9a8ffd7b_f7f4ddcf","updated":"2015-12-02 12:44:56.000000000","message":"Done","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"79b5a5432246bc414f5839be24963e672f9d0975","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":397,"context_line":"                       \u0027_fetch_stream_optimized_image\u0027)"},{"line_number":398,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":399,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_extend_backing\u0027)"},{"line_number":400,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027, \u0027streamOptimized\u0027)"},{"line_number":401,"context_line":"    def test_copy_image_to_volume("},{"line_number":402,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d7af59e1","line":399,"updated":"2015-12-02 10:03:31.000000000","message":"-1: These mocks should be done in `_test_copy_image_to_volume` instead of here since they have no use here.","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"08294a3e6fed4bdace9760d3d3ff4bf10cd45285","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":397,"context_line":"                       \u0027_fetch_stream_optimized_image\u0027)"},{"line_number":398,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":399,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_extend_backing\u0027)"},{"line_number":400,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027, \u0027streamOptimized\u0027)"},{"line_number":401,"context_line":"    def test_copy_image_to_volume("},{"line_number":402,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_434deb70","line":399,"in_reply_to":"9a8ffd7b_32b9137a","updated":"2015-12-02 11:01:41.000000000","message":"You can move decorators to the helper, it will work.\n\nPS: Good idea not to copy paste.  :-)","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2b70255f04a6c3b0ffb4c3bdb52186ec25cea0b1","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":397,"context_line":"                       \u0027_fetch_stream_optimized_image\u0027)"},{"line_number":398,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":399,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_extend_backing\u0027)"},{"line_number":400,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027, \u0027streamOptimized\u0027)"},{"line_number":401,"context_line":"    def test_copy_image_to_volume("},{"line_number":402,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_93c0fc51","line":399,"in_reply_to":"9a8ffd7b_434deb70","updated":"2015-12-02 12:44:56.000000000","message":"Done","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"fdc2fe38bd12eaa058293d34cbd7e0a3ae8b7630","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":397,"context_line":"                       \u0027_fetch_stream_optimized_image\u0027)"},{"line_number":398,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":399,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_extend_backing\u0027)"},{"line_number":400,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027, \u0027streamOptimized\u0027)"},{"line_number":401,"context_line":"    def test_copy_image_to_volume("},{"line_number":402,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_32b9137a","line":399,"in_reply_to":"9a8ffd7b_d7af59e1","updated":"2015-12-02 10:26:51.000000000","message":"Gorka,\n\nCan we move this decorators to a helper? I don\u0027t think it will work. \n\nAre you saying that we should mock with context manager within _test_copy_image_to_volume? I find the decorators cleaner than the context manager approach. But if you insist, I will change.\n\nI\u0027ve the same the response to your remaining comments. I don\u0027t want to copy-paste :)","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"79b5a5432246bc414f5839be24963e672f9d0975","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":426,"context_line":"                       \u0027_fetch_stream_optimized_image\u0027)"},{"line_number":427,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":428,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_extend_backing\u0027)"},{"line_number":429,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027, \u0027streamOptimized\u0027)"},{"line_number":430,"context_line":"    def test_copy_image_to_volume_with_extend_backing("},{"line_number":431,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_f7aa9dd1","line":428,"updated":"2015-12-02 10:03:31.000000000","message":"-1: These mocks should be done in `_test_copy_image_to_volume` instead of here since they have no use here.","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2b70255f04a6c3b0ffb4c3bdb52186ec25cea0b1","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":426,"context_line":"                       \u0027_fetch_stream_optimized_image\u0027)"},{"line_number":427,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":428,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_extend_backing\u0027)"},{"line_number":429,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027, \u0027streamOptimized\u0027)"},{"line_number":430,"context_line":"    def test_copy_image_to_volume_with_extend_backing("},{"line_number":431,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_93a79cbc","line":428,"in_reply_to":"9a8ffd7b_f7aa9dd1","updated":"2015-12-02 12:44:56.000000000","message":"Done","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"79b5a5432246bc414f5839be24963e672f9d0975","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":550,"context_line":"                       \u0027_create_virtual_disk_from_preallocated_image\u0027)"},{"line_number":551,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_select_ds_for_volume\u0027)"},{"line_number":552,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_delete_temp_backing\u0027)"},{"line_number":553,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027)"},{"line_number":554,"context_line":"    def test_create_volume_from_non_stream_optimized_image("},{"line_number":555,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_b7b41535","line":552,"updated":"2015-12-02 10:03:31.000000000","message":"-1: These mocks should be done in `_test_create_volume_from_non_stream_optimized_image` instead of here since they have no use here.","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2b70255f04a6c3b0ffb4c3bdb52186ec25cea0b1","unresolved":false,"context_lines":[{"line_number":549,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":550,"context_line":"                       \u0027_create_virtual_disk_from_preallocated_image\u0027)"},{"line_number":551,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_select_ds_for_volume\u0027)"},{"line_number":552,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_delete_temp_backing\u0027)"},{"line_number":553,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027)"},{"line_number":554,"context_line":"    def test_create_volume_from_non_stream_optimized_image("},{"line_number":555,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_13940c41","line":552,"in_reply_to":"9a8ffd7b_b7b41535","updated":"2015-12-02 12:44:56.000000000","message":"Done","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"79b5a5432246bc414f5839be24963e672f9d0975","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":583,"context_line":"                       \u0027_create_virtual_disk_from_preallocated_image\u0027)"},{"line_number":584,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_select_ds_for_volume\u0027)"},{"line_number":585,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_delete_temp_backing\u0027)"},{"line_number":586,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027)"},{"line_number":587,"context_line":"    def test_create_volume_from_non_stream_opt_image_with_disk_conversion("},{"line_number":588,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d7967993","line":585,"updated":"2015-12-02 10:03:31.000000000","message":"-1: These mocks should be done in `_test_create_volume_from_non_stream_optimized_image` instead of here since they have no use here.","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"2b70255f04a6c3b0ffb4c3bdb52186ec25cea0b1","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    @mock.patch.object(VMDK_DRIVER,"},{"line_number":583,"context_line":"                       \u0027_create_virtual_disk_from_preallocated_image\u0027)"},{"line_number":584,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_select_ds_for_volume\u0027)"},{"line_number":585,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_delete_temp_backing\u0027)"},{"line_number":586,"context_line":"    @ddt.data(\u0027sparse\u0027, \u0027preallocated\u0027)"},{"line_number":587,"context_line":"    def test_create_volume_from_non_stream_opt_image_with_disk_conversion("},{"line_number":588,"context_line":"            self,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d399a47a","line":585,"in_reply_to":"9a8ffd7b_d7967993","updated":"2015-12-02 12:44:56.000000000","message":"Done","commit_id":"8aa0a0820cdbe875b2da2d0520b5b422cc48bd7a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e245088032fdda61fa5e0d35a57769cbb7e979dd","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                   validate_image_disk_type,"},{"line_number":358,"context_line":"                                   validate_image_adapter_type,"},{"line_number":359,"context_line":"                                   validate_disk_format,"},{"line_number":360,"context_line":"                                   vmware_disk_type\u003d\u0027streamOptimized\u0027,"},{"line_number":361,"context_line":"                                   backing_disk_size\u003dVOL_SIZE,"},{"line_number":362,"context_line":"                                   call_extend_backing\u003dFalse):"},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_c0918748","line":360,"updated":"2015-12-03 11:38:09.000000000","message":"I would have passed these 3 as positional arguments instead of optional and passed them in `test_copy_image_to_volume`, but this is fine as well.","commit_id":"c09770af672ebc482fc488f5922bb1bcc0f81679"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e245088032fdda61fa5e0d35a57769cbb7e979dd","unresolved":false,"context_lines":[{"line_number":431,"context_line":"            generate_uuid,"},{"line_number":432,"context_line":"            check_disk_conversion,"},{"line_number":433,"context_line":"            get_disk_type,"},{"line_number":434,"context_line":"            image_disk_type\u003d\u0027sparse\u0027,"},{"line_number":435,"context_line":"            disk_conversion\u003dFalse):"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"        disk_type \u003d mock.sentinel.disk_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_00fb0f48","line":434,"updated":"2015-12-03 11:38:09.000000000","message":"Same here.","commit_id":"c09770af672ebc482fc488f5922bb1bcc0f81679"}]}