)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"a7942a5f6caa0750a7d2a1a8cfc904ada0f1c3e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vipin Balachandran \u003cvbala@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-24 18:02:54 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Unit test refactoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are cases where a single test tests multiple methods. This"},{"line_number":10,"context_line":"patch refactors the unit tests for the following methods in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_f03f6cd4","line":7,"updated":"2015-11-24 16:35:11.000000000","message":"It would be helpful if you added a little more info on this first line that helps show this is the second unit test refactoring patch.","commit_id":"680331b026d7c206b2ea44e01589fe8a67d174fc"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cf05d777cc0605839375b667e09132ffa66c5ed1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vipin Balachandran \u003cvbala@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-24 18:02:54 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: Unit test refactoring"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are cases where a single test tests multiple methods. This"},{"line_number":10,"context_line":"patch refactors the unit tests for the following methods in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_d731dea3","line":7,"in_reply_to":"9a8ffd7b_f03f6cd4","updated":"2015-11-25 07:13:46.000000000","message":"Done","commit_id":"680331b026d7c206b2ea44e01589fe8a67d174fc"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"a7942a5f6caa0750a7d2a1a8cfc904ada0f1c3e1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   * _fetch_stream_optimized_image"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There will be follow-up patches to fix the remaining unit tests."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6b738f08b89e518c78a26a934fead42cc86e0c24"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_9b13a15c","line":17,"updated":"2015-11-24 16:35:11.000000000","message":"Add a Depends-On:\u003cgerrit change-id\u003e tag here.","commit_id":"680331b026d7c206b2ea44e01589fe8a67d174fc"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cf05d777cc0605839375b667e09132ffa66c5ed1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"   * _fetch_stream_optimized_image"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There will be follow-up patches to fix the remaining unit tests."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6b738f08b89e518c78a26a934fead42cc86e0c24"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_37214a4e","line":17,"in_reply_to":"9a8ffd7b_9b13a15c","updated":"2015-11-25 07:13:46.000000000","message":"Done","commit_id":"680331b026d7c206b2ea44e01589fe8a67d174fc"}],"cinder/tests/unit/test_vmware_vmdk.py":[{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"0c16d6a700e5bbb2a89a193e44b03c42e5a5136f","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                           \u0027container_format\u0027: \u0027bare\u0027,"},{"line_number":840,"context_line":"                           \u0027properties\u0027: {\u0027vmware_disktype\u0027: \u0027streamOptimized\u0027,"},{"line_number":841,"context_line":"                                          \u0027vmware_adaptertype\u0027: adapter_type}}"},{"line_number":842,"context_line":"        image_service \u003d mock.Mock(glance.GlanceImageService)"},{"line_number":843,"context_line":"        fake_host \u003d mock.sentinel.host"},{"line_number":844,"context_line":"        fake_rp \u003d mock.sentinel.rp"},{"line_number":845,"context_line":"        fake_folder \u003d mock.sentinel.folder"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_7055bc1b","side":"PARENT","line":842,"updated":"2015-11-24 16:28:48.000000000","message":"Since you removed glance from being used in this test, you should remove the import in line 32 as well.","commit_id":"11ae8b8deaae31da6033fbf0cacf97a0a5d1bb6a"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"0c16d6a700e5bbb2a89a193e44b03c42e5a5136f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from oslo_vmware import image_transfer"},{"line_number":29,"context_line":"import six"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from cinder import exception as cinder_exceptions"},{"line_number":32,"context_line":"from cinder.image import glance"},{"line_number":33,"context_line":"from cinder import test"},{"line_number":34,"context_line":"from cinder.volume import configuration"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_1018f083","line":31,"updated":"2015-11-24 16:28:48.000000000","message":"If you aren\u0027t using this in the updated test, it should be removed from the imports. (see line 842 of the original test)","commit_id":"680331b026d7c206b2ea44e01589fe8a67d174fc"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"cf05d777cc0605839375b667e09132ffa66c5ed1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from oslo_vmware import image_transfer"},{"line_number":29,"context_line":"import six"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from cinder import exception as cinder_exceptions"},{"line_number":32,"context_line":"from cinder.image import glance"},{"line_number":33,"context_line":"from cinder import test"},{"line_number":34,"context_line":"from cinder.volume import configuration"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b7d3fa37","line":31,"in_reply_to":"9a8ffd7b_1018f083","updated":"2015-11-25 07:13:46.000000000","message":"Done","commit_id":"680331b026d7c206b2ea44e01589fe8a67d174fc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c634cc6ee0cb383438c311307dc5d01ec96b285e","unresolved":false,"context_lines":[{"line_number":867,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_extra_config\u0027)"},{"line_number":868,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":869,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":870,"context_line":"    @mock.patch.object(image_transfer, \u0027download_stream_optimized_image\u0027)"},{"line_number":871,"context_line":"    def test_copy_image_to_volume_stream_optimized("},{"line_number":872,"context_line":"            self,"},{"line_number":873,"context_line":"            download_image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_57dda912","line":870,"updated":"2015-12-02 10:15:17.000000000","message":"-1: Better move these mocks to `_test_copy_image_to_volume_stream_optimized`","commit_id":"91a3e12490ed6c7d70b5dba62ef3e9060b15125d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f7bbdcab9034a5681699cc56e8a20d6f302c5229","unresolved":false,"context_lines":[{"line_number":867,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_extra_config\u0027)"},{"line_number":868,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":869,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":870,"context_line":"    @mock.patch.object(image_transfer, \u0027download_stream_optimized_image\u0027)"},{"line_number":871,"context_line":"    def test_copy_image_to_volume_stream_optimized("},{"line_number":872,"context_line":"            self,"},{"line_number":873,"context_line":"            download_image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_ae5fd70d","line":870,"in_reply_to":"9a8ffd7b_57dda912","updated":"2015-12-02 12:54:52.000000000","message":"Done","commit_id":"91a3e12490ed6c7d70b5dba62ef3e9060b15125d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d943ba819beaad74f70cd4f4a0e6a928524d99db","unresolved":false,"context_lines":[{"line_number":867,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_extra_config\u0027)"},{"line_number":868,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":869,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":870,"context_line":"    @mock.patch.object(image_transfer, \u0027download_stream_optimized_image\u0027)"},{"line_number":871,"context_line":"    def test_copy_image_to_volume_stream_optimized("},{"line_number":872,"context_line":"            self,"},{"line_number":873,"context_line":"            download_image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c83fb823","line":870,"in_reply_to":"9a8ffd7b_57dda912","updated":"2015-12-02 10:54:28.000000000","message":"Hi Gorka,\n\nI\u0027ve responded to this comment in the dependent patch. Please comment there.","commit_id":"91a3e12490ed6c7d70b5dba62ef3e9060b15125d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c634cc6ee0cb383438c311307dc5d01ec96b285e","unresolved":false,"context_lines":[{"line_number":888,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_extra_config\u0027)"},{"line_number":889,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":890,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":891,"context_line":"    @mock.patch.object(image_transfer, \u0027download_stream_optimized_image\u0027)"},{"line_number":892,"context_line":"    def test_copy_image_to_volume_stream_optimized_with_download_error("},{"line_number":893,"context_line":"            self,"},{"line_number":894,"context_line":"            download_image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_17e721e5","line":891,"updated":"2015-12-02 10:15:17.000000000","message":"-1: Better move these mocks to `_test_copy_image_to_volume_stream_optimized`","commit_id":"91a3e12490ed6c7d70b5dba62ef3e9060b15125d"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"f7bbdcab9034a5681699cc56e8a20d6f302c5229","unresolved":false,"context_lines":[{"line_number":888,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027_get_extra_config\u0027)"},{"line_number":889,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027volumeops\u0027)"},{"line_number":890,"context_line":"    @mock.patch.object(VMDK_DRIVER, \u0027session\u0027)"},{"line_number":891,"context_line":"    @mock.patch.object(image_transfer, \u0027download_stream_optimized_image\u0027)"},{"line_number":892,"context_line":"    def test_copy_image_to_volume_stream_optimized_with_download_error("},{"line_number":893,"context_line":"            self,"},{"line_number":894,"context_line":"            download_image,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6e9c8fc0","line":891,"in_reply_to":"9a8ffd7b_17e721e5","updated":"2015-12-02 12:54:52.000000000","message":"Done","commit_id":"91a3e12490ed6c7d70b5dba62ef3e9060b15125d"}]}