)]}'
{"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"630af6eae05a941059617d8e943a9146297bc3a7","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            thick_provisioning_support\u003dnot thin_enabled,"},{"line_number":244,"context_line":"            total_volumes\u003dtotal_volumes,"},{"line_number":245,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":246,"context_line":"            goodness_function\u003dself.get_goodness_function(),"},{"line_number":247,"context_line":"            multiattach\u003dTrue"},{"line_number":248,"context_line":"        ))"},{"line_number":249,"context_line":"        data[\"pools\"].append(single_pool)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_52665cee","line":246,"updated":"2015-11-25 07:36:33.000000000","message":"The multiattach is already defined under pool dict. Do we really need to define this under data dict directly?","commit_id":"36ce300f728250debc0a44dbb76a6371e3881396"},{"author":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"change_message_id":"9daf721653310644234ef996bdaede3443d3702d","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            thick_provisioning_support\u003dnot thin_enabled,"},{"line_number":244,"context_line":"            total_volumes\u003dtotal_volumes,"},{"line_number":245,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":246,"context_line":"            goodness_function\u003dself.get_goodness_function(),"},{"line_number":247,"context_line":"            multiattach\u003dTrue"},{"line_number":248,"context_line":"        ))"},{"line_number":249,"context_line":"        data[\"pools\"].append(single_pool)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_cbf132cf","line":246,"in_reply_to":"9a8ffd7b_52665cee","updated":"2015-11-25 10:28:58.000000000","message":"Hi, I\u0027m sorry, I\u0027m wrong, you are right. These\u0027s no need to define that under data dict.","commit_id":"36ce300f728250debc0a44dbb76a6371e3881396"},{"author":{"_account_id":11676,"name":"wuyuting","email":"wytdahu@gmail.com","username":"wuyuting"},"change_message_id":"23c871c4c94d7541dd22dfee842638aee4595635","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            thick_provisioning_support\u003dnot thin_enabled,"},{"line_number":244,"context_line":"            total_volumes\u003dtotal_volumes,"},{"line_number":245,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":246,"context_line":"            goodness_function\u003dself.get_goodness_function(),"},{"line_number":247,"context_line":"            multiattach\u003dTrue"},{"line_number":248,"context_line":"        ))"},{"line_number":249,"context_line":"        data[\"pools\"].append(single_pool)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_92bb6472","line":246,"in_reply_to":"9a8ffd7b_52665cee","updated":"2015-11-25 07:57:59.000000000","message":"I have checked the code of cinder-scheduler, cinder-scheduler check  the capability of cinder-volume host by data dict, rather than nested dict. So, I think it\u0027s necessary to declare the feature under data dict.","commit_id":"36ce300f728250debc0a44dbb76a6371e3881396"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"14045029f72f4fbaabdd2b1bed679d32f48fbc87","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            thick_provisioning_support\u003dnot thin_enabled,"},{"line_number":244,"context_line":"            total_volumes\u003dtotal_volumes,"},{"line_number":245,"context_line":"            filter_function\u003dself.get_filter_function(),"},{"line_number":246,"context_line":"            goodness_function\u003dself.get_goodness_function(),"},{"line_number":247,"context_line":"            multiattach\u003dTrue"},{"line_number":248,"context_line":"        ))"},{"line_number":249,"context_line":"        data[\"pools\"].append(single_pool)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_8dfecb69","line":246,"in_reply_to":"9a8ffd7b_cbf132cf","updated":"2015-11-25 15:29:07.000000000","message":"Sure. Thank you for your confirmation.","commit_id":"36ce300f728250debc0a44dbb76a6371e3881396"}]}