)]}'
{"cinder/volume/drivers/emc/scaleio.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0ccf4a19955f33f04a04d3abc81f7b1faf8e55f2","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                LOG.error(exception_msg)"},{"line_number":424,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexception_msg)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _round_to_8_gran(self, size):"},{"line_number":427,"context_line":"        if size%8\u003d\u003d0:"},{"line_number":428,"context_line":"            return size"},{"line_number":429,"context_line":"        return size + 8 - (size%8)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_bf4f4c91","line":426,"updated":"2015-11-25 09:37:25.000000000","message":"I think you should add a comment here, what this method does, and why it is important. Also, it can be static.","commit_id":"2d90075c5ce11a8ead78ebd0a6b6e3bb895d1591"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7d4f6f8db17e9df48fae5a78b9db6925305d8ff","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                LOG.error(exception_msg)"},{"line_number":424,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexception_msg)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def _round_to_8_gran(self, size):"},{"line_number":427,"context_line":"        if size%8\u003d\u003d0:"},{"line_number":428,"context_line":"            return size"},{"line_number":429,"context_line":"        return size + 8 - (size%8)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_36a0479f","line":426,"in_reply_to":"9a8ffd7b_bf4f4c91","updated":"2015-11-25 18:15:51.000000000","message":"Removed this function as you suggested below.","commit_id":"2d90075c5ce11a8ead78ebd0a6b6e3bb895d1591"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"0ccf4a19955f33f04a04d3abc81f7b1faf8e55f2","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                   \"/action/setVolumeSize\") % req_vars"},{"line_number":547,"context_line":"        LOG.info(_LI(\"Change volume capacity request: %s.\"), request)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        volume_new_size \u003d self._round_to_8_gran(new_size)"},{"line_number":550,"context_line":"        round_volume_capacity \u003d self.configuration.sio_round_volume_capacity"},{"line_number":551,"context_line":"        if (not round_volume_capacity and not new_size % 8 \u003d\u003d 0):"},{"line_number":552,"context_line":"            LOG.warning(_LW("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_ba799a95","line":549,"updated":"2015-11-25 09:37:25.000000000","message":"I think that maybe you don\u0027t even need the _round_to_8_gran method, just use the ternary expression form of the if. That wouldn\u0027t end up with more code. And you only call the method here.","commit_id":"2d90075c5ce11a8ead78ebd0a6b6e3bb895d1591"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7d4f6f8db17e9df48fae5a78b9db6925305d8ff","unresolved":false,"context_lines":[{"line_number":546,"context_line":"                   \"/action/setVolumeSize\") % req_vars"},{"line_number":547,"context_line":"        LOG.info(_LI(\"Change volume capacity request: %s.\"), request)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        volume_new_size \u003d self._round_to_8_gran(new_size)"},{"line_number":550,"context_line":"        round_volume_capacity \u003d self.configuration.sio_round_volume_capacity"},{"line_number":551,"context_line":"        if (not round_volume_capacity and not new_size % 8 \u003d\u003d 0):"},{"line_number":552,"context_line":"            LOG.warning(_LW("}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_b6abd788","line":549,"in_reply_to":"9a8ffd7b_ba799a95","updated":"2015-11-25 18:15:51.000000000","message":"Done","commit_id":"2d90075c5ce11a8ead78ebd0a6b6e3bb895d1591"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a2f23c6032ed3b8703055cb46a3e97c918707f84","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        round_volume_capacity \u003d self.configuration.sio_round_volume_capacity"},{"line_number":551,"context_line":"        if (not round_volume_capacity and not new_size % 8 \u003d\u003d 0):"},{"line_number":552,"context_line":"            LOG.warning(_LW("},{"line_number":553,"context_line":"                        \"ScaleIO only supports volumes with a granularity of\""},{"line_number":554,"context_line":"                         \"8 GB. The new volume size is: %d\"), volume_new_size)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        params \u003d {\u0027sizeInGB\u0027: six.text_type(volume_new_size)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8820f99c","line":553,"updated":"2015-11-25 15:35:31.000000000","message":"Missing space at EOL.","commit_id":"2d90075c5ce11a8ead78ebd0a6b6e3bb895d1591"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c7d4f6f8db17e9df48fae5a78b9db6925305d8ff","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        round_volume_capacity \u003d self.configuration.sio_round_volume_capacity"},{"line_number":551,"context_line":"        if (not round_volume_capacity and not new_size % 8 \u003d\u003d 0):"},{"line_number":552,"context_line":"            LOG.warning(_LW("},{"line_number":553,"context_line":"                        \"ScaleIO only supports volumes with a granularity of\""},{"line_number":554,"context_line":"                         \"8 GB. The new volume size is: %d\"), volume_new_size)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"        params \u003d {\u0027sizeInGB\u0027: six.text_type(volume_new_size)}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_16a503b4","line":553,"in_reply_to":"9a8ffd7b_8820f99c","updated":"2015-11-25 18:15:51.000000000","message":"Done","commit_id":"2d90075c5ce11a8ead78ebd0a6b6e3bb895d1591"}]}