)]}'
{"cinder/volume/drivers/emc/emc_smis_iscsi.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"abd8fb0d8291827a3457a3d8d6ab6d0d49f31159","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            # iqn.1992-04.com.emc:cx.apm00123907237.a9]"},{"line_number":181,"context_line":"            endpoints \u003d self.common._find_iscsi_protocol_endpoints("},{"line_number":182,"context_line":"                sp, storage_system)"},{"line_number":183,"context_line":"        foundEndpoint \u003d False"},{"line_number":184,"context_line":"        for loc in location:"},{"line_number":185,"context_line":"            results \u003d loc.split(\" \")"},{"line_number":186,"context_line":"            properties[\u0027target_portal\u0027] \u003d results[0].split(\",\")[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F6Yk%3D","line":183,"updated":"2013-03-21 06:51:57.000000000","message":"A blank line just before this line 183 can make the code become more clearer.","commit_id":"84b07fb81e21fe1f586c8edf5b3b9be64163c5f4"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"cfac6a2fb8212dee85ae4518b26a0ff5153b0482","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            # iqn.1992-04.com.emc:cx.apm00123907237.a9]"},{"line_number":181,"context_line":"            endpoints \u003d self.common._find_iscsi_protocol_endpoints("},{"line_number":182,"context_line":"                sp, storage_system)"},{"line_number":183,"context_line":"        foundEndpoint \u003d False"},{"line_number":184,"context_line":"        for loc in location:"},{"line_number":185,"context_line":"            results \u003d loc.split(\" \")"},{"line_number":186,"context_line":"            properties[\u0027target_portal\u0027] \u003d results[0].split(\",\")[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F5FU%3D","line":183,"in_reply_to":"AAAAOH%2F%2F6Yk%3D","updated":"2013-03-21 21:56:45.000000000","message":"Done","commit_id":"84b07fb81e21fe1f586c8edf5b3b9be64163c5f4"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"9287ba02852bdfbad8c2ad2b65f8fcfde09c70c4","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                    break"},{"line_number":200,"context_line":"            if foundEndpoint:"},{"line_number":201,"context_line":"                break"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        properties[\u0027target_lun\u0027] \u003d device_number"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        properties[\u0027volume_id\u0027] \u003d volume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2F4wY%3D","line":202,"updated":"2013-03-22 02:44:10.000000000","message":"Is it possible that foundEndpoint is still False here? If so, better log a warning to allow admin to locate issue more easily.","commit_id":"aea8a6cea96f512e407eb7922c3c878cb884abd0"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7c6e6d34e435e2ddda49955eb3c15ffcb926e4c1","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                    break"},{"line_number":200,"context_line":"            if foundEndpoint:"},{"line_number":201,"context_line":"                break"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        properties[\u0027target_lun\u0027] \u003d device_number"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        properties[\u0027volume_id\u0027] \u003d volume[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2F4rs%3D","line":202,"in_reply_to":"AAAAOH%2F%2F4wY%3D","updated":"2013-03-22 03:46:08.000000000","message":"Usually endpoint should be found here, but it is possible that it is False when there are configuration problems.  So I agree it is a better to log a warning.","commit_id":"aea8a6cea96f512e407eb7922c3c878cb884abd0"}]}