)]}'
{"cinder/tests/test_coraid.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"7917a8a060c7b8fd487725923f1b1d8f61086c2b","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                lambda *_: True)"},{"line_number":176,"context_line":"        self.stubs.Set(CoraidRESTClient, \u0027_esm\u0027,"},{"line_number":177,"context_line":"                       lambda *_: fake_login_reply)"},{"line_number":178,"context_line":"        self.drv._set_group(fake_login_reply)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test__configure(self):"},{"line_number":181,"context_line":"        setattr(self.rest_mock, \u0027_configure\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2F4fI%3D","line":178,"updated":"2013-03-22 08:35:21.000000000","message":"Could you add the case, when CoraidESMException is raised(roupId does not exist)?","commit_id":"86670bc62d0450046643f115311807ca0b7c42fc"},{"author":{"_account_id":6798,"name":"Jean-Baptiste Ransy","email":"jean-baptiste.ransy@alyseo.com","username":"jean-baptiste-ransy"},"change_message_id":"d2b43cee88cc458d0d42362fa8fc7eec9ba0771c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                lambda *_: True)"},{"line_number":176,"context_line":"        self.stubs.Set(CoraidRESTClient, \u0027_esm\u0027,"},{"line_number":177,"context_line":"                       lambda *_: fake_login_reply)"},{"line_number":178,"context_line":"        self.drv._set_group(fake_login_reply)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test__configure(self):"},{"line_number":181,"context_line":"        setattr(self.rest_mock, \u0027_configure\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2F3v4%3D","line":178,"in_reply_to":"AAAAOH%2F%2F4fI%3D","updated":"2013-03-22 17:12:02.000000000","message":"Done","commit_id":"86670bc62d0450046643f115311807ca0b7c42fc"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"b9842ad8c0b0cb5ce6720a7180b124e6f0a3b3fa","unresolved":false,"context_lines":[{"line_number":101,"context_line":"fake_group_fail_fullpath \u003d \"fail group:%s\" % (fake_esm_group)"},{"line_number":102,"context_line":"fake_group_fail_id \u003d 5"},{"line_number":103,"context_line":"fake_login_reply_group_fail \u003d {\"values\": ["},{"line_number":104,"context_line":"                                {\"fullPath\": fake_group_fail_fullpath,"},{"line_number":105,"context_line":"                                 \"groupId\": fake_group_fail_id}],"},{"line_number":106,"context_line":"                               \"message\": \"\","},{"line_number":107,"context_line":"                               \"state\": \"adminSucceed\","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F2yY%3D","line":104,"updated":"2013-03-24 07:55:11.000000000","message":"nit: line over indented","commit_id":"7b12420ab7b54c7e0d2c2e73b92d7c95eaf18fea"},{"author":{"_account_id":6798,"name":"Jean-Baptiste Ransy","email":"jean-baptiste.ransy@alyseo.com","username":"jean-baptiste-ransy"},"change_message_id":"75132a619d848dacd41eb0454ed5c29528d0c1f1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"fake_group_fail_fullpath \u003d \"fail group:%s\" % (fake_esm_group)"},{"line_number":102,"context_line":"fake_group_fail_id \u003d 5"},{"line_number":103,"context_line":"fake_login_reply_group_fail \u003d {\"values\": ["},{"line_number":104,"context_line":"                                {\"fullPath\": fake_group_fail_fullpath,"},{"line_number":105,"context_line":"                                 \"groupId\": fake_group_fail_id}],"},{"line_number":106,"context_line":"                               \"message\": \"\","},{"line_number":107,"context_line":"                               \"state\": \"adminSucceed\","}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F2wM%3D","line":104,"in_reply_to":"AAAAOH%2F%2F2yY%3D","updated":"2013-03-24 12:32:05.000000000","message":"Done","commit_id":"7b12420ab7b54c7e0d2c2e73b92d7c95eaf18fea"}],"cinder/volume/drivers/coraid.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"6eb8cffafa242d79d8ebc8afb0e2a8c688a0f5df","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        for kid in loginResult[\u0027values\u0027]:"},{"line_number":135,"context_line":"            fullPath \u003d kid[\u0027fullPath\u0027]"},{"line_number":136,"context_line":"            if fullPath \u003d\u003d fullName:"},{"line_number":137,"context_line":"                groupId \u003d kid[\u0027groupId\u0027]"},{"line_number":138,"context_line":"        if groupId:"},{"line_number":139,"context_line":"            return groupId"},{"line_number":140,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F5ro%3D","line":137,"updated":"2013-03-21 17:04:03.000000000","message":"Is it a good idea to continue looping through the dictionaries in \u0027values\u0027 after you have found the fullpath?","commit_id":"0d0a09c11218a954b86f58bf81d808dc24f8ff55"},{"author":{"_account_id":6798,"name":"Jean-Baptiste Ransy","email":"jean-baptiste.ransy@alyseo.com","username":"jean-baptiste-ransy"},"change_message_id":"d753aad7aed4480f924faf80266e01e25aa4d30c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        for kid in loginResult[\u0027values\u0027]:"},{"line_number":135,"context_line":"            fullPath \u003d kid[\u0027fullPath\u0027]"},{"line_number":136,"context_line":"            if fullPath \u003d\u003d fullName:"},{"line_number":137,"context_line":"                groupId \u003d kid[\u0027groupId\u0027]"},{"line_number":138,"context_line":"        if groupId:"},{"line_number":139,"context_line":"            return groupId"},{"line_number":140,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F5p8%3D","line":137,"in_reply_to":"AAAAOH%2F%2F5ro%3D","updated":"2013-03-21 17:11:18.000000000","message":"You are right.\nI\u0027ll correct that\nThanks","commit_id":"0d0a09c11218a954b86f58bf81d808dc24f8ff55"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"b9842ad8c0b0cb5ce6720a7180b124e6f0a3b3fa","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                raise CoraidESMException(msg % dict(message\u003derrmsg))"},{"line_number":110,"context_line":"        return True"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def _set_group(self, reply):"},{"line_number":113,"context_line":"        \"\"\"Set effective group.\"\"\""},{"line_number":114,"context_line":"        if self.group:"},{"line_number":115,"context_line":"            group \u003d self.group"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F2yk%3D","line":112,"updated":"2013-03-24 07:55:11.000000000","message":"reply from the context of the signature is not being used anywhere. It\u0027s just being changed on line 120 by the self._esm() call.","commit_id":"7b12420ab7b54c7e0d2c2e73b92d7c95eaf18fea"},{"author":{"_account_id":6798,"name":"Jean-Baptiste Ransy","email":"jean-baptiste.ransy@alyseo.com","username":"jean-baptiste-ransy"},"change_message_id":"df8c30b933f150a8cd3ce0e50d7c7e8e285ded54","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                raise CoraidESMException(msg % dict(message\u003derrmsg))"},{"line_number":110,"context_line":"        return True"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def _set_group(self, reply):"},{"line_number":113,"context_line":"        \"\"\"Set effective group.\"\"\""},{"line_number":114,"context_line":"        if self.group:"},{"line_number":115,"context_line":"            group \u003d self.group"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F2wA%3D","line":112,"in_reply_to":"AAAAOH%2F%2F2yk%3D","updated":"2013-03-24 12:45:19.000000000","message":"reply is used in line 116","commit_id":"7b12420ab7b54c7e0d2c2e73b92d7c95eaf18fea"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"b9842ad8c0b0cb5ce6720a7180b124e6f0a3b3fa","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        for kid in loginResult[\u0027values\u0027]:"},{"line_number":138,"context_line":"            fullPath \u003d kid[\u0027fullPath\u0027]"},{"line_number":139,"context_line":"            if fullPath \u003d\u003d fullName:"},{"line_number":140,"context_line":"                groupId \u003d kid[\u0027groupId\u0027]"},{"line_number":141,"context_line":"                return groupId"},{"line_number":142,"context_line":"        return False"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F2yg%3D","line":140,"updated":"2013-03-24 07:55:11.000000000","message":"just return kid[\u0027groupId\u0027]. Nothing is really benefiting off this assignment.","commit_id":"7b12420ab7b54c7e0d2c2e73b92d7c95eaf18fea"},{"author":{"_account_id":6798,"name":"Jean-Baptiste Ransy","email":"jean-baptiste.ransy@alyseo.com","username":"jean-baptiste-ransy"},"change_message_id":"75132a619d848dacd41eb0454ed5c29528d0c1f1","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        for kid in loginResult[\u0027values\u0027]:"},{"line_number":138,"context_line":"            fullPath \u003d kid[\u0027fullPath\u0027]"},{"line_number":139,"context_line":"            if fullPath \u003d\u003d fullName:"},{"line_number":140,"context_line":"                groupId \u003d kid[\u0027groupId\u0027]"},{"line_number":141,"context_line":"                return groupId"},{"line_number":142,"context_line":"        return False"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F2wI%3D","line":140,"in_reply_to":"AAAAOH%2F%2F2yg%3D","updated":"2013-03-24 12:32:05.000000000","message":"Done","commit_id":"7b12420ab7b54c7e0d2c2e73b92d7c95eaf18fea"}]}