)]}'
{"cinder/db/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"007bc5d76b2e3fad4dbc0f1eafd146c7871e2ed2","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                         session)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"def volume_data_get_for_project(context, project_id, volume_type_name\u003dNone,"},{"line_number":220,"context_line":"                                session\u003dNone):"},{"line_number":221,"context_line":"    \"\"\"Get (volume_count, gigabytes) for project.\"\"\""},{"line_number":222,"context_line":"    return IMPL.volume_data_get_for_project(context,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPn%2F%2FqoA%3D","line":219,"updated":"2013-06-25 17:07:20.000000000","message":"I wanted to get away from using the name internally and use UUID but I\u0027m not going to make a stink about it.\n\nIt would make life much simpler in the future even if we still allow specifying Name from the interface if everywhere in the internal code it was always UUID\u0027s for everything that way it\u0027s much easier to keep straight and know what to expect.","commit_id":"dba858f8ee5efaa78fb6c457235f26842152a672"}],"cinder/quota.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1806f9cecc3783413b3a42c95d86f222c82b8de4","unresolved":false,"context_lines":[{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    def __init__(self, part_name, volume_type_name):"},{"line_number":495,"context_line":"        \"\"\" Init. \"\"\""},{"line_number":496,"context_line":"        if part_name \u003d\u003d \u0027snapshots\u0027:"},{"line_number":497,"context_line":"            def _sync(context, project_id, session):"},{"line_number":498,"context_line":"                (snapshots, gigs) \u003d db.snapshot_data_get_for_project("},{"line_number":499,"context_line":"                    context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fkyw%3D","line":496,"updated":"2013-05-03 09:37:09.000000000","message":"Hey,\n\nInstead of having this series of \u0027if\u0027 wouldn\u0027t it be cleaner to have several methods implemented and then doing getattr in the super call?\n\nExample: http://paste.openstack.org/show/36782/","commit_id":"4854e0b0a70212a9f05a496c85e3cd31677e67bd"},{"author":{"_account_id":4159,"name":"Cory Stone","email":"corystone@gmail.com","username":"corystone"},"change_message_id":"27af7172796f23f88769d3f9c2cefa767178b1dd","unresolved":false,"context_lines":[{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    def __init__(self, part_name, volume_type_name):"},{"line_number":495,"context_line":"        \"\"\" Init. \"\"\""},{"line_number":496,"context_line":"        if part_name \u003d\u003d \u0027snapshots\u0027:"},{"line_number":497,"context_line":"            def _sync(context, project_id, session):"},{"line_number":498,"context_line":"                (snapshots, gigs) \u003d db.snapshot_data_get_for_project("},{"line_number":499,"context_line":"                    context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fka0%3D","line":496,"in_reply_to":"AAAAOn%2F%2Fkyw%3D","updated":"2013-05-03 15:53:55.000000000","message":"Totally agree. Should\u0027ve done this in the first place anyway. Done.","commit_id":"4854e0b0a70212a9f05a496c85e3cd31677e67bd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1806f9cecc3783413b3a42c95d86f222c82b8de4","unresolved":false,"context_lines":[{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        self._driver.expire(context)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    def add_volume_type_opts(self, context, opts, volume_type_id):"},{"line_number":821,"context_line":"        if not volume_type_id:"},{"line_number":822,"context_line":"            return"},{"line_number":823,"context_line":"        volume_type \u003d db.volume_type_get(context, volume_type_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fkx4%3D","line":820,"updated":"2013-05-03 09:37:09.000000000","message":"Hey,\n\nIt\u0027d be good to have some docs here.","commit_id":"4854e0b0a70212a9f05a496c85e3cd31677e67bd"},{"author":{"_account_id":4159,"name":"Cory Stone","email":"corystone@gmail.com","username":"corystone"},"change_message_id":"27af7172796f23f88769d3f9c2cefa767178b1dd","unresolved":false,"context_lines":[{"line_number":817,"context_line":""},{"line_number":818,"context_line":"        self._driver.expire(context)"},{"line_number":819,"context_line":""},{"line_number":820,"context_line":"    def add_volume_type_opts(self, context, opts, volume_type_id):"},{"line_number":821,"context_line":"        if not volume_type_id:"},{"line_number":822,"context_line":"            return"},{"line_number":823,"context_line":"        volume_type \u003d db.volume_type_get(context, volume_type_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2Fkaw%3D","line":820,"in_reply_to":"AAAAOn%2F%2Fkx4%3D","updated":"2013-05-03 15:53:55.000000000","message":"Agreed! Done.","commit_id":"4854e0b0a70212a9f05a496c85e3cd31677e67bd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9c3106f122fcc324919521d49aa5c850eb4e766c","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        super(VolumeTypeResource, self).__init__(name, method, flag)"},{"line_number":505,"context_line":"        self.volume_type_name \u003d volume_type_name"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def _sync_snapshots(self, context, project_id, session):"},{"line_number":508,"context_line":"        (snapshots, gigs) \u003d db.snapshot_data_get_for_project("},{"line_number":509,"context_line":"            context,"},{"line_number":510,"context_line":"            project_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FkUw%3D","line":507,"updated":"2013-05-03 16:32:13.000000000","message":"Hi,\n\nIt would be nice to have some docs here.","commit_id":"9a9079bfc1c6dbbb1d8584d40f7a05a5f0c20714"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9c3106f122fcc324919521d49aa5c850eb4e766c","unresolved":false,"context_lines":[{"line_number":512,"context_line":"            session\u003dsession)"},{"line_number":513,"context_line":"        return {\u0027snapshots_%s\u0027 % self.volume_type_name: snapshots}"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    def _sync_volumes(self, context, project_id, session):"},{"line_number":516,"context_line":"        (volumes, gigs) \u003d db.volume_data_get_for_project("},{"line_number":517,"context_line":"            context,"},{"line_number":518,"context_line":"            project_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FkUg%3D","line":515,"updated":"2013-05-03 16:32:13.000000000","message":"ditto (probably ctrl+c/ctrl+v) :P","commit_id":"9a9079bfc1c6dbbb1d8584d40f7a05a5f0c20714"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9c3106f122fcc324919521d49aa5c850eb4e766c","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            session\u003dsession)"},{"line_number":521,"context_line":"        return {\u0027volumes_%s\u0027 % self.volume_type_name: volumes}"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"    def _sync_gigabytes(self, context, project_id, session):"},{"line_number":524,"context_line":"        key \u003d \u0027gigabytes_%s\u0027 % self.volume_type_name"},{"line_number":525,"context_line":"        (_junk, vol_gigs) \u003d db.volume_data_get_for_project("},{"line_number":526,"context_line":"            context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FkUU%3D","line":523,"updated":"2013-05-03 16:32:13.000000000","message":"ditto (probably ctrl+c/ctrl+v) :P","commit_id":"9a9079bfc1c6dbbb1d8584d40f7a05a5f0c20714"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1315aa689e6b88fb42e53a994c4c9f086bc11397","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        self._driver.expire(context)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def add_volume_type_opts(self, context, opts, volume_type_id):"},{"line_number":826,"context_line":"        \"\"\""},{"line_number":827,"context_line":"        Adds elements to the opts hash for volume type quotas."},{"line_number":828,"context_line":"        If a resource is being reserved (\u0027gigabytes\u0027, etc) and the volume"},{"line_number":829,"context_line":"        type is set up for its own quotas, these reservations are copied"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FkUQ%3D","line":826,"updated":"2013-05-03 16:29:23.000000000","message":"docstring needs one line summary like: \"\"\"This is the summary line.","commit_id":"9a9079bfc1c6dbbb1d8584d40f7a05a5f0c20714"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1315aa689e6b88fb42e53a994c4c9f086bc11397","unresolved":false,"context_lines":[{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    def load_volume_type_resources(self):"},{"line_number":847,"context_line":"        \"\"\""},{"line_number":848,"context_line":"        Set up the resources necessary for volume type quotas and load the"},{"line_number":849,"context_line":"        defaults from config."},{"line_number":850,"context_line":"        \"\"\""},{"line_number":851,"context_line":"        quota_volume_types \u003d FLAGS.quota_volume_types"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FkUM%3D","line":848,"updated":"2013-05-03 16:29:23.000000000","message":"Same as above","commit_id":"9a9079bfc1c6dbbb1d8584d40f7a05a5f0c20714"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9c3106f122fcc324919521d49aa5c850eb4e766c","unresolved":false,"context_lines":[{"line_number":849,"context_line":"        defaults from config."},{"line_number":850,"context_line":"        \"\"\""},{"line_number":851,"context_line":"        quota_volume_types \u003d FLAGS.quota_volume_types"},{"line_number":852,"context_line":"        if quota_volume_types:"},{"line_number":853,"context_line":"            LOG.info(\"quota_volume_types: %s\" % quota_volume_types)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"            def build_opt(opt_name, volume_type_name, default\u003d-1):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOn%2F%2FkUE%3D","line":852,"updated":"2013-05-03 16:32:13.000000000","message":"Hi,\n\nI don\u0027t think this check is needed. quota_volume_types\u0027s default value is [] which won\u0027t have any effect in the for bellow. What do you think about removing this and letting it iterate over an empty list?","commit_id":"9a9079bfc1c6dbbb1d8584d40f7a05a5f0c20714"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1d03f5ef5ab09e60d0b6ee679451512f5f86f636","unresolved":false,"context_lines":[{"line_number":853,"context_line":"        Set up the resources necessary for volume type quotas and load the"},{"line_number":854,"context_line":"        defaults from config."},{"line_number":855,"context_line":"        \"\"\""},{"line_number":856,"context_line":"        def build_opt(opt_name, volume_type_name, default\u003d-1):"},{"line_number":857,"context_line":"            return cfg.IntOpt("},{"line_number":858,"context_line":"                opt_name,"},{"line_number":859,"context_line":"                default\u003ddefault,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FiMU%3D","line":856,"updated":"2013-05-06 15:56:40.000000000","message":"Hey,\n\nDo we really need this function? What about moving cfg.IntOpt inside the for-loop?","commit_id":"82bd28cf0134a710a06357208ac75696a91a3f1b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1d03f5ef5ab09e60d0b6ee679451512f5f86f636","unresolved":false,"context_lines":[{"line_number":864,"context_line":"            for part_name in (\u0027volumes\u0027, \u0027gigabytes\u0027, \u0027snapshots\u0027):"},{"line_number":865,"context_line":"                resource_name \u003d \u0027%s_%s\u0027 % (part_name, volume_type_name)"},{"line_number":866,"context_line":"                opt_name \u003d \u0027quota_%s\u0027 % resource_name"},{"line_number":867,"context_line":"                FLAGS.register_opt(build_opt(opt_name, volume_type_name))"},{"line_number":868,"context_line":"                resource \u003d VolumeTypeResource(part_name, volume_type_name)"},{"line_number":869,"context_line":"                self.register_resource(resource)"},{"line_number":870,"context_line":"                LOG.info(\u0027volume quota: %s, default: %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FiLo%3D","line":867,"updated":"2013-05-06 15:56:40.000000000","message":"if the above makes sense, Could you pls add an empty line here? Just to separate logical blocks and make it a bit more readable.","commit_id":"82bd28cf0134a710a06357208ac75696a91a3f1b"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a522fbacbb16829cec7fc5b530064ad92d1b2e14","unresolved":false,"context_lines":[{"line_number":492,"context_line":"    \"\"\"ReservableResource grouped by volume type.\"\"\""},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    def __init__(self, part_name, volume_type_name):"},{"line_number":495,"context_line":"        \"\"\" Init. \"\"\""},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        try:"},{"line_number":498,"context_line":"            method \u003d getattr(self, \u0027_sync_%s\u0027 % part_name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2Fc98%3D","line":495,"updated":"2013-05-09 05:04:24.000000000","message":"docstring","commit_id":"7c78dac760c3aaf3767e71cbd8348a518beb50c5"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"007bc5d76b2e3fad4dbc0f1eafd146c7871e2ed2","unresolved":false,"context_lines":[{"line_number":583,"context_line":""},{"line_number":584,"context_line":"        name \u003d \"%s_%s\" % (part_name, volume_type_name)"},{"line_number":585,"context_line":"        flag \u003d \"quota_%s\" % name"},{"line_number":586,"context_line":"        flag \u003d flag.replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":587,"context_line":"        CONF.register_opt(cfg.IntOpt("},{"line_number":588,"context_line":"            flag,"},{"line_number":589,"context_line":"            default\u003d-1,"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPn%2F%2Fqpg%3D","line":586,"updated":"2013-06-25 17:07:20.000000000","message":"Not sure this is going to fly (the dyamic flag setting thing).  I\u0027d rather see a \"generic\" default types quota, and then a check to see if anything was added.\n\nSo something similar to how we read in the conf settings for multi-backend.","commit_id":"dba858f8ee5efaa78fb6c457235f26842152a672"}],"cinder/volume/api.py":[{"author":{"_account_id":951,"name":"Cian O\u0027Driscoll","email":"cian@hp.com","username":"dricco"},"change_message_id":"3b5ea21d056b15697b3f125ad3c11e503e3a3b8c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                gigs_quota \u003d \u0027gigabytes_%s\u0027 % volume_type[\u0027name\u0027]"},{"line_number":162,"context_line":"                reserve_opts[gigs_quota] \u003d size"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            reservations \u003d QUOTAS.reserve(context, **reserve_opts)"},{"line_number":165,"context_line":"        except exception.OverQuota as e:"},{"line_number":166,"context_line":"            overs \u003d e.kwargs[\u0027overs\u0027]"},{"line_number":167,"context_line":"            usages \u003d e.kwargs[\u0027usages\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F1ig%3D","line":164,"updated":"2013-03-25 17:04:42.000000000","message":"Would like to see this broken out in a new function. def create is getting too big. Makes code more readable as well","commit_id":"ba8f4496b76e97fab27b0bcb379614bc7d5fcbb1"},{"author":{"_account_id":951,"name":"Cian O\u0027Driscoll","email":"cian@hp.com","username":"dricco"},"change_message_id":"3b5ea21d056b15697b3f125ad3c11e503e3a3b8c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                    reserve_opts[volume_quota] \u003d -1"},{"line_number":301,"context_line":"                    gigs_quota \u003d \u0027gigabytes_%s\u0027 % volume_type[\u0027name\u0027]"},{"line_number":302,"context_line":"                    reserve_opts[gigs_quota] \u003d -volume[\u0027size\u0027]"},{"line_number":303,"context_line":"                reservations \u003d QUOTAS.reserve(context, **reserve_opts)"},{"line_number":304,"context_line":"            except Exception:"},{"line_number":305,"context_line":"                reservations \u003d None"},{"line_number":306,"context_line":"                LOG.exception(_(\"Failed to update quota for deleting volume\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F1ic%3D","line":303,"updated":"2013-03-25 17:04:42.000000000","message":"Would like to see this broken out in a new function. def delete is getting too big. Makes code more readable as well","commit_id":"ba8f4496b76e97fab27b0bcb379614bc7d5fcbb1"}],"cinder/volume/manager.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"10e82669add7b8a02c3c6571391b86fbbae4ba88","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        \"\"\"Deletes and unexports snapshot.\"\"\""},{"line_number":505,"context_line":"        context \u003d context.elevated()"},{"line_number":506,"context_line":"        snapshot_ref \u003d self.db.snapshot_get(context, snapshot_id)"},{"line_number":507,"context_line":"        project_id \u003d snapshot_ref[\u0027project_id\u0027]"},{"line_number":508,"context_line":"        LOG.info(_(\"snapshot %s: deleting\"), snapshot_ref[\u0027name\u0027])"},{"line_number":509,"context_line":"        self._notify_about_snapshot_usage("},{"line_number":510,"context_line":"            context, snapshot_ref, \"delete.start\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPn%2F%2FhQ0%3D","line":507,"updated":"2013-06-28 16:32:22.000000000","message":"Not sure about not having the ability to use different project_id here.... but come to think of it don\u0027t know the use case that this would come up in.","commit_id":"afa27908c5ef558ae8822c89a6f95d8150fc6b47"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"fbb74ada8081dbd8c93a8a4c5af2fdc73072d824","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        \"\"\"Deletes and unexports snapshot.\"\"\""},{"line_number":505,"context_line":"        context \u003d context.elevated()"},{"line_number":506,"context_line":"        snapshot_ref \u003d self.db.snapshot_get(context, snapshot_id)"},{"line_number":507,"context_line":"        project_id \u003d snapshot_ref[\u0027project_id\u0027]"},{"line_number":508,"context_line":"        LOG.info(_(\"snapshot %s: deleting\"), snapshot_ref[\u0027name\u0027])"},{"line_number":509,"context_line":"        self._notify_about_snapshot_usage("},{"line_number":510,"context_line":"            context, snapshot_ref, \"delete.start\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPn%2F%2FTEs%3D","line":507,"in_reply_to":"AAAAPn%2F%2FdNE%3D","updated":"2013-07-04 16:26:41.000000000","message":"Ahh.. indeed, nice one! Done","commit_id":"afa27908c5ef558ae8822c89a6f95d8150fc6b47"},{"author":{"_account_id":4159,"name":"Cory Stone","email":"corystone@gmail.com","username":"corystone"},"change_message_id":"cb4653b60e6814205d419af56509b827d8a37ecf","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        \"\"\"Deletes and unexports snapshot.\"\"\""},{"line_number":505,"context_line":"        context \u003d context.elevated()"},{"line_number":506,"context_line":"        snapshot_ref \u003d self.db.snapshot_get(context, snapshot_id)"},{"line_number":507,"context_line":"        project_id \u003d snapshot_ref[\u0027project_id\u0027]"},{"line_number":508,"context_line":"        LOG.info(_(\"snapshot %s: deleting\"), snapshot_ref[\u0027name\u0027])"},{"line_number":509,"context_line":"        self._notify_about_snapshot_usage("},{"line_number":510,"context_line":"            context, snapshot_ref, \"delete.start\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAPn%2F%2FdNE%3D","line":507,"in_reply_to":"AAAAPn%2F%2FhQ0%3D","updated":"2013-07-01 15:45:39.000000000","message":"Hmm, I think I just added this line and took the four down below out because the (il?)logic in those four lines bothered me...\n\nif a !\u003d b:\n    foo \u003d b\nelse:\n    #if a \u003d\u003d b\n    foo \u003d a\n\nI much prefer simplifying that to:\nfoo \u003d b :)","commit_id":"afa27908c5ef558ae8822c89a6f95d8150fc6b47"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1806f9cecc3783413b3a42c95d86f222c82b8de4","unresolved":false,"context_lines":[{"line_number":229,"context_line":"#quota_driver\u003dcinder.quota.DbQuotaDriver"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# volume types with specific quotas (list value)"},{"line_number":232,"context_line":"#quota_volume_types\u003d"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"#"},{"line_number":235,"context_line":"# Options defined in cinder.service"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAOn%2F%2Fkxw%3D","line":232,"updated":"2013-05-03 09:37:09.000000000","message":"Hey,\n\nDoesn\u0027t it have some default values? At least it would be good to comment / list the possible options here.","commit_id":"4854e0b0a70212a9f05a496c85e3cd31677e67bd"},{"author":{"_account_id":4159,"name":"Cory Stone","email":"corystone@gmail.com","username":"corystone"},"change_message_id":"27af7172796f23f88769d3f9c2cefa767178b1dd","unresolved":false,"context_lines":[{"line_number":229,"context_line":"#quota_driver\u003dcinder.quota.DbQuotaDriver"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# volume types with specific quotas (list value)"},{"line_number":232,"context_line":"#quota_volume_types\u003d"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"#"},{"line_number":235,"context_line":"# Options defined in cinder.service"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAOn%2F%2FkbA%3D","line":232,"in_reply_to":"AAAAOn%2F%2Fkxw%3D","updated":"2013-05-03 15:53:55.000000000","message":"I\u0027ll try and make this more clear","commit_id":"4854e0b0a70212a9f05a496c85e3cd31677e67bd"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1315aa689e6b88fb42e53a994c4c9f086bc11397","unresolved":false,"context_lines":[{"line_number":231,"context_line":"# volume types with specific quotas (list value)"},{"line_number":232,"context_line":"# Empty by default. Add any volume type names that require"},{"line_number":233,"context_line":"# their own quotas. "},{"line_number":234,"context_line":"#quota_volume_types\u003d"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"#"},{"line_number":237,"context_line":"# Options defined in cinder.service"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAAOn%2F%2FkUA%3D","line":234,"updated":"2013-05-03 16:29:23.000000000","message":"remove whitespace","commit_id":"9a9079bfc1c6dbbb1d8584d40f7a05a5f0c20714"}]}