)]}'
{"cinder/volume/drivers/emc/xtremio.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a4bc338dc47ff309926c7e20ce95fdaa3a9f5494","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                continue"},{"line_number":215,"context_line":"            if lm[\u0027ig-name\u0027] \u003d\u003d ig_name and lm[\u0027vol-name\u0027] \u003d\u003d vol_name:"},{"line_number":216,"context_line":"                return lm"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def num_of_mapped_volumes(self, initiator):"},{"line_number":219,"context_line":"        cnt \u003d 0"},{"line_number":220,"context_line":"        for lm_link in self.req(\u0027lun-maps\u0027)[\u0027lun-maps\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_fd4bca5d","line":217,"updated":"2015-11-30 16:31:45.000000000","message":"I think the code would be clearer with the recommended change.","commit_id":"1d3a8488c68913891814f09bd618844f3dd81310"},{"author":{"_account_id":10725,"name":"Sergey Gotliv","email":"sgotliv@redhat.com","username":"sgotliv"},"change_message_id":"d3d2332e47f5657e55d6ccea2e231923eedf9fe9","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                continue"},{"line_number":215,"context_line":"            if lm[\u0027ig-name\u0027] \u003d\u003d ig_name and lm[\u0027vol-name\u0027] \u003d\u003d vol_name:"},{"line_number":216,"context_line":"                return lm"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def num_of_mapped_volumes(self, initiator):"},{"line_number":219,"context_line":"        cnt \u003d 0"},{"line_number":220,"context_line":"        for lm_link in self.req(\u0027lun-maps\u0027)[\u0027lun-maps\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2454f5c7","line":217,"updated":"2015-11-30 15:34:29.000000000","message":"I would explicitly return None in case \"lm\" is not found.","commit_id":"1d3a8488c68913891814f09bd618844f3dd81310"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"59a016e6f74c85db83bd234bdd4652d3e27e331d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                continue"},{"line_number":215,"context_line":"            if lm[\u0027ig-name\u0027] \u003d\u003d ig_name and lm[\u0027vol-name\u0027] \u003d\u003d vol_name:"},{"line_number":216,"context_line":"                return lm"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def num_of_mapped_volumes(self, initiator):"},{"line_number":219,"context_line":"        cnt \u003d 0"},{"line_number":220,"context_line":"        for lm_link in self.req(\u0027lun-maps\u0027)[\u0027lun-maps\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_3d4ab256","line":217,"in_reply_to":"9a8ffd7b_2454f5c7","updated":"2015-11-30 16:33:19.000000000","message":"I usually also prefer explicit over implicit returns of None, but I wanted to change the driver as little as possible and that was how the driver was before.  But I\u0027ll gladly change it since that\u0027s how I like it anyways.  :-)","commit_id":"1d3a8488c68913891814f09bd618844f3dd81310"}]}