)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"82c11b8731fb2b2615ddcfceba1aa9707a9fe1c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Béla Vancsics \u003cvancsics@inf.u-szeged.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-20 14:13:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reduce code duplication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reduced source code by extracting duplicated code"},{"line_number":10,"context_line":"(cinder/volume/drivers/netapp/dataontap/ssc_cmode.py)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a5ae5dd_b75f8674","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":23},"updated":"2016-02-09 16:00:28.000000000","message":"You have another patch with the same title. Does one depend on the other? Are they completely separate? If you could make the titles more specific it might help clarify what each patch is doing better.","commit_id":"89e556d013cc2ef5c5d76d7adb17a3e6a1a440b0"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"82c11b8731fb2b2615ddcfceba1aa9707a9fe1c5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reduce code duplication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reduced source code by extracting duplicated code"},{"line_number":10,"context_line":"(cinder/volume/drivers/netapp/dataontap/ssc_cmode.py)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia5aa6ad8423360d447ad0338153fb051885b2e04"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a5ae5dd_d7cb221d","line":10,"updated":"2016-02-09 16:00:28.000000000","message":"Maybe also mention the addition of the new method to reduce duplicated code?","commit_id":"89e556d013cc2ef5c5d76d7adb17a3e6a1a440b0"}],"cinder/volume/drivers/netapp/dataontap/ssc_cmode.py":[{"author":{"_account_id":16100,"name":"Chris Morrell","username":"chrismorrell","inactive":true},"change_message_id":"ae3bb092d5ca58bb13f92a138330ee71f8cb6130","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"def _spec_ineffect(b_specs, spec, opp_spec):"},{"line_number":549,"context_line":"    \"\"\"If the spec with opposite spec is ineffective.\"\"\""},{"line_number":550,"context_line":"    if ((b_specs[spec] is None and b_specs[opp_spec] is None)"},{"line_number":551,"context_line":"            or (b_specs[spec] \u003d\u003d b_specs[opp_spec])):"},{"line_number":552,"context_line":"        return True"},{"line_number":553,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_bb3b0538","line":550,"updated":"2015-11-30 20:41:37.000000000","message":"Any reason for explicitly checking if both values are None, or if both values are equal? If both values are None, the equality check will trigger True.\n\nIt might also be considered less readable but you could simply return b_specs[spec] \u003d\u003d b_specs[opp_spec].\n\nedit: realized this was simply moved from get_volumes_for_specs. Might still want to consider cleaning it up a bit.","commit_id":"e65e22ccfb27c83ea85751d21a8a466a2ac7d253"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"dc03669bd3263b024d4c9ba02d3ba537a0f05260","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        return False"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"def _set_result(_b_specs, _key_1, _key_2, _key_3, _result, _ssc_vols):"},{"line_number":558,"context_line":"    \"\"\"Collect SSC volumes\"\"\""},{"line_number":559,"context_line":"    if _spec_ineffect(_b_specs, _key_1, _key_2):"},{"line_number":560,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_4e55b11b","line":557,"updated":"2016-02-25 11:45:41.000000000","message":"Usually we don\u0027t begin argument name with underscore.","commit_id":"e65e22ccfb27c83ea85751d21a8a466a2ac7d253"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"dc03669bd3263b024d4c9ba02d3ba537a0f05260","unresolved":false,"context_lines":[{"line_number":559,"context_line":"    if _spec_ineffect(_b_specs, _key_1, _key_2):"},{"line_number":560,"context_line":"        pass"},{"line_number":561,"context_line":"    else:"},{"line_number":562,"context_line":"        if _b_specs[_key_1] or _b_specs[_key_2] is False:"},{"line_number":563,"context_line":"            _result \u003d _result \u0026 _ssc_vols[_key_3]"},{"line_number":564,"context_line":"        else:"},{"line_number":565,"context_line":"            _result \u003d _result - _ssc_vols[_key_3]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_113e28b8","line":562,"updated":"2016-02-25 11:45:41.000000000","message":"_key_1, _key_2, _key_3 are bad naming examples. Would you change them to meaningful variable names?","commit_id":"e65e22ccfb27c83ea85751d21a8a466a2ac7d253"},{"author":{"_account_id":16100,"name":"Chris Morrell","username":"chrismorrell","inactive":true},"change_message_id":"89d85360e360d8557b76d019fbb2f591ded1806a","unresolved":false,"context_lines":[{"line_number":547,"context_line":""},{"line_number":548,"context_line":"def _spec_ineffect(b_specs, spec, opp_spec):"},{"line_number":549,"context_line":"    \"\"\"If the spec with opposite spec is ineffective.\"\"\""},{"line_number":550,"context_line":"    return b_specs[spec] \u003d\u003d b_specs[opp_spec] if True else False"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"def _set_result(_b_specs, _key_1, _key_2, _key_3, _result, _ssc_vols):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c7b267e5","line":550,"updated":"2015-12-01 20:54:04.000000000","message":"The \u0027if True else False\u0027 is redundant but that works.","commit_id":"ebb000cc73b7ad8a42498e5def8b8ba2d31ac966"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"300e8baff17f9f6b48d62ba4222f94699a1aa213","unresolved":false,"context_lines":[{"line_number":545,"context_line":"                t.start()"},{"line_number":546,"context_line":""},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"def _set_result(_b_specs, _key_1, _key_2, _key_3, _result, _ssc_vols):"},{"line_number":549,"context_line":"    \"\"\"Collect SSC volumes\"\"\""},{"line_number":550,"context_line":"    if _b_specs[_key_1] \u003d\u003d _b_specs[_key_2]:"},{"line_number":551,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_f17bc479","line":548,"updated":"2016-02-25 11:47:37.000000000","message":"Usually we don\u0027t begin variable name with underscore.","commit_id":"8c49918ccda0d7b7052b45d497397332ae45b370"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"300e8baff17f9f6b48d62ba4222f94699a1aa213","unresolved":false,"context_lines":[{"line_number":550,"context_line":"    if _b_specs[_key_1] \u003d\u003d _b_specs[_key_2]:"},{"line_number":551,"context_line":"        pass"},{"line_number":552,"context_line":"    else:"},{"line_number":553,"context_line":"        if _b_specs[_key_1] or _b_specs[_key_2] is False:"},{"line_number":554,"context_line":"            _result \u003d _result \u0026 _ssc_vols[_key_3]"},{"line_number":555,"context_line":"        else:"},{"line_number":556,"context_line":"            _result \u003d _result - _ssc_vols[_key_3]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_d1804049","line":553,"updated":"2016-02-25 11:47:37.000000000","message":"_key_1, _key_2, _key_3 are bad naming examples. Would you name variables with more meaningful names?","commit_id":"8c49918ccda0d7b7052b45d497397332ae45b370"}]}