)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"b85d92d907e88f24cacebb2f9edb12f76498a23e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"option located in keymgr.encryption_auth_url. Now, the required"},{"line_number":11,"context_line":"auth_uri option from config file is used to authenticate to"},{"line_number":12,"context_line":"keystone."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1076527704f8def2c6755c060df49232e5ebe805"},{"line_number":15,"context_line":"Closes-Bug: 1516085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_a46a77b3","line":13,"updated":"2015-12-02 21:50:33.000000000","message":"DocImpact should be added here.","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"065dd7a9b56f88d13653af3e8b36365384c6cd54","unresolved":false,"context_lines":[{"line_number":10,"context_line":"option located in keymgr.encryption_auth_url. Now, the required"},{"line_number":11,"context_line":"auth_uri option from config file is used to authenticate to"},{"line_number":12,"context_line":"keystone."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1076527704f8def2c6755c060df49232e5ebe805"},{"line_number":15,"context_line":"Closes-Bug: 1516085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_d17e3ce3","line":13,"in_reply_to":"9a8ffd7b_42960ef1","updated":"2015-12-03 11:10:12.000000000","message":"+1","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d1fa9d95d6d930339fd8374dd5c3ecc8cf825f3e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"option located in keymgr.encryption_auth_url. Now, the required"},{"line_number":11,"context_line":"auth_uri option from config file is used to authenticate to"},{"line_number":12,"context_line":"keystone."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1076527704f8def2c6755c060df49232e5ebe805"},{"line_number":15,"context_line":"Closes-Bug: 1516085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_43e04129","line":13,"in_reply_to":"9a8ffd7b_806cdfd0","updated":"2015-12-03 11:48:19.000000000","message":"I thought this code, and therefore this behavior, had been here longer (so I was treating it as an implicit contract), but since this was just merged in July, this doesn\u0027t need DocImpact, it\u0027s just a bug fix.","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"96b089fd22e00d48ca3881f894d4d3f5904518d8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"option located in keymgr.encryption_auth_url. Now, the required"},{"line_number":11,"context_line":"auth_uri option from config file is used to authenticate to"},{"line_number":12,"context_line":"keystone."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1076527704f8def2c6755c060df49232e5ebe805"},{"line_number":15,"context_line":"Closes-Bug: 1516085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_42960ef1","line":13,"in_reply_to":"9a8ffd7b_a46a77b3","updated":"2015-12-03 05:45:39.000000000","message":"+1","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"06b5350785af8569f7f418a7c373a49054533132","unresolved":false,"context_lines":[{"line_number":10,"context_line":"option located in keymgr.encryption_auth_url. Now, the required"},{"line_number":11,"context_line":"auth_uri option from config file is used to authenticate to"},{"line_number":12,"context_line":"keystone."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1076527704f8def2c6755c060df49232e5ebe805"},{"line_number":15,"context_line":"Closes-Bug: 1516085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_806cdfd0","line":13,"in_reply_to":"9a8ffd7b_d17e3ce3","updated":"2015-12-03 11:30:06.000000000","message":"I\u0027m a little confused - the patch is fixing a bug that was caused by code not following the docs. We were reading keystone endpoint from a wrong config option (keymgr.encryption_auth_url) - it wasn\u0027t documented that setting this option is required for core functionalities.\n\nNow with this fix we follow the documentation again and use proper config option. I\u0027m not sure what documentation change we expect to be done.","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"}],"\u003d72":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7a9ce06091365115b9824879c369b6f731729994","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Use proper config option to connect to keystone"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Earlier, quotas used to authenticate to endpoint from not required "},{"line_number":4,"context_line":"option located in keymgr.encryption_auth_url."},{"line_number":5,"context_line":"Now, the required auth_uri option from config file is used to authenticate"},{"line_number":6,"context_line":"to generic keystone client."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9a8ffd7b_4593d7fa","line":3,"updated":"2015-12-01 18:49:08.000000000","message":"Have blank space at EOL.","commit_id":"531e9e6e4a950962d2c0a4b509f0afa2da747bc3"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a25c8b731235c7d413f43f8eb9975bfcd3c4ea7a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        authorize_show(context)"},{"line_number":206,"context_line":"        params \u003d req.params"},{"line_number":207,"context_line":"        target_project_id \u003d id"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        if not hasattr(params, \u0027__call__\u0027) and \u0027usage\u0027 in params:"},{"line_number":210,"context_line":"            usage \u003d strutils.bool_from_string(params[\u0027usage\u0027])"},{"line_number":211,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_d5845fb2","side":"PARENT","line":208,"updated":"2015-12-01 16:27:41.000000000","message":"Unrelated change, please remove it.","commit_id":"55b6773c24039433367cdb36e8bb716333c3c6b7"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a25c8b731235c7d413f43f8eb9975bfcd3c4ea7a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        \"\"\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            auth_plugin \u003d token.Token(auth_url\u003d"},{"line_number":187,"context_line":"                                      CONF.keystone_authtoken.auth_uri,"},{"line_number":188,"context_line":"                                      token\u003dcontext.auth_token,"},{"line_number":189,"context_line":"                                      project_id\u003dcontext.project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_39184575","line":186,"updated":"2015-12-01 16:27:41.000000000","message":"I think it\u0027s better to wrap this like that:\n\n            auth_plugin \u003d token.Token(\n                auth_url\u003dCONF.keystone_authtoken.auth_uri,\n                token\u003dcontext.auth_token,\n                project_id\u003dcontext.project_id)","commit_id":"531e9e6e4a950962d2c0a4b509f0afa2da747bc3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a25c8b731235c7d413f43f8eb9975bfcd3c4ea7a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            keystone \u003d client.Client(auth_url\u003dCONF.keystone_authtoken.auth_uri,"},{"line_number":192,"context_line":"                                     session\u003dclient_session)"},{"line_number":193,"context_line":"            project \u003d keystone.projects.get(id, subtree_as_ids\u003dsubtree_as_ids)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        except exceptions.NotFound:"},{"line_number":196,"context_line":"            msg \u003d (_(\"Tenant ID: %s does not exist.\") % id)"},{"line_number":197,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_39460550","line":194,"updated":"2015-12-01 16:27:41.000000000","message":"No need to for this newline.","commit_id":"531e9e6e4a950962d2c0a4b509f0afa2da747bc3"}],"cinder/tests/unit/api/contrib/test_quotas.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"96b089fd22e00d48ca3881f894d4d3f5904518d8","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def test_keystone_client_instantiation(self, ksclient_session,"},{"line_number":129,"context_line":"                                           ksclient_class):"},{"line_number":130,"context_line":"        context \u003d self.req.environ[\u0027cinder.context\u0027]"},{"line_number":131,"context_line":"        CONF.import_opt(\u0027auth_uri\u0027, \u0027keystonemiddleware.auth_token\u0027,"},{"line_number":132,"context_line":"                        group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":133,"context_line":"        CONF.set_default(\u0027auth_uri\u0027, \u0027http://localhost:5000/v3\u0027,"},{"line_number":134,"context_line":"                         group\u003d\u0027keystone_authtoken\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_a28d7ad4","line":131,"updated":"2015-12-03 05:45:39.000000000","message":"Please, don\u0027t change the global config object for the tests. You should use copy or a mock instead.\n\nSuch changes could introduce races and/or errors in a concurrency mode","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"065dd7a9b56f88d13653af3e8b36365384c6cd54","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def test_keystone_client_instantiation(self, ksclient_session,"},{"line_number":129,"context_line":"                                           ksclient_class):"},{"line_number":130,"context_line":"        context \u003d self.req.environ[\u0027cinder.context\u0027]"},{"line_number":131,"context_line":"        CONF.import_opt(\u0027auth_uri\u0027, \u0027keystonemiddleware.auth_token\u0027,"},{"line_number":132,"context_line":"                        group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":133,"context_line":"        CONF.set_default(\u0027auth_uri\u0027, \u0027http://localhost:5000/v3\u0027,"},{"line_number":134,"context_line":"                         group\u003d\u0027keystone_authtoken\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d1171ca1","line":131,"in_reply_to":"9a8ffd7b_a28d7ad4","updated":"2015-12-03 11:10:12.000000000","message":"I understand what you mean, but aren\u0027t we doing that all over the place?  Should we have a look and clean those tests?  r:-??","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"06b5350785af8569f7f418a7c373a49054533132","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    def test_keystone_client_instantiation(self, ksclient_session,"},{"line_number":129,"context_line":"                                           ksclient_class):"},{"line_number":130,"context_line":"        context \u003d self.req.environ[\u0027cinder.context\u0027]"},{"line_number":131,"context_line":"        CONF.import_opt(\u0027auth_uri\u0027, \u0027keystonemiddleware.auth_token\u0027,"},{"line_number":132,"context_line":"                        group\u003d\u0027keystone_authtoken\u0027)"},{"line_number":133,"context_line":"        CONF.set_default(\u0027auth_uri\u0027, \u0027http://localhost:5000/v3\u0027,"},{"line_number":134,"context_line":"                         group\u003d\u0027keystone_authtoken\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_60945b8a","line":131,"in_reply_to":"9a8ffd7b_d1171ca1","updated":"2015-12-03 11:30:06.000000000","message":"I have same doubts as Gorka. What is the correct way then?","commit_id":"09cbfba3c46893d87e01d56476f7331d555aec90"}]}