)]}'
{"cinder/volume/drivers/netapp/eseries/client.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fa873ddf7952170d7e131bdae430c06e9fab279f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                                \"incorrect, please update the configured \""},{"line_number":290,"context_line":"                                \"password.\") % self._system_id"},{"line_number":291,"context_line":"            elif status_code \u003d\u003d 424:"},{"line_number":292,"context_line":"                msg \u003d _(\"Response error - %s.\") % (\"The storage-system is \""},{"line_number":293,"context_line":"                                                   \"offline\")"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                msg \u003d _(\"Response error code - %s.\") % status_code"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_5b9ad46f","line":292,"updated":"2015-12-01 19:25:02.000000000","message":"Does this really need to be split up like this instead of just one string?","commit_id":"875539ce535a06b634cf22755ea184fc7abe3325"},{"author":{"_account_id":16821,"name":"Michael Price","email":"michael.price@netapp.com","username":"michael.price"},"change_message_id":"292bd9c0e07754974afa6413bef39a1dcdfc53a1","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                                \"incorrect, please update the configured \""},{"line_number":290,"context_line":"                                \"password.\") % self._system_id"},{"line_number":291,"context_line":"            elif status_code \u003d\u003d 424:"},{"line_number":292,"context_line":"                msg \u003d _(\"Response error - %s.\") % (\"The storage-system is \""},{"line_number":293,"context_line":"                                                   \"offline\")"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                msg \u003d _(\"Response error code - %s.\") % status_code"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_36904795","line":292,"in_reply_to":"9a8ffd7b_5b9ad46f","updated":"2015-12-01 20:09:14.000000000","message":"No, it doesn\u0027t need to be split up. I probably just followed the pattern above.","commit_id":"875539ce535a06b634cf22755ea184fc7abe3325"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3e24fd6aad94b6cf2f7312c2024e240640d45a07","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                      headers\u003dheaders,"},{"line_number":222,"context_line":"                                      timeout\u003dtimeout, verify\u003dverify)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            try:"},{"line_number":225,"context_line":"                res_dict \u003d res.json() if res.text else None"},{"line_number":226,"context_line":"            # This should only occur if we expected JSON, but were sent"},{"line_number":227,"context_line":"            # something else"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_494c7b42","line":224,"updated":"2015-12-04 10:56:43.000000000","message":"-1: I believe the right way to do this would be to move `_eval_response` call before this try and in the except instead of doing `res_dict \u003d None` it should raise an exception.","commit_id":"489c8d2a5f829e5398d861d29d1a2beb504c6027"},{"author":{"_account_id":16821,"name":"Michael Price","email":"michael.price@netapp.com","username":"michael.price"},"change_message_id":"11617cd06464d113527ee49af1ee408faae87592","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                      headers\u003dheaders,"},{"line_number":222,"context_line":"                                      timeout\u003dtimeout, verify\u003dverify)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            try:"},{"line_number":225,"context_line":"                res_dict \u003d res.json() if res.text else None"},{"line_number":226,"context_line":"            # This should only occur if we expected JSON, but were sent"},{"line_number":227,"context_line":"            # something else"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_bba145fa","line":224,"in_reply_to":"7a740942_494c7b42","updated":"2015-12-11 16:34:33.000000000","message":"Gorka, the reason that I did it that way is so that the http response, along with the response json (if applicable), can be logged on line 232. I think that this is the best way to achieve that.","commit_id":"489c8d2a5f829e5398d861d29d1a2beb504c6027"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e90fb24b3da1cf334d95ea3547a123bf3aaf5b7c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                      headers\u003dheaders,"},{"line_number":222,"context_line":"                                      timeout\u003dtimeout, verify\u003dverify)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            try:"},{"line_number":225,"context_line":"                res_dict \u003d res.json() if res.text else None"},{"line_number":226,"context_line":"            # This should only occur if we expected JSON, but were sent"},{"line_number":227,"context_line":"            # something else"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_4e561acf","line":224,"in_reply_to":"7a740942_bba145fa","updated":"2015-12-14 12:11:38.000000000","message":"Ok, but for that purpose it may have made more sense to log the actual body of the response so you log something even on non JSON responses.","commit_id":"489c8d2a5f829e5398d861d29d1a2beb504c6027"}]}