)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"cafbd357db069a4248c12df6005d0ebf060d96ee","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"2. Return the \u0027replica_volume_ref\u0027 in response body of"},{"line_number":23,"context_line":"querying volume."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ieda66b6bc73b973112fb64ae24155580d7e6bbf5"},{"line_number":26,"context_line":"Implements: buleprint: get-replicated-volume-ref-for-dr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_681543e3","line":24,"updated":"2015-12-07 22:27:34.000000000","message":"I think this needs an API Impact.","commit_id":"bee5f3fffdda1bfb542407f5aeba75b3603ab839"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"61bc2c93c84041191bfcb48fd632fad5fabfc28b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"2. Return the \u0027replica_volume_ref\u0027 in response body of"},{"line_number":23,"context_line":"querying volume."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: Ieda66b6bc73b973112fb64ae24155580d7e6bbf5"},{"line_number":26,"context_line":"Implements: buleprint: get-replicated-volume-ref-for-dr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_97a8b978","line":24,"in_reply_to":"7a740942_681543e3","updated":"2015-12-08 09:32:41.000000000","message":"Done","commit_id":"bee5f3fffdda1bfb542407f5aeba75b3603ab839"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"39c77ec91c494ab87d34a48d286bd2e2331c08b1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"when disaster happens."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Changes:"},{"line_number":18,"context_line":"1. Only allow admin to querying replication_driver_data \u0026"},{"line_number":19,"context_line":"replicaiton_extended_status. Those information should only"},{"line_number":20,"context_line":"be know by admin users."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_8a2cf599","line":18,"updated":"2015-12-08 16:28:26.000000000","message":"Suggestion: querying -\u003e query","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"0bc1ab5819ce9eda90f4cef41f4988e4337696c7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"when disaster happens."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Changes:"},{"line_number":18,"context_line":"1. Only allow admin to querying replication_driver_data \u0026"},{"line_number":19,"context_line":"replicaiton_extended_status. Those information should only"},{"line_number":20,"context_line":"be know by admin users."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_e2133c63","line":18,"in_reply_to":"7a740942_8a2cf599","updated":"2015-12-09 07:59:43.000000000","message":"Done","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"39c77ec91c494ab87d34a48d286bd2e2331c08b1","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Changes:"},{"line_number":18,"context_line":"1. Only allow admin to querying replication_driver_data \u0026"},{"line_number":19,"context_line":"replicaiton_extended_status. Those information should only"},{"line_number":20,"context_line":"be know by admin users."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"2. Return the \u0027replica_volume_ref\u0027 in response body of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_4a0b6d24","line":19,"updated":"2015-12-08 16:28:26.000000000","message":"Suggestion: Those -\u003e This\n\nreplicaiton_extended_status -\u003e replication_extended_status","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"0bc1ab5819ce9eda90f4cef41f4988e4337696c7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Changes:"},{"line_number":18,"context_line":"1. Only allow admin to querying replication_driver_data \u0026"},{"line_number":19,"context_line":"replicaiton_extended_status. Those information should only"},{"line_number":20,"context_line":"be know by admin users."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"2. Return the \u0027replica_volume_ref\u0027 in response body of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_820fd835","line":19,"in_reply_to":"7a740942_4a0b6d24","updated":"2015-12-09 07:59:43.000000000","message":"Done","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"39c77ec91c494ab87d34a48d286bd2e2331c08b1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Changes:"},{"line_number":18,"context_line":"1. Only allow admin to querying replication_driver_data \u0026"},{"line_number":19,"context_line":"replicaiton_extended_status. Those information should only"},{"line_number":20,"context_line":"be know by admin users."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"2. Return the \u0027replica_volume_ref\u0027 in response body of"},{"line_number":23,"context_line":"querying volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_caebddda","line":20,"updated":"2015-12-08 16:28:26.000000000","message":"know -\u003e known","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"0bc1ab5819ce9eda90f4cef41f4988e4337696c7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Changes:"},{"line_number":18,"context_line":"1. Only allow admin to querying replication_driver_data \u0026"},{"line_number":19,"context_line":"replicaiton_extended_status. Those information should only"},{"line_number":20,"context_line":"be know by admin users."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"2. Return the \u0027replica_volume_ref\u0027 in response body of"},{"line_number":23,"context_line":"querying volume."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_a20a1424","line":20,"in_reply_to":"7a740942_caebddda","updated":"2015-12-09 07:59:43.000000000","message":"Done","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"39c77ec91c494ab87d34a48d286bd2e2331c08b1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"replicaiton_extended_status. Those information should only"},{"line_number":20,"context_line":"be know by admin users."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"2. Return the \u0027replica_volume_ref\u0027 in response body of"},{"line_number":23,"context_line":"querying volume."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_4aa12d45","line":22,"updated":"2015-12-08 16:28:26.000000000","message":"Suggestion: If I am understanding this sentence right, remove \u0027body\u0027.","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"39c77ec91c494ab87d34a48d286bd2e2331c08b1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":"Change-Id: Ieda66b6bc73b973112fb64ae24155580d7e6bbf5"},{"line_number":27,"context_line":"Implements: buleprint: get-replicated-volume-ref-for-dr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_e744d24a","line":27,"updated":"2015-12-08 16:28:26.000000000","message":"buleprint: -\u003e blueprint","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"0bc1ab5819ce9eda90f4cef41f4988e4337696c7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":"Change-Id: Ieda66b6bc73b973112fb64ae24155580d7e6bbf5"},{"line_number":27,"context_line":"Implements: buleprint: get-replicated-volume-ref-for-dr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_1d058d0f","line":27,"in_reply_to":"7a740942_e744d24a","updated":"2015-12-09 07:59:43.000000000","message":"Done","commit_id":"cd83f245ebccf29682755b2f88c1e29feedf5437"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"e3aa70c3af1aeb3159195fff63bcbcd4d5c7799f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"APIImpact"},{"line_number":23,"context_line":"Change-Id: Ieda66b6bc73b973112fb64ae24155580d7e6bbf5"},{"line_number":24,"context_line":"Implements: blueprint: get-replicated-volume-ref-for-dr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a710552_cec05a7f","line":24,"updated":"2015-12-15 18:45:15.000000000","message":"This doesn\u0027t seem to link to the blueprint correctly. Also, is this not more of a bug? It currently seems you can get this information and all this patch does is require you to be admin to get it. Should it say \"Only allow admin to fetch replica volume ref for DR?\" The wording of the commit msg sounds like we are adding the ability to get the replica volume ref at all.","commit_id":"3efd03c8e44b5d0cd728a544daafe63286d2ffb8"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"d3b5f58a53bad9e93d0d254b2312eaf15954baa4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"APIImpact"},{"line_number":23,"context_line":"Change-Id: Ieda66b6bc73b973112fb64ae24155580d7e6bbf5"},{"line_number":24,"context_line":"Implements: blueprint: get-replicated-volume-ref-for-dr"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a710552_1f8c4034","line":24,"in_reply_to":"5a710552_cec05a7f","updated":"2015-12-16 01:50:59.000000000","message":"I feel it\u0027s not a bug, we had some design options for this bp, and discussed with cores and we found that drivers can use replication_driver_data to store the information of replica volume ref, this will bring minimum changes to Cinder. Since replication_driver_data is string type, it\u0027s a little hard to extract replica volume ref from a string, and I feel this field also should be gotten by admin only, so I choose a simple way, just allow admin to fetch the replication_driver_data.","commit_id":"3efd03c8e44b5d0cd728a544daafe63286d2ffb8"}],"cinder/api/contrib/volume_replication.py":[{"author":{"_account_id":11819,"name":"Chaoyi Huang","email":"joehuang@huawei.com","username":"joehuang"},"change_message_id":"9766ceda28d939de571c6d2e3a137fb16eeac4d5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        resp_volume[key] \u003d db_volume[\u0027replication_extended_status\u0027]"},{"line_number":46,"context_line":"        if admin_only:"},{"line_number":47,"context_line":"            key \u003d \"%s:driver_data\" % Volume_replication.alias"},{"line_number":48,"context_line":"            resp_volume[key] \u003d db_volume[\u0027replication_driver_data\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @wsgi.extends"},{"line_number":51,"context_line":"    def show(self, req, resp_obj, id):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_491e0271","line":48,"range":{"start_line":48,"start_character":42,"end_line":48,"end_character":65},"updated":"2015-12-22 06:39:05.000000000","message":"use special tag in the replication_driver_data for the replica volume ref. If no this tag, it\u0027s normal driver data without replica volume ref, otherwise, return the content of this special tag as the replica volume ref.\n\nadd a new key-value return for the replica volume ref, so that only admin can see the replica volume ref. but tenant user and admin can still see the normal driver data","commit_id":"dc0c39dd8872b0ff72064151396924f597b58b06"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"4c683a025fd2aa25709eceddd4f8dadc2f6dd1b6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        resp_volume[key] \u003d db_volume[\u0027replication_extended_status\u0027]"},{"line_number":46,"context_line":"        if admin_only:"},{"line_number":47,"context_line":"            key \u003d \"%s:driver_data\" % Volume_replication.alias"},{"line_number":48,"context_line":"            resp_volume[key] \u003d db_volume[\u0027replication_driver_data\u0027]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @wsgi.extends"},{"line_number":51,"context_line":"    def show(self, req, resp_obj, id):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a7b0d38_da104251","line":48,"range":{"start_line":48,"start_character":42,"end_line":48,"end_character":65},"in_reply_to":"3a7e1126_491e0271","updated":"2015-12-23 06:09:16.000000000","message":"Done","commit_id":"dc0c39dd8872b0ff72064151396924f597b58b06"}],"cinder/db/sqlalchemy/migrate_repo/versions/061_add_replica_volume_ref.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7f5ddeb8e2fed3a2f2200796cbbd9667c1d7d1e1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from sqlalchemy import Column"},{"line_number":16,"context_line":"from sqlalchemy import MetaData, String, Table"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def upgrade(migrate_engine):"},{"line_number":20,"context_line":"    \"\"\"Add replication columns to volumes.\"\"\""},{"line_number":21,"context_line":"    meta \u003d MetaData()"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_7a6cbe36","line":18,"updated":"2015-12-09 15:32:28.000000000","message":"I\u0027ll admit that I\u0027m still kinda fuzzy on the use case, but it seems like maybe there\u0027s some data that you should be handling on the migration here?","commit_id":"b0060080eb3520f2a64a4120993d06baabbd7282"}],"cinder/db/sqlalchemy/models.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"7f5ddeb8e2fed3a2f2200796cbbd9667c1d7d1e1","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    replication_status \u003d Column(String(255))"},{"line_number":173,"context_line":"    replication_extended_status \u003d Column(String(255))"},{"line_number":174,"context_line":"    replication_driver_data \u003d Column(String(255))"},{"line_number":175,"context_line":"    replica_volume_ref \u003d Column(String(255))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    previous_status \u003d Column(String(255))"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_7af7de8c","line":175,"updated":"2015-12-09 15:32:28.000000000","message":"so what \"is\" a replica_volume_ref in this case?  Is this just like a provider_id?  In your spec I started to get the impression it was a standard cinder volume-ref, but here it\u0027s just a String column so I\u0027m unclear what the intent actually is here.  I\u0027m also unclear if it\u0027s really needed as a column in the db as opposed to one of the existing provider fields we already offer or backend stored info.\n\nMaybe we could chat more about the problem you\u0027re trying to solve and that would help me figure out what I\u0027m missing.","commit_id":"b0060080eb3520f2a64a4120993d06baabbd7282"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"1e6d251a9a62bff22b0f9b60af0279706abdf033","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    replication_status \u003d Column(String(255))"},{"line_number":173,"context_line":"    replication_extended_status \u003d Column(String(255))"},{"line_number":174,"context_line":"    replication_driver_data \u003d Column(String(255))"},{"line_number":175,"context_line":"    replica_volume_ref \u003d Column(String(255))"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    previous_status \u003d Column(String(255))"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_5b264869","line":175,"in_reply_to":"7a740942_7af7de8c","updated":"2015-12-11 01:17:32.000000000","message":"As we talked in IRC, the replica volume ref is more like provider_id, like logic volume name in LVM when using it to manage a existing LVM volume.\n\nAnd I will try to use a replication_driver_data to store this info.","commit_id":"b0060080eb3520f2a64a4120993d06baabbd7282"}]}