)]}'
{"cinder/volume/drivers/netapp/eseries/utils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c3cf517c0d55e6cb70d5dbaf4d51a41c4cc8cfdd","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def encode_hex_to_base32(hex_string):"},{"line_number":36,"context_line":"    \"\"\"Encodes hex to base32 bit as per RFC4648.\"\"\""},{"line_number":37,"context_line":"    bin_form \u003d binascii.unhexlify(hex_string)"},{"line_number":38,"context_line":"    return base64.b32encode(bin_form)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_aa6eac2c","line":37,"updated":"2015-12-03 08:00:22.000000000","message":"This function may also be modified to return Unicode.","commit_id":"a228f0cd413eef58a53aca35e367cc91a63771d5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1ee6fca678c485f31aaf6d5bd788d8cc49480178","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def encode_hex_to_base32(hex_string):"},{"line_number":36,"context_line":"    \"\"\"Encodes hex to base32 bit as per RFC4648.\"\"\""},{"line_number":37,"context_line":"    bin_form \u003d binascii.unhexlify(hex_string)"},{"line_number":38,"context_line":"    return base64.b32encode(bin_form)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_3d0aff26","line":37,"in_reply_to":"9a8ffd7b_aa6eac2c","updated":"2015-12-03 10:12:15.000000000","message":"+1","commit_id":"a228f0cd413eef58a53aca35e367cc91a63771d5"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c3cf517c0d55e6cb70d5dbaf4d51a41c4cc8cfdd","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def decode_base32_to_hex(base32_string):"},{"line_number":42,"context_line":"    \"\"\"Decodes base32 string to hex string.\"\"\""},{"line_number":43,"context_line":"    bin_form \u003d base64.b32decode(base32_string)"},{"line_number":44,"context_line":"    return binascii.hexlify(bin_form)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_ca6bf01c","line":43,"updated":"2015-12-03 08:00:22.000000000","message":"This function may also be modified to return Unicode.","commit_id":"a228f0cd413eef58a53aca35e367cc91a63771d5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1ee6fca678c485f31aaf6d5bd788d8cc49480178","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def decode_base32_to_hex(base32_string):"},{"line_number":42,"context_line":"    \"\"\"Decodes base32 string to hex string.\"\"\""},{"line_number":43,"context_line":"    bin_form \u003d base64.b32decode(base32_string)"},{"line_number":44,"context_line":"    return binascii.hexlify(bin_form)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_fdff97ff","line":43,"in_reply_to":"9a8ffd7b_ca6bf01c","updated":"2015-12-03 10:12:15.000000000","message":"+1","commit_id":"a228f0cd413eef58a53aca35e367cc91a63771d5"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c3cf517c0d55e6cb70d5dbaf4d51a41c4cc8cfdd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def convert_uuid_to_es_fmt(uuid_str):"},{"line_number":48,"context_line":"    \"\"\"Converts uuid to e-series compatible name format.\"\"\""},{"line_number":49,"context_line":"    uuid_base32 \u003d encode_hex_to_base32(uuid.UUID(six.text_type(uuid_str)).hex)"},{"line_number":50,"context_line":"    return uuid_base32.strip(b\u0027\u003d\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def convert_es_fmt_to_uuid(es_label):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_aa278c10","line":50,"updated":"2015-12-03 08:00:22.000000000","message":"Hum, in my opinion this function must return Unicode, not bytes. Same remark for encode_hex_to_base32().\n\nExample:\n\nname \u003d uuid_base32.strip(b\u0027\u003d\u0027)\nif six.PY3:\n    name \u003d name.decode(\u0027ascii\u0027)\nreturn name","commit_id":"a228f0cd413eef58a53aca35e367cc91a63771d5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1ee6fca678c485f31aaf6d5bd788d8cc49480178","unresolved":false,"context_lines":[{"line_number":47,"context_line":"def convert_uuid_to_es_fmt(uuid_str):"},{"line_number":48,"context_line":"    \"\"\"Converts uuid to e-series compatible name format.\"\"\""},{"line_number":49,"context_line":"    uuid_base32 \u003d encode_hex_to_base32(uuid.UUID(six.text_type(uuid_str)).hex)"},{"line_number":50,"context_line":"    return uuid_base32.strip(b\u0027\u003d\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def convert_es_fmt_to_uuid(es_label):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_dd9173f2","line":50,"in_reply_to":"9a8ffd7b_aa278c10","updated":"2015-12-03 10:12:15.000000000","message":"If we change `encode_hex_to_base32` and `decode_base32_to_hex` to return unicode then we will return unicode here as well (just need to change b\u0027\u003d\u0027 to \u0027\u003d\u0027) right?","commit_id":"a228f0cd413eef58a53aca35e367cc91a63771d5"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"c3cf517c0d55e6cb70d5dbaf4d51a41c4cc8cfdd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        es_label \u003d es_label[4:]"},{"line_number":57,"context_line":"    es_label_b32 \u003d es_label.ljust(32, \u0027\u003d\u0027)"},{"line_number":58,"context_line":"    es_label_b32_decoded \u003d base64.b32decode(es_label_b32)"},{"line_number":59,"context_line":"    return uuid.UUID(binascii.hexlify(es_label_b32_decoded).decode(\u0027utf-8\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_aaf9cc81","line":59,"updated":"2015-12-03 08:00:22.000000000","message":"Decoding from ASCII should be fine.","commit_id":"a228f0cd413eef58a53aca35e367cc91a63771d5"}]}