)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"f05830658e8fca58e506ccc338e6220484748926","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Current Cinder uses method CONF.set_override to change config option\u0027s"},{"line_number":10,"context_line":"value with designated value in unit test, but never check if the"},{"line_number":11,"context_line":"designated vaule is valid. Each config option has a type like"},{"line_number":12,"context_line":"strOpt, BoolOpt, etc. StrOpt with parameter choices only allows values"},{"line_number":13,"context_line":"in set of choices. In short word, each config option has limitation for"},{"line_number":14,"context_line":"type and value. In production code, oslo.conf can ensure user\u0027s input is"},{"line_number":15,"context_line":"valid, but in unit test, test methods can pass if we use method"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_c6927f9f","line":12,"updated":"2015-12-04 18:28:57.000000000","message":"strOpt -\u003e StrOpt","commit_id":"c816f1911c71331c530a6e73c742c89c8de566af"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"72e376bfd325f20609c68277a17bb9503e6ce843","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Current Cinder uses method CONF.set_override to change config option\u0027s"},{"line_number":10,"context_line":"value with designated value in unit test, but never check if the"},{"line_number":11,"context_line":"designated vaule is valid. Each config option has a type like"},{"line_number":12,"context_line":"strOpt, BoolOpt, etc. StrOpt with parameter choices only allows values"},{"line_number":13,"context_line":"in set of choices. In short word, each config option has limitation for"},{"line_number":14,"context_line":"type and value. In production code, oslo.conf can ensure user\u0027s input is"},{"line_number":15,"context_line":"valid, but in unit test, test methods can pass if we use method"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_6c289a9a","line":12,"in_reply_to":"7a740942_c6927f9f","updated":"2016-01-07 08:10:12.000000000","message":"Done","commit_id":"c816f1911c71331c530a6e73c742c89c8de566af"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"f05830658e8fca58e506ccc338e6220484748926","unresolved":false,"context_lines":[{"line_number":10,"context_line":"value with designated value in unit test, but never check if the"},{"line_number":11,"context_line":"designated vaule is valid. Each config option has a type like"},{"line_number":12,"context_line":"strOpt, BoolOpt, etc. StrOpt with parameter choices only allows values"},{"line_number":13,"context_line":"in set of choices. In short word, each config option has limitation for"},{"line_number":14,"context_line":"type and value. In production code, oslo.conf can ensure user\u0027s input is"},{"line_number":15,"context_line":"valid, but in unit test, test methods can pass if we use method"},{"line_number":16,"context_line":"CONF.set_override without parameter enforce_type\u003dTrue even we pass"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_46ed2f24","line":13,"updated":"2015-12-04 18:28:57.000000000","message":"Suggest: \"In short, each config option has limitations for type and value.\"","commit_id":"c816f1911c71331c530a6e73c742c89c8de566af"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"72e376bfd325f20609c68277a17bb9503e6ce843","unresolved":false,"context_lines":[{"line_number":10,"context_line":"value with designated value in unit test, but never check if the"},{"line_number":11,"context_line":"designated vaule is valid. Each config option has a type like"},{"line_number":12,"context_line":"strOpt, BoolOpt, etc. StrOpt with parameter choices only allows values"},{"line_number":13,"context_line":"in set of choices. In short word, each config option has limitation for"},{"line_number":14,"context_line":"type and value. In production code, oslo.conf can ensure user\u0027s input is"},{"line_number":15,"context_line":"valid, but in unit test, test methods can pass if we use method"},{"line_number":16,"context_line":"CONF.set_override without parameter enforce_type\u003dTrue even we pass"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_2c2e22a5","line":13,"in_reply_to":"7a740942_46ed2f24","updated":"2016-01-07 08:10:12.000000000","message":"Done","commit_id":"c816f1911c71331c530a6e73c742c89c8de566af"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"f05830658e8fca58e506ccc338e6220484748926","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF.set_override without parameter enforce_type\u003dTrue even we pass"},{"line_number":17,"context_line":"wrong type or wrong value to config option. This commit makes sure"},{"line_number":18,"context_line":"calling"},{"line_number":19,"context_line":"method CONF.set_override with enforce_type\u003dTrue, and remove invalid"},{"line_number":20,"context_line":"tests."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Note: We can\u0027t set enforce_type\u003dTrue by default in oslo.config now,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_86b55732","line":19,"updated":"2015-12-04 18:28:57.000000000","message":"Might want to move this up to the line above so it doesn\u0027t look like you are talking about something new.","commit_id":"c816f1911c71331c530a6e73c742c89c8de566af"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"72e376bfd325f20609c68277a17bb9503e6ce843","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF.set_override without parameter enforce_type\u003dTrue even we pass"},{"line_number":17,"context_line":"wrong type or wrong value to config option. This commit makes sure"},{"line_number":18,"context_line":"calling"},{"line_number":19,"context_line":"method CONF.set_override with enforce_type\u003dTrue, and remove invalid"},{"line_number":20,"context_line":"tests."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Note: We can\u0027t set enforce_type\u003dTrue by default in oslo.config now,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_8c0aae24","line":19,"in_reply_to":"7a740942_86b55732","updated":"2016-01-07 08:10:12.000000000","message":"Done","commit_id":"c816f1911c71331c530a6e73c742c89c8de566af"}]}