)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"04111295bf470de5191828294d10f2e395119892","unresolved":false,"context_lines":[{"line_number":10,"context_line":"a cinder-api returns a 403 error to nova by default."},{"line_number":11,"context_line":"So the default setting in cinder policy.json has been changed"},{"line_number":12,"context_line":"to \u0027rule:admin_or_owner\u0027 instead of \u0027rule:admin_api\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id356c1503d630e31b53a8f66ad207d8dd8cdad7e"},{"line_number":15,"context_line":"Closes-Bug: #1522705"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_f37a7bf0","line":13,"updated":"2015-12-08 05:00:31.000000000","message":"API guide needs changes, sop lease add \"DocImpact\" flag.","commit_id":"15852e4e6b1f18e4230d719ca6a1e28c535c5d7e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"04c616b2d61ca8d2071ec4ab02c90071e2ae6d85","unresolved":false,"context_lines":[{"line_number":10,"context_line":"a cinder-api returns a 403 error to nova by default."},{"line_number":11,"context_line":"So the default setting in cinder policy.json has been changed"},{"line_number":12,"context_line":"to \u0027rule:admin_or_owner\u0027 instead of \u0027rule:admin_api\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id356c1503d630e31b53a8f66ad207d8dd8cdad7e"},{"line_number":15,"context_line":"Closes-Bug: #1522705"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_b33873ef","line":13,"in_reply_to":"7a740942_f37a7bf0","updated":"2015-12-08 05:22:10.000000000","message":"Done","commit_id":"15852e4e6b1f18e4230d719ca6a1e28c535c5d7e"}],"cinder/tests/unit/api/contrib/test_admin_actions.py":[{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"fe4bb23b29a2e5d7b3608f3bf8905c59c5f2a9db","unresolved":false,"context_lines":[{"line_number":919,"context_line":"        else:"},{"line_number":920,"context_line":"            self.assertNotIn(\u0027save_volume_id\u0027, resp_dict)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def test_migrate_volume_comp_as_non_admin(self):"},{"line_number":923,"context_line":"        admin_ctx \u003d context.get_admin_context()"},{"line_number":924,"context_line":"        volume \u003d db.volume_create(admin_ctx, {\u0027id\u0027: \u0027fake1\u0027})"},{"line_number":925,"context_line":"        new_volume \u003d db.volume_create(admin_ctx, {\u0027id\u0027: \u0027fake2\u0027})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_fb737413","side":"PARENT","line":922,"updated":"2015-12-07 03:27:14.000000000","message":"I think you may change one, not delete. change as test_migrate_volume_comp_as_owner  and test_migrate_volume_comp_as_non_owner","commit_id":"ef08af911244210b5b7839502302a90199b14263"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"35914197878c48924eb03388242913b8149d8de7","unresolved":false,"context_lines":[{"line_number":919,"context_line":"        else:"},{"line_number":920,"context_line":"            self.assertNotIn(\u0027save_volume_id\u0027, resp_dict)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def test_migrate_volume_comp_as_non_admin(self):"},{"line_number":923,"context_line":"        admin_ctx \u003d context.get_admin_context()"},{"line_number":924,"context_line":"        volume \u003d db.volume_create(admin_ctx, {\u0027id\u0027: \u0027fake1\u0027})"},{"line_number":925,"context_line":"        new_volume \u003d db.volume_create(admin_ctx, {\u0027id\u0027: \u0027fake2\u0027})"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_beab971c","side":"PARENT","line":922,"in_reply_to":"7a740942_fb737413","updated":"2015-12-07 06:53:28.000000000","message":"Done","commit_id":"ef08af911244210b5b7839502302a90199b14263"},{"author":{"_account_id":11224,"name":"Swami Reddy","email":"swamireddy@gmail.com","username":"swamireddy"},"change_message_id":"04111295bf470de5191828294d10f2e395119892","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        else:"},{"line_number":922,"context_line":"            self.assertNotIn(\u0027save_volume_id\u0027, resp_dict)"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"    def test_migrate_volume_comp_as_owner_and_non_admin(self):"},{"line_number":925,"context_line":"        ctx \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":926,"context_line":"        updates \u003d {\u0027user_id\u0027: \u0027fake\u0027, \u0027project_id\u0027: \u0027fake\u0027}"},{"line_number":927,"context_line":"        volume \u003d self._create_volume(ctx, updates\u003dupdates)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_7341aba8","line":924,"updated":"2015-12-08 05:00:31.000000000","message":"Its good have separate test for owner like \"test_migrate_volume_comp_as_owner\". Please add new test case instead of updating the as_non_admin testcase.","commit_id":"15852e4e6b1f18e4230d719ca6a1e28c535c5d7e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"04c616b2d61ca8d2071ec4ab02c90071e2ae6d85","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        else:"},{"line_number":922,"context_line":"            self.assertNotIn(\u0027save_volume_id\u0027, resp_dict)"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"    def test_migrate_volume_comp_as_owner_and_non_admin(self):"},{"line_number":925,"context_line":"        ctx \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":926,"context_line":"        updates \u003d {\u0027user_id\u0027: \u0027fake\u0027, \u0027project_id\u0027: \u0027fake\u0027}"},{"line_number":927,"context_line":"        volume \u003d self._create_volume(ctx, updates\u003dupdates)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_8eae6ce4","line":924,"in_reply_to":"7a740942_7341aba8","updated":"2015-12-08 05:22:10.000000000","message":"There were tests for admin case and non admin case(2cases) before.\nThey were \u0027test_migrate_volume_comp_from_nova\u0027 and \u0027test_migrate_volume_comp_as_non_admin\u0027.\n\nNow 3 test cases are needed.\nThey are admin case, owner(and non admin) case and non owner(and non admin) case.\nSo I split \u0027test_migrate_volume_comp_as_non_admin\u0027 in two.\nThey are \u0027test_migrate_volume_comp_as_owner_and_non_admin\u0027 and \u0027test_migrate_volume_comp_as_non_owner_and_non_admin\u0027.\n\nSo it is no problem.","commit_id":"15852e4e6b1f18e4230d719ca6a1e28c535c5d7e"}]}