)]}'
{"cinder/tests/unit/api/contrib/test_admin_actions.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"24315751e56d8281b3f6452209f23310424ff228","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        self.assertEqual(405, res.status_int)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"class AdminActionsTest2(AdminActionsTest):"},{"line_number":680,"context_line":"    def setUp(self):"},{"line_number":681,"context_line":"        super(AdminActionsTest2, self).setUp()"},{"line_number":682,"context_line":"        # admin context"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_10af6195","line":679,"updated":"2015-12-04 17:40:51.000000000","message":"This needs a more descriptive name than AdminActionsTest2.  It isn\u0027t clear what this is in comparison to AdminActionsTest.","commit_id":"c185cbd81ea5d675c92e92677a6cde6cd9bf7919"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a3465eb37063811249e00595b7c547ebcd00b5f0","unresolved":false,"context_lines":[{"line_number":676,"context_line":"        self.assertEqual(405, res.status_int)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"class AdminActionsAttachDetachTest(AdminActionsTest):"},{"line_number":680,"context_line":"    def setUp(self):"},{"line_number":681,"context_line":"        super(AdminActionsAttachDetachTest, self).setUp()"},{"line_number":682,"context_line":"        # admin context"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_9a951c34","line":679,"updated":"2015-12-08 19:46:08.000000000","message":"I\u0027m not sure if I understand the intent of this patch, but… Doesn\u0027t deriving from AdminActionsTest mean that all the other tests from AdminActionsTest are inherited and therefore are executed twice?","commit_id":"f77f280f3b33aca257580cd75599fdf28e65d1a4"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1f4175bec25a85a6d13fb93db0f4b15b124a5f3","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        volume \u003d db.volume_update(ctx, volume[\u0027id\u0027], model_update)"},{"line_number":519,"context_line":"        self._migrate_volume_exec(ctx, volume, host, expected_status)"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_migrate_volume_with_snap(self):"},{"line_number":522,"context_line":"        expected_status \u003d 400"},{"line_number":523,"context_line":"        host \u003d \u0027test2\u0027"},{"line_number":524,"context_line":"        ctx \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_cb016a6c","line":521,"updated":"2015-12-09 14:10:00.000000000","message":"The method duplicates with it at line 1124. There are also many other duplicated methods.","commit_id":"4c1b2871a4ffd8ae126f1aa3da8362d15064ac46"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1f4175bec25a85a6d13fb93db0f4b15b124a5f3","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"    def test_migrate_volume_success(self):"},{"line_number":1059,"context_line":"        expected_status \u003d 202"},{"line_number":1060,"context_line":"        host \u003d \u0027test2\u0027"},{"line_number":1061,"context_line":"        ctx \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"},{"line_number":1062,"context_line":"        volume \u003d self._migrate_volume_prep()"},{"line_number":1063,"context_line":"        volume \u003d self._migrate_volume_exec(ctx, volume, host, expected_status)"},{"line_number":1064,"context_line":"        self.assertEqual(\u0027starting\u0027, volume[\u0027migration_status\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_ab809ef8","line":1061,"updated":"2015-12-09 14:10:00.000000000","message":"Why don\u0027t you remove the ctx creation here and use self.ctx instead?","commit_id":"4c1b2871a4ffd8ae126f1aa3da8362d15064ac46"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"f1f4175bec25a85a6d13fb93db0f4b15b124a5f3","unresolved":false,"context_lines":[{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"    def test_migrate_volume_fail_replication(self):"},{"line_number":1067,"context_line":"        expected_status \u003d 400"},{"line_number":1068,"context_line":"        host \u003d \u0027test2\u0027"},{"line_number":1069,"context_line":"        ctx \u003d context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True)"},{"line_number":1070,"context_line":"        volume \u003d self._migrate_volume_prep()"},{"line_number":1071,"context_line":"        # current status is available"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_6ba2b69c","line":1068,"updated":"2015-12-09 14:10:00.000000000","message":"Ditto.","commit_id":"4c1b2871a4ffd8ae126f1aa3da8362d15064ac46"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"fd4213eae67f0fafb5a7d514cc0c0a94477c8b3b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        volume \u003d db.volume_get(self.ctx, volume[\u0027id\u0027])"},{"line_number":182,"context_line":"        self.assertEqual(\u0027error\u0027, volume[\u0027status\u0027])"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_reset_status_as_non_admin(self):"},{"line_number":185,"context_line":"        ctx \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027)"},{"line_number":186,"context_line":"        volume \u003d db.volume_create(self.ctx,"},{"line_number":187,"context_line":"                                  {\u0027status\u0027: \u0027error\u0027, \u0027size\u0027: 1})"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_818ec825","line":184,"updated":"2015-12-09 23:06:44.000000000","message":"Would be nice to either name these non-admin context\u0027s something different in the test cases where we use both admin and non-admin contexts in the same test case.\n\nOther option could be renaming self.ctx -\u003e self.adm_ctx","commit_id":"4845770fee6150e46ddbad23df46f887b1e5a78c"}]}