)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"3667a9fcc099d4a2433014cfcd563adc41f312f2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave McCowan \u003cdmccowan@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 14:49:49 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check current context before returning cached key manager client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The key manager caches the value of barbican client to be reused,"},{"line_number":10,"context_line":"saving an extra call to keystone.  The cached value is only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_62200549","line":7,"updated":"2015-12-07 20:28:18.000000000","message":"First line should be limited to 50 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"8d206b731f8159dbaea9c7700eabd16768145c9b"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"9ff9dbb4bc0e264bc000baa3069498fbc6df6ba5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave McCowan \u003cdmccowan@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 14:49:49 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check current context before returning cached key manager client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The key manager caches the value of barbican client to be reused,"},{"line_number":10,"context_line":"saving an extra call to keystone.  The cached value is only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_93467b79","line":7,"in_reply_to":"7a740942_62200549","updated":"2015-12-08 14:39:34.000000000","message":"Done","commit_id":"8d206b731f8159dbaea9c7700eabd16768145c9b"}],"cinder/keymgr/barbican.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"288d52bb7fd05a0b8b7dc2cc647ee4d413809c72","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            raise exception.KeyManagerError(msg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # If same context, return cached barbican client"},{"line_number":100,"context_line":"        if self._barbican_client and self._current_context \u003d\u003d ctxt:"},{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_ec338ea9","line":100,"updated":"2015-12-07 19:43:31.000000000","message":"If I didn\u0027t miss anything, self._current_context will be always None","commit_id":"339e405216d878ad6319c8cb63e9bf911334ade1"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"53da22c82d03dd76ab4d77f211be59a497669d23","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            raise exception.KeyManagerError(msg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # If same context, return cached barbican client"},{"line_number":100,"context_line":"        if self._barbican_client and self._current_context \u003d\u003d ctxt:"},{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_8ca9aa92","line":100,"in_reply_to":"7a740942_ec338ea9","updated":"2015-12-07 19:52:25.000000000","message":"Done. Thanks.  I dropped a line when reformatting.","commit_id":"339e405216d878ad6319c8cb63e9bf911334ade1"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"3667a9fcc099d4a2433014cfcd563adc41f312f2","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            raise exception.KeyManagerError(msg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # If same context, return cached barbican client"},{"line_number":100,"context_line":"        if self._barbican_client and self._current_context \u003d\u003d ctxt:"},{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_c239b9a5","line":100,"updated":"2015-12-07 20:28:18.000000000","message":"Going off what Ivan said, it looks like to me that by this point, self._current_context will always be none. So we would not be able to get into this if statement, correct?","commit_id":"8d206b731f8159dbaea9c7700eabd16768145c9b"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"9ff9dbb4bc0e264bc000baa3069498fbc6df6ba5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            raise exception.KeyManagerError(msg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # If same context, return cached barbican client"},{"line_number":100,"context_line":"        if self._barbican_client and self._current_context \u003d\u003d ctxt:"},{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_b3661728","line":100,"in_reply_to":"7a740942_1624c45b","updated":"2015-12-08 14:39:34.000000000","message":"See line 104.","commit_id":"8d206b731f8159dbaea9c7700eabd16768145c9b"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"53098d506409bb3202d84ebfdfa6faa8dde2677e","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            raise exception.KeyManagerError(msg)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # If same context, return cached barbican client"},{"line_number":100,"context_line":"        if self._barbican_client and self._current_context \u003d\u003d ctxt:"},{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_1624c45b","line":100,"in_reply_to":"7a740942_c239b9a5","updated":"2015-12-08 11:33:42.000000000","message":"Agree. Looks like it never will be True.","commit_id":"8d206b731f8159dbaea9c7700eabd16768145c9b"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"9ff9dbb4bc0e264bc000baa3069498fbc6df6ba5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            self._current_context \u003d ctxt"},{"line_number":105,"context_line":"            auth \u003d identity.v3.Token("},{"line_number":106,"context_line":"                auth_url\u003dCONF.keymgr.encryption_auth_url,"},{"line_number":107,"context_line":"                token\u003dctxt.auth_token,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_13a5ab45","line":104,"updated":"2015-12-08 14:39:34.000000000","message":"Saving current_context in this line.\nWhen copy_key() runs, it both reads and stores the key with the same context (and same instance of this class) and will use the cached value.","commit_id":"8d206b731f8159dbaea9c7700eabd16768145c9b"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"2b03291be0cc7c43be8a8b3e29223e12a43a9d5a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            self._current_context \u003d ctxt"},{"line_number":105,"context_line":"            auth \u003d identity.v3.Token("},{"line_number":106,"context_line":"                auth_url\u003dCONF.keymgr.encryption_auth_url,"},{"line_number":107,"context_line":"                token\u003dctxt.auth_token,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_23df1c3b","line":104,"updated":"2015-12-08 21:58:00.000000000","message":"I believe to make line 104 to line 116 will be better, in case there are some exceptions could be raise during the try. Otherwise,  I think the self._current_context and self._barbican_client might not be consistent.","commit_id":"d513dd2893e08e54f855e826494280d63a6633b7"},{"author":{"_account_id":11561,"name":"Dave McCowan","email":"dmccowan@cisco.com","username":"dave-mccowan"},"change_message_id":"2f66773e1916d08759ec19b2a68a556b2989869f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            return self._barbican_client"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            self._current_context \u003d ctxt"},{"line_number":105,"context_line":"            auth \u003d identity.v3.Token("},{"line_number":106,"context_line":"                auth_url\u003dCONF.keymgr.encryption_auth_url,"},{"line_number":107,"context_line":"                token\u003dctxt.auth_token,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_ba248a0c","line":104,"in_reply_to":"7a740942_23df1c3b","updated":"2015-12-09 01:52:45.000000000","message":"Done","commit_id":"d513dd2893e08e54f855e826494280d63a6633b7"}]}