)]}'
{"cinder/volume/drivers/netapp/eseries/client.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1f2a3e0ff4bebe9e9466da8b4f874d1d8c8df19b","unresolved":false,"context_lines":[{"line_number":726,"context_line":"        path \u003d (\u0027/counters/%s/setCounter?value\u003d%d\u0027 % (key, value))"},{"line_number":727,"context_line":"        self._invoke(\u0027POST\u0027, path)"},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"    def _get_asup_info(self):"},{"line_number":730,"context_line":"        \"\"\"Returns a dictionary of relevant autosupport information."},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"        Currently returned fields are:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_5e941de1","line":729,"range":{"start_line":729,"start_character":8,"end_line":729,"end_character":10},"updated":"2015-12-17 14:53:39.000000000","message":"This is used externally, so it should not be marked private with the leading _.","commit_id":"a019f4742c6c6e7e651db437367ad595aa220849"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1f2a3e0ff4bebe9e9466da8b4f874d1d8c8df19b","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        if controllers:"},{"line_number":742,"context_line":"            asup_info[\u0027model\u0027] \u003d controllers[0].get(\u0027modelName\u0027, \u0027unknown\u0027)"},{"line_number":743,"context_line":"            serial_numbers \u003d [value[\u0027serialNumber\u0027].rstrip()"},{"line_number":744,"context_line":"                              for _, value in enumerate(controllers)]"},{"line_number":745,"context_line":"            serial_numbers.sort()"},{"line_number":746,"context_line":"            for index, value in enumerate(serial_numbers):"},{"line_number":747,"context_line":"                if not value:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_f9b723f3","line":744,"range":{"start_line":744,"start_character":34,"end_line":744,"end_character":35},"updated":"2015-12-17 14:53:39.000000000","message":"Using _ to denote unused variables is great practice - except when doing i18n. This has the risk of overriding the _() localization call in py27. I believe that\u0027s fixed in py34. If any kind of logging or exception handling was added after this point it would not get an error that \u0027int\u0027 object is not callable.","commit_id":"a019f4742c6c6e7e651db437367ad595aa220849"}]}