)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"16ce91e2e4ebae19a5656de70daedf38b44b79a7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-12-10 21:21:23 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":" Below changes are done in this commit:"},{"line_number":8,"context_line":" a. replaces update() with  oslo.db\u0027s soft_delete() used in"},{"line_number":9,"context_line":" volume_type_access_remove in sqlalchemy.db.api."},{"line_number":10,"context_line":" b. updated db schema of volume_type_projects."},{"line_number":11,"context_line":" \"deleted\" column type is modified from boolean to integer"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_e328c287","line":8,"updated":"2015-12-10 16:15:19.000000000","message":"Please add another line break between the summary line and the longer description. Also change the summary line to be a short (\u003c50 characters) summary of what this patch is addressing.\n\nLeading spaces for each line can also be removed.","commit_id":"f2772277f3097a68173e7f15511f20137c9e4701"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9bab5834821db9c6643537a8025683a08fae3afd","unresolved":false,"context_lines":[{"line_number":14,"context_line":" \"deleted\" column type is boolean before this fix."},{"line_number":15,"context_line":" Boolean is represented as TINYINT which can store at max 127."},{"line_number":16,"context_line":" But soft_delete sets deleted column to the value of id during"},{"line_number":17,"context_line":" volume type access remove operation."},{"line_number":18,"context_line":" So, in this commit, column type is updated to integer."},{"line_number":19,"context_line":" Closes-Bug: #1518363"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_20beb5ff","line":17,"updated":"2015-12-10 18:52:42.000000000","message":"Recommend blank line here as well.","commit_id":"f2772277f3097a68173e7f15511f20137c9e4701"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9bab5834821db9c6643537a8025683a08fae3afd","unresolved":false,"context_lines":[{"line_number":15,"context_line":" Boolean is represented as TINYINT which can store at max 127."},{"line_number":16,"context_line":" But soft_delete sets deleted column to the value of id during"},{"line_number":17,"context_line":" volume type access remove operation."},{"line_number":18,"context_line":" So, in this commit, column type is updated to integer."},{"line_number":19,"context_line":" Closes-Bug: #1518363"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I638a202dfb2b4febf1d623683de22df3b6dc2615"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_c9c60716","line":18,"updated":"2015-12-10 18:52:42.000000000","message":"Also need a blank line here before \u0027closes-bug\u0027","commit_id":"f2772277f3097a68173e7f15511f20137c9e4701"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"4f893d27e0ca30b0dc2320370ba6d0e7d1d5accc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sheel Rana \u003cranasheel2000@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-12 22:29:18 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated \"deleted\" column type of volume_type_access tinyint-\u003eint."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Below changes are done in this commit:"},{"line_number":10,"context_line":"a.replaces update() with  oslo.db\u0027s soft_delete() used in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_9f8a071a","line":7,"updated":"2015-12-14 00:29:02.000000000","message":"Please remove \".\" from end of the summary line. Also, try to limit the number of characters in the first line to 50 characters. Thanks! \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Git_Commit_Good_Practice","commit_id":"d6483fec65380d43a4eaa866069e48964b207fde"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"4f893d27e0ca30b0dc2320370ba6d0e7d1d5accc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Updated \"deleted\" column type of volume_type_access tinyint-\u003eint."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Below changes are done in this commit:"},{"line_number":10,"context_line":"a.replaces update() with  oslo.db\u0027s soft_delete() used in"},{"line_number":11,"context_line":"volume_type_access_remove() function of sqlalchemy.db.api to use value of"},{"line_number":12,"context_line":"\"id\" in \"deleted\" column during volume type access remove operation."},{"line_number":13,"context_line":"This bug will be solved due to this change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_bf94a336","line":10,"updated":"2015-12-14 00:29:02.000000000","message":"Suggest: \"1. Replaces update() ...\"\n\nThis just makes it a little clearer what the changes are. Also maybe add a space in between the \"Changes in this commit\" line, the first change, and the second change to break things up a little bit more and make it easier to read.","commit_id":"d6483fec65380d43a4eaa866069e48964b207fde"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"4f893d27e0ca30b0dc2320370ba6d0e7d1d5accc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"volume_type_access_remove() function of sqlalchemy.db.api to use value of"},{"line_number":12,"context_line":"\"id\" in \"deleted\" column during volume type access remove operation."},{"line_number":13,"context_line":"This bug will be solved due to this change."},{"line_number":14,"context_line":"b.updated db schema of volume_type_projects."},{"line_number":15,"context_line":"As tinyint can store maximum 127, \"deleted\" column type is modified"},{"line_number":16,"context_line":"tinyint-\u003einteger so that it can store more than 128 entries in it."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_5f97bf39","line":14,"updated":"2015-12-14 00:29:02.000000000","message":"Suggest: \"2. Updated db schema...\"","commit_id":"d6483fec65380d43a4eaa866069e48964b207fde"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fcf1904922a043b49896d40a0ef77d4b796974e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sheel Rana \u003cranasheel2000@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-14 19:54:17 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated \"deleted\" column of volume_type_access(tinyint\u003eint)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Below changes are done in this commit:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a710552_0f30dc55","line":7,"updated":"2015-12-14 20:55:01.000000000","message":"This should still get shortened to around 50 characters. Thanks!","commit_id":"b5de4963425549f3f74bf127c9ac19b0b9a46b62"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5a861a7b2aa51978ff67aef6ef3eea672de84934","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"UpgradeImpact:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"a. After upgrading deleted column from tinyint to integer,"},{"line_number":30,"context_line":"Volume_type_access can be removed multiple times from one project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"b. Adding or removing volume_type access from project during"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa69d971_cd173d53","line":29,"updated":"2015-12-29 17:22:04.000000000","message":"Ah, we\u0027re leaving the constraint in place, so I don\u0027t think this still applies. Am I wrong?","commit_id":"da4d092a40c306d9b74070eab0d906d3bbcf7d0a"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"8a3d7d72a8382fc201919265cfc9dc9fec005c2a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"UpgradeImpact:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"a. After upgrading deleted column from tinyint to integer,"},{"line_number":30,"context_line":"Volume_type_access can be removed multiple times from one project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"b. Adding or removing volume_type access from project during"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa69d971_a1ce8281","line":29,"in_reply_to":"fa69d971_cd173d53","updated":"2015-12-30 09:24:22.000000000","message":"It applies Michal.\nAlong with tinyint-\u003einteger, I made changes to store \"id\" in \"deleted\" instead of true/false.\nDue to this, for each new volume_type_access record, there will be different entries which will satisfy the constraint as well during deletion.\nSo, user will be able to remove access multiple times.","commit_id":"da4d092a40c306d9b74070eab0d906d3bbcf7d0a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"5a861a7b2aa51978ff67aef6ef3eea672de84934","unresolved":false,"context_lines":[{"line_number":29,"context_line":"a. After upgrading deleted column from tinyint to integer,"},{"line_number":30,"context_line":"Volume_type_access can be removed multiple times from one project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"b. Adding or removing volume_type access from project during"},{"line_number":33,"context_line":"upgrade must be avoided."},{"line_number":34,"context_line":"Same is mentioned in release notes."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa69d971_90087c2a","line":32,"updated":"2015-12-29 17:22:04.000000000","message":"As this is mentioned in release note I don\u0027t think we need this here. I think bare\n\n UpgradeImpact\n\nis enough.","commit_id":"da4d092a40c306d9b74070eab0d906d3bbcf7d0a"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"8a3d7d72a8382fc201919265cfc9dc9fec005c2a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"a. After upgrading deleted column from tinyint to integer,"},{"line_number":30,"context_line":"Volume_type_access can be removed multiple times from one project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"b. Adding or removing volume_type access from project during"},{"line_number":33,"context_line":"upgrade must be avoided."},{"line_number":34,"context_line":"Same is mentioned in release notes."},{"line_number":35,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa69d971_c1929657","line":32,"in_reply_to":"fa69d971_90087c2a","updated":"2015-12-30 09:24:22.000000000","message":"Sure, I will remove same.","commit_id":"da4d092a40c306d9b74070eab0d906d3bbcf7d0a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ed437b9b091a62f0579f79ee351298adea515837","unresolved":false,"context_lines":[{"line_number":27,"context_line":"UpgradeImpact:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"After upgrading deleted column from tinyint to integer,"},{"line_number":30,"context_line":"Volume_type_access can be removed multiple times from one project."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Closes-Bug: #1518363"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_adcbd371","line":30,"updated":"2015-12-30 11:00:26.000000000","message":"Ah, right, so that\u0027s what you mean. I don\u0027t think that\u0027s an UpgradeImpact but a bugfix. And we have a bug link in line 32, so this is redundant to me.","commit_id":"292048bcf4ad0b26b7e6bf9f375555c30158aa1e"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2a1649511194c4632201ccfb2b75cf3af0287d5f","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        pass  # omit the filter to include deleted and active"},{"line_number":259,"context_line":"    elif read_deleted \u003d\u003d \u0027only\u0027:"},{"line_number":260,"context_line":"        query \u003d query.filter_by(deleted\u003dTrue)"},{"line_number":261,"context_line":"    elif read_deleted \u003d\u003d \u0027int\u0027:"},{"line_number":262,"context_line":"        query \u003d query.filter_by(deleted\u003d0)"},{"line_number":263,"context_line":"    else:"},{"line_number":264,"context_line":"        raise Exception("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_876335b1","line":261,"updated":"2015-12-23 12:53:29.000000000","message":"This should be something like \u0027int_no\u0027.","commit_id":"48940fec03ddb528819b851f5737d72d2ab8c01c"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2a1649511194c4632201ccfb2b75cf3af0287d5f","unresolved":false,"context_lines":[{"line_number":2802,"context_line":"    \"\"\"Remove given tenant from the volume type access list.\"\"\""},{"line_number":2803,"context_line":"    volume_type_id \u003d _volume_type_get_id_from_volume_type(context, type_id)"},{"line_number":2804,"context_line":""},{"line_number":2805,"context_line":"    count \u003d _volume_type_access_query(context).\\"},{"line_number":2806,"context_line":"        filter_by(volume_type_id\u003dvolume_type_id).\\"},{"line_number":2807,"context_line":"        filter_by(project_id\u003dproject_id).\\"},{"line_number":2808,"context_line":"        soft_delete(synchronize_session\u003dFalse)"},{"line_number":2809,"context_line":"    if count \u003d\u003d 0:"},{"line_number":2810,"context_line":"        raise exception.VolumeTypeAccessNotFound("},{"line_number":2811,"context_line":"            volume_type_id\u003dtype_id, project_id\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_07cf4557","line":2808,"range":{"start_line":2805,"start_character":0,"end_line":2808,"end_character":46},"updated":"2015-12-23 12:53:29.000000000","message":"Please don\u0027t use \\ to wrap lines. You can use () instead.\n\nhttp://docs.openstack.org/developer/hacking/#general","commit_id":"48940fec03ddb528819b851f5737d72d2ab8c01c"}],"cinder/db/sqlalchemy/migrate_repo/versions/061_deleted_type_to_Integer.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fcf1904922a043b49896d40a0ef77d4b796974e5","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def upgrade(migrate_engine):"},{"line_number":18,"context_line":"    \"\"\"deleted col of volume_type_projects converted(tinyint-\u003eInt).\"\"\""},{"line_number":19,"context_line":"    meta \u003d MetaData()"},{"line_number":20,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_ef5f9073","line":18,"updated":"2015-12-14 20:55:01.000000000","message":"Please remove \".\" at EOL and capitalize the first letter in the comment.","commit_id":"b5de4963425549f3f74bf127c9ac19b0b9a46b62"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"856c786ee10ac563c9950b51aefeade0b0b2505f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"def upgrade(migrate_engine):"},{"line_number":18,"context_line":"    \"\"\"deleted col of volume_type_projects converted(tinyint-\u003eInt).\"\"\""},{"line_number":19,"context_line":"    meta \u003d MetaData()"},{"line_number":20,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_58653e43","line":18,"in_reply_to":"5a710552_ef5f9073","updated":"2015-12-15 05:20:26.000000000","message":"061_deleted_type_to_Integer.py:17:1: D400  First line should end with a period (not \u0027)\u0027)","commit_id":"b5de4963425549f3f74bf127c9ac19b0b9a46b62"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"fcf1904922a043b49896d40a0ef77d4b796974e5","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def downgrade(migrate_engine):"},{"line_number":34,"context_line":"    \"\"\"deleted Col of volume_type_projects converted(Int-\u003etinyint).\"\"\""},{"line_number":35,"context_line":"    meta \u003d MetaData()"},{"line_number":36,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_8f512c65","line":34,"updated":"2015-12-14 20:55:01.000000000","message":"Same comment here.","commit_id":"b5de4963425549f3f74bf127c9ac19b0b9a46b62"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7e54ec6b7e31ae29e7a51bb5f7a88e66c492e0c3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volume_type_projects \u003d Table(\u0027volume_type_projects\u0027, meta, autoload\u003dTrue)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    if migrate_engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":25,"context_line":"        # NOTE: PostgreSQL can\u0027t cast tinyint to int automatically"},{"line_number":26,"context_line":"        sql \u003d \u0027ALTER TABLE volume_type_projects ALTER COLUMN deleted \u0027 + \\"},{"line_number":27,"context_line":"              \u0027TYPE INTEGER USING deleted::integer\u0027"},{"line_number":28,"context_line":"        migrate_engine.execute(sql)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_52f7748c","line":25,"range":{"start_line":25,"start_character":38,"end_line":25,"end_character":45},"updated":"2015-12-22 14:01:47.000000000","message":"In PostgreSQL this isn\u0027t actually tinyint but a real boolean column.","commit_id":"96b1a6d2f89b67f9fa1965b01a19f0b709b83c1e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"80cab614a758e873f6bc57a9065b8b6446877081","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volume_type_projects \u003d Table(\u0027volume_type_projects\u0027, meta, autoload\u003dTrue)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    if migrate_engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":25,"context_line":"        # NOTE: PostgreSQL can\u0027t cast tinyint to int automatically"},{"line_number":26,"context_line":"        sql \u003d \u0027ALTER TABLE volume_type_projects ALTER COLUMN deleted \u0027 + \\"},{"line_number":27,"context_line":"              \u0027TYPE INTEGER USING deleted::integer\u0027"},{"line_number":28,"context_line":"        migrate_engine.execute(sql)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_b2a2584a","line":25,"range":{"start_line":25,"start_character":38,"end_line":25,"end_character":45},"updated":"2015-12-22 14:03:25.000000000","message":"In PostgreSQL this isn\u0027t actually tinyint but a real boolean column.","commit_id":"96b1a6d2f89b67f9fa1965b01a19f0b709b83c1e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"80cab614a758e873f6bc57a9065b8b6446877081","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        volume_type_projects.c.deleted.alter(Integer)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def downgrade(migrate_engine):"},{"line_number":34,"context_line":"    \"\"\"downgrade migrations should be removed.\"\"\""},{"line_number":35,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_5288d4c6","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":28},"updated":"2015-12-22 14:03:25.000000000","message":"As patch removing downgrading migrations got merged you should completely remove this method now.","commit_id":"96b1a6d2f89b67f9fa1965b01a19f0b709b83c1e"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"7e54ec6b7e31ae29e7a51bb5f7a88e66c492e0c3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        volume_type_projects.c.deleted.alter(Integer)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def downgrade(migrate_engine):"},{"line_number":34,"context_line":"    \"\"\"downgrade migrations should be removed.\"\"\""},{"line_number":35,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_92587c8c","line":33,"range":{"start_line":33,"start_character":14,"end_line":33,"end_character":28},"updated":"2015-12-22 14:01:47.000000000","message":"As patch removing downgrading migrations got merged you should completely remove this method now.","commit_id":"96b1a6d2f89b67f9fa1965b01a19f0b709b83c1e"}],"cinder/db/sqlalchemy/models.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2a1649511194c4632201ccfb2b75cf3af0287d5f","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    volume_type_id \u003d Column(Integer, ForeignKey(\u0027volume_types.id\u0027),"},{"line_number":266,"context_line":"                            nullable\u003dFalse)"},{"line_number":267,"context_line":"    project_id \u003d Column(String(255))"},{"line_number":268,"context_line":"    deleted \u003d Column(Integer, default\u003d0)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    volume_type \u003d relationship("},{"line_number":271,"context_line":"        VolumeTypes,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_672c094b","line":268,"updated":"2015-12-23 12:53:29.000000000","message":"Please remove the other changes in this file, these aren\u0027t related to the patch.","commit_id":"48940fec03ddb528819b851f5737d72d2ab8c01c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"af3e03d1f0f1a015f86836b84c869538d2f5ca01","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    volume_type_id \u003d Column(Integer, ForeignKey(\u0027volume_types.id\u0027),"},{"line_number":260,"context_line":"                            nullable\u003dFalse)"},{"line_number":261,"context_line":"    project_id \u003d Column(String(255))"},{"line_number":262,"context_line":"    deleted \u003d Column(Integer, default\u003d0)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    volume_type \u003d relationship("},{"line_number":265,"context_line":"        VolumeTypes,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_1745e96e","line":262,"updated":"2016-01-04 20:16:18.000000000","message":"Should we override \u0027delete\u0027 method here? In current implementation, it will set deleted\u003d1 always and bug will be still actual","commit_id":"b2cd356cacad84d925a5781c7ac6c56c68a73e04"}],"cinder/tests/unit/test_migrations.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2a1649511194c4632201ccfb2b75cf3af0287d5f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    BOOL_TYPE \u003d sqlalchemy.types.BOOLEAN"},{"line_number":40,"context_line":"    TIME_TYPE \u003d sqlalchemy.types.DATETIME"},{"line_number":41,"context_line":"    INTEGER_TYPE \u003d sqlalchemy.types.INTEGER"},{"line_number":42,"context_line":"    VARCHAR_TYPE \u003d sqlalchemy.types.VARCHAR"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def INIT_VERSION(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_a7f191cf","line":42,"updated":"2015-12-23 12:53:29.000000000","message":"You can do this refactoring in other patch. Doing that in this one makes the patch much harder to review.","commit_id":"48940fec03ddb528819b851f5737d72d2ab8c01c"}],"releasenotes/notes/add-del-volumeTypeAccess-9b18b9a241d38813.yaml":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"2a1649511194c4632201ccfb2b75cf3af0287d5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adding or removing volume_type_access from any project during upgrade must not be performed."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a7b0d38_07cc2588","line":3,"range":{"start_line":3,"start_character":59,"end_line":3,"end_character":73},"updated":"2015-12-23 12:53:29.000000000","message":"during DB migration 61","commit_id":"48940fec03ddb528819b851f5737d72d2ab8c01c"}],"releasenotes/notes/add-del-volumeTypeAccess-b1c8cb14a9d14db3.yaml":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"ed437b9b091a62f0579f79ee351298adea515837","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Adding or removing volume_type_access from any project during DB migration 62 must not be performed."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"fa69d971_0d8f7f24","line":3,"updated":"2015-12-30 11:00:26.000000000","message":"Please add following phrase here:\n\n  - When running PostgreSQL it is required to upgrade and restart all the cinder-api services along with DB migration 62.","commit_id":"292048bcf4ad0b26b7e6bf9f375555c30158aa1e"}]}