)]}'
{"cinder/volume/drivers/coraid.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"67c912d566a2073ce57e574848a0020c1f1c3808","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self._login()"},{"line_number":144,"context_line":"        return self._esm_rest(url, data)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _esm_rest(self, url\u003dFalse, data\u003dNone):"},{"line_number":147,"context_line":"        \"\"\""},{"line_number":148,"context_line":"        _esm_rest represent the entry point to send requests to ESM Appliance."},{"line_number":149,"context_line":"        Send the HTTPS call, get response in JSON"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fu3k%3D","line":146,"updated":"2013-03-30 19:12:18.000000000","message":"This seems a bit silly to have these two methods like this... why not just move the login call in to _esm_rest and loose the indirection here?","commit_id":"73d0527968a333a096c34c21a4dadf16b8415070"},{"author":{"_account_id":7067,"name":"Larry Matter","email":"lmatter@coraid.com","username":"lmatter"},"change_message_id":"c315ae20b8b48264e66d59fccd5d6ba4b0871c00","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self._login()"},{"line_number":144,"context_line":"        return self._esm_rest(url, data)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _esm_rest(self, url\u003dFalse, data\u003dNone):"},{"line_number":147,"context_line":"        \"\"\""},{"line_number":148,"context_line":"        _esm_rest represent the entry point to send requests to ESM Appliance."},{"line_number":149,"context_line":"        Send the HTTPS call, get response in JSON"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fuz0%3D","line":146,"in_reply_to":"AAAAOH%2F%2Fu3M%3D","updated":"2013-03-31 01:11:51.000000000","message":"Done","commit_id":"73d0527968a333a096c34c21a4dadf16b8415070"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e4f3dd104e4668aab94069b995fc4afcb1e6f1f6","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self._login()"},{"line_number":144,"context_line":"        return self._esm_rest(url, data)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _esm_rest(self, url\u003dFalse, data\u003dNone):"},{"line_number":147,"context_line":"        \"\"\""},{"line_number":148,"context_line":"        _esm_rest represent the entry point to send requests to ESM Appliance."},{"line_number":149,"context_line":"        Send the HTTPS call, get response in JSON"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fu3M%3D","line":146,"in_reply_to":"AAAAOH%2F%2Fu3c%3D","updated":"2013-03-30 19:47:42.000000000","message":"I see... you have some functionality that requires login() and some that don\u0027t (basicly admin functionality)?\n\nIt\u0027s a bit confusing IMO due to the naming etc.... might have been better to do something like \"_admin_esm_cmd()\" and \"_esm_cmd()\" and/or use a flag in the args to execute _login() or not.","commit_id":"73d0527968a333a096c34c21a4dadf16b8415070"},{"author":{"_account_id":7067,"name":"Larry Matter","email":"lmatter@coraid.com","username":"lmatter"},"change_message_id":"9c95e696dcdf065d43cb3ca34a21d7cee993999d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        self._login()"},{"line_number":144,"context_line":"        return self._esm_rest(url, data)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def _esm_rest(self, url\u003dFalse, data\u003dNone):"},{"line_number":147,"context_line":"        \"\"\""},{"line_number":148,"context_line":"        _esm_rest represent the entry point to send requests to ESM Appliance."},{"line_number":149,"context_line":"        Send the HTTPS call, get response in JSON"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fu3c%3D","line":146,"in_reply_to":"AAAAOH%2F%2Fu3k%3D","updated":"2013-03-30 19:30:48.000000000","message":"_login and _set_group need to call _esm_rest directly.  The other methods that interact with an ESM (e.g., _configure and _get_volume_info ) need to ensure _login is called prior to making any other REST calls to the ESM.","commit_id":"73d0527968a333a096c34c21a4dadf16b8415070"}]}