)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"bbbc407c7383a69702cc7e19bc5eec399f034534","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                )"},{"line_number":1096,"context_line":"            image_volume.create()"},{"line_number":1097,"context_line":"        except Exception as ex:"},{"line_number":1098,"context_line":"            LOG.exception(_LE(\u0027Failed to create cache volume object %(volume_id)s\u0027"},{"line_number":1099,"context_line":"                              \u0027for image %(image_id)s\u0027),"},{"line_number":1100,"context_line":"                          {\u0027volume_id\u0027: volume.id,"},{"line_number":1101,"context_line":"                           \u0027image_id\u0027: image_meta[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_7fc1692e","line":1098,"updated":"2015-12-12 20:04:30.000000000","message":"This should probably be more like \"Failed to clone image volume\" since this method isn\u0027t only for the cache, its original purpose was for the glance cinder backend stuff, afaik it still would be used for it too even when the cache isn\u0027t being used.","commit_id":"73aefe0c33d801ab3f1a0294d9c904bb3feb736b"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"ffb9e3126b08dc6323a83616dd95a76ab506389c","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"                )"},{"line_number":1096,"context_line":"            image_volume.create()"},{"line_number":1097,"context_line":"        except Exception as ex:"},{"line_number":1098,"context_line":"            LOG.exception(_LE(\u0027Failed to create cache volume object %(volume_id)s\u0027"},{"line_number":1099,"context_line":"                              \u0027for image %(image_id)s\u0027),"},{"line_number":1100,"context_line":"                          {\u0027volume_id\u0027: volume.id,"},{"line_number":1101,"context_line":"                           \u0027image_id\u0027: image_meta[\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_5ca7d04f","line":1098,"in_reply_to":"7a740942_7fc1692e","updated":"2015-12-13 18:31:00.000000000","message":"Good call, I\u0027ll modify that","commit_id":"73aefe0c33d801ab3f1a0294d9c904bb3feb736b"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b4d20c1ff80c95178e90464d5e3f1bc02a42cc92","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"            new_vol_values[\u0027display_name\u0027] \u003d \u0027image-%s\u0027 % image_meta[\u0027id\u0027]"},{"line_number":1090,"context_line":"            new_vol_values[\u0027source_volid\u0027] \u003d volume.id"},{"line_number":1091,"context_line":"            LOG.debug(\u0027Creating image volume entry: %s.\u0027, new_vol_values)"},{"line_number":1092,"context_line":"            image_volume \u003d self.db.volume_create(ctx, new_vol_values)"},{"line_number":1093,"context_line":"        except Exception as ex:"},{"line_number":1094,"context_line":"            LOG.exception(_LE(\u0027Create clone_image_volume: %(volume_id)s\u0027"},{"line_number":1095,"context_line":"                              \u0027for image %(image_id)s, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_3600e033","line":1092,"updated":"2015-12-13 18:50:14.000000000","message":"NOTE: I think this should be an object create like I have in patchset-2, the problem is I can not figure out all the paths to mocks/fakes etc in the unit tests for cinder-images that sets the location path.\n\nFor now, I\u0027m using the db call still to get things working and will circle back after talking with Tsekyami about the location field in image-meta.\n\nThis method no longer sets any of that directly so I\u0027m not sure that that the test is even really a good test any longer or not, or if perhaps that code is broken as well.  It\u0027s another item we don\u0027t test actively so it very well may not even work.","commit_id":"89d9b1e832531179398db86a8db10a1f4ada5ddc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9f6db5a9d3298fdba331191c6fd20fd38760316c","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"            new_vol_values[\u0027display_name\u0027] \u003d \u0027image-%s\u0027 % image_meta[\u0027id\u0027]"},{"line_number":1090,"context_line":"            new_vol_values[\u0027source_volid\u0027] \u003d volume.id"},{"line_number":1091,"context_line":"            LOG.debug(\u0027Creating image volume entry: %s.\u0027, new_vol_values)"},{"line_number":1092,"context_line":"            image_volume \u003d self.db.volume_create(ctx, new_vol_values)"},{"line_number":1093,"context_line":"        except Exception as ex:"},{"line_number":1094,"context_line":"            LOG.exception(_LE(\u0027Create clone_image_volume: %(volume_id)s\u0027"},{"line_number":1095,"context_line":"                              \u0027for image %(image_id)s, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_6b24395f","line":1092,"in_reply_to":"7a740942_10f6045d","updated":"2015-12-14 04:33:04.000000000","message":"There are a couple of other places in this function that also do direct db calls.  Do you want to change line 1092 but leave other places (line 1109 and 1113) out?  Probably better to change all 3 places together (either in this patch or in a different patch).","commit_id":"89d9b1e832531179398db86a8db10a1f4ada5ddc"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"a02e83b2b5a8cc63a3b186b627aa88d39038e3e1","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"            new_vol_values[\u0027display_name\u0027] \u003d \u0027image-%s\u0027 % image_meta[\u0027id\u0027]"},{"line_number":1090,"context_line":"            new_vol_values[\u0027source_volid\u0027] \u003d volume.id"},{"line_number":1091,"context_line":"            LOG.debug(\u0027Creating image volume entry: %s.\u0027, new_vol_values)"},{"line_number":1092,"context_line":"            image_volume \u003d self.db.volume_create(ctx, new_vol_values)"},{"line_number":1093,"context_line":"        except Exception as ex:"},{"line_number":1094,"context_line":"            LOG.exception(_LE(\u0027Create clone_image_volume: %(volume_id)s\u0027"},{"line_number":1095,"context_line":"                              \u0027for image %(image_id)s, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_6adbd74f","line":1092,"in_reply_to":"7a740942_3600e033","updated":"2015-12-14 01:52:52.000000000","message":"Agree, we should use object instead of direct DB API call.","commit_id":"89d9b1e832531179398db86a8db10a1f4ada5ddc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a24a8f87b86a4fff004e72fe187e7489dad11030","unresolved":false,"context_lines":[{"line_number":1089,"context_line":"            new_vol_values[\u0027display_name\u0027] \u003d \u0027image-%s\u0027 % image_meta[\u0027id\u0027]"},{"line_number":1090,"context_line":"            new_vol_values[\u0027source_volid\u0027] \u003d volume.id"},{"line_number":1091,"context_line":"            LOG.debug(\u0027Creating image volume entry: %s.\u0027, new_vol_values)"},{"line_number":1092,"context_line":"            image_volume \u003d self.db.volume_create(ctx, new_vol_values)"},{"line_number":1093,"context_line":"        except Exception as ex:"},{"line_number":1094,"context_line":"            LOG.exception(_LE(\u0027Create clone_image_volume: %(volume_id)s\u0027"},{"line_number":1095,"context_line":"                              \u0027for image %(image_id)s, \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_10f6045d","line":1092,"in_reply_to":"7a740942_6adbd74f","updated":"2015-12-14 03:48:26.000000000","message":"I\u0027ll see if I can fix the unit tests again.  If nothing else maybe rewrite or skip them, I\u0027ll try and catch tesakami again... Thanks!","commit_id":"89d9b1e832531179398db86a8db10a1f4ada5ddc"}]}