)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"07d3e5d17090724fb10a0adecf79435e707962c1","unresolved":false,"context_lines":[{"line_number":1368,"context_line":"            # When we\u0027re not migrating and haven\u0027t hit any errors, we issue"},{"line_number":1369,"context_line":"            # volume attach and detach requests so the volumes don\u0027t end in"},{"line_number":1370,"context_line":"            # \u0027attaching\u0027 and \u0027detaching\u0027 state"},{"line_number":1371,"context_line":"            if not error:"},{"line_number":1372,"context_line":"                attachments \u003d volume[\u0027volume_attachment\u0027]"},{"line_number":1373,"context_line":"                for attachment in attachments:"},{"line_number":1374,"context_line":"                    self.detach(context, volume, attachment[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_4c546220","line":1371,"range":{"start_line":1371,"start_character":24,"end_line":1371,"end_character":25},"updated":"2015-12-17 21:00:11.000000000","message":"I don\u0027t think I reviewed the original on this, but I am curious.  If error is set why are we even getting this call?  I\u0027m not clear on the concept here, if the call comes in with error set, then we don\u0027t actually change the attachment or in other words \"complete\" the migration, BUT we still return the new volume.id?\n\nThis seems weird to me, what am I missing?","commit_id":"444fc0993e138f68d2f837fa7f5749ddf31dec40"}]}