)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"c7adb9e8c876cf425996a49daaef71b459c72b6a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"manager.py tries to extract the host field from volume before"},{"line_number":11,"context_line":"deleting the volume."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Above logic is invlid if the volume met error during creation,"},{"line_number":14,"context_line":"since host field of faulted volume is None."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This fix will bypass the check if the host field is None to avoid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_dd097496","line":13,"updated":"2015-12-14 05:42:49.000000000","message":"\"invlid\" typo","commit_id":"4430b7c11437ef6e7147262b81c19a78b7f51b87"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"51d9718ee500c2d19268d01f5496a70ca84fb95c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"manager.py tries to extract the host field from volume before"},{"line_number":11,"context_line":"deleting the volume."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Above logic is invlid if the volume met error during creation,"},{"line_number":14,"context_line":"since host field of faulted volume is None."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This fix will bypass the check if the host field is None to avoid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_9d13ec64","line":13,"in_reply_to":"7a740942_dd097496","updated":"2015-12-14 05:59:59.000000000","message":"Good catch, thanks","commit_id":"4430b7c11437ef6e7147262b81c19a78b7f51b87"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"d726aef37a2a945463a6e44ef95d4a13cc2500b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     peter_wang \u003cpeter.wang13@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-14 00:55:25 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bypass volume[\u0027host\u0027] check if it\u0027s None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When force deleting a consistency group containing volumes,"},{"line_number":10,"context_line":"manager.py tries to extract the host field from volume before"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_0563dd1b","line":7,"updated":"2015-12-14 21:42:51.000000000","message":"This is a bit pedantic, but you are really bypassing the check to see if the volume is local to this node.\nYou are actually doing a volume_ref[\u0027host\u0027] check to see if it exists.","commit_id":"e205516055ff25bf4e23268cd76f18a230c3930f"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"50fb1c5416383828675e15d3bb105502d9d42e67","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     peter_wang \u003cpeter.wang13@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-14 00:55:25 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bypass volume[\u0027host\u0027] check if it\u0027s None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When force deleting a consistency group containing volumes,"},{"line_number":10,"context_line":"manager.py tries to extract the host field from volume before"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_9a8dd533","line":7,"in_reply_to":"5a710552_0563dd1b","updated":"2015-12-15 08:27:15.000000000","message":"Hi Scott\nI revised by commit msg\nplease have a review again\n\nThanks\nPeter","commit_id":"e205516055ff25bf4e23268cd76f18a230c3930f"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"d726aef37a2a945463a6e44ef95d4a13cc2500b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Bypass volume[\u0027host\u0027] check if it\u0027s None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When force deleting a consistency group containing volumes,"},{"line_number":10,"context_line":"manager.py tries to extract the host field from volume before"},{"line_number":11,"context_line":"deleting the volume."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Above logic is invalid if the volume meets error during creation,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_4581e58e","line":10,"updated":"2015-12-14 21:42:51.000000000","message":"Here you might add that it is trying to extract field from the volume to check that the volume is local to the node.","commit_id":"e205516055ff25bf4e23268cd76f18a230c3930f"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"50fb1c5416383828675e15d3bb105502d9d42e67","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Bypass volume[\u0027host\u0027] check if it\u0027s None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When force deleting a consistency group containing volumes,"},{"line_number":10,"context_line":"manager.py tries to extract the host field from volume before"},{"line_number":11,"context_line":"deleting the volume."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Above logic is invalid if the volume meets error during creation,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_fa7c1922","line":10,"in_reply_to":"5a710552_4581e58e","updated":"2015-12-15 08:27:15.000000000","message":"Ditto","commit_id":"e205516055ff25bf4e23268cd76f18a230c3930f"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"d726aef37a2a945463a6e44ef95d4a13cc2500b4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"since host field of faulted volume is None."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This fix will bypass the check if the host field is None to avoid"},{"line_number":17,"context_line":"CG deletion failure."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I477c80c21c0b554b69c6222fb4fb0461813ac2bb"},{"line_number":20,"context_line":"Closes-Bug: 1524195"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_25361904","line":17,"updated":"2015-12-14 21:42:51.000000000","message":"Similar to above, this is a bit confusing.","commit_id":"e205516055ff25bf4e23268cd76f18a230c3930f"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"50fb1c5416383828675e15d3bb105502d9d42e67","unresolved":false,"context_lines":[{"line_number":14,"context_line":"since host field of faulted volume is None."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This fix will bypass the check if the host field is None to avoid"},{"line_number":17,"context_line":"CG deletion failure."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I477c80c21c0b554b69c6222fb4fb0461813ac2bb"},{"line_number":20,"context_line":"Closes-Bug: 1524195"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a710552_ba76913c","line":17,"in_reply_to":"5a710552_25361904","updated":"2015-12-15 08:27:15.000000000","message":"Ditto","commit_id":"e205516055ff25bf4e23268cd76f18a230c3930f"}],"cinder/volume/manager.py":[{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"c7adb9e8c876cf425996a49daaef71b459c72b6a","unresolved":false,"context_lines":[{"line_number":2650,"context_line":"                new_host \u003d vol_utils.extract_host(volume_ref[\u0027host\u0027])"},{"line_number":2651,"context_line":"                if new_host !\u003d self.host:"},{"line_number":2652,"context_line":"                    raise exception.InvalidVolume("},{"line_number":2653,"context_line":"                        reason\u003d_(\"Volume is not local to this node\"))"},{"line_number":2654,"context_line":""},{"line_number":2655,"context_line":"        self._notify_about_consistencygroup_usage("},{"line_number":2656,"context_line":"            context, group, \"delete.start\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_fd4c70c9","line":2653,"updated":"2015-12-14 05:42:49.000000000","message":"I am not sure if we can directly delete the volume which does not have \u0027host\u0027 field. The fault volume may not local to this node also.","commit_id":"4430b7c11437ef6e7147262b81c19a78b7f51b87"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"51d9718ee500c2d19268d01f5496a70ca84fb95c","unresolved":false,"context_lines":[{"line_number":2650,"context_line":"                new_host \u003d vol_utils.extract_host(volume_ref[\u0027host\u0027])"},{"line_number":2651,"context_line":"                if new_host !\u003d self.host:"},{"line_number":2652,"context_line":"                    raise exception.InvalidVolume("},{"line_number":2653,"context_line":"                        reason\u003d_(\"Volume is not local to this node\"))"},{"line_number":2654,"context_line":""},{"line_number":2655,"context_line":"        self._notify_about_consistencygroup_usage("},{"line_number":2656,"context_line":"            context, group, \"delete.start\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_4044b748","line":2653,"in_reply_to":"7a740942_fd4c70c9","updated":"2015-12-14 05:59:59.000000000","message":"According to my try, volume without host field can be deleted directly.\n\nif the faulted volume with unmatched host filed, I think exception should be raised here as expected.","commit_id":"4430b7c11437ef6e7147262b81c19a78b7f51b87"}]}