)]}'
{"cinder/scheduler/weights/capacity.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2af569d340797585445bc1fc30a1c40b9dbc3d51","unresolved":false,"context_lines":[{"line_number":45,"context_line":"from oslo_config import cfg"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"from cinder.scheduler import weights"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from cinder import utils"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"capacity_weight_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_5b5d8c45","line":48,"updated":"2015-12-21 12:20:35.000000000","message":"-1: No empty line needed","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"948def9ff65882fbf4fc3321d3a8997c1480d654","unresolved":false,"context_lines":[{"line_number":45,"context_line":"from oslo_config import cfg"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"from cinder.scheduler import weights"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from cinder import utils"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"capacity_weight_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_09e8ce7b","line":48,"in_reply_to":"3a7e1126_5b5d8c45","updated":"2015-12-23 03:18:21.000000000","message":"Done","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2af569d340797585445bc1fc30a1c40b9dbc3d51","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from cinder import utils"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"capacity_weight_opts \u003d ["},{"line_number":52,"context_line":"    cfg.FloatOpt(\u0027capacity_weight_multiplier\u0027,"},{"line_number":53,"context_line":"                 default\u003d1.0,"},{"line_number":54,"context_line":"                 help\u003d\u0027Multiplier used for weighing volume capacity. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_be025e08","line":51,"updated":"2015-12-21 12:20:35.000000000","message":"nit: Better add an extra empty line before this one","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"948def9ff65882fbf4fc3321d3a8997c1480d654","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"from cinder import utils"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"capacity_weight_opts \u003d ["},{"line_number":52,"context_line":"    cfg.FloatOpt(\u0027capacity_weight_multiplier\u0027,"},{"line_number":53,"context_line":"                 default\u003d1.0,"},{"line_number":54,"context_line":"                 help\u003d\u0027Multiplier used for weighing volume capacity. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_699ab216","line":51,"in_reply_to":"3a7e1126_be025e08","updated":"2015-12-23 03:18:21.000000000","message":"Done","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2af569d340797585445bc1fc30a1c40b9dbc3d51","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            support \u003d host_state.thin_provisioning_support"},{"line_number":120,"context_line":"            ratio \u003d host_state.max_over_subscription_ratio"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            free \u003d utils.calculate_virtual_free_capacity(total_space,"},{"line_number":123,"context_line":"                                                         free_space,"},{"line_number":124,"context_line":"                                                         provisioned,"},{"line_number":125,"context_line":"                                                         support,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_7eaab686","line":122,"updated":"2015-12-21 12:20:35.000000000","message":"nit: Wouldn\u0027t it be best to actually pass the values directly instead of using an intermediary variable that actually conveys less information?  Ex: support vs this_provisioning_support, from the first one you can\u0027t tell what it is supporting.\n\n free \u003d utils.calculate_virtual_free_capacity(\n     total_space,\n     free_space,\n     host_state.provisioned_capacity_gb,\n     host_state.thin_provisioning_support,\n     host_state.max_over_subscription_ratio,\n     host_state.reserved_percentage)","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"948def9ff65882fbf4fc3321d3a8997c1480d654","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            support \u003d host_state.thin_provisioning_support"},{"line_number":120,"context_line":"            ratio \u003d host_state.max_over_subscription_ratio"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"            free \u003d utils.calculate_virtual_free_capacity(total_space,"},{"line_number":123,"context_line":"                                                         free_space,"},{"line_number":124,"context_line":"                                                         provisioned,"},{"line_number":125,"context_line":"                                                         support,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_89aa7e18","line":122,"in_reply_to":"3a7e1126_7eaab686","updated":"2015-12-23 03:18:21.000000000","message":"Done","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"}],"cinder/tests/unit/test_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2af569d340797585445bc1fc30a1c40b9dbc3d51","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"            host_stat2[\u0027reserved_percentage\u0027])"},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"        self.assertEqual(27.01, free1)"},{"line_number":1359,"context_line":"        self.assertEqual(37.02, free2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_7e34f648","line":1359,"updated":"2015-12-21 12:20:35.000000000","message":"-1: Please split this into 2 tests, as each test should test only 1 thing.  And append to the function name _thin or _thick depending on the test.","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"948def9ff65882fbf4fc3321d3a8997c1480d654","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"            host_stat2[\u0027reserved_percentage\u0027])"},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"        self.assertEqual(27.01, free1)"},{"line_number":1359,"context_line":"        self.assertEqual(37.02, free2)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_a94bbaaf","line":1359,"in_reply_to":"3a7e1126_7e34f648","updated":"2015-12-23 03:18:21.000000000","message":"Done","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"}],"cinder/utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2af569d340797585445bc1fc30a1c40b9dbc3d51","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                                    reserved_percentage):"},{"line_number":984,"context_line":"    \"\"\"Calculate the virtual free capacity based on thin provisioning support."},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    The logic is already there. Now just to Wrap the logic in a function to"},{"line_number":987,"context_line":"    make consistency when there are more than one code path to use it."},{"line_number":988,"context_line":"    \"\"\""},{"line_number":989,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_3ece6e63","line":986,"updated":"2015-12-21 12:20:35.000000000","message":"-1: This is not a good docstring.  Limit to a oneliner or give an explanation of the function and the arguments.","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"948def9ff65882fbf4fc3321d3a8997c1480d654","unresolved":false,"context_lines":[{"line_number":983,"context_line":"                                    reserved_percentage):"},{"line_number":984,"context_line":"    \"\"\"Calculate the virtual free capacity based on thin provisioning support."},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    The logic is already there. Now just to Wrap the logic in a function to"},{"line_number":987,"context_line":"    make consistency when there are more than one code path to use it."},{"line_number":988,"context_line":"    \"\"\""},{"line_number":989,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a7b0d38_c9f8867f","line":986,"in_reply_to":"3a7e1126_3ece6e63","updated":"2015-12-23 03:18:21.000000000","message":"Done","commit_id":"1369cb4acd029fd229f4b1a95623a23554fb0de8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"19005b359c05c3dae0b0ce40472dc271debd2996","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"    \"\"\"Calculate the virtual free capacity based on thin provisioning support."},{"line_number":1008,"context_line":""},{"line_number":1009,"context_line":"    :param total_capacity:  total_capacity_gb of a host_state or pool."},{"line_number":1010,"context_line":"    :param free_capacity:   free_capacity_gb of a host_state or pool."},{"line_number":1011,"context_line":"    :param provisioned_capacity:    provisioned_capacity_gb of a host_state"},{"line_number":1012,"context_line":"                                    or pool."},{"line_number":1013,"context_line":"    :param thin_provisioning_support:   thin_provisioning_support of"}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_6a061822","line":1010,"updated":"2016-01-12 12:14:17.000000000","message":"nit: Extra spacing from the : to the next word looks a little weird in all these lines.","commit_id":"a00c80de024309dcf939fc2ec09d20c95c601328"}]}