)]}'
{"cinder/tests/unit/scheduler/test_rpcapi.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"8eb4a0459a42c1e2897eb7edb9fb502e64765067","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                                 volume\u003d\u0027volume\u0027,"},{"line_number":119,"context_line":"                                 version\u003d\u00272.0\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027, return_value\u003dTrue)"},{"line_number":122,"context_line":"    def test_manage_existing(self, can_send_version):"},{"line_number":123,"context_line":"        self._test_scheduler_api(\u0027manage_existing\u0027,"},{"line_number":124,"context_line":"                                 rpc_method\u003d\u0027cast\u0027,"},{"line_number":125,"context_line":"                                 topic\u003d\u0027topic\u0027,"},{"line_number":126,"context_line":"                                 volume_id\u003d\u0027volume_id\u0027,"},{"line_number":127,"context_line":"                                 request_spec\u003d\u0027fake_request_spec\u0027,"},{"line_number":128,"context_line":"                                 filter_properties\u003d\u0027filter_properties\u0027,"},{"line_number":129,"context_line":"                                 volume\u003d\u0027volume\u0027,"},{"line_number":130,"context_line":"                                 version\u003d\u00272.1\u0027)"},{"line_number":131,"context_line":"        can_send_version.assert_called_with(\u00272.1\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027,"},{"line_number":134,"context_line":"                return_value\u003dFalse)"},{"line_number":135,"context_line":"    def test_manage_existing_old(self, can_send_version):"},{"line_number":136,"context_line":"        self._test_scheduler_api(\u0027manage_existing\u0027,"},{"line_number":137,"context_line":"                                 rpc_method\u003d\u0027cast\u0027,"},{"line_number":138,"context_line":"                                 topic\u003d\u0027topic\u0027,"},{"line_number":139,"context_line":"                                 volume_id\u003d\u0027volume_id\u0027,"},{"line_number":140,"context_line":"                                 request_spec\u003d\u0027fake_request_spec\u0027,"},{"line_number":141,"context_line":"                                 filter_properties\u003d\u0027filter_properties\u0027,"},{"line_number":142,"context_line":"                                 version\u003d\u00272.0\u0027)"},{"line_number":143,"context_line":"        can_send_version.assert_called_with(\u00272.1\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_get_pools(self):"},{"line_number":146,"context_line":"        self._test_scheduler_api(\u0027get_pools\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_e09af560","line":143,"range":{"start_line":121,"start_character":0,"end_line":143,"end_character":50},"updated":"2016-05-12 03:44:00.000000000","message":"Could use ddt to merge those two tests?","commit_id":"3c914c122032ca19d9872de3a635c51d89626f56"}],"cinder/tests/unit/test_volume_rpcapi.py":[{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"29e9e2d996f8ca9545fce59f46c4204b028bd753","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                              old_reservations\u003dself.fake_reservations,"},{"line_number":409,"context_line":"                              version\u003d\u00272.0\u0027)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027, return_value\u003dTrue)"},{"line_number":412,"context_line":"    def test_manage_existing(self, can_send_version):"},{"line_number":413,"context_line":"        self._test_volume_api(\u0027manage_existing\u0027,"},{"line_number":414,"context_line":"                              rpc_method\u003d\u0027cast\u0027,"},{"line_number":415,"context_line":"                              volume\u003dself.fake_volume_obj,"},{"line_number":416,"context_line":"                              ref\u003d{\u0027lv_name\u0027: \u0027foo\u0027},"},{"line_number":417,"context_line":"                              version\u003d\u00272.1\u0027)"},{"line_number":418,"context_line":"        can_send_version.assert_called_once_with(\u00272.1\u0027)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027,"},{"line_number":421,"context_line":"                return_value\u003dFalse)"},{"line_number":422,"context_line":"    def test_manage_existing_old(self, can_send_version):"},{"line_number":423,"context_line":"        self._test_volume_api(\u0027manage_existing\u0027,"},{"line_number":424,"context_line":"                              rpc_method\u003d\u0027cast\u0027,"},{"line_number":425,"context_line":"                              volume\u003dself.fake_volume_obj,"},{"line_number":426,"context_line":"                              ref\u003d{\u0027lv_name\u0027: \u0027foo\u0027},"},{"line_number":427,"context_line":"                              version\u003d\u00272.0\u0027)"},{"line_number":428,"context_line":"        can_send_version.assert_called_once_with(\u00272.1\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def test_manage_existing_snapshot(self):"},{"line_number":431,"context_line":"        volume_update \u003d {\u0027host\u0027: \u0027fake_host\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_c5d20f5b","line":428,"range":{"start_line":411,"start_character":0,"end_line":428,"end_character":55},"updated":"2016-04-23 18:43:05.000000000","message":"These 2 tests are almost same for 2.0 and 2.1 rpc version.\nmay be ddt can be used to merge to save some line of code in test cases..","commit_id":"3c914c122032ca19d9872de3a635c51d89626f56"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"8eb4a0459a42c1e2897eb7edb9fb502e64765067","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                              old_reservations\u003dself.fake_reservations,"},{"line_number":409,"context_line":"                              version\u003d\u00272.0\u0027)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027, return_value\u003dTrue)"},{"line_number":412,"context_line":"    def test_manage_existing(self, can_send_version):"},{"line_number":413,"context_line":"        self._test_volume_api(\u0027manage_existing\u0027,"},{"line_number":414,"context_line":"                              rpc_method\u003d\u0027cast\u0027,"},{"line_number":415,"context_line":"                              volume\u003dself.fake_volume_obj,"},{"line_number":416,"context_line":"                              ref\u003d{\u0027lv_name\u0027: \u0027foo\u0027},"},{"line_number":417,"context_line":"                              version\u003d\u00272.1\u0027)"},{"line_number":418,"context_line":"        can_send_version.assert_called_once_with(\u00272.1\u0027)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027,"},{"line_number":421,"context_line":"                return_value\u003dFalse)"},{"line_number":422,"context_line":"    def test_manage_existing_old(self, can_send_version):"},{"line_number":423,"context_line":"        self._test_volume_api(\u0027manage_existing\u0027,"},{"line_number":424,"context_line":"                              rpc_method\u003d\u0027cast\u0027,"},{"line_number":425,"context_line":"                              volume\u003dself.fake_volume_obj,"},{"line_number":426,"context_line":"                              ref\u003d{\u0027lv_name\u0027: \u0027foo\u0027},"},{"line_number":427,"context_line":"                              version\u003d\u00272.0\u0027)"},{"line_number":428,"context_line":"        can_send_version.assert_called_once_with(\u00272.1\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def test_manage_existing_snapshot(self):"},{"line_number":431,"context_line":"        volume_update \u003d {\u0027host\u0027: \u0027fake_host\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_20a19d94","line":428,"range":{"start_line":411,"start_character":0,"end_line":428,"end_character":55},"in_reply_to":"1a122d0e_c5d20f5b","updated":"2016-05-12 03:44:00.000000000","message":"+1","commit_id":"3c914c122032ca19d9872de3a635c51d89626f56"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"3a12b2ba49c49830604939c26dbdfdcf765854b5","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                              old_reservations\u003dself.fake_reservations,"},{"line_number":409,"context_line":"                              version\u003d\u00272.0\u0027)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027, return_value\u003dTrue)"},{"line_number":412,"context_line":"    def test_manage_existing(self, can_send_version):"},{"line_number":413,"context_line":"        self._test_volume_api(\u0027manage_existing\u0027,"},{"line_number":414,"context_line":"                              rpc_method\u003d\u0027cast\u0027,"},{"line_number":415,"context_line":"                              volume\u003dself.fake_volume_obj,"},{"line_number":416,"context_line":"                              ref\u003d{\u0027lv_name\u0027: \u0027foo\u0027},"},{"line_number":417,"context_line":"                              version\u003d\u00272.1\u0027)"},{"line_number":418,"context_line":"        can_send_version.assert_called_once_with(\u00272.1\u0027)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    @mock.patch(\u0027oslo_messaging.RPCClient.can_send_version\u0027,"},{"line_number":421,"context_line":"                return_value\u003dFalse)"},{"line_number":422,"context_line":"    def test_manage_existing_old(self, can_send_version):"},{"line_number":423,"context_line":"        self._test_volume_api(\u0027manage_existing\u0027,"},{"line_number":424,"context_line":"                              rpc_method\u003d\u0027cast\u0027,"},{"line_number":425,"context_line":"                              volume\u003dself.fake_volume_obj,"},{"line_number":426,"context_line":"                              ref\u003d{\u0027lv_name\u0027: \u0027foo\u0027},"},{"line_number":427,"context_line":"                              version\u003d\u00272.0\u0027)"},{"line_number":428,"context_line":"        can_send_version.assert_called_once_with(\u00272.1\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    def test_manage_existing_snapshot(self):"},{"line_number":431,"context_line":"        volume_update \u003d {\u0027host\u0027: \u0027fake_host\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_d9660fec","line":428,"range":{"start_line":411,"start_character":0,"end_line":428,"end_character":55},"in_reply_to":"dab17558_20a19d94","updated":"2016-06-08 11:59:38.000000000","message":"Done. These tests require some serious refactoring anyway, but why not ddt?","commit_id":"3c914c122032ca19d9872de3a635c51d89626f56"}],"cinder/volume/flows/manager/manage_existing.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"df230b8c4e113a9587f624e1dfe9edffa94aacb1","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        return {\u0027volume\u0027: volume_ref}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def get_flow(context, db, driver, host, volume_id, ref, volume):"},{"line_number":95,"context_line":"    \"\"\"Constructs and returns the manager entrypoint flow.\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    flow_name \u003d ACTION.replace(\":\", \"_\") + \"_manager\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a710552_3594bde0","line":94,"updated":"2015-12-16 03:12:40.000000000","message":"get_flow does not have to be backwards compatible, since it does not go over rpc.  You could just use volume in place of volume_id here.\n\nget_flow(context, db, driver, host, volume, ref)","commit_id":"6be9bcf6901a8bc023e2abdc9c6f8605133ff61e"}]}