)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"96171325653c6e126c78fc7d0b4df4e47e7872be","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Due to some VNX side sync issue, a migration session will fail"},{"line_number":10,"context_line":"when it uses a destination LUN id which also involves in a"},{"line_number":11,"context_line":"previous finished session. the errror message is:"},{"line_number":12,"context_line":"Error: migrate -start command failed."},{"line_number":13,"context_line":"The destination LUN is not available for migration."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch will retry to start the session when above error occurs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_62ffde34","line":12,"range":{"start_line":12,"start_character":7,"end_line":12,"end_character":14},"updated":"2015-12-18 00:57:06.000000000","message":"My 0.02$: adding a blank line above makes the formatting better.","commit_id":"b4be6cc81993182a2778e8d1f296c1c6ae58358e"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"6dc5bcfea788ef4891ecf9389234a361a1040104","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Due to some VNX side sync issue, a migration session will fail"},{"line_number":10,"context_line":"when it uses a destination LUN id which also involves in a"},{"line_number":11,"context_line":"previous finished session. the errror message is:"},{"line_number":12,"context_line":"Error: migrate -start command failed."},{"line_number":13,"context_line":"The destination LUN is not available for migration."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch will retry to start the session when above error occurs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a7e1126_897995ca","line":12,"range":{"start_line":12,"start_character":7,"end_line":12,"end_character":14},"in_reply_to":"3a7e1126_62ffde34","updated":"2015-12-19 08:48:58.000000000","message":"Done","commit_id":"b4be6cc81993182a2778e8d1f296c1c6ae58358e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"0664a69755446c0a9447686c28799ee3ab32c116","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to some VNX side sync issue, a migration session will fail"},{"line_number":10,"context_line":"when it uses a destination LUN id which also involves in a"},{"line_number":11,"context_line":"previous finished session. the errror message is:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Error: migrate -start command failed."},{"line_number":14,"context_line":"The destination LUN is not available for migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_5413b60d","line":11,"updated":"2016-01-17 14:17:39.000000000","message":"s/the/The","commit_id":"3b624ff2b0db22eb5d2047c88979141e90bd295c"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"762338b0a269b2ca9ac476aba07373b57a65babf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to some VNX side sync issue, a migration session will fail"},{"line_number":10,"context_line":"when it uses a destination LUN id which also involves in a"},{"line_number":11,"context_line":"previous finished session. the errror message is:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Error: migrate -start command failed."},{"line_number":14,"context_line":"The destination LUN is not available for migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da6ed579_62b953ec","line":11,"in_reply_to":"da6ed579_5413b60d","updated":"2016-01-18 02:21:00.000000000","message":"Done","commit_id":"3b624ff2b0db22eb5d2047c88979141e90bd295c"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"0dc1aa3a36a84e8f5b0254afa7eda64522efbfe4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to some VNX side sync issue, a migration session will fail"},{"line_number":10,"context_line":"when it uses a destination LUN id which also involves in a"},{"line_number":11,"context_line":"previous finished session. The errror message is:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Error: migrate -start command failed."},{"line_number":14,"context_line":"The destination LUN is not available for migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da6ed579_932a9a2b","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":49},"updated":"2016-01-18 05:43:32.000000000","message":"s/errror/error","commit_id":"aca4cc54709854eeae7e7239da54cf42ffefb8fb"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"0a2d606f27ed063e163e8bcf64229f7647df88a9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to some VNX side sync issue, a migration session will fail"},{"line_number":10,"context_line":"when it uses a destination LUN id which also involves in a"},{"line_number":11,"context_line":"previous finished session. The errror message is:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Error: migrate -start command failed."},{"line_number":14,"context_line":"The destination LUN is not available for migration."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da6ed579_56097030","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":49},"in_reply_to":"da6ed579_932a9a2b","updated":"2016-01-18 06:42:55.000000000","message":"Done","commit_id":"aca4cc54709854eeae7e7239da54cf42ffefb8fb"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"df2767d7f65a082244371d99af382a3754276ae1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch will retry to start the session when above error occurs."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"liberty-backport-potential"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7e7bb56f72aa0363ece18ecc27a81bf60555d93c"},{"line_number":21,"context_line":"Closes-Bug: 1524160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba0121b8_187e9669","line":18,"updated":"2016-04-01 13:29:04.000000000","message":"This is a launchpad tag, it doesn\u0027t need to be in commit messages.","commit_id":"2c090af7b861d9098a88ab927000d20a9b318792"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e75804bfc49c946a39346e4c4014b975efc2dc1d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch will retry to start the session when above error occurs."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"liberty-backport-potential"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I7e7bb56f72aa0363ece18ecc27a81bf60555d93c"},{"line_number":21,"context_line":"Closes-Bug: 1524160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba0121b8_643eef2a","line":18,"in_reply_to":"ba0121b8_187e9669","updated":"2016-04-02 10:15:33.000000000","message":"Thanks, removed","commit_id":"2c090af7b861d9098a88ab927000d20a9b318792"}],"cinder/volume/drivers/emc/emc_vnx_cli.py":[{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"98456e8a51188592e0e8ba1afc2cb30da136ffe3","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                                       poll\u003dTrue)"},{"line_number":1280,"context_line":"        if 0 !\u003d rc:"},{"line_number":1281,"context_line":"            if (rc \u003d\u003d 7 and"},{"line_number":1282,"context_line":"                    out.find(\u0027LUN is not available for migration\u0027) \u003e\u003d 0):"},{"line_number":1283,"context_line":"                raise exception.EMCLunNotAvailableException("},{"line_number":1284,"context_line":"                    cmd\u003dcommand_migrate_lun, rc\u003drc, out\u003dout)"},{"line_number":1285,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_fb62fbac","line":1282,"range":{"start_line":1282,"start_character":20,"end_line":1282,"end_character":71},"updated":"2015-12-16 23:01:41.000000000","message":"Using \u0027in\u0027 here would make this more readable and slightly faster:\n\nif (rc \u003d\u003d 7 and \u0027LUN is not available for migration\u0027 in out):","commit_id":"693f66b45abb3c21855be896c00a491df6c82511"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"c08005c9f3a0cf826125152c0042f42510fca5c2","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                                       poll\u003dTrue)"},{"line_number":1280,"context_line":"        if 0 !\u003d rc:"},{"line_number":1281,"context_line":"            if (rc \u003d\u003d 7 and"},{"line_number":1282,"context_line":"                    out.find(\u0027LUN is not available for migration\u0027) \u003e\u003d 0):"},{"line_number":1283,"context_line":"                raise exception.EMCLunNotAvailableException("},{"line_number":1284,"context_line":"                    cmd\u003dcommand_migrate_lun, rc\u003drc, out\u003dout)"},{"line_number":1285,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_c7b5dd7e","line":1282,"range":{"start_line":1282,"start_character":20,"end_line":1282,"end_character":71},"in_reply_to":"3a7e1126_fb62fbac","updated":"2015-12-17 02:44:50.000000000","message":"Hi Anthony\nThanks for the reminder, I just updated it based on existing util\n\nplease have a review again","commit_id":"693f66b45abb3c21855be896c00a491df6c82511"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"96171325653c6e126c78fc7d0b4df4e47e7872be","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                                       retry_disable\u003dTrue,"},{"line_number":1280,"context_line":"                                       poll\u003dTrue)"},{"line_number":1281,"context_line":"        if 0 !\u003d rc:"},{"line_number":1282,"context_line":"            if (rc \u003d\u003d 7 and"},{"line_number":1283,"context_line":"                    VNXError.has_error(out, VNXError.LUN_NOT_AVAILABLE)):"},{"line_number":1284,"context_line":"                raise exception.EMCLunNotAvailableException("},{"line_number":1285,"context_line":"                    cmd\u003dcommand_migrate_lun, rc\u003drc, out\u003dout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_3d15773f","line":1282,"range":{"start_line":1282,"start_character":22,"end_line":1282,"end_character":23},"updated":"2015-12-18 00:57:06.000000000","message":"I\u0027m OK with that, but it would be better to replace literal `7` with constants. There are many similar issues in this file.","commit_id":"b4be6cc81993182a2778e8d1f296c1c6ae58358e"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"6dc5bcfea788ef4891ecf9389234a361a1040104","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                                       retry_disable\u003dTrue,"},{"line_number":1280,"context_line":"                                       poll\u003dTrue)"},{"line_number":1281,"context_line":"        if 0 !\u003d rc:"},{"line_number":1282,"context_line":"            if (rc \u003d\u003d 7 and"},{"line_number":1283,"context_line":"                    VNXError.has_error(out, VNXError.LUN_NOT_AVAILABLE)):"},{"line_number":1284,"context_line":"                raise exception.EMCLunNotAvailableException("},{"line_number":1285,"context_line":"                    cmd\u003dcommand_migrate_lun, rc\u003drc, out\u003dout)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_497f2dab","line":1282,"range":{"start_line":1282,"start_character":22,"end_line":1282,"end_character":23},"in_reply_to":"3a7e1126_3d15773f","updated":"2015-12-19 08:48:58.000000000","message":"Hi Accela\nThanks for pointing it out.\nwe plan to do a refactor in near future, will address your comments.\n\nThanks\nPeter","commit_id":"b4be6cc81993182a2778e8d1f296c1c6ae58358e"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"0dc1aa3a36a84e8f5b0254afa7eda64522efbfe4","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                                       retry_disable\u003dTrue,"},{"line_number":1280,"context_line":"                                       poll\u003dTrue)"},{"line_number":1281,"context_line":"        if 0 !\u003d rc:"},{"line_number":1282,"context_line":"            if (rc \u003d\u003d 7 and"},{"line_number":1283,"context_line":"                    VNXError.has_error(out, VNXError.LUN_NOT_AVAILABLE)):"},{"line_number":1284,"context_line":"                raise exception.EMCLunNotAvailableException("},{"line_number":1285,"context_line":"                    cmd\u003dcommand_migrate_lun, rc\u003drc, out\u003dout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_d3d7b221","line":1282,"range":{"start_line":1282,"start_character":21,"end_line":1282,"end_character":22},"updated":"2016-01-18 05:43:32.000000000","message":"What does the \"7\" mean here? Maybe it\u0027s better to replace it with Macro or something like that.","commit_id":"aca4cc54709854eeae7e7239da54cf42ffefb8fb"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"06e89d3842169d0265c90c5bc79b61a4829e6b1c","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                                       retry_disable\u003dTrue,"},{"line_number":1280,"context_line":"                                       poll\u003dTrue)"},{"line_number":1281,"context_line":"        if 0 !\u003d rc:"},{"line_number":1282,"context_line":"            if (rc \u003d\u003d 7 and"},{"line_number":1283,"context_line":"                    VNXError.has_error(out, VNXError.LUN_NOT_AVAILABLE)):"},{"line_number":1284,"context_line":"                raise exception.EMCLunNotAvailableException("},{"line_number":1285,"context_line":"                    cmd\u003dcommand_migrate_lun, rc\u003drc, out\u003dout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_31428211","line":1282,"range":{"start_line":1282,"start_character":21,"end_line":1282,"end_character":22},"in_reply_to":"da6ed579_d3d7b221","updated":"2016-01-22 07:17:28.000000000","message":"7 means the target volume is not available for migration","commit_id":"aca4cc54709854eeae7e7239da54cf42ffefb8fb"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"0a2d606f27ed063e163e8bcf64229f7647df88a9","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"                                       retry_disable\u003dTrue,"},{"line_number":1280,"context_line":"                                       poll\u003dTrue)"},{"line_number":1281,"context_line":"        if 0 !\u003d rc:"},{"line_number":1282,"context_line":"            if (rc \u003d\u003d 7 and"},{"line_number":1283,"context_line":"                    VNXError.has_error(out, VNXError.LUN_NOT_AVAILABLE)):"},{"line_number":1284,"context_line":"                raise exception.EMCLunNotAvailableException("},{"line_number":1285,"context_line":"                    cmd\u003dcommand_migrate_lun, rc\u003drc, out\u003dout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_d667a023","line":1282,"range":{"start_line":1282,"start_character":21,"end_line":1282,"end_character":22},"in_reply_to":"da6ed579_d3d7b221","updated":"2016-01-18 06:42:55.000000000","message":"This magic 7 can be deleted now,\nwe plan to only use error message to do error handling,","commit_id":"aca4cc54709854eeae7e7239da54cf42ffefb8fb"}]}