)]}'
{"cinder/tests/unit/test_rbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"adbb93b327bc556ffe8503f07135790cd4cd4a97","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.cfg.rbd_pool \u003d None"},{"line_number":162,"context_line":"        mock_exc \u003d mock.Mock()"},{"line_number":163,"context_line":"        mock_exc.return_value.side_effect \u003d exception.InvalidConfigurationValue"},{"line_number":164,"context_line":"        self.assertRaises(exception.InvalidConfigurationValue,"},{"line_number":165,"context_line":"                          driver.RBDDriver, execute\u003dmock_exc,"},{"line_number":166,"context_line":"                          configuration\u003dself.cfg)"},{"line_number":167,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_7b1e3971","line":164,"updated":"2015-12-21 16:54:33.000000000","message":"Please, use ddt lib and test \u0027rbd_cluster_name\u0027 validation too","commit_id":"f58d389748ac27d0c1ded9d5e6c91af5ca868c6c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d25c60db679c204c5aa46781c261f4cae7ff3ac3","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_min_config(self):"},{"line_number":157,"context_line":"        self.cfg \u003d mock.Mock(spec\u003dconf.Configuration)"},{"line_number":158,"context_line":"        self.cfg.rbd_user \u003d None"},{"line_number":159,"context_line":"        self.cfg.rbd_cluster_name \u003d None"},{"line_number":160,"context_line":"        self.cfg.rbd_ceph_conf \u003d None"},{"line_number":161,"context_line":"        self.cfg.rbd_pool \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_8dbf2c60","line":158,"updated":"2015-12-21 17:10:29.000000000","message":"It\u0027s not needed here","commit_id":"5641b4579748ad7877034b0865ecbef57b5f4903"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d25c60db679c204c5aa46781c261f4cae7ff3ac3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.cfg \u003d mock.Mock(spec\u003dconf.Configuration)"},{"line_number":158,"context_line":"        self.cfg.rbd_user \u003d None"},{"line_number":159,"context_line":"        self.cfg.rbd_cluster_name \u003d None"},{"line_number":160,"context_line":"        self.cfg.rbd_ceph_conf \u003d None"},{"line_number":161,"context_line":"        self.cfg.rbd_pool \u003d None"},{"line_number":162,"context_line":"        mock_exc \u003d mock.Mock()"},{"line_number":163,"context_line":"        mock_exc.return_value.side_effect \u003d exception.InvalidConfigurationValue"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_6db8c075","line":160,"range":{"start_line":160,"start_character":17,"end_line":160,"end_character":30},"updated":"2015-12-21 17:10:29.000000000","message":"It\u0027s not needed here","commit_id":"5641b4579748ad7877034b0865ecbef57b5f4903"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"719a0ce68af4001506e23a13aa566a9330e5bbeb","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        self.cfg.rbd_cluster_name \u003d cluster_name"},{"line_number":162,"context_line":"        self.cfg.rbd_pool \u003d pool_name"},{"line_number":163,"context_line":"        mock_exc \u003d mock.Mock()"},{"line_number":164,"context_line":"        mock_exc.return_value.side_effect \u003d exception.InvalidConfigurationValue"},{"line_number":165,"context_line":"        self.driver \u003d driver.RBDDriver(execute\u003dmock_exc,"},{"line_number":166,"context_line":"                                       configuration\u003dself.cfg)"},{"line_number":167,"context_line":"        with mock.patch(\u0027cinder.volume.drivers.rbd.rados\u0027):"},{"line_number":168,"context_line":"            with mock.patch(\u0027cinder.volume.drivers.rbd.RADOSClient\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a7b0d38_54ef5db0","line":165,"range":{"start_line":164,"start_character":0,"end_line":165,"end_character":56},"updated":"2015-12-22 17:28:56.000000000","message":"Wait, this is passing something raising an expected exception as execute method? This seems totally wrong. The test is passing without it, so I don\u0027t understand why is it here?","commit_id":"c21b77a4f04b0da2e6de52d1a1e2ab1ed5b61ee5"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"31c72a614b737057db242bb52ce9cdd81da010c6","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                setattr(self.configuration, attr, utils.convert_str(val))"},{"line_number":286,"context_line":"            else:"},{"line_number":287,"context_line":"                msg \u003d _(\u0027The value of %s is not provided.\u0027 % attr)"},{"line_number":288,"context_line":"                raise exception.InvalidInput(data\u003dmsg)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def check_for_setup_error(self):"},{"line_number":291,"context_line":"        \"\"\"Returns an error if prerequisites aren\u0027t met.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_f11d0c67","line":288,"range":{"start_line":288,"start_character":16,"end_line":288,"end_character":21},"updated":"2015-12-17 11:39:14.000000000","message":"Please, use InvalidConfigurationValue exception here","commit_id":"4567feba3c2a5ac8cfaa9403f63a704a66ed7c31"}]}