)]}'
{"cinder/image/glance.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"7e96c9e12559f7fbfa2b01e3e5b8e124e48ddbad","unresolved":false,"context_lines":[{"line_number":419,"context_line":"            properties \u003d image_meta.get(\u0027properties\u0027)"},{"line_number":420,"context_line":"            if properties:"},{"line_number":421,"context_line":"                image_meta.update(properties)"},{"line_number":422,"context_line":"                del image_meta[\u0027properties\u0027]"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        return image_meta"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_511a1dc7","line":422,"range":{"start_line":422,"start_character":42,"end_line":422,"end_character":44},"updated":"2015-12-22 10:25:44.000000000","message":"try:\n    properties \u003d image_meta.pop(\u0027properties\u0027)\n    image_meta.update(properties)\nexcept KeyError:\n    pass\nIMHO, the above piece of code is more Pythonic.","commit_id":"edf00659aadaf898ae679f358a6ea8533f4dd891"}],"cinder/tests/unit/api/contrib/test_volume_actions.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"b9cc5fcebed875aebf4a02d9bfbe0483edfb0bc9","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"                with mock.patch.object(volume_api.API, \"update\") \\"},{"line_number":1063,"context_line":"                        as mock_update:"},{"line_number":1064,"context_line":"                    mock_update.side_effect \u003d stubs.stub_volume_update"},{"line_number":1065,"context_line":""},{"line_number":1066,"context_line":"                    with mock.patch.object(volume_rpcapi.VolumeAPI,"},{"line_number":1067,"context_line":"                                           \"copy_volume_to_image\") \\"},{"line_number":1068,"context_line":"                            as mock_copy_volume_to_image:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_79fae244","line":1065,"updated":"2015-12-21 05:16:00.000000000","message":"You\u0027b better to check when glance is v2, it calls metadata.update(properties\u003dproperties) which you update.","commit_id":"eb45cf2c49869351a6cb6c099cc09019208b67a7"}],"cinder/volume/api.py":[{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"c92821010547d53e373e062d3e14b9d12aa915da","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"            force \u003d False"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        self._check_volume_availability(volume, force)"},{"line_number":1184,"context_line":"        glance_core_properties \u003d CONF.glance_core_properties"},{"line_number":1185,"context_line":"        if CONF.glance_api_version \u003d\u003d 1 and glance_core_properties:"},{"line_number":1186,"context_line":"            try:"},{"line_number":1187,"context_line":"                volume_image_metadata \u003d self.get_volume_image_metadata(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_d96784b5","line":1184,"range":{"start_line":1184,"start_character":33,"end_line":1184,"end_character":37},"updated":"2015-12-18 15:04:49.000000000","message":"I\u0027d recommend to add a comment for this parameter in cinder.conf, like \"This parameter is valid only if glance_api version is 1\".","commit_id":"f6923b7267653b9608120f2057c88fd4ffe66e48"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"cc455cd2097844dc44a1992a64da1e8c08fe8e78","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"            force \u003d False"},{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":"        self._check_volume_availability(volume, force)"},{"line_number":1184,"context_line":"        glance_core_properties \u003d CONF.glance_core_properties"},{"line_number":1185,"context_line":"        if CONF.glance_api_version \u003d\u003d 1 and glance_core_properties:"},{"line_number":1186,"context_line":"            try:"},{"line_number":1187,"context_line":"                volume_image_metadata \u003d self.get_volume_image_metadata(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_b9412aab","line":1184,"range":{"start_line":1184,"start_character":33,"end_line":1184,"end_character":37},"in_reply_to":"3a7e1126_d96784b5","updated":"2015-12-21 05:11:05.000000000","message":"Now the parameter glance_core_properties is also required in v2.","commit_id":"f6923b7267653b9608120f2057c88fd4ffe66e48"}]}