)]}'
{"cinder/tests/unit/test_storwize_svc.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"d8169334568980d07b6eefe8ad8ff99ec0ec72b0","unresolved":false,"context_lines":[{"line_number":1946,"context_line":"    def _create_cgsnapshot(self, cg_id, **kwargs):"},{"line_number":1947,"context_line":"        cg_snapshot \u003d self._create_cgsnapshot_in_db(cg_id, **kwargs)"},{"line_number":1948,"context_line":""},{"line_number":1949,"context_line":"        model_update, snapshots \u003d \\"},{"line_number":1950,"context_line":"            (self.driver.create_cgsnapshot(self.ctxt, cg_snapshot, []))"},{"line_number":1951,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":1952,"context_line":"                         model_update[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_efc7e495","line":1949,"range":{"start_line":1949,"start_character":34,"end_line":1949,"end_character":35},"updated":"2015-12-21 06:31:25.000000000","message":"Try to use replace \\ with ().","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"d8169334568980d07b6eefe8ad8ff99ec0ec72b0","unresolved":false,"context_lines":[{"line_number":1954,"context_line":""},{"line_number":1955,"context_line":"        for snapshot in snapshots:"},{"line_number":1956,"context_line":"            self.assertEqual(\u0027available\u0027, snapshot[\u0027status\u0027])"},{"line_number":1957,"context_line":"        snapshots \u003d \\"},{"line_number":1958,"context_line":"            self.db.snapshot_get_all_for_cgsnapshot(self.ctxt.elevated(),"},{"line_number":1959,"context_line":"                                                    cg_snapshot[\u0027id\u0027])"},{"line_number":1960,"context_line":"        return cg_snapshot, snapshots"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_8fe2e02d","line":1957,"range":{"start_line":1957,"start_character":20,"end_line":1957,"end_character":21},"updated":"2015-12-21 06:31:25.000000000","message":"Try to use replace \\ with ().","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"d8169334568980d07b6eefe8ad8ff99ec0ec72b0","unresolved":false,"context_lines":[{"line_number":3543,"context_line":"        for volume in model_update[1]:"},{"line_number":3544,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3545,"context_line":""},{"line_number":3546,"context_line":"        model_update \u003d \\"},{"line_number":3547,"context_line":"            self.driver.delete_consistencygroup(self.ctxt, source_cg, [])"},{"line_number":3548,"context_line":""},{"line_number":3549,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_eff044ff","line":3546,"range":{"start_line":3546,"start_character":23,"end_line":3546,"end_character":24},"updated":"2015-12-21 06:31:25.000000000","message":"Try to use replace \\ with ().","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"d8169334568980d07b6eefe8ad8ff99ec0ec72b0","unresolved":false,"context_lines":[{"line_number":3550,"context_line":"        for volume in model_update[1]:"},{"line_number":3551,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3552,"context_line":""},{"line_number":3553,"context_line":"        model_update \u003d \\"},{"line_number":3554,"context_line":"            self.driver.delete_consistencygroup(self.ctxt, cgsnapshot, [])"},{"line_number":3555,"context_line":""},{"line_number":3556,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_2febac14","line":3553,"range":{"start_line":3553,"start_character":23,"end_line":3553,"end_character":24},"updated":"2015-12-21 06:31:25.000000000","message":"Try to use replace \\ with ().","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"d8169334568980d07b6eefe8ad8ff99ec0ec72b0","unresolved":false,"context_lines":[{"line_number":3570,"context_line":"                                consistencygroup_id\u003dcg[\u0027id\u0027])"},{"line_number":3571,"context_line":"        testutils.create_volume(self.ctxt, volume_type_id\u003dcg_type[\u0027id\u0027],"},{"line_number":3572,"context_line":"                                consistencygroup_id\u003dcg[\u0027id\u0027])"},{"line_number":3573,"context_line":"        volumes \u003d \\"},{"line_number":3574,"context_line":"            self.db.volume_get_all_by_group(self.ctxt.elevated(), cg[\u0027id\u0027])"},{"line_number":3575,"context_line":""},{"line_number":3576,"context_line":"        # Create source CG"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_cf954887","line":3573,"range":{"start_line":3573,"start_character":18,"end_line":3573,"end_character":19},"updated":"2015-12-21 06:31:25.000000000","message":"Try to use replace \\ with ().","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"cdb2059eb644b0e37fff8be0a4435e8821f222ef","unresolved":false,"context_lines":[{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"    def create_cg_from_source(self, group, fc_consistgrp,"},{"line_number":1148,"context_line":"                              sources, targets, state,"},{"line_number":1149,"context_line":"                              config, db, timeout):"},{"line_number":1150,"context_line":"        \"\"\"Create consistence group from source\"\"\""},{"line_number":1151,"context_line":"        LOG.debug(\u0027Enter: create_cg_from_source: cg %(cg)s\u0027"},{"line_number":1152,"context_line":"                  \u0027 source %(source)s, target %(target)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_12805ef6","line":1149,"range":{"start_line":1149,"start_character":38,"end_line":1149,"end_character":40},"updated":"2015-12-20 16:59:45.000000000","message":"There shouldn\u0027t be a need for accessing the db directly in the drivers anymore. What are you using this for?","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"cdb2059eb644b0e37fff8be0a4435e8821f222ef","unresolved":false,"context_lines":[{"line_number":1181,"context_line":"        LOG.debug(\u0027Leave: create_cg_from_source\u0027)"},{"line_number":1182,"context_line":"        return model_update, volumes_model_update"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"    def get_volume_model_updates("},{"line_number":1185,"context_line":"            self, ctxt, db, cgId, status\u003d\u0027available\u0027):"},{"line_number":1186,"context_line":"        \"\"\"Update the volume model\u0027s status and return it. \"\"\""},{"line_number":1187,"context_line":"        volume_model_updates \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_52a346b2","line":1184,"range":{"start_line":1184,"start_character":8,"end_line":1184,"end_character":32},"updated":"2015-12-20 16:59:45.000000000","message":"is this method only called in create_cg_from_source? It should have an underscore in front to denote it is a private method. _get_volume_model_updates","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"cdb2059eb644b0e37fff8be0a4435e8821f222ef","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"            self, ctxt, db, cgId, status\u003d\u0027available\u0027):"},{"line_number":1186,"context_line":"        \"\"\"Update the volume model\u0027s status and return it. \"\"\""},{"line_number":1187,"context_line":"        volume_model_updates \u003d []"},{"line_number":1188,"context_line":"        volumes \u003d db.volume_get_all_by_group(ctxt, cgId)"},{"line_number":1189,"context_line":"        LOG.info(_LI("},{"line_number":1190,"context_line":"            \"Updating status for CG: %(id)s.\"),"},{"line_number":1191,"context_line":"            {\u0027id\u0027: cgId})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_f27b5226","line":1188,"range":{"start_line":1188,"start_character":8,"end_line":1188,"end_character":15},"updated":"2015-12-20 16:59:45.000000000","message":"The volumes that are passed in to create_consisgroup_from_src should be all the volumes in the group. Grabbing them from the database is no longer needed.","commit_id":"50525562f8b6cd4ca2b36f537ae844583ebf6f59"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"973682bba1a97fdd1f07a13a8a2297197ae4f1d6","unresolved":false,"context_lines":[{"line_number":1243,"context_line":"                              \"Exception: %s\"), err)"},{"line_number":1244,"context_line":"            return model_update, volumes_model_update"},{"line_number":1245,"context_line":""},{"line_number":1246,"context_line":"        LOG.debug(\u0027Leave: create_cg_from_source\u0027)"},{"line_number":1247,"context_line":"        return model_update, volumes_model_update"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def _get_volume_model_updates("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_956544b6","line":1246,"updated":"2015-12-27 13:10:35.000000000","message":"Please add a \u0027.\u0027 at the EOL.","commit_id":"869972bf90dc8aae721d1eac5c369af29ddfcc8e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"973682bba1a97fdd1f07a13a8a2297197ae4f1d6","unresolved":false,"context_lines":[{"line_number":2353,"context_line":""},{"line_number":2354,"context_line":"    def update_consistencygroup(self, ctxt, group, add_volumes,"},{"line_number":2355,"context_line":"                                remove_volumes):"},{"line_number":2356,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":2357,"context_line":""},{"line_number":2358,"context_line":"        LOG.debug(\"Updating consistency group\")"},{"line_number":2359,"context_line":"        return None, None, None"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_555b5cf6","line":2356,"updated":"2015-12-27 13:10:35.000000000","message":"Please add a \u0027.\u0027 at the EOL.","commit_id":"869972bf90dc8aae721d1eac5c369af29ddfcc8e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"973682bba1a97fdd1f07a13a8a2297197ae4f1d6","unresolved":false,"context_lines":[{"line_number":2355,"context_line":"                                remove_volumes):"},{"line_number":2356,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":2357,"context_line":""},{"line_number":2358,"context_line":"        LOG.debug(\"Updating consistency group\")"},{"line_number":2359,"context_line":"        return None, None, None"},{"line_number":2360,"context_line":""},{"line_number":2361,"context_line":"    def create_consistencygroup_from_src(self, context, group, volumes,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_3556d0ce","line":2358,"updated":"2015-12-27 13:10:35.000000000","message":"Please add a \u0027.\u0027 at the EOL.","commit_id":"869972bf90dc8aae721d1eac5c369af29ddfcc8e"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"f0586dfe215338b559fd62cca65d626d04e94a66","unresolved":false,"context_lines":[{"line_number":1247,"context_line":"        return model_update, volumes_model_update"},{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def _get_volume_model_updates("},{"line_number":1250,"context_line":"            self, ctxt, volumes, cgId, status\u003d\u0027available\u0027):"},{"line_number":1251,"context_line":"        \"\"\"Update the volume model\u0027s status and return it. \"\"\""},{"line_number":1252,"context_line":"        volume_model_updates \u003d []"},{"line_number":1253,"context_line":"        LOG.info(_LI("}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_8cc8cca9","line":1250,"updated":"2015-12-28 14:02:39.000000000","message":"I think it\u0027s better to change to:\n    def _get_volume_model_updates(self, ctxt, volumes, cgId,\n                                  status\u003d\u0027available\u0027):","commit_id":"20433b4bdd00b223739947ecbae2183237f9efd1"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"f0586dfe215338b559fd62cca65d626d04e94a66","unresolved":false,"context_lines":[{"line_number":1248,"context_line":""},{"line_number":1249,"context_line":"    def _get_volume_model_updates("},{"line_number":1250,"context_line":"            self, ctxt, volumes, cgId, status\u003d\u0027available\u0027):"},{"line_number":1251,"context_line":"        \"\"\"Update the volume model\u0027s status and return it. \"\"\""},{"line_number":1252,"context_line":"        volume_model_updates \u003d []"},{"line_number":1253,"context_line":"        LOG.info(_LI("},{"line_number":1254,"context_line":"            \"Updating status for CG: %(id)s.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_0c613cd3","line":1251,"range":{"start_line":1251,"start_character":58,"end_line":1251,"end_character":59},"updated":"2015-12-28 14:02:39.000000000","message":"The space at the end of this line is no need, please remove it.","commit_id":"20433b4bdd00b223739947ecbae2183237f9efd1"}]}