)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"2c23542dff5e505cf6d26983996014069a678123","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When image_volume_cache_enabled \u003d True, Cinder will create"},{"line_number":10,"context_line":"a cached image volume. But when creating this image volume,"},{"line_number":11,"context_line":"the name_id is set to id of newly created volume, which causing the"},{"line_number":12,"context_line":"image volume is unabled to be created in the underlying storage"},{"line_number":13,"context_line":"system."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_d0c7c343","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":63},"updated":"2015-12-23 06:46:45.000000000","message":"causing \u003d\u003e causes","commit_id":"0d3a389f4d66a828ebcc98c200106cf374a9e249"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"4075323ea487ce5c215603c9fb13c01e4fa4969d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When image_volume_cache_enabled \u003d True, Cinder will create"},{"line_number":10,"context_line":"a cached image volume. But when creating this image volume,"},{"line_number":11,"context_line":"the name_id is set to id of newly created volume, which causing the"},{"line_number":12,"context_line":"image volume is unabled to be created in the underlying storage"},{"line_number":13,"context_line":"system."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_eb40d209","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":63},"in_reply_to":"1a7b0d38_d0c7c343","updated":"2015-12-23 07:41:44.000000000","message":"Done","commit_id":"0d3a389f4d66a828ebcc98c200106cf374a9e249"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"823453c25659b3b0cf8f795867f7e58c79c6130c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When image_volume_cache_enabled \u003d True, Cinder will create"},{"line_number":10,"context_line":"a cached image volume. But when creating this image volume,"},{"line_number":11,"context_line":"the name_id is set to id of newly created volume, which causing the"},{"line_number":12,"context_line":"image volume is unabled to be created in the underlying storage"},{"line_number":13,"context_line":"system."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This fix will remove the name_id so that volume.name can refer to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_0b5d1ee9","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":23},"updated":"2015-12-23 07:13:44.000000000","message":"nit: unabled-\u003eunable","commit_id":"0d3a389f4d66a828ebcc98c200106cf374a9e249"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"2c23542dff5e505cf6d26983996014069a678123","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Also, a minor fix: passing volume.id to delete_volume."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib47b189a525d8a9bd9026cc20f62542aede9c9d4"},{"line_number":21,"context_line":"Closes-bug: 1487952"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_b0d1d7fd","line":21,"updated":"2015-12-23 06:46:45.000000000","message":"The referenced bug seems unrelated to what you mentioned above. Where is \u0027provider_location\u0027?","commit_id":"0d3a389f4d66a828ebcc98c200106cf374a9e249"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"4075323ea487ce5c215603c9fb13c01e4fa4969d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Also, a minor fix: passing volume.id to delete_volume."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib47b189a525d8a9bd9026cc20f62542aede9c9d4"},{"line_number":21,"context_line":"Closes-bug: 1487952"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_8b526edc","line":21,"in_reply_to":"1a7b0d38_b0d1d7fd","updated":"2015-12-23 07:41:44.000000000","message":"my fault, will update with correct bug","commit_id":"0d3a389f4d66a828ebcc98c200106cf374a9e249"}],"cinder/volume/manager.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"2c23542dff5e505cf6d26983996014069a678123","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                          {\u0027volume_id\u0027: volume.id,"},{"line_number":1123,"context_line":"                           \u0027image_id\u0027: image_meta[\u0027id\u0027]})"},{"line_number":1124,"context_line":"            try:"},{"line_number":1125,"context_line":"                self.delete_volume(ctx, image_volume.id)"},{"line_number":1126,"context_line":"            except exception.CinderException:"},{"line_number":1127,"context_line":"                LOG.exception(_LE(\u0027Could not delete the image volume %(id)s.\u0027),"},{"line_number":1128,"context_line":"                              {\u0027id\u0027: volume.id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_d03ca331","line":1125,"range":{"start_line":1125,"start_character":35,"end_line":1125,"end_character":38},"updated":"2015-12-23 06:46:45.000000000","message":"It would be easier to pass review if you tell more about why you need to fix here.","commit_id":"0d3a389f4d66a828ebcc98c200106cf374a9e249"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"4075323ea487ce5c215603c9fb13c01e4fa4969d","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                          {\u0027volume_id\u0027: volume.id,"},{"line_number":1123,"context_line":"                           \u0027image_id\u0027: image_meta[\u0027id\u0027]})"},{"line_number":1124,"context_line":"            try:"},{"line_number":1125,"context_line":"                self.delete_volume(ctx, image_volume.id)"},{"line_number":1126,"context_line":"            except exception.CinderException:"},{"line_number":1127,"context_line":"                LOG.exception(_LE(\u0027Could not delete the image volume %(id)s.\u0027),"},{"line_number":1128,"context_line":"                              {\u0027id\u0027: volume.id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_4b0a46d4","line":1125,"range":{"start_line":1125,"start_character":35,"end_line":1125,"end_character":38},"in_reply_to":"1a7b0d38_d03ca331","updated":"2015-12-23 07:41:44.000000000","message":"Sure, will add some explanations in commit message","commit_id":"0d3a389f4d66a828ebcc98c200106cf374a9e249"}]}
