)]}'
{"cinder/volume/drivers/glusterfs.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"1cf682d26dde6f105980c88c67e9b9b4013c8f80","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def _update_volume_stats(self):"},{"line_number":268,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":271,"context_line":"        data \u003d {}"},{"line_number":272,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":273,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or \u0027GlusterFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F%2BCk%3D","line":270,"updated":"2013-04-04 04:06:54.000000000","message":"this debug is not necessary. periodic task for _report_driver_status in the manager already logs this.","commit_id":"0c6360167c24601f8c17e8d1582035f5ff3ca140"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"91ef265b415e3da526966fe2a207280e22f19491","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def _update_volume_stats(self):"},{"line_number":268,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":271,"context_line":"        data \u003d {}"},{"line_number":272,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":273,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or \u0027GlusterFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F91U%3D","line":270,"in_reply_to":"AAAAOX%2F%2F%2BCk%3D","updated":"2013-04-04 08:29:03.000000000","message":"Since _update_volume_stats() isn\u0027t always called by get_volume_stats(), a debug level log is reasonable enough here, I think.","commit_id":"0c6360167c24601f8c17e8d1582035f5ff3ca140"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"fe0a512dfe967a3655f27fc9f108acc20b6d2103","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def _update_volume_stats(self):"},{"line_number":268,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":271,"context_line":"        data \u003d {}"},{"line_number":272,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":273,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or \u0027GlusterFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F7lQ%3D","line":270,"in_reply_to":"AAAAOX%2F%2F768%3D","updated":"2013-04-05 14:38:24.000000000","message":"In this case, the manager appears to always call with refresh\u003dTrue.  I agree w/ Mike, so I\u0027ll remove this message and resubmit.  (And probably make a similar separate change for the NFS driver.)","commit_id":"0c6360167c24601f8c17e8d1582035f5ff3ca140"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"76adb686ba82b50a9346fc4a964f1c7b4985bbcc","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def _update_volume_stats(self):"},{"line_number":268,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":271,"context_line":"        data \u003d {}"},{"line_number":272,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":273,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or \u0027GlusterFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F768%3D","line":270,"in_reply_to":"AAAAOX%2F%2F8Yw%3D","updated":"2013-04-05 09:25:19.000000000","message":"Sorry, my comment was ambiguous.\n _update_volume_stats() is not called from anywhere else, only get_volume_stats() just above it.\n\nThe point I was making was that it is not always called, it\u0027s only called when \u0027refresh\u0027 is true. So the debug log here may be useful to indicate whether \u0027refresh\u0027 is true or false on each time that the periodic task is called.","commit_id":"0c6360167c24601f8c17e8d1582035f5ff3ca140"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"de8846a60c7543b066bcebb6bd4abd0497e0a473","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def _update_volume_stats(self):"},{"line_number":268,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":271,"context_line":"        data \u003d {}"},{"line_number":272,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":273,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or \u0027GlusterFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F8Yw%3D","line":270,"in_reply_to":"AAAAOX%2F%2F91U%3D","updated":"2013-04-04 23:05:58.000000000","message":"Oliver, Where else is it being called? I missed it with my quick search.\n\nEric, if this periodic task is the only place it\u0027s being called, I will make a point to move it out of the other drivers. Otherwise we see this message twice.","commit_id":"0c6360167c24601f8c17e8d1582035f5ff3ca140"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9ab7ee0c12588d2455f79d5be80dd493e16e705e","unresolved":false,"context_lines":[{"line_number":267,"context_line":"    def _update_volume_stats(self):"},{"line_number":268,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":271,"context_line":"        data \u003d {}"},{"line_number":272,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":273,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d backend_name or \u0027GlusterFS\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOX%2F%2F9p8%3D","line":270,"in_reply_to":"AAAAOX%2F%2F91U%3D","updated":"2013-04-04 11:23:23.000000000","message":"Right -- the NFS driver logs this in the same way.","commit_id":"0c6360167c24601f8c17e8d1582035f5ff3ca140"}]}