)]}'
{"cinder/tests/unit/test_hpe3par.py":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"641122b634e39af18b5b29415dc2978b0dde6584","unresolved":false,"context_lines":[{"line_number":3782,"context_line":"                               \u0027_create_client\u0027) as mock_create_client:"},{"line_number":3783,"context_line":"            mock_create_client.return_value \u003d mock_client"},{"line_number":3784,"context_line":"            common \u003d self.driver._login()"},{"line_number":3785,"context_line":"            "},{"line_number":3786,"context_line":"            self.assertRaises(exception.SnapshotIsBusy,"},{"line_number":3787,"context_line":"                              self.driver.unmanage_snapshot,"},{"line_number":3788,"context_line":"                              snapshot\u003dsnapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_b82195b6","line":3785,"range":{"start_line":3785,"start_character":0,"end_line":3785,"end_character":12},"updated":"2015-12-24 05:47:09.000000000","message":"Is there some space there? Please remove them.","commit_id":"4226894d4a97bb034b69ee0d3c62f1ca1104e8e0"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"b018db0f98da897e72d2b8cf163ea9e59fc31164","unresolved":false,"context_lines":[{"line_number":3782,"context_line":"                               \u0027_create_client\u0027) as mock_create_client:"},{"line_number":3783,"context_line":"            mock_create_client.return_value \u003d mock_client"},{"line_number":3784,"context_line":"            common \u003d self.driver._login()"},{"line_number":3785,"context_line":"            "},{"line_number":3786,"context_line":"            self.assertRaises(exception.SnapshotIsBusy,"},{"line_number":3787,"context_line":"                              self.driver.unmanage_snapshot,"},{"line_number":3788,"context_line":"                              snapshot\u003dsnapshot)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_b663c6db","line":3785,"range":{"start_line":3785,"start_character":0,"end_line":3785,"end_character":12},"in_reply_to":"1a7b0d38_b82195b6","updated":"2016-01-04 18:02:28.000000000","message":"Done","commit_id":"4226894d4a97bb034b69ee0d3c62f1ca1104e8e0"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"5720b6eb9f27394ba5daba978bd30b4dbb0e200c","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            err \u003d (_(\"Managing of snapshots to failed-over volumes is \""},{"line_number":802,"context_line":"                     \"not allowed.\"))"},{"line_number":803,"context_line":"            LOG.error(err)"},{"line_number":804,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"        new_comment \u003d {}"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_4c53a439","line":804,"range":{"start_line":804,"start_character":12,"end_line":804,"end_character":72},"updated":"2016-01-05 18:30:23.000000000","message":"I don\u0027t think there is a need for raising SnapshotIsBusy when trying to manage a snapshot. Manage does not try and catch this exception, only unmanage. We see strange error logs and stack traces when this exception is not caught.","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f06db9e0dee7d6cfd8ed1b420eb4d40c038dfd79","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            err \u003d (_(\"Managing of snapshots to failed-over volumes is \""},{"line_number":802,"context_line":"                     \"not allowed.\"))"},{"line_number":803,"context_line":"            LOG.error(err)"},{"line_number":804,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"        new_comment \u003d {}"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_6c3c68c8","line":804,"updated":"2016-01-05 18:07:24.000000000","message":"So, the exception we raise here seems odd.  the snapshot isn\u0027t really busy.  The request being made to manage a snapshot, in this case is invalid and unsupported.","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"5720b6eb9f27394ba5daba978bd30b4dbb0e200c","unresolved":false,"context_lines":[{"line_number":796,"context_line":"            LOG.error(err)"},{"line_number":797,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        # Do not allow for managing of snapshots for \u0027failed-over\u0027 volumes."},{"line_number":800,"context_line":"        if volume.get(\u0027replication_status\u0027) \u003d\u003d \u0027failed-over\u0027:"},{"line_number":801,"context_line":"            err \u003d (_(\"Managing of snapshots to failed-over volumes is \""},{"line_number":802,"context_line":"                     \"not allowed.\"))"},{"line_number":803,"context_line":"            LOG.error(err)"},{"line_number":804,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"        new_comment \u003d {}"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_8ce67c13","line":804,"range":{"start_line":799,"start_character":8,"end_line":804,"end_character":72},"updated":"2016-01-05 18:30:23.000000000","message":"This check should be the first of the function. If the volume is failed over, we will make a few client calls even though we know we are going to fail later on.","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"86dac9f5e3ae7229134c6cb9eb6cfc5781a600b1","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            err \u003d (_(\"Managing of snapshots to failed-over volumes is \""},{"line_number":802,"context_line":"                     \"not allowed.\"))"},{"line_number":803,"context_line":"            LOG.error(err)"},{"line_number":804,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"        new_comment \u003d {}"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_a206e719","line":804,"range":{"start_line":804,"start_character":12,"end_line":804,"end_character":72},"in_reply_to":"fa69d971_4c53a439","updated":"2016-01-05 19:02:58.000000000","message":"Done","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"82b4c47b2b52497cdb7f94c933181cd641ace988","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            err \u003d (_(\"Managing of snapshots to failed-over volumes is \""},{"line_number":802,"context_line":"                     \"not allowed.\"))"},{"line_number":803,"context_line":"            LOG.error(err)"},{"line_number":804,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"        new_comment \u003d {}"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_ec9618ef","line":804,"in_reply_to":"fa69d971_6c3c68c8","updated":"2016-01-05 18:24:59.000000000","message":"Ok it seems that the volume manager only looks for SnapshotIsBusy to not throw the snap into an error state.  For manage and unmanage it\u0027s really an invalid request.  So, lets just add a comment block above the raise to say # TODO(leeantho)  change the exception to Invalid when the volume manager handles that.","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"86dac9f5e3ae7229134c6cb9eb6cfc5781a600b1","unresolved":false,"context_lines":[{"line_number":796,"context_line":"            LOG.error(err)"},{"line_number":797,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"        # Do not allow for managing of snapshots for \u0027failed-over\u0027 volumes."},{"line_number":800,"context_line":"        if volume.get(\u0027replication_status\u0027) \u003d\u003d \u0027failed-over\u0027:"},{"line_number":801,"context_line":"            err \u003d (_(\"Managing of snapshots to failed-over volumes is \""},{"line_number":802,"context_line":"                     \"not allowed.\"))"},{"line_number":803,"context_line":"            LOG.error(err)"},{"line_number":804,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"        new_comment \u003d {}"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_c20bdb22","line":804,"range":{"start_line":799,"start_character":8,"end_line":804,"end_character":72},"in_reply_to":"fa69d971_8ce67c13","updated":"2016-01-05 19:02:58.000000000","message":"Done","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"86dac9f5e3ae7229134c6cb9eb6cfc5781a600b1","unresolved":false,"context_lines":[{"line_number":801,"context_line":"            err \u003d (_(\"Managing of snapshots to failed-over volumes is \""},{"line_number":802,"context_line":"                     \"not allowed.\"))"},{"line_number":803,"context_line":"            LOG.error(err)"},{"line_number":804,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":805,"context_line":""},{"line_number":806,"context_line":"        new_comment \u003d {}"},{"line_number":807,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_47013d05","line":804,"in_reply_to":"fa69d971_ec9618ef","updated":"2016-01-05 19:02:58.000000000","message":"Done","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"f06db9e0dee7d6cfd8ed1b420eb4d40c038dfd79","unresolved":false,"context_lines":[{"line_number":921,"context_line":"            err \u003d (_(\"Unmanaging of snapshots from failed-over volumes is \""},{"line_number":922,"context_line":"                     \"not allowed.\"))"},{"line_number":923,"context_line":"            LOG.error(err)"},{"line_number":924,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        # Rename the snapshots\u0027s name to ums-* format so that it can be"},{"line_number":927,"context_line":"        # easily found later."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_4c2f2488","line":924,"updated":"2016-01-05 18:07:24.000000000","message":"same here","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"86dac9f5e3ae7229134c6cb9eb6cfc5781a600b1","unresolved":false,"context_lines":[{"line_number":921,"context_line":"            err \u003d (_(\"Unmanaging of snapshots from failed-over volumes is \""},{"line_number":922,"context_line":"                     \"not allowed.\"))"},{"line_number":923,"context_line":"            LOG.error(err)"},{"line_number":924,"context_line":"            raise exception.SnapshotIsBusy(snapshot_name\u003dsnapshot[\u0027id\u0027])"},{"line_number":925,"context_line":""},{"line_number":926,"context_line":"        # Rename the snapshots\u0027s name to ums-* format so that it can be"},{"line_number":927,"context_line":"        # easily found later."}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_8212c355","line":924,"in_reply_to":"fa69d971_4c2f2488","updated":"2016-01-05 19:02:58.000000000","message":"Done","commit_id":"74040628ebe8da687aa7f6c13d15a4ec66844232"}]}