)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"96fb7bdf260312a5e2d9a6729ba34f58dbfd3a12","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add CGSnapshotStatus enum field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new enum and field, CGSnapshotStatus and"},{"line_number":10,"context_line":"CGSnapshotStatusField, that will hold the constants for the \u0027status\u0027"},{"line_number":11,"context_line":"field of the CGSnapshot object.  This enum and field are based off"},{"line_number":12,"context_line":"the base oslo.versionedobjects enum and field.  Thsi also changes over"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_b769a827","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":16},"updated":"2015-12-24 02:41:20.000000000","message":"add -\u003e adds","commit_id":"5f410ffd90dd0161ba91c860112ec3feb763aec3"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"96fb7bdf260312a5e2d9a6729ba34f58dbfd3a12","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change add a new enum and field, CGSnapshotStatus and"},{"line_number":10,"context_line":"CGSnapshotStatusField, that will hold the constants for the \u0027status\u0027"},{"line_number":11,"context_line":"field of the CGSnapshot object.  This enum and field are based off"},{"line_number":12,"context_line":"the base oslo.versionedobjects enum and field.  Thsi also changes over"},{"line_number":13,"context_line":"the CGSnapshot object to use the new field (and bumps the version so"},{"line_number":14,"context_line":"newer versions know to enforce valid values).  Finally all uses of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_f75df079","line":11,"range":{"start_line":11,"start_character":63,"end_line":11,"end_character":66},"updated":"2015-12-24 02:41:20.000000000","message":"based off -\u003e based of","commit_id":"5f410ffd90dd0161ba91c860112ec3feb763aec3"},{"author":{"_account_id":14274,"name":"XinXiaohui","email":"xiaohui.xin@intel.com","username":"XinXiaohui"},"change_message_id":"96fb7bdf260312a5e2d9a6729ba34f58dbfd3a12","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change add a new enum and field, CGSnapshotStatus and"},{"line_number":10,"context_line":"CGSnapshotStatusField, that will hold the constants for the \u0027status\u0027"},{"line_number":11,"context_line":"field of the CGSnapshot object.  This enum and field are based off"},{"line_number":12,"context_line":"the base oslo.versionedobjects enum and field.  Thsi also changes over"},{"line_number":13,"context_line":"the CGSnapshot object to use the new field (and bumps the version so"},{"line_number":14,"context_line":"newer versions know to enforce valid values).  Finally all uses of"},{"line_number":15,"context_line":"strings for comparison and assignment to this field are changed over to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_574f24bd","line":12,"range":{"start_line":12,"start_character":48,"end_line":12,"end_character":52},"updated":"2015-12-24 02:41:20.000000000","message":"Thsi -\u003e This","commit_id":"5f410ffd90dd0161ba91c860112ec3feb763aec3"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":11,"context_line":"field of the CGSnapshot object.  This enum and field are based off"},{"line_number":12,"context_line":"the base oslo.versionedobjects enum and field.  This also changes over"},{"line_number":13,"context_line":"the CGSnapshot object to use the new field (and bumps the version so"},{"line_number":14,"context_line":"newer versions know to enforce valid values).  Finally all uses of"},{"line_number":15,"context_line":"strings for comparison and assignment to this field are changed over to"},{"line_number":16,"context_line":"use the constants defined withing the enum."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_2a483f5b","line":14,"range":{"start_line":14,"start_character":59,"end_line":14,"end_character":63},"updated":"2015-12-29 16:20:56.000000000","message":"usages?","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":11,"context_line":"field of the CGSnapshot object.  This enum and field are based off"},{"line_number":12,"context_line":"the base oslo.versionedobjects enum and field.  This also changes over"},{"line_number":13,"context_line":"the CGSnapshot object to use the new field (and bumps the version so"},{"line_number":14,"context_line":"newer versions know to enforce valid values).  Finally all uses of"},{"line_number":15,"context_line":"strings for comparison and assignment to this field are changed over to"},{"line_number":16,"context_line":"use the constants defined withing the enum."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da6ed579_a5c22c83","line":14,"range":{"start_line":14,"start_character":59,"end_line":14,"end_character":63},"in_reply_to":"fa69d971_2a483f5b","updated":"2016-02-26 17:54:41.000000000","message":"Not sure that is the best wording, but I made the change.  :-)","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/objects/fields.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    AVAILABLE \u003d \u0027available\u0027"},{"line_number":49,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":50,"context_line":"    DELETED \u003d \u0027deleted\u0027"},{"line_number":51,"context_line":"    ACTIVE \u003d \u0027active\u0027"},{"line_number":52,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":53,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":54,"context_line":"    ERROR_DELETING \u003d \u0027error_deleting\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2a17dfee","line":51,"updated":"2015-12-29 16:20:56.000000000","message":"I\u0027m just curious - but isn\u0027t \u0027active\u0027 very similar to \u0027available\u0027?","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    AVAILABLE \u003d \u0027available\u0027"},{"line_number":49,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":50,"context_line":"    DELETED \u003d \u0027deleted\u0027"},{"line_number":51,"context_line":"    ACTIVE \u003d \u0027active\u0027"},{"line_number":52,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":53,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":54,"context_line":"    ERROR_DELETING \u003d \u0027error_deleting\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_344aef55","line":51,"in_reply_to":"fa69d971_2a17dfee","updated":"2016-02-26 17:54:41.000000000","message":"They do seem very similar.  I will see what I find as I look through the code here again.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    DELETED \u003d \u0027deleted\u0027"},{"line_number":51,"context_line":"    ACTIVE \u003d \u0027active\u0027"},{"line_number":52,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":53,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":54,"context_line":"    ERROR_DELETING \u003d \u0027error_deleting\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    ALL \u003d (ERROR, AVAILABLE, DELETING, DELETED, ACTIVE, CREATING,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ea3b079b","line":53,"updated":"2015-12-29 16:20:56.000000000","message":"I think \u0027invalid\u0027 status is used only in tests as a status that blocks deleting. We shouldn\u0027t add it here.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    DELETED \u003d \u0027deleted\u0027"},{"line_number":51,"context_line":"    ACTIVE \u003d \u0027active\u0027"},{"line_number":52,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":53,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":54,"context_line":"    ERROR_DELETING \u003d \u0027error_deleting\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    ALL \u003d (ERROR, AVAILABLE, DELETING, DELETED, ACTIVE, CREATING,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_142c8b97","line":53,"in_reply_to":"fa69d971_ea3b079b","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/api/contrib/test_cgsnapshots.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        cgsnapshot \u003d utils.create_cgsnapshot("},{"line_number":443,"context_line":"            self.context,"},{"line_number":444,"context_line":"            consistencygroup_id\u003dconsistencygroup.id,"},{"line_number":445,"context_line":"            status\u003dfields.CGSnapshotStatus.INVALID)"},{"line_number":446,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/cgsnapshots/%s\u0027 %"},{"line_number":447,"context_line":"                                  cgsnapshot.id)"},{"line_number":448,"context_line":"        req.method \u003d \u0027DELETE\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4a20134a","line":445,"updated":"2015-12-29 16:20:56.000000000","message":"I think you should get rid of INVALID and use other blocking status here. Creating seems okay.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":442,"context_line":"        cgsnapshot \u003d utils.create_cgsnapshot("},{"line_number":443,"context_line":"            self.context,"},{"line_number":444,"context_line":"            consistencygroup_id\u003dconsistencygroup.id,"},{"line_number":445,"context_line":"            status\u003dfields.CGSnapshotStatus.INVALID)"},{"line_number":446,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/cgsnapshots/%s\u0027 %"},{"line_number":447,"context_line":"                                  cgsnapshot.id)"},{"line_number":448,"context_line":"        req.method \u003d \u0027DELETE\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_b4f1ff02","line":445,"in_reply_to":"fa69d971_4a20134a","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/fake_driver.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            snapshot_model_update \u003d {\u0027id\u0027: snapshot.id}"},{"line_number":292,"context_line":"            try:"},{"line_number":293,"context_line":"                self.create_snapshot(snapshot)"},{"line_number":294,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":295,"context_line":"                    fields.CGSnapshotStatus.AVAILABLE)"},{"line_number":296,"context_line":"            except Exception:"},{"line_number":297,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_0a9f7b60","line":294,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            snapshot_model_update \u003d {\u0027id\u0027: snapshot.id}"},{"line_number":292,"context_line":"            try:"},{"line_number":293,"context_line":"                self.create_snapshot(snapshot)"},{"line_number":294,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":295,"context_line":"                    fields.CGSnapshotStatus.AVAILABLE)"},{"line_number":296,"context_line":"            except Exception:"},{"line_number":297,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_cfaac684","line":294,"in_reply_to":"fa69d971_0a9f7b60","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                    fields.CGSnapshotStatus.AVAILABLE)"},{"line_number":296,"context_line":"            except Exception:"},{"line_number":297,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":298,"context_line":"                    fields.CGSnapshotStatus.ERROR)"},{"line_number":299,"context_line":"                model_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":300,"context_line":"            snapshot_model_updates.append(snapshot_model_update)"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6acb9773","line":298,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                    fields.CGSnapshotStatus.AVAILABLE)"},{"line_number":296,"context_line":"            except Exception:"},{"line_number":297,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":298,"context_line":"                    fields.CGSnapshotStatus.ERROR)"},{"line_number":299,"context_line":"                model_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":300,"context_line":"            snapshot_model_updates.append(snapshot_model_update)"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_2abda401","line":298,"in_reply_to":"fa69d971_6acb9773","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            snapshot_model_update \u003d {\u0027id\u0027: snapshot.id}"},{"line_number":310,"context_line":"            try:"},{"line_number":311,"context_line":"                self.delete_snapshot(snapshot)"},{"line_number":312,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":313,"context_line":"                    fields.CGSnapshotStatus.DELETED)"},{"line_number":314,"context_line":"            except exception.SnapshotIsBusy:"},{"line_number":315,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8aaa8b84","line":312,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            snapshot_model_update \u003d {\u0027id\u0027: snapshot.id}"},{"line_number":310,"context_line":"            try:"},{"line_number":311,"context_line":"                self.delete_snapshot(snapshot)"},{"line_number":312,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":313,"context_line":"                    fields.CGSnapshotStatus.DELETED)"},{"line_number":314,"context_line":"            except exception.SnapshotIsBusy:"},{"line_number":315,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ca108802","line":312,"in_reply_to":"fa69d971_8aaa8b84","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":313,"context_line":"                    fields.CGSnapshotStatus.DELETED)"},{"line_number":314,"context_line":"            except exception.SnapshotIsBusy:"},{"line_number":315,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":316,"context_line":"                    fields.CGSnapshotStatus.AVAILABLE)"},{"line_number":317,"context_line":"            except Exception:"},{"line_number":318,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2ac59f5a","line":315,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":312,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":313,"context_line":"                    fields.CGSnapshotStatus.DELETED)"},{"line_number":314,"context_line":"            except exception.SnapshotIsBusy:"},{"line_number":315,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("},{"line_number":316,"context_line":"                    fields.CGSnapshotStatus.AVAILABLE)"},{"line_number":317,"context_line":"            except Exception:"},{"line_number":318,"context_line":"                snapshot_model_update[\u0027status\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_6afcfcb7","line":315,"in_reply_to":"fa69d971_2ac59f5a","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/objects/test_cgsnapshot.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_save(self, cgsnapshot_update):"},{"line_number":58,"context_line":"        cgsnapshot \u003d objects.CGSnapshot._from_db_object("},{"line_number":59,"context_line":"            self.context, objects.CGSnapshot(), fake_cgsnapshot)"},{"line_number":60,"context_line":"        cgsnapshot.status \u003d fields.CGSnapshotStatus.ACTIVE"},{"line_number":61,"context_line":"        cgsnapshot.save()"},{"line_number":62,"context_line":"        cgsnapshot_update.assert_called_once_with("},{"line_number":63,"context_line":"            self.context, cgsnapshot.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_aa9d0f5b","line":60,"updated":"2015-12-29 16:20:56.000000000","message":"Isn\u0027t it the the only place \u0027active\u0027 it is used? Shouldn\u0027t this be \u0027available\u0027 actually?","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def test_save(self, cgsnapshot_update):"},{"line_number":58,"context_line":"        cgsnapshot \u003d objects.CGSnapshot._from_db_object("},{"line_number":59,"context_line":"            self.context, objects.CGSnapshot(), fake_cgsnapshot)"},{"line_number":60,"context_line":"        cgsnapshot.status \u003d fields.CGSnapshotStatus.ACTIVE"},{"line_number":61,"context_line":"        cgsnapshot.save()"},{"line_number":62,"context_line":"        cgsnapshot_update.assert_called_once_with("},{"line_number":63,"context_line":"            self.context, cgsnapshot.id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_0a954031","line":60,"in_reply_to":"fa69d971_aa9d0f5b","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/objects/test_fields.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                   (\u0027available\u0027, \u0027available\u0027),"},{"line_number":91,"context_line":"                                   (\u0027deleting\u0027, \u0027deleting\u0027),"},{"line_number":92,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"},{"line_number":93,"context_line":"                                   (\u0027active\u0027, \u0027active\u0027),"},{"line_number":94,"context_line":"                                   (\u0027creating\u0027, \u0027creating\u0027),"},{"line_number":95,"context_line":"                                   (\u0027invalid\u0027, \u0027invalid\u0027),"},{"line_number":96,"context_line":"                                   (\u0027error_deleting\u0027, \u0027error_deleting\u0027)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6a6ab71c","line":93,"updated":"2015-12-29 16:20:56.000000000","message":"I think \u0027active\u0027 isn\u0027t a valid status - looks like it got into tests by mistake.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                   (\u0027available\u0027, \u0027available\u0027),"},{"line_number":91,"context_line":"                                   (\u0027deleting\u0027, \u0027deleting\u0027),"},{"line_number":92,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"},{"line_number":93,"context_line":"                                   (\u0027active\u0027, \u0027active\u0027),"},{"line_number":94,"context_line":"                                   (\u0027creating\u0027, \u0027creating\u0027),"},{"line_number":95,"context_line":"                                   (\u0027invalid\u0027, \u0027invalid\u0027),"},{"line_number":96,"context_line":"                                   (\u0027error_deleting\u0027, \u0027error_deleting\u0027)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_8ac85056","line":93,"in_reply_to":"fa69d971_6a6ab71c","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"},{"line_number":93,"context_line":"                                   (\u0027active\u0027, \u0027active\u0027),"},{"line_number":94,"context_line":"                                   (\u0027creating\u0027, \u0027creating\u0027),"},{"line_number":95,"context_line":"                                   (\u0027invalid\u0027, \u0027invalid\u0027),"},{"line_number":96,"context_line":"                                   (\u0027error_deleting\u0027, \u0027error_deleting\u0027)]"},{"line_number":97,"context_line":"        self.coerce_bad_values \u003d [\u0027acme\u0027]"},{"line_number":98,"context_line":"        self.to_primitive_values \u003d self.coerce_good_values[0:1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4a26d317","line":95,"updated":"2015-12-29 16:20:56.000000000","message":"I don\u0027t think \u0027invalid\u0027 is used besides tests.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"},{"line_number":93,"context_line":"                                   (\u0027active\u0027, \u0027active\u0027),"},{"line_number":94,"context_line":"                                   (\u0027creating\u0027, \u0027creating\u0027),"},{"line_number":95,"context_line":"                                   (\u0027invalid\u0027, \u0027invalid\u0027),"},{"line_number":96,"context_line":"                                   (\u0027error_deleting\u0027, \u0027error_deleting\u0027)]"},{"line_number":97,"context_line":"        self.coerce_bad_values \u003d [\u0027acme\u0027]"},{"line_number":98,"context_line":"        self.to_primitive_values \u003d self.coerce_good_values[0:1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_4abed8ae","line":95,"in_reply_to":"fa69d971_4a26d317","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/test_gpfs.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"                                                                [])"},{"line_number":1755,"context_line":"        self.driver.delete_snapshot.assert_called_once_with(snapshot1)"},{"line_number":1756,"context_line":"        self.assertEqual({\u0027status\u0027: cgsnap[\u0027status\u0027]}, model_update)"},{"line_number":1757,"context_line":"        self.assertEqual(fields.CGSnapshotStatus.DELETED, snapshot1[\u0027status\u0027])"},{"line_number":1758,"context_line":"        self.driver.db.snapshot_get_all_for_cgsnapshot.\\"},{"line_number":1759,"context_line":"            assert_called_once_with(ctxt, cgsnap[\u0027id\u0027])"},{"line_number":1760,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_aad50fba","line":1757,"updated":"2015-12-29 16:20:56.000000000","message":"This is snapshot\u0027s status, not cgsnapshot\u0027s one.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"                                                                [])"},{"line_number":1755,"context_line":"        self.driver.delete_snapshot.assert_called_once_with(snapshot1)"},{"line_number":1756,"context_line":"        self.assertEqual({\u0027status\u0027: cgsnap[\u0027status\u0027]}, model_update)"},{"line_number":1757,"context_line":"        self.assertEqual(fields.CGSnapshotStatus.DELETED, snapshot1[\u0027status\u0027])"},{"line_number":1758,"context_line":"        self.driver.db.snapshot_get_all_for_cgsnapshot.\\"},{"line_number":1759,"context_line":"            assert_called_once_with(ctxt, cgsnap[\u0027id\u0027])"},{"line_number":1760,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_4871000b","line":1757,"in_reply_to":"fa69d971_aad50fba","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/test_ibm_xiv_ds8k.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                snapshot[\u0027name\u0027] \u003d CANNOT_DELETE \\"},{"line_number":256,"context_line":"                    if snapshot[\u0027name\u0027] \u003d\u003d CANNOT_DELETE \\"},{"line_number":257,"context_line":"                    else snapshot[\u0027name\u0027] + \u0027Snapshot\u0027"},{"line_number":258,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":259,"context_line":"                snapshot[\u0027cgsnapshot_id\u0027] \u003d cgsnapshot.get(\u0027id\u0027, None)"},{"line_number":260,"context_line":"                snapshot[\u0027consistencygroup_id\u0027] \u003d \\"},{"line_number":261,"context_line":"                    cgsnapshot.get(\u0027consistencygroup_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_aaa3cf4e","line":258,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s not a cgsnpashot\u0027s status, but snapshot\u0027s.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                snapshot[\u0027name\u0027] \u003d CANNOT_DELETE \\"},{"line_number":256,"context_line":"                    if snapshot[\u0027name\u0027] \u003d\u003d CANNOT_DELETE \\"},{"line_number":257,"context_line":"                    else snapshot[\u0027name\u0027] + \u0027Snapshot\u0027"},{"line_number":258,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":259,"context_line":"                snapshot[\u0027cgsnapshot_id\u0027] \u003d cgsnapshot.get(\u0027id\u0027, None)"},{"line_number":260,"context_line":"                snapshot[\u0027consistencygroup_id\u0027] \u003d \\"},{"line_number":261,"context_line":"                    cgsnapshot.get(\u0027consistencygroup_id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ea978ce9","line":258,"in_reply_to":"fa69d971_aaa3cf4e","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                raise exception.VolumeBackendAPIException("},{"line_number":272,"context_line":"                    message\u003d\u0027Snapshot can not be deleted\u0027)"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":275,"context_line":"                updated_snapshots.append(snapshot)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        # Delete snapshots in consistency group"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8a9e0b06","line":274,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s a snapshot status, not cgsnapshot.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                raise exception.VolumeBackendAPIException("},{"line_number":272,"context_line":"                    message\u003d\u0027Snapshot can not be deleted\u0027)"},{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":275,"context_line":"                updated_snapshots.append(snapshot)"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        # Delete snapshots in consistency group"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_0a9b0019","line":274,"in_reply_to":"fa69d971_8a9e0b06","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/test_pure.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":919,"context_line":"        self.assertEqual({\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE},"},{"line_number":920,"context_line":"                         model_update)"},{"line_number":921,"context_line":"        self.assertEqual(expected_snaps, snapshots)"},{"line_number":922,"context_line":"        self.assertEqual(fields.CGSnapshotStatus.AVAILABLE,"},{"line_number":923,"context_line":"                         mock_snap.status)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        self.assert_error_propagates("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2a903fec","line":922,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s snapshot status, not cgsnapshot.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":919,"context_line":"        self.assertEqual({\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE},"},{"line_number":920,"context_line":"                         model_update)"},{"line_number":921,"context_line":"        self.assertEqual(expected_snaps, snapshots)"},{"line_number":922,"context_line":"        self.assertEqual(fields.CGSnapshotStatus.AVAILABLE,"},{"line_number":923,"context_line":"                         mock_snap.status)"},{"line_number":924,"context_line":""},{"line_number":925,"context_line":"        self.assert_error_propagates("}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ed4fa668","line":922,"in_reply_to":"fa69d971_2a903fec","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/test_storwize_svc.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":3801,"context_line":"                         \"CGSnapshot created failed\")"},{"line_number":3802,"context_line":""},{"line_number":3803,"context_line":"        for snapshot in model_update[1]:"},{"line_number":3804,"context_line":"            self.assertEqual(fields.CGSnapshotStatus.AVAILABLE,"},{"line_number":3805,"context_line":"                             snapshot[\u0027status\u0027])"},{"line_number":3806,"context_line":""},{"line_number":3807,"context_line":"        model_update \u003d self.driver.delete_consistencygroup(self.ctxt, cg, [])"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8ab5ab7f","line":3804,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s asserting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":3801,"context_line":"                         \"CGSnapshot created failed\")"},{"line_number":3802,"context_line":""},{"line_number":3803,"context_line":"        for snapshot in model_update[1]:"},{"line_number":3804,"context_line":"            self.assertEqual(fields.CGSnapshotStatus.AVAILABLE,"},{"line_number":3805,"context_line":"                             snapshot[\u0027status\u0027])"},{"line_number":3806,"context_line":""},{"line_number":3807,"context_line":"        model_update \u003d self.driver.delete_consistencygroup(self.ctxt, cg, [])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_0d88fa6f","line":3804,"in_reply_to":"fa69d971_8ab5ab7f","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":3809,"context_line":"        self.assertEqual(fields.CGSnapshotStatus.DELETED,"},{"line_number":3810,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":3811,"context_line":"        for volume in model_update[1]:"},{"line_number":3812,"context_line":"            self.assertEqual(fields.CGSnapshotStatus.DELETED, volume[\u0027status\u0027])"},{"line_number":3813,"context_line":""},{"line_number":3814,"context_line":"    def _create_volume_type_qos(self, extra_specs, fake_qos):"},{"line_number":3815,"context_line":"        # Generate a QoS volume type for volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_aa718fe2","line":3812,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s volume status.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":3809,"context_line":"        self.assertEqual(fields.CGSnapshotStatus.DELETED,"},{"line_number":3810,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":3811,"context_line":"        for volume in model_update[1]:"},{"line_number":3812,"context_line":"            self.assertEqual(fields.CGSnapshotStatus.DELETED, volume[\u0027status\u0027])"},{"line_number":3813,"context_line":""},{"line_number":3814,"context_line":"    def _create_volume_type_qos(self, extra_specs, fake_qos):"},{"line_number":3815,"context_line":"        # Generate a QoS volume type for volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_6d9976c3","line":3812,"in_reply_to":"fa69d971_aa718fe2","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":5358,"context_line":"        snap.user_id \u003d \u0027fake\u0027"},{"line_number":5359,"context_line":"        snap.project_id \u003d \u0027fake\u0027"},{"line_number":5360,"context_line":"        snap.volume_id \u003d volume_id"},{"line_number":5361,"context_line":"        snap.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":5362,"context_line":"        snap.cgsnapshot_id \u003d cgsnap.id"},{"line_number":5363,"context_line":"        snap.create()"},{"line_number":5364,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ca496390","line":5361,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s snapshot, not a cgsnapshot.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":5358,"context_line":"        snap.user_id \u003d \u0027fake\u0027"},{"line_number":5359,"context_line":"        snap.project_id \u003d \u0027fake\u0027"},{"line_number":5360,"context_line":"        snap.volume_id \u003d volume_id"},{"line_number":5361,"context_line":"        snap.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":5362,"context_line":"        snap.cgsnapshot_id \u003d cgsnap.id"},{"line_number":5363,"context_line":"        snap.create()"},{"line_number":5364,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_0def9a1e","line":5361,"in_reply_to":"fa69d971_ca496390","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/dell/dell_storagecenter_common.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                    snapshots \u003d objects.SnapshotList().get_all_for_cgsnapshot("},{"line_number":517,"context_line":"                        context, snapshotid)"},{"line_number":518,"context_line":"                    for snapshot in snapshots:"},{"line_number":519,"context_line":"                        snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"                    model_update \u003d {\u0027status\u0027:"},{"line_number":522,"context_line":"                                    fields.CGSnapshotStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6a5b9755","line":519,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s snapshot, not a cgsnapshot\u0027s status.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":516,"context_line":"                    snapshots \u003d objects.SnapshotList().get_all_for_cgsnapshot("},{"line_number":517,"context_line":"                        context, snapshotid)"},{"line_number":518,"context_line":"                    for snapshot in snapshots:"},{"line_number":519,"context_line":"                        snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"                    model_update \u003d {\u0027status\u0027:"},{"line_number":522,"context_line":"                                    fields.CGSnapshotStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_0d3d5a8e","line":519,"in_reply_to":"fa69d971_6a5b9755","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            snapshots \u003d objects.SnapshotList().get_all_for_cgsnapshot("},{"line_number":560,"context_line":"                context, snapshotid)"},{"line_number":561,"context_line":"            for snapshot in snapshots:"},{"line_number":562,"context_line":"                snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"            model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.DELETED}"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2a559f1c","line":562,"updated":"2015-12-29 16:20:56.000000000","message":"ditto.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            snapshots \u003d objects.SnapshotList().get_all_for_cgsnapshot("},{"line_number":560,"context_line":"                context, snapshotid)"},{"line_number":561,"context_line":"            for snapshot in snapshots:"},{"line_number":562,"context_line":"                snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"            model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.DELETED}"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_cd10a202","line":562,"in_reply_to":"fa69d971_2a559f1c","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/emc/xtremio.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":694,"context_line":"            context, cgsnapshot[\u0027id\u0027])"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        for snapshot in snapshots:"},{"line_number":697,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8a3a8be6","line":697,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":694,"context_line":"            context, cgsnapshot[\u0027id\u0027])"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        for snapshot in snapshots:"},{"line_number":697,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_8de5ca09","line":697,"in_reply_to":"fa69d971_8a3a8be6","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            context, cgsnapshot[\u0027id\u0027])"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        for snapshot in snapshots:"},{"line_number":712,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ca172353","line":712,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":709,"context_line":"            context, cgsnapshot[\u0027id\u0027])"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        for snapshot in snapshots:"},{"line_number":712,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_2df05ec8","line":712,"in_reply_to":"fa69d971_ca172353","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        snapshot_model_updates \u003d []"},{"line_number":624,"context_line":"        for snapshot in snapshots:"},{"line_number":625,"context_line":"            snapshot_update \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":626,"context_line":"                               \u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":627,"context_line":"            snapshot_model_updates.append(snapshot_update)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ad0d2939","line":626,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        snapshot_model_updates \u003d []"},{"line_number":624,"context_line":"        for snapshot in snapshots:"},{"line_number":625,"context_line":"            snapshot_update \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":626,"context_line":"                               \u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":627,"context_line":"            snapshot_model_updates.append(snapshot_update)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_cd8422d4","line":626,"in_reply_to":"fa69d971_ad0d2939","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":641,"context_line":"            try:"},{"line_number":642,"context_line":"                snap_name \u003d cgsnap_name + \"-\" + six.text_type(i)"},{"line_number":643,"context_line":"                self.client.deleteVolume(snap_name)"},{"line_number":644,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":645,"context_line":"            except hpeexceptions.HTTPNotFound as ex:"},{"line_number":646,"context_line":"                # We\u0027ll let this act as if it worked"},{"line_number":647,"context_line":"                # it helps clean up the cinder entries."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6d10914f","line":644,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":641,"context_line":"            try:"},{"line_number":642,"context_line":"                snap_name \u003d cgsnap_name + \"-\" + six.text_type(i)"},{"line_number":643,"context_line":"                self.client.deleteVolume(snap_name)"},{"line_number":644,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":645,"context_line":"            except hpeexceptions.HTTPNotFound as ex:"},{"line_number":646,"context_line":"                # We\u0027ll let this act as if it worked"},{"line_number":647,"context_line":"                # it helps clean up the cinder entries."}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_6d70960b","line":644,"in_reply_to":"fa69d971_6d10914f","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                LOG.warning(_LW(\"Delete Snapshot id not found. Removing from \""},{"line_number":649,"context_line":"                                \"cinder: %(id)s Ex: %(msg)s\"),"},{"line_number":650,"context_line":"                            {\u0027id\u0027: snapshot[\u0027id\u0027], \u0027msg\u0027: ex})"},{"line_number":651,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":652,"context_line":"            except Exception as ex:"},{"line_number":653,"context_line":"                LOG.error(_LE(\"There was an error deleting snapshot %(id)s: \""},{"line_number":654,"context_line":"                              \"%(error).\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2d1a996f","line":651,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":648,"context_line":"                LOG.warning(_LW(\"Delete Snapshot id not found. Removing from \""},{"line_number":649,"context_line":"                                \"cinder: %(id)s Ex: %(msg)s\"),"},{"line_number":650,"context_line":"                            {\u0027id\u0027: snapshot[\u0027id\u0027], \u0027msg\u0027: ex})"},{"line_number":651,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":652,"context_line":"            except Exception as ex:"},{"line_number":653,"context_line":"                LOG.error(_LE(\"There was an error deleting snapshot %(id)s: \""},{"line_number":654,"context_line":"                              \"%(error).\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_8d6b8a1d","line":651,"in_reply_to":"fa69d971_2d1a996f","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":654,"context_line":"                              \"%(error).\"),"},{"line_number":655,"context_line":"                          {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":656,"context_line":"                           \u0027error\u0027: six.text_type(ex)})"},{"line_number":657,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":658,"context_line":"            snapshot_model_updates.append(snapshot_update)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4d3a6dcf","line":657,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":654,"context_line":"                              \"%(error).\"),"},{"line_number":655,"context_line":"                          {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":656,"context_line":"                           \u0027error\u0027: six.text_type(ex)})"},{"line_number":657,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":658,"context_line":"            snapshot_model_updates.append(snapshot_update)"},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ed62463d","line":657,"in_reply_to":"fa69d971_4d3a6dcf","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/hpe/hpe_lefthand_iscsi.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                                   \u0027snapshotName\u0027: snapshot_name}"},{"line_number":364,"context_line":"                snap_set.append(snap_set_member)"},{"line_number":365,"context_line":"                snapshot_update \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":366,"context_line":"                                   \u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":367,"context_line":"                snapshot_model_updates.append(snapshot_update)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            source_volume_id \u003d snap_set[0][\u0027volumeId\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_cd4c1d79","line":366,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                                   \u0027snapshotName\u0027: snapshot_name}"},{"line_number":364,"context_line":"                snap_set.append(snap_set_member)"},{"line_number":365,"context_line":"                snapshot_update \u003d {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":366,"context_line":"                                   \u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":367,"context_line":"                snapshot_model_updates.append(snapshot_update)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"            source_volume_id \u003d snap_set[0][\u0027volumeId\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_8d870ab4","line":366,"in_reply_to":"fa69d971_cd4c1d79","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                snap_name \u003d snap_name_base + \"-\" + six.text_type(i)"},{"line_number":404,"context_line":"                snap_info \u003d client.getSnapshotByName(snap_name)"},{"line_number":405,"context_line":"                client.deleteSnapshot(snap_info[\u0027id\u0027])"},{"line_number":406,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":407,"context_line":"            except hpeexceptions.HTTPServerError as ex:"},{"line_number":408,"context_line":"                in_use_msg \u003d (\u0027cannot be deleted because it is a clone \u0027"},{"line_number":409,"context_line":"                              \u0027point\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8d562505","line":406,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                snap_name \u003d snap_name_base + \"-\" + six.text_type(i)"},{"line_number":404,"context_line":"                snap_info \u003d client.getSnapshotByName(snap_name)"},{"line_number":405,"context_line":"                client.deleteSnapshot(snap_info[\u0027id\u0027])"},{"line_number":406,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":407,"context_line":"            except hpeexceptions.HTTPServerError as ex:"},{"line_number":408,"context_line":"                in_use_msg \u003d (\u0027cannot be deleted because it is a clone \u0027"},{"line_number":409,"context_line":"                              \u0027point\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_2d929ef6","line":406,"in_reply_to":"fa69d971_8d562505","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                              \"%(error).\"),"},{"line_number":417,"context_line":"                          {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":418,"context_line":"                           \u0027error\u0027: six.text_type(ex)})"},{"line_number":419,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":420,"context_line":"            snapshot_model_updates.append(snapshot_update)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        self._logout(client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ad5be92d","line":419,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                              \"%(error).\"),"},{"line_number":417,"context_line":"                          {\u0027id\u0027: snapshot[\u0027id\u0027],"},{"line_number":418,"context_line":"                           \u0027error\u0027: six.text_type(ex)})"},{"line_number":419,"context_line":"                snapshot_update[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":420,"context_line":"            snapshot_model_updates.append(snapshot_update)"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        self._logout(client)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_edbec663","line":419,"in_reply_to":"fa69d971_ad5be92d","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/ibm/gpfs.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"        for snapshot in snapshots:"},{"line_number":1212,"context_line":"            self.create_snapshot(snapshot)"},{"line_number":1213,"context_line":"            snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":1216,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4d410d39","line":1213,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"        for snapshot in snapshots:"},{"line_number":1212,"context_line":"            self.create_snapshot(snapshot)"},{"line_number":1213,"context_line":"            snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":1214,"context_line":""},{"line_number":1215,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":1216,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_ad6beeef","line":1213,"in_reply_to":"fa69d971_4d410d39","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        for snapshot in snapshots:"},{"line_number":1225,"context_line":"            self.delete_snapshot(snapshot)"},{"line_number":1226,"context_line":"            snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot[\u0027status\u0027]}"},{"line_number":1229,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_cd73bdb3","line":1226,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        for snapshot in snapshots:"},{"line_number":1225,"context_line":"            self.delete_snapshot(snapshot)"},{"line_number":1226,"context_line":"            snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":1227,"context_line":""},{"line_number":1228,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot[\u0027status\u0027]}"},{"line_number":1229,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_cd6e62ff","line":1226,"in_reply_to":"fa69d971_cd73bdb3","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"                                                    snapshot[\u0027name\u0027],"},{"line_number":1151,"context_line":"                                                    fc_consistgrp,"},{"line_number":1152,"context_line":"                                                    config, opts)"},{"line_number":1153,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"            self.prepare_fc_consistgrp(fc_consistgrp, timeout)"},{"line_number":1156,"context_line":"            self.start_fc_consistgrp(fc_consistgrp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ed780192","line":1153,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"                                                    snapshot[\u0027name\u0027],"},{"line_number":1151,"context_line":"                                                    fc_consistgrp,"},{"line_number":1152,"context_line":"                                                    config, opts)"},{"line_number":1153,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"            self.prepare_fc_consistgrp(fc_consistgrp, timeout)"},{"line_number":1156,"context_line":"            self.start_fc_consistgrp(fc_consistgrp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_2d05be12","line":1153,"in_reply_to":"fa69d971_ed780192","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":1160,"context_line":"            self.delete_fc_consistgrp(fc_consistgrp)"},{"line_number":1161,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1162,"context_line":"            for snapshot in snapshots:"},{"line_number":1163,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":1164,"context_line":"            cgsnapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":1165,"context_line":"            # Release cg"},{"line_number":1166,"context_line":"            self.delete_fc_consistgrp(fc_consistgrp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8d6dc5ce","line":1163,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":1160,"context_line":"            self.delete_fc_consistgrp(fc_consistgrp)"},{"line_number":1161,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1162,"context_line":"            for snapshot in snapshots:"},{"line_number":1163,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":1164,"context_line":"            cgsnapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":1165,"context_line":"            # Release cg"},{"line_number":1166,"context_line":"            self.delete_fc_consistgrp(fc_consistgrp)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_0805480f","line":1163,"in_reply_to":"fa69d971_8d6dc5ce","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        try:"},{"line_number":1176,"context_line":"            for snapshot in snapshots:"},{"line_number":1177,"context_line":"                self.ssh.rmvdisk(snapshot[\u0027name\u0027], True)"},{"line_number":1178,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":1179,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1180,"context_line":"            for snapshot in snapshots:"},{"line_number":1181,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR_DELETING"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4d682dbb","line":1178,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        try:"},{"line_number":1176,"context_line":"            for snapshot in snapshots:"},{"line_number":1177,"context_line":"                self.ssh.rmvdisk(snapshot[\u0027name\u0027], True)"},{"line_number":1178,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":1179,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1180,"context_line":"            for snapshot in snapshots:"},{"line_number":1181,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR_DELETING"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_a8075c16","line":1178,"in_reply_to":"fa69d971_4d682dbb","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":1179,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1180,"context_line":"            for snapshot in snapshots:"},{"line_number":1181,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR_DELETING"},{"line_number":1182,"context_line":"            cgsnapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR_DELETING"},{"line_number":1183,"context_line":"            LOG.error(_LE(\"Failed to delete the snapshot %(snap)s of \""},{"line_number":1184,"context_line":"                          \"CGSnapshot. Exception: %(exception)s.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_0d6235d9","line":1181,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":1179,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1180,"context_line":"            for snapshot in snapshots:"},{"line_number":1181,"context_line":"                snapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR_DELETING"},{"line_number":1182,"context_line":"            cgsnapshot[\u0027status\u0027] \u003d fields.CGSnapshotStatus.ERROR_DELETING"},{"line_number":1183,"context_line":"            LOG.error(_LE(\"Failed to delete the snapshot %(snap)s of \""},{"line_number":1184,"context_line":"                          \"CGSnapshot. Exception: %(exception)s.\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_4817c044","line":1181,"in_reply_to":"fa69d971_0d6235d9","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/prophetstor/dplcommon.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":933,"context_line":"                cgsnapshot.get(\u0027description\u0027, \u0027\u0027),"},{"line_number":934,"context_line":"                True)"},{"line_number":935,"context_line":"            for snapshot in snapshots:"},{"line_number":936,"context_line":"                snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":937,"context_line":"        except Exception as e:"},{"line_number":938,"context_line":"            msg \u003d _(\u0027Failed to create cg snapshot %(id)s \u0027"},{"line_number":939,"context_line":"                    \u0027due to %(reason)s.\u0027) % {\u0027id\u0027: cgsnapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ada9a9e1","line":936,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":933,"context_line":"                cgsnapshot.get(\u0027description\u0027, \u0027\u0027),"},{"line_number":934,"context_line":"                True)"},{"line_number":935,"context_line":"            for snapshot in snapshots:"},{"line_number":936,"context_line":"                snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":937,"context_line":"        except Exception as e:"},{"line_number":938,"context_line":"            msg \u003d _(\u0027Failed to create cg snapshot %(id)s \u0027"},{"line_number":939,"context_line":"                    \u0027due to %(reason)s.\u0027) % {\u0027id\u0027: cgsnapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_883858d4","line":936,"in_reply_to":"fa69d971_ada9a9e1","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                self._conver_uuid2hex(cgsnapshot[\u0027consistencygroup_id\u0027]),"},{"line_number":960,"context_line":"                self._conver_uuid2hex(cgsnapshot[\u0027id\u0027]), True)"},{"line_number":961,"context_line":"            for snapshot in snapshots:"},{"line_number":962,"context_line":"                snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":963,"context_line":"        except Exception as e:"},{"line_number":964,"context_line":"            msg \u003d _(\u0027Failed to delete cgsnapshot %(id)s due to \u0027"},{"line_number":965,"context_line":"                    \u0027%(reason)s.\u0027) % {\u0027id\u0027: cgsnapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_cde89d19","line":962,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                self._conver_uuid2hex(cgsnapshot[\u0027consistencygroup_id\u0027]),"},{"line_number":960,"context_line":"                self._conver_uuid2hex(cgsnapshot[\u0027id\u0027]), True)"},{"line_number":961,"context_line":"            for snapshot in snapshots:"},{"line_number":962,"context_line":"                snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":963,"context_line":"        except Exception as e:"},{"line_number":964,"context_line":"            msg \u003d _(\u0027Failed to delete cgsnapshot %(id)s due to \u0027"},{"line_number":965,"context_line":"                    \u0027%(reason)s.\u0027) % {\u0027id\u0027: cgsnapshot[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_e89d54bc","line":962,"in_reply_to":"fa69d971_cde89d19","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            context, cgsnapshot.id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        for snapshot in snapshots:"},{"line_number":469,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8df2a505","line":469,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            context, cgsnapshot.id)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"        for snapshot in snapshots:"},{"line_number":469,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"        model_update \u003d {\u0027status\u0027: fields.CGSnapshotStatus.AVAILABLE}"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_88db787b","line":469,"in_reply_to":"fa69d971_8df2a505","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            context, cgsnapshot.id)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        for snapshot in snapshots:"},{"line_number":502,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4ddd8d6f","line":502,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            context, cgsnapshot.id)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        for snapshot in snapshots:"},{"line_number":502,"context_line":"            snapshot.status \u003d fields.CGSnapshotStatus.DELETED"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        model_update \u003d {\u0027status\u0027: cgsnapshot.status}"},{"line_number":505,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_48e10029","line":502,"in_reply_to":"fa69d971_4ddd8d6f","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}],"cinder/volume/manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":2937,"context_line":"            if snapshots_model_update:"},{"line_number":2938,"context_line":"                for snap_model in snapshots_model_update:"},{"line_number":2939,"context_line":"                    # Update db if status is error"},{"line_number":2940,"context_line":"                    if snap_model[\u0027status\u0027] \u003d\u003d fields.CGSnapshotStatus.ERROR:"},{"line_number":2941,"context_line":"                        # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":2942,"context_line":"                        # snapshots_model_update should be a list of dicts."},{"line_number":2943,"context_line":"                        snap \u003d next((item for item in snapshots if"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8dc945af","line":2940,"updated":"2015-12-29 16:20:56.000000000","message":"That\u0027s setting a snapshot status, this shouldn\u0027t use CGSnapshot enum.","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":2937,"context_line":"            if snapshots_model_update:"},{"line_number":2938,"context_line":"                for snap_model in snapshots_model_update:"},{"line_number":2939,"context_line":"                    # Update db if status is error"},{"line_number":2940,"context_line":"                    if snap_model[\u0027status\u0027] \u003d\u003d fields.CGSnapshotStatus.ERROR:"},{"line_number":2941,"context_line":"                        # NOTE(xyang): snapshots is a list of snapshot objects."},{"line_number":2942,"context_line":"                        # snapshots_model_update should be a list of dicts."},{"line_number":2943,"context_line":"                        snap \u003d next((item for item in snapshots if"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_c8273061","line":2940,"in_reply_to":"fa69d971_8dc945af","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":2947,"context_line":"                            snap.save()"},{"line_number":2948,"context_line":""},{"line_number":2949,"context_line":"                    if (snap_model[\u0027status\u0027] in"},{"line_number":2950,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":2951,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":2952,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":2953,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_adce89b2","line":2950,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":2947,"context_line":"                            snap.save()"},{"line_number":2948,"context_line":""},{"line_number":2949,"context_line":"                    if (snap_model[\u0027status\u0027] in"},{"line_number":2950,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":2951,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":2952,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":2953,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_881e180a","line":2950,"in_reply_to":"fa69d971_adce89b2","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":2950,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":2951,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":2952,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":2953,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":2954,"context_line":"                         fields.CGSnapshotStatus.ERROR]):"},{"line_number":2955,"context_line":"                        model_update[\u0027status\u0027] \u003d snap_model[\u0027status\u0027]"},{"line_number":2956,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4dc4ad91","line":2953,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":2950,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":2951,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":2952,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":2953,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":2954,"context_line":"                         fields.CGSnapshotStatus.ERROR]):"},{"line_number":2955,"context_line":"                        model_update[\u0027status\u0027] \u003d snap_model[\u0027status\u0027]"},{"line_number":2956,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_28192c22","line":2953,"in_reply_to":"fa69d971_4dc4ad91","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":2969,"context_line":"                # None for snapshots_model_update."},{"line_number":2970,"context_line":"                if not snapshots_model_update:"},{"line_number":2971,"context_line":"                    for snapshot in snapshots:"},{"line_number":2972,"context_line":"                        snapshot.status \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":2973,"context_line":"                        snapshot.save()"},{"line_number":2974,"context_line":""},{"line_number":2975,"context_line":"        for snapshot in snapshots:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_0dbeb5ff","line":2972,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":2969,"context_line":"                # None for snapshots_model_update."},{"line_number":2970,"context_line":"                if not snapshots_model_update:"},{"line_number":2971,"context_line":"                    for snapshot in snapshots:"},{"line_number":2972,"context_line":"                        snapshot.status \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":2973,"context_line":"                        snapshot.save()"},{"line_number":2974,"context_line":""},{"line_number":2975,"context_line":"        for snapshot in snapshots:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_08c0e84e","line":2972,"in_reply_to":"fa69d971_0dbeb5ff","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":2991,"context_line":"                    # after cgsnapshot-objects bugs are fixed"},{"line_number":2992,"context_line":"                    self.db.snapshot_update(context, snapshot_id,"},{"line_number":2993,"context_line":"                                            {\u0027status\u0027:"},{"line_number":2994,"context_line":"                                             fields.CGSnapshotStatus.ERROR})"},{"line_number":2995,"context_line":"                    raise exception.MetadataCopyFailure("},{"line_number":2996,"context_line":"                        reason\u003dsix.text_type(ex))"},{"line_number":2997,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8d406509","line":2994,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":2991,"context_line":"                    # after cgsnapshot-objects bugs are fixed"},{"line_number":2992,"context_line":"                    self.db.snapshot_update(context, snapshot_id,"},{"line_number":2993,"context_line":"                                            {\u0027status\u0027:"},{"line_number":2994,"context_line":"                                             fields.CGSnapshotStatus.ERROR})"},{"line_number":2995,"context_line":"                    raise exception.MetadataCopyFailure("},{"line_number":2996,"context_line":"                        reason\u003dsix.text_type(ex))"},{"line_number":2997,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_67cc0462","line":2994,"in_reply_to":"fa69d971_8d406509","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":2998,"context_line":"            self.db.snapshot_update(context,"},{"line_number":2999,"context_line":"                                    snapshot[\u0027id\u0027],"},{"line_number":3000,"context_line":"                                    {\u0027status\u0027:"},{"line_number":3001,"context_line":"                                     fields.CGSnapshotStatus.AVAILABLE,"},{"line_number":3002,"context_line":"                                     \u0027progress\u0027: \u0027100%\u0027})"},{"line_number":3003,"context_line":""},{"line_number":3004,"context_line":"        cgsnapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_4d4b4d2c","line":3001,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":2998,"context_line":"            self.db.snapshot_update(context,"},{"line_number":2999,"context_line":"                                    snapshot[\u0027id\u0027],"},{"line_number":3000,"context_line":"                                    {\u0027status\u0027:"},{"line_number":3001,"context_line":"                                     fields.CGSnapshotStatus.AVAILABLE,"},{"line_number":3002,"context_line":"                                     \u0027progress\u0027: \u0027100%\u0027})"},{"line_number":3003,"context_line":""},{"line_number":3004,"context_line":"        cgsnapshot.status \u003d fields.CGSnapshotStatus.AVAILABLE"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_27383c3d","line":3001,"in_reply_to":"fa69d971_4d4b4d2c","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":3053,"context_line":"                        snap.save()"},{"line_number":3054,"context_line":""},{"line_number":3055,"context_line":"                    if (snap_model[\u0027status\u0027] in"},{"line_number":3056,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":3057,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":3058,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":3059,"context_line":"                            [fields.CGSnapshotStatus.ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_ad5c49ee","line":3056,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":3053,"context_line":"                        snap.save()"},{"line_number":3054,"context_line":""},{"line_number":3055,"context_line":"                    if (snap_model[\u0027status\u0027] in"},{"line_number":3056,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":3057,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":3058,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":3059,"context_line":"                            [fields.CGSnapshotStatus.ERROR_DELETING,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_08e308da","line":3056,"in_reply_to":"fa69d971_ad5c49ee","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":3056,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":3057,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":3058,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":3059,"context_line":"                            [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":3060,"context_line":"                             fields.CGSnapshotStatus.ERROR]):"},{"line_number":3061,"context_line":"                        model_update[\u0027status\u0027] \u003d snap_model[\u0027status\u0027]"},{"line_number":3062,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6d6f3193","line":3059,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":3056,"context_line":"                        [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":3057,"context_line":"                         fields.CGSnapshotStatus.ERROR] and"},{"line_number":3058,"context_line":"                            model_update[\u0027status\u0027] not in"},{"line_number":3059,"context_line":"                            [fields.CGSnapshotStatus.ERROR_DELETING,"},{"line_number":3060,"context_line":"                             fields.CGSnapshotStatus.ERROR]):"},{"line_number":3061,"context_line":"                        model_update[\u0027status\u0027] \u003d snap_model[\u0027status\u0027]"},{"line_number":3062,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_c8e890b5","line":3059,"in_reply_to":"fa69d971_6d6f3193","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"97618a918cafc490dadb3a4557ee576c35848942","unresolved":false,"context_lines":[{"line_number":3080,"context_line":"                # None for snapshots_model_update."},{"line_number":3081,"context_line":"                if not snapshots_model_update:"},{"line_number":3082,"context_line":"                    for snapshot in snapshots:"},{"line_number":3083,"context_line":"                        snapshot.status \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":3084,"context_line":"                        snapshot.save()"},{"line_number":3085,"context_line":""},{"line_number":3086,"context_line":"        for snapshot in snapshots:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_2d0059aa","line":3083,"updated":"2015-12-29 16:20:56.000000000","message":"ditto","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9b3dee6c560ae8245fe96026caf83f68240d65bf","unresolved":false,"context_lines":[{"line_number":3080,"context_line":"                # None for snapshots_model_update."},{"line_number":3081,"context_line":"                if not snapshots_model_update:"},{"line_number":3082,"context_line":"                    for snapshot in snapshots:"},{"line_number":3083,"context_line":"                        snapshot.status \u003d fields.CGSnapshotStatus.ERROR"},{"line_number":3084,"context_line":"                        snapshot.save()"},{"line_number":3085,"context_line":""},{"line_number":3086,"context_line":"        for snapshot in snapshots:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da6ed579_e806b484","line":3083,"in_reply_to":"fa69d971_2d0059aa","updated":"2016-02-26 17:54:41.000000000","message":"Done","commit_id":"28b18e18f041b1b67a6aaccfd27f1188d9139e37"}]}