)]}'
{"cinder/volume/drivers/tintri.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6618a5e47ccc36696bfbea74aae0350af81bbe0f","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                    self._ensure_share_mounted(share)"},{"line_number":747,"context_line":"                    mounted_image_shares.append(share)"},{"line_number":748,"context_line":"                except Exception as exc:"},{"line_number":749,"context_line":"                    LOG.error(_LE(\u0027Exception during mounting %s\u0027), exc)"},{"line_number":750,"context_line":"        self._mounted_image_shares \u003d mounted_image_shares"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        # Mount Cinder shares"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_1aa98d90","line":749,"range":{"start_line":749,"start_character":34,"end_line":749,"end_character":64},"updated":"2016-01-04 21:39:36.000000000","message":"This error message is not clear. Recommend \u0027Exception during mounting.  Exception: %s\u0027","commit_id":"f0d202b4a215f60108347f1a731f953019cf12de"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4d99849ebc75c706611bb1f9a0aa1c6c19b30906","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                volume_display_name, volume_id,"},{"line_number":196,"context_line":"                                share\u003dNone, dst\u003dNone, image_id\u003dNone):"},{"line_number":197,"context_line":"        \"\"\"Creates volume snapshot then clones volume.\"\"\""},{"line_number":198,"context_line":"        (_, path) \u003d self._get_export_ip_path(volume_id, share)"},{"line_number":199,"context_line":"        volume_path \u003d \u0027%s/%s\u0027 % (path, volume_name)"},{"line_number":200,"context_line":"        if dst:"},{"line_number":201,"context_line":"            (_, dst_path) \u003d self._get_export_ip_path(None, dst)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_da7ee7e3","line":198,"range":{"start_line":198,"start_character":9,"end_line":198,"end_character":10},"updated":"2016-02-03 18:32:25.000000000","message":"I like the practice of marking a variable as unused, but unfortunately the usual practice of using _ can conflict with the _() translation marker for i18n.\n\nI would recommend either making it _host or __ (two underscores).","commit_id":"0d2cc5a90097671039a056a559563bb955a9d4f5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4d99849ebc75c706611bb1f9a0aa1c6c19b30906","unresolved":false,"context_lines":[{"line_number":746,"context_line":"                    self._ensure_share_mounted(share)"},{"line_number":747,"context_line":"                    mounted_image_shares.append(share)"},{"line_number":748,"context_line":"                except Exception as exc:"},{"line_number":749,"context_line":"                    LOG.error(_LE("},{"line_number":750,"context_line":"                        \u0027Exception during mounting. Exception: %s\u0027), exc)"},{"line_number":751,"context_line":"        self._mounted_image_shares \u003d mounted_image_shares"},{"line_number":752,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_da658745","line":749,"updated":"2016-02-03 18:32:25.000000000","message":"LOG.exception could be used here instead, but this is fine.","commit_id":"0d2cc5a90097671039a056a559563bb955a9d4f5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"83e7232d66e8d584a7fab0d756284f2e1c61cac1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        (__, path) \u003d self._get_export_ip_path(volume_id, share)"},{"line_number":199,"context_line":"        volume_path \u003d \u0027%s/%s\u0027 % (path, volume_name)"},{"line_number":200,"context_line":"        if dst:"},{"line_number":201,"context_line":"            (_, dst_path) \u003d self._get_export_ip_path(None, dst)"},{"line_number":202,"context_line":"            clone_path \u003d \u0027%s/%s-d\u0027 % (dst_path, clone_name)"},{"line_number":203,"context_line":"        else:"},{"line_number":204,"context_line":"            clone_path \u003d \u0027%s/%s-d\u0027 % (path, clone_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_05a91724","line":201,"range":{"start_line":201,"start_character":13,"end_line":201,"end_character":14},"updated":"2016-02-05 14:20:03.000000000","message":"Another instance of using _ that could hide the _() import.","commit_id":"c1972fd3fa7b7e9b153f63b03fa43257509e5085"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"83e7232d66e8d584a7fab0d756284f2e1c61cac1","unresolved":false,"context_lines":[{"line_number":747,"context_line":"                    mounted_image_shares.append(share)"},{"line_number":748,"context_line":"                except Exception as exc:"},{"line_number":749,"context_line":"                    LOG.exception(_LE("},{"line_number":750,"context_line":"                        \u0027Exception during mounting. Exception: %s\u0027), exc)"},{"line_number":751,"context_line":"        self._mounted_image_shares \u003d mounted_image_shares"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # Mount Cinder shares"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_e5515b37","line":750,"range":{"start_line":750,"start_character":62,"end_line":750,"end_character":72},"updated":"2016-02-05 14:20:03.000000000","message":"Don\u0027t pass in exception to LOG.exception. It just picks up whatever exception is in scope, so it is automatic.","commit_id":"c1972fd3fa7b7e9b153f63b03fa43257509e5085"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9fb517e17272498597c1d62ef45e8fa7715fb821","unresolved":false,"context_lines":[{"line_number":58,"context_line":"               default\u003d30,"},{"line_number":59,"context_line":"               help\u003d\u0027Delete unused image snapshots older than mentioned days\u0027),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027tintri_image_shares_config\u0027,"},{"line_number":61,"context_line":"               help\u003d\u0027Image nfs shares\u0027),"},{"line_number":62,"context_line":"]"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_2b1e6563","line":61,"range":{"start_line":61,"start_character":21,"end_line":61,"end_character":37},"updated":"2016-03-01 18:29:00.000000000","message":"This help text isn\u0027t clear.  What is this set to?  A path?  If so suggest:  \"Path to NFS image shares.\"  Or something more descriptive please.","commit_id":"d271a386a157d0752d625a829a439e110962f429"}],"releasenotes/notes/tintri_image_direct_clone-f73e561985aad867.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4d99849ebc75c706611bb1f9a0aa1c6c19b30906","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Fix for Tintri image direct clone feature."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5a5ae5dd_dacca737","line":2,"updated":"2016-02-03 18:32:25.000000000","message":"This is probably better under the bug fixes section.","commit_id":"0d2cc5a90097671039a056a559563bb955a9d4f5"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"d9e925af1993fbf2f72972f270e0f248122a0e41","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fix for Tintri image direct clone feature."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7af24918_c8cb8771","line":3,"updated":"2016-03-01 18:22:42.000000000","message":"Can we try better with the release note here? I read this first before the commit message and this really told me nothing, and will likely not be helpful to an operator reading through.\n\nTake into consideration of the discussion from here:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2016-February/087631.html","commit_id":"d271a386a157d0752d625a829a439e110962f429"}]}