)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add ConsistencyGroupStatus enum field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new enum and field, ConsistencyGroupStatus and"},{"line_number":10,"context_line":"ConsistencyGroupStatusField, that will hold the constants for the \u0027status\u0027"},{"line_number":11,"context_line":"field of the ConsistencyGroup object.  This enum and field are based"},{"line_number":12,"context_line":"off the base oslo.versionedobjects enum and field.  This also changes"},{"line_number":13,"context_line":"over the ConsistencyGroup object to use the new field (and bumps the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a7b0d38_ba3cbac8","line":10,"updated":"2015-12-29 15:45:46.000000000","message":"nit: We\u0027re normally wrapping commit message description at 73 column (and title at 50).","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add ConsistencyGroupStatus enum field"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds a new enum and field, ConsistencyGroupStatus and"},{"line_number":10,"context_line":"ConsistencyGroupStatusField, that will hold the constants for the \u0027status\u0027"},{"line_number":11,"context_line":"field of the ConsistencyGroup object.  This enum and field are based"},{"line_number":12,"context_line":"off the base oslo.versionedobjects enum and field.  This also changes"},{"line_number":13,"context_line":"over the ConsistencyGroup object to use the new field (and bumps the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_d49d815a","line":10,"in_reply_to":"1a7b0d38_ba3cbac8","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"}],"cinder/objects/fields.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4532d03095bbea26511a685ea47c273b13c3ec74","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ERROR \u003d \u0027error\u0027"},{"line_number":48,"context_line":"    AVAILABLE \u003d \u0027available\u0027"},{"line_number":49,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":50,"context_line":"    ACTIVE \u003d \u0027active\u0027"},{"line_number":51,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":52,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":53,"context_line":"    DELETED \u003d \u0027deleted\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_ea08e793","line":50,"updated":"2015-12-29 16:08:02.000000000","message":"Isn\u0027t \u0027active\u0027 actually the same as \u0027available\u0027, but used somewhere in tests by mistake?","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ERROR \u003d \u0027error\u0027"},{"line_number":48,"context_line":"    AVAILABLE \u003d \u0027available\u0027"},{"line_number":49,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":50,"context_line":"    ACTIVE \u003d \u0027active\u0027"},{"line_number":51,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":52,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":53,"context_line":"    DELETED \u003d \u0027deleted\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_74a3759f","line":50,"in_reply_to":"fa69d971_ea08e793","updated":"2015-12-29 22:13:43.000000000","message":"Made those cases \u0027available\u0027","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":53,"context_line":"    DELETED \u003d \u0027deleted\u0027"},{"line_number":54,"context_line":"    UPDATING \u003d \u0027updating\u0027"},{"line_number":55,"context_line":"    WRONG_STATUS \u003d \u0027wrong_status\u0027"},{"line_number":56,"context_line":"    IN_USE \u003d \u0027in-use\u0027"},{"line_number":57,"context_line":"    ERROR_DELETING \u003d \u0027error_deleting\u0027"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_1a706edb","line":55,"updated":"2015-12-29 15:45:46.000000000","message":"This shouldn\u0027t be here - this status is used in tests to indicate a non-available status.","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":53,"context_line":"    DELETED \u003d \u0027deleted\u0027"},{"line_number":54,"context_line":"    UPDATING \u003d \u0027updating\u0027"},{"line_number":55,"context_line":"    WRONG_STATUS \u003d \u0027wrong_status\u0027"},{"line_number":56,"context_line":"    IN_USE \u003d \u0027in-use\u0027"},{"line_number":57,"context_line":"    ERROR_DELETING \u003d \u0027error_deleting\u0027"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_94a06992","line":55,"in_reply_to":"1a7b0d38_1a706edb","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f5cb17790d60062c5f60afd15a33aaa0b71c2386","unresolved":false,"context_lines":[{"line_number":46,"context_line":"class ConsistencyGroupStatus(Enum):"},{"line_number":47,"context_line":"    ERROR \u003d \u0027error\u0027"},{"line_number":48,"context_line":"    AVAILABLE \u003d \u0027available\u0027"},{"line_number":49,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":50,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":51,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":52,"context_line":"    DELETED \u003d \u0027deleted\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_db7b697a","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":23},"updated":"2015-12-30 08:34:21.000000000","message":"I think invalid is also used only in tests.","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"e0513929d065c6f6c20890ca9685e028ae0b327d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"class ConsistencyGroupStatus(Enum):"},{"line_number":47,"context_line":"    ERROR \u003d \u0027error\u0027"},{"line_number":48,"context_line":"    AVAILABLE \u003d \u0027available\u0027"},{"line_number":49,"context_line":"    INVALID \u003d \u0027invalid\u0027"},{"line_number":50,"context_line":"    CREATING \u003d \u0027creating\u0027"},{"line_number":51,"context_line":"    DELETING \u003d \u0027deleting\u0027"},{"line_number":52,"context_line":"    DELETED \u003d \u0027deleted\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_eb21574e","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":23},"in_reply_to":"fa69d971_db7b697a","updated":"2016-01-04 19:31:36.000000000","message":"Good catch!","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"}],"cinder/tests/unit/api/contrib/test_consistencygroups.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        consistencygroup.destroy()"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_update_consistencygroup_empty_parameters(self):"},{"line_number":636,"context_line":"        consistencygroup \u003d (self._create_consistencygroup("},{"line_number":637,"context_line":"            ctxt\u003dself.ctxt,"},{"line_number":638,"context_line":"            status\u003dfields.ConsistencyGroupStatus.AVAILABLE))"},{"line_number":639,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/consistencygroups/%s/update\u0027 %"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_ba6a7ab1","line":636,"range":{"start_line":636,"start_character":27,"end_line":636,"end_character":28},"updated":"2015-12-29 15:45:46.000000000","message":"nit: I don\u0027t think you need to add an additional ( if you\u0027re wrapping after the second (. Same things for a lot occurrences below. It isn\u0027t of course harmful. :)","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        consistencygroup.destroy()"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_update_consistencygroup_empty_parameters(self):"},{"line_number":636,"context_line":"        consistencygroup \u003d (self._create_consistencygroup("},{"line_number":637,"context_line":"            ctxt\u003dself.ctxt,"},{"line_number":638,"context_line":"            status\u003dfields.ConsistencyGroupStatus.AVAILABLE))"},{"line_number":639,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/consistencygroups/%s/update\u0027 %"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_54aaf171","line":636,"range":{"start_line":636,"start_character":27,"end_line":636,"end_character":28},"in_reply_to":"1a7b0d38_ba6a7ab1","updated":"2015-12-29 22:13:43.000000000","message":"Fixed these. Thanks for the suggestion!","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def test_update_consistencygroup_invalid_state(self):"},{"line_number":751,"context_line":"        consistencygroup \u003d self._create_consistencygroup("},{"line_number":752,"context_line":"            status\u003dfields.ConsistencyGroupStatus.WRONG_STATUS,"},{"line_number":753,"context_line":"            ctxt\u003dself.ctxt)"},{"line_number":754,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/consistencygroups/%s/update\u0027 %"},{"line_number":755,"context_line":"                                  consistencygroup.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_1acdceb6","line":752,"updated":"2015-12-29 15:45:46.000000000","message":"Yeah, I think this WRONG_STATUS is used only in tests. I don\u0027t see a point in adding that if it isn\u0027t used besides tests and actually isn\u0027t a \"correct\" CG status.","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"ea9d7b5a58738335c57db396b31140464a821244","unresolved":false,"context_lines":[{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def test_update_consistencygroup_invalid_state(self):"},{"line_number":751,"context_line":"        consistencygroup \u003d self._create_consistencygroup("},{"line_number":752,"context_line":"            status\u003dfields.ConsistencyGroupStatus.WRONG_STATUS,"},{"line_number":753,"context_line":"            ctxt\u003dself.ctxt)"},{"line_number":754,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/consistencygroups/%s/update\u0027 %"},{"line_number":755,"context_line":"                                  consistencygroup.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_de7845fb","line":752,"in_reply_to":"1a7b0d38_1acdceb6","updated":"2015-12-29 18:05:29.000000000","message":"Good catch Michal. You don\u0027t want to have \u0027wrong_status\u0027 in the enum because, well, the status is wrong! It\u0027s up to Cinder to decide whether or not this test is necessary anymore. If it is, I\u0027d just leave it as a string.","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":749,"context_line":""},{"line_number":750,"context_line":"    def test_update_consistencygroup_invalid_state(self):"},{"line_number":751,"context_line":"        consistencygroup \u003d self._create_consistencygroup("},{"line_number":752,"context_line":"            status\u003dfields.ConsistencyGroupStatus.WRONG_STATUS,"},{"line_number":753,"context_line":"            ctxt\u003dself.ctxt)"},{"line_number":754,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/consistencygroups/%s/update\u0027 %"},{"line_number":755,"context_line":"                                  consistencygroup.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_d4b4a1d2","line":752,"in_reply_to":"fa69d971_de7845fb","updated":"2015-12-29 22:13:43.000000000","message":"Per Michal\u0027s suggestion, I just changed these to use another enum value because the test simply wants to fail \"group.status in (\u0027available\u0027,\u0027error\u0027)","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f5cb17790d60062c5f60afd15a33aaa0b71c2386","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_delete_consistencygroup_with_Invalidconsistencygroup(self):"},{"line_number":402,"context_line":"        consistencygroup \u003d self._create_consistencygroup("},{"line_number":403,"context_line":"            status\u003dfields.ConsistencyGroupStatus.INVALID)"},{"line_number":404,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/consistencygroups/%s/delete\u0027 %"},{"line_number":405,"context_line":"                                  consistencygroup.id)"},{"line_number":406,"context_line":"        req.method \u003d \u0027POST\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_bb6f9591","line":403,"range":{"start_line":403,"start_character":49,"end_line":403,"end_character":56},"updated":"2015-12-30 08:34:21.000000000","message":"\u0027in-use\u0027 here makes this test pass, so I think we should get rid of INVALID.","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"e0513929d065c6f6c20890ca9685e028ae0b327d","unresolved":false,"context_lines":[{"line_number":400,"context_line":""},{"line_number":401,"context_line":"    def test_delete_consistencygroup_with_Invalidconsistencygroup(self):"},{"line_number":402,"context_line":"        consistencygroup \u003d self._create_consistencygroup("},{"line_number":403,"context_line":"            status\u003dfields.ConsistencyGroupStatus.INVALID)"},{"line_number":404,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/consistencygroups/%s/delete\u0027 %"},{"line_number":405,"context_line":"                                  consistencygroup.id)"},{"line_number":406,"context_line":"        req.method \u003d \u0027POST\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_6bbb27e6","line":403,"range":{"start_line":403,"start_character":49,"end_line":403,"end_character":56},"in_reply_to":"fa69d971_bb6f9591","updated":"2016-01-04 19:31:36.000000000","message":"Done","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"}],"cinder/tests/unit/objects/test_consistencygroup.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4532d03095bbea26511a685ea47c273b13c3ec74","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def test_save(self, consistencygroup_update):"},{"line_number":70,"context_line":"        consistencygroup \u003d objects.ConsistencyGroup._from_db_object("},{"line_number":71,"context_line":"            self.context, objects.ConsistencyGroup(), fake_consistencygroup)"},{"line_number":72,"context_line":"        consistencygroup.status \u003d fields.ConsistencyGroupStatus.ACTIVE"},{"line_number":73,"context_line":"        consistencygroup.save()"},{"line_number":74,"context_line":"        consistencygroup_update.assert_called_once_with("},{"line_number":75,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_ca2ac3e7","line":72,"updated":"2015-12-29 16:08:02.000000000","message":"Isn\u0027t \u0027active\u0027 here used by mistake and should be \u0027available\u0027?","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    def test_save(self, consistencygroup_update):"},{"line_number":70,"context_line":"        consistencygroup \u003d objects.ConsistencyGroup._from_db_object("},{"line_number":71,"context_line":"            self.context, objects.ConsistencyGroup(), fake_consistencygroup)"},{"line_number":72,"context_line":"        consistencygroup.status \u003d fields.ConsistencyGroupStatus.ACTIVE"},{"line_number":73,"context_line":"        consistencygroup.save()"},{"line_number":74,"context_line":"        consistencygroup_update.assert_called_once_with("},{"line_number":75,"context_line":"            self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_74ca9551","line":72,"in_reply_to":"fa69d971_ca2ac3e7","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"4532d03095bbea26511a685ea47c273b13c3ec74","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        consistencygroup_update.assert_called_once_with("},{"line_number":75,"context_line":"            self.context,"},{"line_number":76,"context_line":"            consistencygroup.id,"},{"line_number":77,"context_line":"            {\u0027status\u0027: fields.ConsistencyGroupStatus.ACTIVE})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @mock.patch(\u0027cinder.db.consistencygroup_destroy\u0027)"},{"line_number":80,"context_line":"    def test_destroy(self, consistencygroup_destroy):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_8a34cb4a","line":77,"updated":"2015-12-29 16:08:02.000000000","message":"ditto","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        consistencygroup_update.assert_called_once_with("},{"line_number":75,"context_line":"            self.context,"},{"line_number":76,"context_line":"            consistencygroup.id,"},{"line_number":77,"context_line":"            {\u0027status\u0027: fields.ConsistencyGroupStatus.ACTIVE})"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @mock.patch(\u0027cinder.db.consistencygroup_destroy\u0027)"},{"line_number":80,"context_line":"    def test_destroy(self, consistencygroup_destroy):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_94c70945","line":77,"in_reply_to":"fa69d971_8a34cb4a","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"}],"cinder/tests/unit/objects/test_fields.py":[{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.coerce_good_values \u003d [(\u0027error\u0027, \u0027error\u0027),"},{"line_number":92,"context_line":"                                   (\u0027available\u0027, \u0027available\u0027),"},{"line_number":93,"context_line":"                                   (\u0027invalid\u0027, \u0027invalid\u0027),"},{"line_number":94,"context_line":"                                   (\u0027active\u0027, \u0027active\u0027),"},{"line_number":95,"context_line":"                                   (\u0027creating\u0027, \u0027creating\u0027),"},{"line_number":96,"context_line":"                                   (\u0027deleting\u0027, \u0027deleting\u0027),"},{"line_number":97,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_14e239d6","line":94,"range":{"start_line":94,"start_character":34,"end_line":94,"end_character":56},"updated":"2015-12-29 22:13:43.000000000","message":"Also removed this section (as it isn\u0027t a valid value anymore)","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                   (\u0027deleting\u0027, \u0027deleting\u0027),"},{"line_number":97,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"},{"line_number":98,"context_line":"                                   (\u0027updating\u0027, \u0027updating\u0027),"},{"line_number":99,"context_line":"                                   (\u0027wrong_status\u0027, \u0027wrong_status\u0027),"},{"line_number":100,"context_line":"                                   (\u0027in-use\u0027, \u0027in-use\u0027),"},{"line_number":101,"context_line":"                                   (\u0027error_deleting\u0027, \u0027error_deleting\u0027)]"},{"line_number":102,"context_line":"        self.coerce_bad_values \u003d [\u0027acme\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_da4ae625","line":99,"updated":"2015-12-29 15:45:46.000000000","message":"I don\u0027t think a status used only in tests should be here.","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                   (\u0027deleting\u0027, \u0027deleting\u0027),"},{"line_number":97,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"},{"line_number":98,"context_line":"                                   (\u0027updating\u0027, \u0027updating\u0027),"},{"line_number":99,"context_line":"                                   (\u0027wrong_status\u0027, \u0027wrong_status\u0027),"},{"line_number":100,"context_line":"                                   (\u0027in-use\u0027, \u0027in-use\u0027),"},{"line_number":101,"context_line":"                                   (\u0027error_deleting\u0027, \u0027error_deleting\u0027)]"},{"line_number":102,"context_line":"        self.coerce_bad_values \u003d [\u0027acme\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_34c41d3f","line":99,"in_reply_to":"1a7b0d38_da4ae625","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f5cb17790d60062c5f60afd15a33aaa0b71c2386","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.field \u003d fields.ConsistencyGroupStatusField()"},{"line_number":91,"context_line":"        self.coerce_good_values \u003d [(\u0027error\u0027, \u0027error\u0027),"},{"line_number":92,"context_line":"                                   (\u0027available\u0027, \u0027available\u0027),"},{"line_number":93,"context_line":"                                   (\u0027invalid\u0027, \u0027invalid\u0027),"},{"line_number":94,"context_line":"                                   (\u0027creating\u0027, \u0027creating\u0027),"},{"line_number":95,"context_line":"                                   (\u0027deleting\u0027, \u0027deleting\u0027),"},{"line_number":96,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_381deb73","line":93,"range":{"start_line":93,"start_character":36,"end_line":93,"end_character":56},"updated":"2015-12-30 08:34:21.000000000","message":"Ah, I haven\u0027t noticed this one! This seems to be similar story like \u0027wrong_status\u0027…","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"e0513929d065c6f6c20890ca9685e028ae0b327d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        self.field \u003d fields.ConsistencyGroupStatusField()"},{"line_number":91,"context_line":"        self.coerce_good_values \u003d [(\u0027error\u0027, \u0027error\u0027),"},{"line_number":92,"context_line":"                                   (\u0027available\u0027, \u0027available\u0027),"},{"line_number":93,"context_line":"                                   (\u0027invalid\u0027, \u0027invalid\u0027),"},{"line_number":94,"context_line":"                                   (\u0027creating\u0027, \u0027creating\u0027),"},{"line_number":95,"context_line":"                                   (\u0027deleting\u0027, \u0027deleting\u0027),"},{"line_number":96,"context_line":"                                   (\u0027deleted\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_8bbe9bd2","line":93,"range":{"start_line":93,"start_character":36,"end_line":93,"end_character":56},"in_reply_to":"fa69d971_381deb73","updated":"2016-01-04 19:31:36.000000000","message":"Done","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"}],"cinder/tests/unit/test_emc_vmax.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":3603,"context_line":"                self.data.test_CG_snapshot, snapshots))"},{"line_number":3604,"context_line":"        self.assertEqual({\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE},"},{"line_number":3605,"context_line":"                         model_update)"},{"line_number":3606,"context_line":"        self.assertEqual([{\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE,"},{"line_number":3607,"context_line":"                           \u0027id\u0027: \u00272\u0027}],"},{"line_number":3608,"context_line":"                         volumes_model_update)"},{"line_number":3609,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_1a12ae09","line":3606,"updated":"2015-12-29 15:45:46.000000000","message":"This is tested against volumes_model_update, so technically this isn\u0027t a CG status.","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":3603,"context_line":"                self.data.test_CG_snapshot, snapshots))"},{"line_number":3604,"context_line":"        self.assertEqual({\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE},"},{"line_number":3605,"context_line":"                         model_update)"},{"line_number":3606,"context_line":"        self.assertEqual([{\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE,"},{"line_number":3607,"context_line":"                           \u0027id\u0027: \u00272\u0027}],"},{"line_number":3608,"context_line":"                         volumes_model_update)"},{"line_number":3609,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_b4e6cde6","line":3606,"in_reply_to":"1a7b0d38_1a12ae09","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"}],"cinder/tests/unit/test_gpfs.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"        group \u003d self._fake_group()"},{"line_number":1680,"context_line":"        group[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.AVAILABLE"},{"line_number":1681,"context_line":"        volume \u003d self._fake_volume()"},{"line_number":1682,"context_line":"        volume[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.AVAILABLE"},{"line_number":1683,"context_line":"        volumes \u003d []"},{"line_number":1684,"context_line":"        volumes.append(volume)"},{"line_number":1685,"context_line":"        self.driver.db \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_7a18921e","line":1682,"updated":"2015-12-29 15:45:46.000000000","message":"That\u0027s a volume status, shouldn\u0027t be taken from CGs status enum.","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"        group \u003d self._fake_group()"},{"line_number":1680,"context_line":"        group[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.AVAILABLE"},{"line_number":1681,"context_line":"        volume \u003d self._fake_volume()"},{"line_number":1682,"context_line":"        volume[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.AVAILABLE"},{"line_number":1683,"context_line":"        volumes \u003d []"},{"line_number":1684,"context_line":"        volumes.append(volume)"},{"line_number":1685,"context_line":"        self.driver.db \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_74d135fb","line":1682,"in_reply_to":"1a7b0d38_7a18921e","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"}],"cinder/tests/unit/test_ibm_xiv_ds8k.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"b1a662cc880554211c438a4edd3121342e3bb566","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                    raise exception.VolumeBackendAPIException("},{"line_number":216,"context_line":"                        message\u003d\u0027Volume can not be deleted\u0027)"},{"line_number":217,"context_line":"                else:"},{"line_number":218,"context_line":"                    volume[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.DELETED"},{"line_number":219,"context_line":"                    volumes.append(volume)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Delete snapshots in consistency group"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_fab1e201","line":218,"updated":"2015-12-29 15:45:46.000000000","message":"That\u0027s volume status, not a CG one.","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"d42c17b1b3f26f9c97f627aeb73392ac6fe90c49","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                    raise exception.VolumeBackendAPIException("},{"line_number":216,"context_line":"                        message\u003d\u0027Volume can not be deleted\u0027)"},{"line_number":217,"context_line":"                else:"},{"line_number":218,"context_line":"                    volume[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.DELETED"},{"line_number":219,"context_line":"                    volumes.append(volume)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        # Delete snapshots in consistency group"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_94ce2959","line":218,"in_reply_to":"1a7b0d38_fab1e201","updated":"2015-12-29 22:13:43.000000000","message":"Done","commit_id":"262507d6295d7e406f261589f81c5ecd71b29d94"}],"cinder/tests/unit/test_storwize_svc.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":2651,"context_line":"        cg \u003d self._create_consistencygroup_in_db(**kwargs)"},{"line_number":2652,"context_line":""},{"line_number":2653,"context_line":"        model_update \u003d self.driver.create_consistencygroup(self.ctxt, cg)"},{"line_number":2654,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":2655,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":2656,"context_line":"                         \"CG created failed\")"},{"line_number":2657,"context_line":"        return cg"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_68ed6224","line":2654,"range":{"start_line":2654,"start_character":25,"end_line":2654,"end_character":37},"updated":"2016-01-04 21:17:36.000000000","message":"New occurrence…","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":2651,"context_line":"        cg \u003d self._create_consistencygroup_in_db(**kwargs)"},{"line_number":2652,"context_line":""},{"line_number":2653,"context_line":"        model_update \u003d self.driver.create_consistencygroup(self.ctxt, cg)"},{"line_number":2654,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":2655,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":2656,"context_line":"                         \"CG created failed\")"},{"line_number":2657,"context_line":"        return cg"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_36bfa1ab","line":2654,"range":{"start_line":2654,"start_character":25,"end_line":2654,"end_character":37},"in_reply_to":"fa69d971_68ed6224","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3830,"context_line":""},{"line_number":3831,"context_line":"        model_update \u003d self.driver.delete_consistencygroup(self.ctxt, cg, [])"},{"line_number":3832,"context_line":""},{"line_number":3833,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3834,"context_line":"        for volume in model_update[1]:"},{"line_number":3835,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3836,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_5641f5a7","line":3833,"range":{"start_line":3833,"start_character":26,"end_line":3833,"end_character":33},"updated":"2016-01-05 19:47:40.000000000","message":"Will change this in the new patch as well.","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3891,"context_line":""},{"line_number":3892,"context_line":"        model_update \u003d self.driver.delete_consistencygroup(self.ctxt, cg, [])"},{"line_number":3893,"context_line":""},{"line_number":3894,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3895,"context_line":"        for volume in model_update[1]:"},{"line_number":3896,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3897,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_164cddc6","line":3894,"range":{"start_line":3894,"start_character":26,"end_line":3894,"end_character":33},"updated":"2016-01-05 19:47:40.000000000","message":"Changing this as well.","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        model_update \u003d ("},{"line_number":3899,"context_line":"            self.driver.delete_consistencygroup(self.ctxt, source_cg, []))"},{"line_number":3900,"context_line":""},{"line_number":3901,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3902,"context_line":"        for volume in model_update[1]:"},{"line_number":3903,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3904,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_28ce8ab4","line":3901,"range":{"start_line":3901,"start_character":25,"end_line":3901,"end_character":35},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"        model_update \u003d ("},{"line_number":3899,"context_line":"            self.driver.delete_consistencygroup(self.ctxt, source_cg, []))"},{"line_number":3900,"context_line":""},{"line_number":3901,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3902,"context_line":"        for volume in model_update[1]:"},{"line_number":3903,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3904,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_56dd75de","line":3901,"range":{"start_line":3901,"start_character":25,"end_line":3901,"end_character":35},"in_reply_to":"fa69d971_28ce8ab4","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3905,"context_line":"        model_update \u003d ("},{"line_number":3906,"context_line":"            self.driver.delete_consistencygroup(self.ctxt, cgsnapshot, []))"},{"line_number":3907,"context_line":""},{"line_number":3908,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3909,"context_line":"        for volume in model_update[1]:"},{"line_number":3910,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3911,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_e8c0727e","line":3908,"range":{"start_line":3908,"start_character":25,"end_line":3908,"end_character":35},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3905,"context_line":"        model_update \u003d ("},{"line_number":3906,"context_line":"            self.driver.delete_consistencygroup(self.ctxt, cgsnapshot, []))"},{"line_number":3907,"context_line":""},{"line_number":3908,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3909,"context_line":"        for volume in model_update[1]:"},{"line_number":3910,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3911,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_d632c50f","line":3908,"range":{"start_line":3908,"start_character":25,"end_line":3908,"end_character":35},"in_reply_to":"fa69d971_e8c0727e","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3946,"context_line":"                                                         None, None,"},{"line_number":3947,"context_line":"                                                         source_cg,"},{"line_number":3948,"context_line":"                                                         source_vols))"},{"line_number":3949,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":3950,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":3951,"context_line":"                         \"CG create from src created failed\")"},{"line_number":3952,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_28452a16","line":3949,"range":{"start_line":3949,"start_character":25,"end_line":3949,"end_character":36},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3956,"context_line":"                                                           cg,"},{"line_number":3957,"context_line":"                                                           [])"},{"line_number":3958,"context_line":""},{"line_number":3959,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3960,"context_line":"        for each_vol in model_update[1]:"},{"line_number":3961,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":3962,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_a8511ada","line":3959,"range":{"start_line":3959,"start_character":25,"end_line":3959,"end_character":34},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3956,"context_line":"                                                           cg,"},{"line_number":3957,"context_line":"                                                           [])"},{"line_number":3958,"context_line":""},{"line_number":3959,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3960,"context_line":"        for each_vol in model_update[1]:"},{"line_number":3961,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":3962,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_b1063b1a","line":3959,"range":{"start_line":3959,"start_character":25,"end_line":3959,"end_character":34},"in_reply_to":"fa69d971_a8511ada","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3968,"context_line":"                                                         cgsnapshot,"},{"line_number":3969,"context_line":"                                                         snapshots,"},{"line_number":3970,"context_line":"                                                         None, None))"},{"line_number":3971,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":3972,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":3973,"context_line":"                         \"CG create from src created failed\")"},{"line_number":3974,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_686242af","line":3971,"range":{"start_line":3971,"start_character":25,"end_line":3971,"end_character":36},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3968,"context_line":"                                                         cgsnapshot,"},{"line_number":3969,"context_line":"                                                         snapshots,"},{"line_number":3970,"context_line":"                                                         None, None))"},{"line_number":3971,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":3972,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":3973,"context_line":"                         \"CG create from src created failed\")"},{"line_number":3974,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_7115233e","line":3971,"range":{"start_line":3971,"start_character":25,"end_line":3971,"end_character":36},"in_reply_to":"fa69d971_686242af","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3978,"context_line":"        model_update \u003d self.driver.delete_consistencygroup(self.ctxt,"},{"line_number":3979,"context_line":"                                                           cg, [])"},{"line_number":3980,"context_line":""},{"line_number":3981,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3982,"context_line":"        for each_vol in model_update[1]:"},{"line_number":3983,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":3984,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_085946fe","line":3981,"range":{"start_line":3981,"start_character":25,"end_line":3981,"end_character":34},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3978,"context_line":"        model_update \u003d self.driver.delete_consistencygroup(self.ctxt,"},{"line_number":3979,"context_line":"                                                           cg, [])"},{"line_number":3980,"context_line":""},{"line_number":3981,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3982,"context_line":"        for each_vol in model_update[1]:"},{"line_number":3983,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":3984,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_91121756","line":3981,"range":{"start_line":3981,"start_character":25,"end_line":3981,"end_character":34},"in_reply_to":"fa69d971_085946fe","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3986,"context_line":"                                                           cgsnapshot,"},{"line_number":3987,"context_line":"                                                           [])"},{"line_number":3988,"context_line":""},{"line_number":3989,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3990,"context_line":"        for volume in model_update[1]:"},{"line_number":3991,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3992,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_a8683a88","line":3989,"range":{"start_line":3989,"start_character":25,"end_line":3989,"end_character":34},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3986,"context_line":"                                                           cgsnapshot,"},{"line_number":3987,"context_line":"                                                           [])"},{"line_number":3988,"context_line":""},{"line_number":3989,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3990,"context_line":"        for volume in model_update[1]:"},{"line_number":3991,"context_line":"            self.assertEqual(\u0027deleted\u0027, volume[\u0027status\u0027])"},{"line_number":3992,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_31324bf3","line":3989,"range":{"start_line":3989,"start_character":25,"end_line":3989,"end_character":34},"in_reply_to":"fa69d971_a8683a88","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":3994,"context_line":"                                                           source_cg,"},{"line_number":3995,"context_line":"                                                           [])"},{"line_number":3996,"context_line":""},{"line_number":3997,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3998,"context_line":"        for each_vol in model_update[1]:"},{"line_number":3999,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":4000,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_48065ecf","line":3997,"range":{"start_line":3997,"start_character":25,"end_line":3997,"end_character":34},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":3994,"context_line":"                                                           source_cg,"},{"line_number":3995,"context_line":"                                                           [])"},{"line_number":3996,"context_line":""},{"line_number":3997,"context_line":"        self.assertEqual(\u0027deleted\u0027, model_update[0][\u0027status\u0027])"},{"line_number":3998,"context_line":"        for each_vol in model_update[1]:"},{"line_number":3999,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":4000,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_3149eb60","line":3997,"range":{"start_line":3997,"start_character":25,"end_line":3997,"end_character":34},"in_reply_to":"fa69d971_48065ecf","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f5cb17790d60062c5f60afd15a33aaa0b71c2386","unresolved":false,"context_lines":[{"line_number":5089,"context_line":"        fake_update_cg.return_value \u003d ("},{"line_number":5090,"context_line":"            {\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE},"},{"line_number":5091,"context_line":"            [{\u0027id\u0027: volume_id2, \u0027status\u0027: ("},{"line_number":5092,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}],"},{"line_number":5093,"context_line":"            [{\u0027id\u0027: volume_id, \u0027status\u0027: ("},{"line_number":5094,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}])"},{"line_number":5095,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_7b311dec","line":5092,"updated":"2015-12-30 08:34:21.000000000","message":"This is a volume status, not a CG one.","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"e0513929d065c6f6c20890ca9685e028ae0b327d","unresolved":false,"context_lines":[{"line_number":5089,"context_line":"        fake_update_cg.return_value \u003d ("},{"line_number":5090,"context_line":"            {\u0027status\u0027: fields.ConsistencyGroupStatus.AVAILABLE},"},{"line_number":5091,"context_line":"            [{\u0027id\u0027: volume_id2, \u0027status\u0027: ("},{"line_number":5092,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}],"},{"line_number":5093,"context_line":"            [{\u0027id\u0027: volume_id, \u0027status\u0027: ("},{"line_number":5094,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}])"},{"line_number":5095,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_0bf62bd7","line":5092,"in_reply_to":"fa69d971_7b311dec","updated":"2016-01-04 19:31:36.000000000","message":"reverted","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f5cb17790d60062c5f60afd15a33aaa0b71c2386","unresolved":false,"context_lines":[{"line_number":5091,"context_line":"            [{\u0027id\u0027: volume_id2, \u0027status\u0027: ("},{"line_number":5092,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}],"},{"line_number":5093,"context_line":"            [{\u0027id\u0027: volume_id, \u0027status\u0027: ("},{"line_number":5094,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}])"},{"line_number":5095,"context_line":""},{"line_number":5096,"context_line":"        self.volume.update_consistencygroup(self.context, group,"},{"line_number":5097,"context_line":"                                            add_volumes\u003dvolume_id2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_3b52c514","line":5094,"updated":"2015-12-30 08:34:21.000000000","message":"ditto","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"e0513929d065c6f6c20890ca9685e028ae0b327d","unresolved":false,"context_lines":[{"line_number":5091,"context_line":"            [{\u0027id\u0027: volume_id2, \u0027status\u0027: ("},{"line_number":5092,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}],"},{"line_number":5093,"context_line":"            [{\u0027id\u0027: volume_id, \u0027status\u0027: ("},{"line_number":5094,"context_line":"                fields.ConsistencyGroupStatus.AVAILABLE)}])"},{"line_number":5095,"context_line":""},{"line_number":5096,"context_line":"        self.volume.update_consistencygroup(self.context, group,"},{"line_number":5097,"context_line":"                                            add_volumes\u003dvolume_id2,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_ab04bfbf","line":5094,"in_reply_to":"fa69d971_3b52c514","updated":"2016-01-04 19:31:36.000000000","message":"Done","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"        LOG.debug(\u0027Enter: create_cg_from_source: cg %(cg)s\u0027"},{"line_number":1218,"context_line":"                  \u0027 source %(source)s, target %(target)s\u0027,"},{"line_number":1219,"context_line":"                  {\u0027cg\u0027: fc_consistgrp, \u0027source\u0027: sources, \u0027target\u0027: targets})"},{"line_number":1220,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1221,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":1222,"context_line":"        try:"},{"line_number":1223,"context_line":"            for source, target in zip(sources, targets):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_08270665","line":1220,"range":{"start_line":1220,"start_character":34,"end_line":1220,"end_character":45},"updated":"2016-01-04 21:17:36.000000000","message":"New occurrence.","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"        LOG.debug(\u0027Enter: create_cg_from_source: cg %(cg)s\u0027"},{"line_number":1218,"context_line":"                  \u0027 source %(source)s, target %(target)s\u0027,"},{"line_number":1219,"context_line":"                  {\u0027cg\u0027: fc_consistgrp, \u0027source\u0027: sources, \u0027target\u0027: targets})"},{"line_number":1220,"context_line":"        model_update \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":1221,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":1222,"context_line":"        try:"},{"line_number":1223,"context_line":"            for source, target in zip(sources, targets):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_36a80177","line":1220,"range":{"start_line":1220,"start_character":34,"end_line":1220,"end_character":45},"in_reply_to":"fa69d971_08270665","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"afafe261bbea5a7f2dd99bc0c1799a5eb21bc8bf","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":1235,"context_line":"                ctxt, targets, group[\u0027id\u0027], model_update[\u0027status\u0027])"},{"line_number":1236,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1237,"context_line":"            model_update[\u0027status\u0027] \u003d \u0027error\u0027"},{"line_number":1238,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":1239,"context_line":"                ctxt, targets, group[\u0027id\u0027], model_update[\u0027status\u0027])"},{"line_number":1240,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_e81cf214","line":1237,"range":{"start_line":1237,"start_character":37,"end_line":1237,"end_character":44},"updated":"2016-01-04 21:17:36.000000000","message":"ditto","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"477f9e1a8ea5ad5fb681a48abbf3c43d2138a477","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":1235,"context_line":"                ctxt, targets, group[\u0027id\u0027], model_update[\u0027status\u0027])"},{"line_number":1236,"context_line":"        except exception.VolumeBackendAPIException as err:"},{"line_number":1237,"context_line":"            model_update[\u0027status\u0027] \u003d \u0027error\u0027"},{"line_number":1238,"context_line":"            volumes_model_update \u003d self._get_volume_model_updates("},{"line_number":1239,"context_line":"                ctxt, targets, group[\u0027id\u0027], model_update[\u0027status\u0027])"},{"line_number":1240,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_f6bca9bc","line":1237,"range":{"start_line":1237,"start_character":37,"end_line":1237,"end_character":44},"in_reply_to":"fa69d971_e81cf214","updated":"2016-01-05 19:47:40.000000000","message":"Done","commit_id":"3525f51588c40a3fd92ea3cf51c5cab30782c4a8"}],"cinder/volume/manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"f5cb17790d60062c5f60afd15a33aaa0b71c2386","unresolved":false,"context_lines":[{"line_number":2386,"context_line":"                                                               group)"},{"line_number":2387,"context_line":""},{"line_number":2388,"context_line":"            if model_update:"},{"line_number":2389,"context_line":"                if model_update[\u0027status\u0027] \u003d\u003d ("},{"line_number":2390,"context_line":"                        fields.ConsistencyGroupStatus.ERROR):"},{"line_number":2391,"context_line":"                    msg \u003d (_(\u0027Create consistency group failed.\u0027))"},{"line_number":2392,"context_line":"                    LOG.error(msg,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_fba98de0","line":2389,"range":{"start_line":2389,"start_character":45,"end_line":2389,"end_character":46},"updated":"2015-12-30 08:34:21.000000000","message":"I would move that opening parentheses just after if. That\u0027s nothing harmful though.","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"a44cea1b0fcf2bff6f9d251ccfe621f1f1b6453a","unresolved":false,"context_lines":[{"line_number":2386,"context_line":"                                                               group)"},{"line_number":2387,"context_line":""},{"line_number":2388,"context_line":"            if model_update:"},{"line_number":2389,"context_line":"                if model_update[\u0027status\u0027] \u003d\u003d ("},{"line_number":2390,"context_line":"                        fields.ConsistencyGroupStatus.ERROR):"},{"line_number":2391,"context_line":"                    msg \u003d (_(\u0027Create consistency group failed.\u0027))"},{"line_number":2392,"context_line":"                    LOG.error(msg,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_ed08842f","line":2389,"range":{"start_line":2389,"start_character":45,"end_line":2389,"end_character":46},"in_reply_to":"fa69d971_8b93fb4e","updated":"2016-01-04 21:07:22.000000000","message":"But\n\n                if (model_update[\u0027status\u0027] \u003d\u003d\n                    fields.ConsistencyGroupStatus.ERROR):\n\nshould be fine. That\u0027s nothing blocking of course. :)","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"},{"author":{"_account_id":18479,"name":"Slade Baumann","email":"baumann@us.ibm.com","username":"baumann"},"change_message_id":"e0513929d065c6f6c20890ca9685e028ae0b327d","unresolved":false,"context_lines":[{"line_number":2386,"context_line":"                                                               group)"},{"line_number":2387,"context_line":""},{"line_number":2388,"context_line":"            if model_update:"},{"line_number":2389,"context_line":"                if model_update[\u0027status\u0027] \u003d\u003d ("},{"line_number":2390,"context_line":"                        fields.ConsistencyGroupStatus.ERROR):"},{"line_number":2391,"context_line":"                    msg \u003d (_(\u0027Create consistency group failed.\u0027))"},{"line_number":2392,"context_line":"                    LOG.error(msg,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_8b93fb4e","line":2389,"range":{"start_line":2389,"start_character":45,"end_line":2389,"end_character":46},"in_reply_to":"fa69d971_fba98de0","updated":"2016-01-04 19:31:36.000000000","message":"I\u0027m going to leave this one for now I think. If I try to put the parentheses after the \"if\", the line still spills over the pep8 limit (as far as I can tell). But I could be missing something there.","commit_id":"702b89bb6f624157d3d5691e0e1ce9458f7c6d44"}]}