)]}'
{"bin/cinder-manage":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"43ba249b3d55e7edbfe54cb5ea166d268772c53c","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":657,"context_line":"        backups \u003d db.backup_get_all(ctxt)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        hdr \u003d \"%-32s\\t%-32s\\t%-32s\\t%-24s\\t%-24s\\t%-12s\\t%-12s\\t%-12s\\t%-12s\""},{"line_number":660,"context_line":"        print hdr % (_(\u0027ID\u0027),"},{"line_number":661,"context_line":"                     _(\u0027User ID\u0027),"},{"line_number":662,"context_line":"                     _(\u0027Project ID\u0027),"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOX%2F%2F59Y%3D","line":659,"updated":"2013-04-08 08:16:35.000000000","message":"This change looks like is not related to this commit. Adding info about this change to commit message, or having this change in a separate patch would be good I think.","commit_id":"d53af833fe52e18e1b59c0fb9f762268aac69445"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"f0aca8e0f62a0a7106fe32f10d90bf311c383884","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":657,"context_line":"        backups \u003d db.backup_get_all(ctxt)"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        hdr \u003d \"%-32s\\t%-32s\\t%-32s\\t%-24s\\t%-24s\\t%-12s\\t%-12s\\t%-12s\\t%-12s\""},{"line_number":660,"context_line":"        print hdr % (_(\u0027ID\u0027),"},{"line_number":661,"context_line":"                     _(\u0027User ID\u0027),"},{"line_number":662,"context_line":"                     _(\u0027Project ID\u0027),"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOX%2F%2F57Q%3D","line":659,"in_reply_to":"AAAAOX%2F%2F59Y%3D","updated":"2013-04-08 08:57:58.000000000","message":"Its from another change submitted separately, will remove from here","commit_id":"d53af833fe52e18e1b59c0fb9f762268aac69445"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"43ba249b3d55e7edbfe54cb5ea166d268772c53c","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        Show a list of all running services."},{"line_number":691,"context_line":"        \"\"\""},{"line_number":692,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":693,"context_line":"        now \u003d timeutils.utcnow()"},{"line_number":694,"context_line":"        services \u003d db.service_get_all(ctxt)"},{"line_number":695,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-5s %-10s\""},{"line_number":696,"context_line":"        print print_format % ("}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOX%2F%2F59c%3D","line":693,"updated":"2013-04-08 08:16:35.000000000","message":"Variable \u0027now\u0027 not used","commit_id":"d53af833fe52e18e1b59c0fb9f762268aac69445"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"f0aca8e0f62a0a7106fe32f10d90bf311c383884","unresolved":false,"context_lines":[{"line_number":690,"context_line":"        Show a list of all running services."},{"line_number":691,"context_line":"        \"\"\""},{"line_number":692,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":693,"context_line":"        now \u003d timeutils.utcnow()"},{"line_number":694,"context_line":"        services \u003d db.service_get_all(ctxt)"},{"line_number":695,"context_line":"        print_format \u003d \"%-16s %-36s %-16s %-10s %-5s %-10s\""},{"line_number":696,"context_line":"        print print_format % ("}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAOX%2F%2F57I%3D","line":693,"in_reply_to":"AAAAOX%2F%2F59c%3D","updated":"2013-04-08 08:57:58.000000000","message":"Removed","commit_id":"d53af833fe52e18e1b59c0fb9f762268aac69445"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"80c6341bc20f0ed47a41112f65841283ef55c3ee","unresolved":false,"context_lines":[{"line_number":84,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":85,"context_line":"from cinder.openstack.common import rpc"},{"line_number":86,"context_line":"from cinder.openstack.common import uuidutils"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"from cinder import utils"},{"line_number":89,"context_line":"from cinder import version"},{"line_number":90,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAOX%2F%2F50M%3D","line":87,"updated":"2013-04-08 11:25:34.000000000","message":"Blank line?","commit_id":"1c00f95fbb160a776c1466b3e64a82628157b0bb"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"9a4c938b2d2cae89722ced68975ec27ea804dc21","unresolved":false,"context_lines":[{"line_number":84,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":85,"context_line":"from cinder.openstack.common import rpc"},{"line_number":86,"context_line":"from cinder.openstack.common import uuidutils"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"from cinder import utils"},{"line_number":89,"context_line":"from cinder import version"},{"line_number":90,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAOX%2F%2F5x4%3D","line":87,"in_reply_to":"AAAAOX%2F%2F50M%3D","updated":"2013-04-08 12:27:25.000000000","message":"Done","commit_id":"1c00f95fbb160a776c1466b3e64a82628157b0bb"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"8db15761c0d8f9200a5dabf1bd15db36132674bf","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    \"\"\"Methods for managing services.\"\"\""},{"line_number":686,"context_line":"    def list(self):"},{"line_number":687,"context_line":"        \"\"\""},{"line_number":688,"context_line":"        Show a list of all running services."},{"line_number":689,"context_line":"        \"\"\""},{"line_number":690,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":691,"context_line":"        services \u003d db.service_get_all(ctxt)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2B%2Bk%3D","line":688,"updated":"2013-04-09 05:44:29.000000000","message":"docstring needs to follow HACKING","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"eea9ed3d95d6bc83904f10c3a2e8a08a438087f5","unresolved":false,"context_lines":[{"line_number":685,"context_line":"    \"\"\"Methods for managing services.\"\"\""},{"line_number":686,"context_line":"    def list(self):"},{"line_number":687,"context_line":"        \"\"\""},{"line_number":688,"context_line":"        Show a list of all running services."},{"line_number":689,"context_line":"        \"\"\""},{"line_number":690,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":691,"context_line":"        services \u003d db.service_get_all(ctxt)"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2B3o%3D","line":688,"in_reply_to":"AAAAOn%2F%2F%2B%2Bk%3D","updated":"2013-04-09 08:14:31.000000000","message":"Done","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3386916f60ec8a7430f052796f51884ed37c4407","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                    _(\u0027Updated_At\u0027))"},{"line_number":700,"context_line":"        for svc in services:"},{"line_number":701,"context_line":"            alive \u003d utils.service_is_up(svc)"},{"line_number":702,"context_line":"            art \u003d (alive and \":-)\") or \"XXX\""},{"line_number":703,"context_line":"            active \u003d \u0027enabled\u0027"},{"line_number":704,"context_line":"            if svc[\u0027disabled\u0027]:"},{"line_number":705,"context_line":"                active \u003d \u0027disabled\u0027"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2FhI%3D","line":702,"updated":"2013-04-08 22:12:19.000000000","message":"I\u0027d prefer something like\n\nart \u003d \":-)\" if alive else \"XXX\"\n\nfor readability.  That\u0027s a lot easier to parse IMO.","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"eea9ed3d95d6bc83904f10c3a2e8a08a438087f5","unresolved":false,"context_lines":[{"line_number":699,"context_line":"                    _(\u0027Updated_At\u0027))"},{"line_number":700,"context_line":"        for svc in services:"},{"line_number":701,"context_line":"            alive \u003d utils.service_is_up(svc)"},{"line_number":702,"context_line":"            art \u003d (alive and \":-)\") or \"XXX\""},{"line_number":703,"context_line":"            active \u003d \u0027enabled\u0027"},{"line_number":704,"context_line":"            if svc[\u0027disabled\u0027]:"},{"line_number":705,"context_line":"                active \u003d \u0027disabled\u0027"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2B3k%3D","line":702,"in_reply_to":"AAAAOn%2F%2F%2FhI%3D","updated":"2013-04-09 08:14:31.000000000","message":"Done","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3386916f60ec8a7430f052796f51884ed37c4407","unresolved":false,"context_lines":[{"line_number":700,"context_line":"        for svc in services:"},{"line_number":701,"context_line":"            alive \u003d utils.service_is_up(svc)"},{"line_number":702,"context_line":"            art \u003d (alive and \":-)\") or \"XXX\""},{"line_number":703,"context_line":"            active \u003d \u0027enabled\u0027"},{"line_number":704,"context_line":"            if svc[\u0027disabled\u0027]:"},{"line_number":705,"context_line":"                active \u003d \u0027disabled\u0027"},{"line_number":706,"context_line":"            print print_format % (svc[\u0027binary\u0027], svc[\u0027host\u0027].partition(\u0027.\u0027)[0],"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2FhE%3D","line":703,"updated":"2013-04-08 22:12:19.000000000","message":"Safer to default to disabled?  Not sure, just a thought.","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"eea9ed3d95d6bc83904f10c3a2e8a08a438087f5","unresolved":false,"context_lines":[{"line_number":700,"context_line":"        for svc in services:"},{"line_number":701,"context_line":"            alive \u003d utils.service_is_up(svc)"},{"line_number":702,"context_line":"            art \u003d (alive and \":-)\") or \"XXX\""},{"line_number":703,"context_line":"            active \u003d \u0027enabled\u0027"},{"line_number":704,"context_line":"            if svc[\u0027disabled\u0027]:"},{"line_number":705,"context_line":"                active \u003d \u0027disabled\u0027"},{"line_number":706,"context_line":"            print print_format % (svc[\u0027binary\u0027], svc[\u0027host\u0027].partition(\u0027.\u0027)[0],"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2B3U%3D","line":703,"in_reply_to":"AAAAOn%2F%2F%2FhE%3D","updated":"2013-04-09 08:14:31.000000000","message":"Not sure about this one, if you feel strongly about it ping it again but I think it\u0027ll reduce readability of the check if anything.","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"8db15761c0d8f9200a5dabf1bd15db36132674bf","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            art \u003d (alive and \":-)\") or \"XXX\""},{"line_number":703,"context_line":"            active \u003d \u0027enabled\u0027"},{"line_number":704,"context_line":"            if svc[\u0027disabled\u0027]:"},{"line_number":705,"context_line":"                active \u003d \u0027disabled\u0027"},{"line_number":706,"context_line":"            print print_format % (svc[\u0027binary\u0027], svc[\u0027host\u0027].partition(\u0027.\u0027)[0],"},{"line_number":707,"context_line":"                                  svc[\u0027availability_zone\u0027], active, art,"},{"line_number":708,"context_line":"                                  svc[\u0027updated_at\u0027])"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2B%2Bg%3D","line":705,"updated":"2013-04-09 05:44:29.000000000","message":"can we call this status? active and disabled just conflict. :)","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"},{"author":{"_account_id":6153,"name":"stephen-mulcahy","email":"stephen.mulcahy@hpe.com","username":"stephen-mulcahy"},"change_message_id":"eea9ed3d95d6bc83904f10c3a2e8a08a438087f5","unresolved":false,"context_lines":[{"line_number":702,"context_line":"            art \u003d (alive and \":-)\") or \"XXX\""},{"line_number":703,"context_line":"            active \u003d \u0027enabled\u0027"},{"line_number":704,"context_line":"            if svc[\u0027disabled\u0027]:"},{"line_number":705,"context_line":"                active \u003d \u0027disabled\u0027"},{"line_number":706,"context_line":"            print print_format % (svc[\u0027binary\u0027], svc[\u0027host\u0027].partition(\u0027.\u0027)[0],"},{"line_number":707,"context_line":"                                  svc[\u0027availability_zone\u0027], active, art,"},{"line_number":708,"context_line":"                                  svc[\u0027updated_at\u0027])"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAOn%2F%2F%2B3c%3D","line":705,"in_reply_to":"AAAAOn%2F%2F%2B%2Bg%3D","updated":"2013-04-09 08:14:31.000000000","message":"Done","commit_id":"5084a437d5b751fdee5b753890109eced4141dad"}]}
