)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f68b4f501bbb6fbb3ceda0b3d53cf493b365f7fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Javeme \u003czhangmei.li@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-29 16:59:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XIO: refactor _send_cmd to to reduce the redundant"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactor _send_cmd to to reduce the redundant and make the code clear:"},{"line_number":10,"context_line":" * reduce the if statement;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a7b0d38_2512f409","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":29},"updated":"2015-12-29 13:06:41.000000000","message":"s/to to/to\n\nSince you need to do another update.","commit_id":"28c10dcd72930fd2da2e84a5d2ac82326c582d1f"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"94a15dd9e8c616e1f5f3f7015a6ac60dde50e557","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Javeme \u003czhangmei.li@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-29 16:59:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XIO: refactor _send_cmd to to reduce the redundant"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refactor _send_cmd to to reduce the redundant and make the code clear:"},{"line_number":10,"context_line":" * reduce the if statement;"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_45779902","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":29},"in_reply_to":"1a7b0d38_2512f409","updated":"2015-12-30 02:51:16.000000000","message":"thanks","commit_id":"28c10dcd72930fd2da2e84a5d2ac82326c582d1f"}],"cinder/volume/drivers/xio.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f68b4f501bbb6fbb3ceda0b3d53cf493b365f7fc","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                url +\u003d \u0027?\u0027 + self._param_string(params)"},{"line_number":436,"context_line":"            body \u003d \u0027\u0027"},{"line_number":437,"context_line":"        elif method in (\u0027POST\u0027,):"},{"line_number":438,"context_line":"            body \u003d self._param_string(params)"},{"line_number":439,"context_line":"        else:"},{"line_number":440,"context_line":"            # method like \u0027DELETE\u0027"},{"line_number":441,"context_line":"            body \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_a51584e5","line":438,"updated":"2015-12-29 13:06:41.000000000","message":"If params is None this will cause an issue. Maybe better to make the default an empty dict?","commit_id":"28c10dcd72930fd2da2e84a5d2ac82326c582d1f"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"94a15dd9e8c616e1f5f3f7015a6ac60dde50e557","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                url +\u003d \u0027?\u0027 + self._param_string(params)"},{"line_number":436,"context_line":"            body \u003d \u0027\u0027"},{"line_number":437,"context_line":"        elif method in (\u0027POST\u0027,):"},{"line_number":438,"context_line":"            body \u003d self._param_string(params)"},{"line_number":439,"context_line":"        else:"},{"line_number":440,"context_line":"            # method like \u0027DELETE\u0027"},{"line_number":441,"context_line":"            body \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_856d9134","line":438,"in_reply_to":"1a7b0d38_a51584e5","updated":"2015-12-30 02:51:16.000000000","message":"Good catch,thanks! but default argument should not be mutable[1, so we use \"params \u003d params or {}\" instead.\n \n[1]:http://docs.python-guide.org/en/latest/writing/gotchas/","commit_id":"28c10dcd72930fd2da2e84a5d2ac82326c582d1f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5580b507ee96bf55c8cccf93d97bc80f56aaafec","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            if params:"},{"line_number":436,"context_line":"                url +\u003d \u0027?\u0027 + self._param_string(params)"},{"line_number":437,"context_line":"            body \u003d \u0027\u0027"},{"line_number":438,"context_line":"        elif method in (\u0027POST\u0027,):"},{"line_number":439,"context_line":"            body \u003d self._param_string(params)"},{"line_number":440,"context_line":"        else:"},{"line_number":441,"context_line":"            # method like \u0027DELETE\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_8f4cb771","line":438,"updated":"2016-03-14 12:08:09.000000000","message":"-1: This is not nice, you replace a simple string comparison with a tuple build and a comparison iteration with no significant benefit.","commit_id":"e086360ca27bea46378cf455c1229ec073a63832"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"bbc5f4a251a1b280567a1dd37800688d464a894b","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            if params:"},{"line_number":436,"context_line":"                url +\u003d \u0027?\u0027 + self._param_string(params)"},{"line_number":437,"context_line":"            body \u003d \u0027\u0027"},{"line_number":438,"context_line":"        elif method in (\u0027POST\u0027,):"},{"line_number":439,"context_line":"            body \u003d self._param_string(params)"},{"line_number":440,"context_line":"        else:"},{"line_number":441,"context_line":"            # method like \u0027DELETE\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_6f813dc3","line":438,"in_reply_to":"3afc51ec_8f4cb771","updated":"2016-03-15 05:58:09.000000000","message":"Done","commit_id":"e086360ca27bea46378cf455c1229ec073a63832"}]}