)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"2a0cfbaf9aef8bc392a27df0e384539b92056d83","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change assertTrue(isinstance()) by optimal assert"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of tests use different method of assertTrue(isinstance(A, B)) or"},{"line_number":10,"context_line":"assertEqual(type(A), B). The correct way is to use assertIsInstance(A,"},{"line_number":11,"context_line":"B) provided by testtools."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Id51f6385dc61a73e29ba38f738d945ef234553ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bae84128_93056a47","line":10,"updated":"2016-02-24 11:36:27.000000000","message":"I think \u0027assertEqual(type(A), B)\u0027 and \u0027assertIsInstance(A, B)\u0027 are not equivalent. For example\n\n```\n\nclass Fun(dict):\n  pass\n\nA \u003d Fun()\nB \u003d dict\n\nprint type(A) \u003d\u003d B    # returns False\nprint isinstance(A, B)    # returns True\n```","commit_id":"1676b45278f9d004f72b743da18f9d2e457dc66a"}]}