)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f957d26f171206a7ffddf9130d3e11c33ec2642","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Snapshot object was missing glance_metadata field that should be"},{"line_number":10,"context_line":"defined in the SQLAlchemy model and oslo versioned object."},{"line_number":11,"context_line":"This commit adds this missing field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2bb3224fee70f9763962992219961396b6834130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_38fe4006","line":12,"updated":"2016-01-07 19:45:20.000000000","message":"Please reference this bug: https://bugs.launchpad.net/cinder/+bug/1509012","commit_id":"0dcbc18557d3757234921c735d92011885247677"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"454c088b88a4711f46b07693dd83fd2de527b05c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Snapshot object was missing glance_metadata field that should be"},{"line_number":10,"context_line":"defined in the SQLAlchemy model and oslo versioned object."},{"line_number":11,"context_line":"This commit adds this missing field."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2bb3224fee70f9763962992219961396b6834130"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_c94d869a","line":12,"in_reply_to":"fa69d971_38fe4006","updated":"2016-01-08 17:01:57.000000000","message":"Done","commit_id":"0dcbc18557d3757234921c735d92011885247677"}],"cinder/db/sqlalchemy/models.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f957d26f171206a7ffddf9130d3e11c33ec2642","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                          \u0027VolumeGlanceMetadata.volume_id \u003d\u003d Volume.id,\u0027"},{"line_number":498,"context_line":"                          \u0027VolumeGlanceMetadata.deleted \u003d\u003d False)\u0027)"},{"line_number":499,"context_line":"    snapshot \u003d relationship("},{"line_number":500,"context_line":"            Snapshot, backref\u003d\"snapshot_glance_metadata\","},{"line_number":501,"context_line":"            foreign_keys\u003dsnapshot_id,"},{"line_number":502,"context_line":"            primaryjoin\u003d\u0027and_(\u0027"},{"line_number":503,"context_line":"                        \u0027VolumeGlanceMetadata.snapshot_id \u003d\u003d Snapshot.id,\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_98308cea","line":500,"range":{"start_line":500,"start_character":12,"end_line":500,"end_character":20},"updated":"2016-01-07 19:45:20.000000000","message":"Instead of moving whole model class just do \u0027Snapshot\u0027 here. I think it should work as you expect.","commit_id":"0dcbc18557d3757234921c735d92011885247677"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"454c088b88a4711f46b07693dd83fd2de527b05c","unresolved":false,"context_lines":[{"line_number":497,"context_line":"                          \u0027VolumeGlanceMetadata.volume_id \u003d\u003d Volume.id,\u0027"},{"line_number":498,"context_line":"                          \u0027VolumeGlanceMetadata.deleted \u003d\u003d False)\u0027)"},{"line_number":499,"context_line":"    snapshot \u003d relationship("},{"line_number":500,"context_line":"            Snapshot, backref\u003d\"snapshot_glance_metadata\","},{"line_number":501,"context_line":"            foreign_keys\u003dsnapshot_id,"},{"line_number":502,"context_line":"            primaryjoin\u003d\u0027and_(\u0027"},{"line_number":503,"context_line":"                        \u0027VolumeGlanceMetadata.snapshot_id \u003d\u003d Snapshot.id,\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_55c4e090","line":500,"range":{"start_line":500,"start_character":12,"end_line":500,"end_character":20},"in_reply_to":"fa69d971_98308cea","updated":"2016-01-08 17:01:57.000000000","message":"Done","commit_id":"0dcbc18557d3757234921c735d92011885247677"}],"cinder/objects/snapshot.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f957d26f171206a7ffddf9130d3e11c33ec2642","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \u0027provider_location\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":62,"context_line":"        \u0027provider_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":63,"context_line":"        \u0027metadata\u0027: fields.DictOfStringsField(),"},{"line_number":64,"context_line":"        \u0027glance_metadata\u0027: fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":65,"context_line":"        \u0027provider_auth\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        \u0027volume\u0027: fields.ObjectField(\u0027Volume\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_5878d48f","line":64,"updated":"2016-01-07 19:45:20.000000000","message":"Normally I would say we should add snapshot_glance_metadata, but as you\u0027re adding a new relationship to the model I think we can use just the new name.","commit_id":"0dcbc18557d3757234921c735d92011885247677"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"454c088b88a4711f46b07693dd83fd2de527b05c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        \u0027provider_location\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":62,"context_line":"        \u0027provider_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":63,"context_line":"        \u0027metadata\u0027: fields.DictOfStringsField(),"},{"line_number":64,"context_line":"        \u0027glance_metadata\u0027: fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":65,"context_line":"        \u0027provider_auth\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        \u0027volume\u0027: fields.ObjectField(\u0027Volume\u0027, nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_751b241d","line":64,"in_reply_to":"fa69d971_5878d48f","updated":"2016-01-08 17:01:57.000000000","message":"Yup, backward compatible name is not needed.","commit_id":"0dcbc18557d3757234921c735d92011885247677"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f957d26f171206a7ffddf9130d3e11c33ec2642","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":167,"context_line":"                                              reason\u003d_(\u0027cgsnapshot assigned\u0027))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        db_snapshot \u003d db.snapshot_create(self._context, updates)"},{"line_number":170,"context_line":"        self._from_db_object(self._context, self, db_snapshot)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_f8f18802","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":64},"updated":"2016-01-07 19:45:20.000000000","message":"Will this add also correct glance_metadata entries?","commit_id":"0dcbc18557d3757234921c735d92011885247677"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"454c088b88a4711f46b07693dd83fd2de527b05c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027create\u0027,"},{"line_number":167,"context_line":"                                              reason\u003d_(\u0027cgsnapshot assigned\u0027))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        db_snapshot \u003d db.snapshot_create(self._context, updates)"},{"line_number":170,"context_line":"        self._from_db_object(self._context, self, db_snapshot)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @base.remotable"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8e74749c","line":169,"range":{"start_line":169,"start_character":0,"end_line":169,"end_character":64},"in_reply_to":"fa69d971_f8f18802","updated":"2016-01-08 17:01:57.000000000","message":"Nope. Fixed by raising exception during attempt to create with glance_metadata filled.","commit_id":"0dcbc18557d3757234921c735d92011885247677"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9f957d26f171206a7ffddf9130d3e11c33ec2642","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                raise exception.ObjectActionError("},{"line_number":181,"context_line":"                    action\u003d\u0027save\u0027, reason\u003d_(\u0027cgsnapshot changed\u0027))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"            if \u0027glance_metadata\u0027 in updates:"},{"line_number":184,"context_line":"                raise exception.ObjectActionError("},{"line_number":185,"context_line":"                    action\u003d\u0027save\u0027, reason\u003d_(\u0027glance_metadata changed\u0027))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"            if \u0027metadata\u0027 in updates:"},{"line_number":188,"context_line":"                # Metadata items that are not specified in the"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_788fd875","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":71},"updated":"2016-01-07 19:45:20.000000000","message":"If we\u0027re not allowing editing them, then how do we set them through objects…?","commit_id":"0dcbc18557d3757234921c735d92011885247677"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"454c088b88a4711f46b07693dd83fd2de527b05c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                raise exception.ObjectActionError("},{"line_number":181,"context_line":"                    action\u003d\u0027save\u0027, reason\u003d_(\u0027cgsnapshot changed\u0027))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"            if \u0027glance_metadata\u0027 in updates:"},{"line_number":184,"context_line":"                raise exception.ObjectActionError("},{"line_number":185,"context_line":"                    action\u003d\u0027save\u0027, reason\u003d_(\u0027glance_metadata changed\u0027))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"            if \u0027metadata\u0027 in updates:"},{"line_number":188,"context_line":"                # Metadata items that are not specified in the"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_6ea820dc","line":185,"range":{"start_line":183,"start_character":0,"end_line":185,"end_character":71},"in_reply_to":"fa69d971_788fd875","updated":"2016-01-08 17:01:57.000000000","message":"Only with glance_metadata_copy_from_volume which is missing. Fixed.","commit_id":"0dcbc18557d3757234921c735d92011885247677"}]}