)]}'
{"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"d48103e9719177d3e6f43099a41f6cd449c11b98","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        pool_details \u003d self.zfssa.get_pool_details(lcfg.zfssa_pool)"},{"line_number":420,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":421,"context_line":"        data[\u0027zfssa_volblocksize\u0027] \u003d lcfg.zfssa_lun_volblocksize"},{"line_number":422,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.zfssa_lun_sparse)"},{"line_number":423,"context_line":"        data[\u0027zfssa_compression\u0027] \u003d lcfg.zfssa_lun_compression"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_10583387","line":420,"updated":"2016-01-06 16:45:00.000000000","message":"Seems like you\u0027re only considering \u0027data profile\u0027? How about \u0027log profile\u0027?","commit_id":"2fbcc96c31ad26eea9ddee22f406d4e6f702c12d"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"559d60cb2adb2193615b9d0e4f9af2f252213dd6","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        pool_details \u003d self.zfssa.get_pool_details(lcfg.zfssa_pool)"},{"line_number":420,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":421,"context_line":"        data[\u0027zfssa_volblocksize\u0027] \u003d lcfg.zfssa_lun_volblocksize"},{"line_number":422,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.zfssa_lun_sparse)"},{"line_number":423,"context_line":"        data[\u0027zfssa_compression\u0027] \u003d lcfg.zfssa_lun_compression"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_65da0119","line":420,"in_reply_to":"fa69d971_10583387","updated":"2016-01-06 22:01:45.000000000","message":"The zfssa_poolprofile is a combination of both the data profile and the log profile for pools that have a log profile.\ne.g. for a pool with log devices, the zfssa_poolprofile will be: \"mirror:log_stripe\". The data and log profiles are separated by a \":\"\nfor a pool without log devices, the zfssa_poolprofile will be:\n\"raidz2\" as an example. I have covered both cases in the unit test.","commit_id":"2fbcc96c31ad26eea9ddee22f406d4e6f702c12d"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"a36c88707ad42fdde5058ce065dea2b545c8c184","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        pool_details \u003d self.zfssa.get_pool_details(lcfg.zfssa_pool)"},{"line_number":420,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":421,"context_line":"        data[\u0027zfssa_volblocksize\u0027] \u003d lcfg.zfssa_lun_volblocksize"},{"line_number":422,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.zfssa_lun_sparse)"},{"line_number":423,"context_line":"        data[\u0027zfssa_compression\u0027] \u003d lcfg.zfssa_lun_compression"},{"line_number":424,"context_line":"        data[\u0027zfssa_logbias\u0027] \u003d lcfg.zfssa_lun_logbias"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_85dafc4a","line":422,"updated":"2016-01-29 12:45:43.000000000","message":"Please change str to six.text_type().","commit_id":"efddceda0dc4673f86b9f45c3d6a2b175eee05bc"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"68a9f3f7fba7acaf10a3ff778bfed7e181ad6e45","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        pool_details \u003d self.zfssa.get_pool_details(lcfg.zfssa_pool)"},{"line_number":420,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":421,"context_line":"        data[\u0027zfssa_volblocksize\u0027] \u003d lcfg.zfssa_lun_volblocksize"},{"line_number":422,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.zfssa_lun_sparse)"},{"line_number":423,"context_line":"        data[\u0027zfssa_compression\u0027] \u003d lcfg.zfssa_lun_compression"},{"line_number":424,"context_line":"        data[\u0027zfssa_logbias\u0027] \u003d lcfg.zfssa_lun_logbias"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_27754263","line":422,"in_reply_to":"7a5de9d1_85dafc4a","updated":"2016-01-29 16:22:17.000000000","message":"Done","commit_id":"efddceda0dc4673f86b9f45c3d6a2b175eee05bc"}],"cinder/volume/drivers/zfssa/zfssanfs.py":[{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"d48103e9719177d3e6f43099a41f6cd449c11b98","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        data[\u0027zfssa_compression\u0027] \u003d share_details[\u0027compression\u0027]"},{"line_number":567,"context_line":"        data[\u0027zfssa_encryption\u0027] \u003d share_details[\u0027encryption\u0027]"},{"line_number":568,"context_line":"        data[\u0027zfssa_logbias\u0027] \u003d share_details[\u0027logbias\u0027]"},{"line_number":569,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":570,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.nfs_sparsed_volumes)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        self._stats \u003d data"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_90cae319","line":569,"updated":"2016-01-06 16:45:00.000000000","message":"Seems like you\u0027re only considering \u0027data profile\u0027? How about \u0027log profile\u0027?","commit_id":"2fbcc96c31ad26eea9ddee22f406d4e6f702c12d"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"559d60cb2adb2193615b9d0e4f9af2f252213dd6","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        data[\u0027zfssa_compression\u0027] \u003d share_details[\u0027compression\u0027]"},{"line_number":567,"context_line":"        data[\u0027zfssa_encryption\u0027] \u003d share_details[\u0027encryption\u0027]"},{"line_number":568,"context_line":"        data[\u0027zfssa_logbias\u0027] \u003d share_details[\u0027logbias\u0027]"},{"line_number":569,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":570,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.nfs_sparsed_volumes)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        self._stats \u003d data"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_450a5d8b","line":569,"in_reply_to":"fa69d971_90cae319","updated":"2016-01-06 22:01:45.000000000","message":"The zfssa_poolprofile is a combination of both the data profile and the log profile for pools that have a log profile.\ne.g. for a pool with log devices, the zfssa_poolprofile will be: \"mirror:log_stripe\". The data and log profiles are separated by a \":\"\nfor a pool without log devices, the zfssa_poolprofile will be:\n\"raidz2\" as an example. I have covered both cases in the unit test.","commit_id":"2fbcc96c31ad26eea9ddee22f406d4e6f702c12d"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"a36c88707ad42fdde5058ce065dea2b545c8c184","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        data[\u0027zfssa_encryption\u0027] \u003d share_details[\u0027encryption\u0027]"},{"line_number":568,"context_line":"        data[\u0027zfssa_logbias\u0027] \u003d share_details[\u0027logbias\u0027]"},{"line_number":569,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":570,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.nfs_sparsed_volumes)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        self._stats \u003d data"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_45296436","line":570,"updated":"2016-01-29 12:45:43.000000000","message":"Please change str to six.text_type().","commit_id":"efddceda0dc4673f86b9f45c3d6a2b175eee05bc"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"68a9f3f7fba7acaf10a3ff778bfed7e181ad6e45","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        data[\u0027zfssa_encryption\u0027] \u003d share_details[\u0027encryption\u0027]"},{"line_number":568,"context_line":"        data[\u0027zfssa_logbias\u0027] \u003d share_details[\u0027logbias\u0027]"},{"line_number":569,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":570,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d str(lcfg.nfs_sparsed_volumes)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        self._stats \u003d data"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a5de9d1_07684686","line":570,"in_reply_to":"7a5de9d1_45296436","updated":"2016-01-29 16:22:17.000000000","message":"Done","commit_id":"efddceda0dc4673f86b9f45c3d6a2b175eee05bc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"5db3414b3077ade19a5cf0e994fd3bf80d49350e","unresolved":false,"context_lines":[{"line_number":563,"context_line":"                                             lcfg.zfssa_nfs_share)"},{"line_number":564,"context_line":"        pool_details \u003d self.zfssa.get_pool_details(lcfg.zfssa_nfs_pool)"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"        data[\u0027zfssa_compression\u0027] \u003d share_details[\u0027compression\u0027]"},{"line_number":567,"context_line":"        data[\u0027zfssa_encryption\u0027] \u003d share_details[\u0027encryption\u0027]"},{"line_number":568,"context_line":"        data[\u0027zfssa_logbias\u0027] \u003d share_details[\u0027logbias\u0027]"},{"line_number":569,"context_line":"        data[\u0027zfssa_poolprofile\u0027] \u003d pool_details[\u0027profile\u0027]"},{"line_number":570,"context_line":"        data[\u0027zfssa_sparse\u0027] \u003d six.text_type(lcfg.nfs_sparsed_volumes)"},{"line_number":571,"context_line":""},{"line_number":572,"context_line":"        self._stats \u003d data"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dae33548_f01745eb","line":570,"range":{"start_line":566,"start_character":8,"end_line":570,"end_character":70},"updated":"2016-02-15 15:54:52.000000000","message":"At some point we should revisit the idea of having a separate section for vendor-unique fields.","commit_id":"c64eda69e3688ae0d4a3e6da5f2d51d24f62d158"}]}