)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d0b7bc4f54ef0f972b7c7937c02f41f439206e2c","unresolved":false,"context_lines":[{"line_number":1434,"context_line":""},{"line_number":1435,"context_line":"        # FIXME(sborkows): Remove this in v2.0 of RPC API"},{"line_number":1436,"context_line":"        if volume is None:"},{"line_number":1437,"context_line":"            volume \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"        # NOTE(flaper87): Verify the driver is enabled"},{"line_number":1440,"context_line":"        # before going forward. The exception will be caught"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_d2b26606","line":1437,"updated":"2016-01-07 18:04:50.000000000","message":"A comment that this is a backward compatibility shim could be useful if you\u0027ll be forced to do another patchset.","commit_id":"083a93f26dade7ad02d2d8b1a14617196175682b"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"12413a0f2bb07a0a2d59dd393b77d6033f26a913","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        msg_args \u003d {\u0027volume_id\u0027: volume.id, \u0027connector\u0027: connector,"},{"line_number":222,"context_line":"                    \u0027force\u0027: force}"},{"line_number":223,"context_line":"        if self.client.can_send_version(\u00271.38\u0027):"},{"line_number":224,"context_line":"            msg_args[\u0027volume\u0027] \u003d volume"},{"line_number":225,"context_line":"            version \u003d \u00271.38\u0027"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            version \u003d self.BASE_RPC_API_VERSION"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8767cee9","line":224,"updated":"2016-01-07 17:34:09.000000000","message":"Can \u00271.38\u0027 be set as a constant?  (Or as constanty as python gets.)","commit_id":"083a93f26dade7ad02d2d8b1a14617196175682b"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"d66e960648fcf3716f526bca6924781176112ad6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        msg_args \u003d {\u0027volume_id\u0027: volume.id, \u0027connector\u0027: connector,"},{"line_number":222,"context_line":"                    \u0027force\u0027: force}"},{"line_number":223,"context_line":"        if self.client.can_send_version(\u00271.38\u0027):"},{"line_number":224,"context_line":"            msg_args[\u0027volume\u0027] \u003d volume"},{"line_number":225,"context_line":"            version \u003d \u00271.38\u0027"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            version \u003d self.BASE_RPC_API_VERSION"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_8d392fdb","line":224,"in_reply_to":"fa69d971_3293c251","updated":"2016-01-07 18:13:57.000000000","message":"Comment cheerfully withdrawn.","commit_id":"083a93f26dade7ad02d2d8b1a14617196175682b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d0b7bc4f54ef0f972b7c7937c02f41f439206e2c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        msg_args \u003d {\u0027volume_id\u0027: volume.id, \u0027connector\u0027: connector,"},{"line_number":222,"context_line":"                    \u0027force\u0027: force}"},{"line_number":223,"context_line":"        if self.client.can_send_version(\u00271.38\u0027):"},{"line_number":224,"context_line":"            msg_args[\u0027volume\u0027] \u003d volume"},{"line_number":225,"context_line":"            version \u003d \u00271.38\u0027"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            version \u003d self.BASE_RPC_API_VERSION"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_3293c251","line":224,"in_reply_to":"fa69d971_8767cee9","updated":"2016-01-07 18:04:50.000000000","message":"I don\u0027t see a point in making it a constant - if someone raises the global latest version of the RPC API, this should still point to \u00271.38\u0027. \n\nWe can do a variable in this method, but that will just add additional line without a clear benefit.","commit_id":"083a93f26dade7ad02d2d8b1a14617196175682b"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"d0b7bc4f54ef0f972b7c7937c02f41f439206e2c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            msg_args[\u0027volume\u0027] \u003d volume"},{"line_number":225,"context_line":"            version \u003d \u00271.38\u0027"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            version \u003d self.BASE_RPC_API_VERSION"},{"line_number":228,"context_line":"        cctxt \u003d self.client.prepare(server\u003dnew_host, version\u003dversion)"},{"line_number":229,"context_line":"        return cctxt.call(ctxt, \u0027terminate_connection\u0027, **msg_args)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_72d7faed","line":227,"range":{"start_line":227,"start_character":22,"end_line":227,"end_character":47},"updated":"2016-01-07 18:04:50.000000000","message":"I would prefer literal 1.0. I\u0027m not sure why we even have that constant (Nova which we share codebase with, haven\u0027t).","commit_id":"083a93f26dade7ad02d2d8b1a14617196175682b"}]}