)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"6f442011ec4c9cab1ea2470deb7828900d7a4699","unresolved":false,"context_lines":[{"line_number":2813,"context_line":""},{"line_number":2814,"context_line":"        # If we have failed over, we need to issue a fail-back."},{"line_number":2815,"context_line":"        if is_failed_over:"},{"line_number":2816,"context_line":"            model_update \u003d self._replication_failback(volume)"},{"line_number":2817,"context_line":"        else:"},{"line_number":2818,"context_line":"            model_update \u003d {\"provider_location\": self.client.id}"},{"line_number":2819,"context_line":"            # If replication is not enabled and the volume is of replicated"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_fceb43da","line":2816,"updated":"2016-01-11 03:43:13.000000000","message":"I would not suggest putting failback in the enable function\n\nAccording to \u0027doc/source/devref/replication.rst\u0027:\n\n\n209 Note that ideally drivers will know how to update the volume reference properly so that Cinder is now\n210 pointing to the secondary.  Also, while it\u0027s not required, at this time; ideally the command would\n211 act as a toggle, allowing to switch back and forth between primary and secondary and back to primary.\n\nreplication_failover should play this role.","commit_id":"210d4a9bdf738e3a40b31a24211f4eda8c376662"}]}