)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5261747900fd86bed7ed7e1eedf7e5c38bdfc9d5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Béla Vancsics \u003cvancsics@inf.u-szeged.hu\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-27 17:53:27 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reduce code duplication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reduced source code by extracting duplicated code"},{"line_number":10,"context_line":"(cinder/volume/drivers/emc/emc_vmax_provision.py)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_fd6b9d83","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":23},"updated":"2016-02-09 16:26:07.000000000","message":"Same comment as on the other patch, please make these tiles more specific to what area you are reducing code duplication in so that it will be easier to reference back to them in the future.","commit_id":"c17594ed36903f6c6d4c7d4c376785875ca6109a"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"5261747900fd86bed7ed7e1eedf7e5c38bdfc9d5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Reduced source code by extracting duplicated code"},{"line_number":10,"context_line":"(cinder/volume/drivers/emc/emc_vmax_provision.py)"},{"line_number":11,"context_line":"http://openqa.sed.hu/dashboard/index/137221?did\u003d1 , 48~CloneClass"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib59a72e2041581bc0cca85006b515f573e2e5033"},{"line_number":14,"context_line":"Closes-Bug: 1536173"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_fdf07dcb","line":12,"updated":"2016-02-09 16:26:07.000000000","message":"Please include some discussion on the methods you created to reduce code duplication.","commit_id":"c17594ed36903f6c6d4c7d4c376785875ca6109a"}],"cinder/volume/drivers/emc/emc_vmax_provision.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"ee6c9f48f57d47ef73c4e5af9599feffd0fb2676","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                        controllerConfigService,"},{"line_number":252,"context_line":"                                        MaskingGroup\u003dstorageGroupInstanceName,"},{"line_number":253,"context_line":"                                        Members\u003d[volumeInstanceName])"},{"line_number":254,"context_line":"        if rc !\u003d 0:"},{"line_number":255,"context_line":"            rc, errorDesc \u003d self.utils.wait_for_job_complete(conn, jobDict,"},{"line_number":256,"context_line":"                                                             extraSpecs)"},{"line_number":257,"context_line":"            if rc !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_61ce5a85","line":254,"updated":"2016-01-20 13:47:39.000000000","message":"We can update here as well. There are more places which use similar code.","commit_id":"2b8a16bf65a48939ac2ef60b30fc61f8c89080a8"},{"author":{"_account_id":18603,"name":"Béla Vancsics","email":"vancsics@inf.u-szeged.hu","username":"vancsics"},"change_message_id":"3bcc95d7006ed53c85aebf1ca71b5af7e81c2e82","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                                        controllerConfigService,"},{"line_number":252,"context_line":"                                        MaskingGroup\u003dstorageGroupInstanceName,"},{"line_number":253,"context_line":"                                        Members\u003d[volumeInstanceName])"},{"line_number":254,"context_line":"        if rc !\u003d 0:"},{"line_number":255,"context_line":"            rc, errorDesc \u003d self.utils.wait_for_job_complete(conn, jobDict,"},{"line_number":256,"context_line":"                                                             extraSpecs)"},{"line_number":257,"context_line":"            if rc !\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_6f8fe9cc","line":254,"in_reply_to":"9a68dd71_61ce5a85","updated":"2016-01-21 11:23:04.000000000","message":"There are differences in the exceptionMessage. Therefore I didn\u0027t simplified. (Shall I try to transfigure it?)","commit_id":"2b8a16bf65a48939ac2ef60b30fc61f8c89080a8"}],"cinder/volume/drivers/emc/emc_vmax_provision_v3.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"3f44dacf96b67aa1f6cf09ada82d22628269862d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.protocol \u003d prtcl"},{"line_number":44,"context_line":"        self.utils \u003d emc_vmax_utils.EMCVMAXUtils(prtcl)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def invoke_log(self, invokeMessage, startTime):"},{"line_number":47,"context_line":"        LOG.debug(\"InvokeMethod \" + invokeMessage + \" took: \""},{"line_number":48,"context_line":"                  \"%(delta)s H:MM:SS.\","},{"line_number":49,"context_line":"                  {\u0027delta\u0027: self.utils.get_time_delta(startTime,"},{"line_number":50,"context_line":"                                                      time.time())})"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def check_return_code(self, rc, conn, job, extraSpecs, message, name_str,"},{"line_number":53,"context_line":"                          name_attr, invokeMessage, startTime):"},{"line_number":54,"context_line":"        if rc !\u003d 0:"},{"line_number":55,"context_line":"            rc_, errordesc \u003d self.utils.wait_for_job_complete(conn, job,"},{"line_number":56,"context_line":"                                                              extraSpecs)"},{"line_number":57,"context_line":"            if rc_ !\u003d 0:"},{"line_number":58,"context_line":"                exceptionMessage \u003d (_("},{"line_number":59,"context_line":"                    \"Error %(message): %(name_err)s. \""},{"line_number":60,"context_line":"                    \"Return code: %(rc)lu.  Error: %(error)s.\")"},{"line_number":61,"context_line":"                    % {\u0027message\u0027: message,"},{"line_number":62,"context_line":"                       \u0027name_err\u0027: name_str,"},{"line_number":63,"context_line":"                       name_str: name_attr,"},{"line_number":64,"context_line":"                       \u0027rc\u0027: rc_,"},{"line_number":65,"context_line":"                       \u0027error\u0027: errordesc})"},{"line_number":66,"context_line":"                LOG.error(exceptionMessage)"},{"line_number":67,"context_line":"                raise exception.VolumeBackendAPIException("},{"line_number":68,"context_line":"                    data\u003dexceptionMessage)"},{"line_number":69,"context_line":"            self.invoke_log(invokeMessage, startTime)"},{"line_number":70,"context_line":"            return rc_"},{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            self.invoke_log(invokeMessage, startTime)"},{"line_number":73,"context_line":"            return rc"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def delete_volume_from_pool("},{"line_number":76,"context_line":"            self, conn, storageConfigservice, volumeInstanceName, volumeName,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_49b3c1e9","line":73,"range":{"start_line":46,"start_character":4,"end_line":73,"end_character":21},"updated":"2016-02-05 03:46:34.000000000","message":"If the goal is to reduce code duplication, why not go all the way and not duplicate this same code in both of the provision classes?","commit_id":"c17594ed36903f6c6d4c7d4c376785875ca6109a"}]}